with rigorous integration test
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conversion.mlir | ||
---|---|---|
118–168 | I wonder where there is a better way to assert %10 == %20, %11 == %21, so that we don't have to repeat the dump output in this block, which is the same as line 110-115. |
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conversion.mlir | ||
---|---|---|
118–168 | Yeah, fair enough. After working with FileCheck for close to two years now, I have a bit of the "when you have a hammer everything looks like a nail" approach to checking with output. I will rewrite this into a form that uses more intuitive comparisons, so this can become a simple pass/fail check. Thanks for the suggestion! |
clang-tidy: warning: do not use 'else' after 'return' [llvm-else-after-return]
not useful