Page MenuHomePhabricator

gussmith23 (Gus Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2021, 3:57 PM (50 w, 10 h)

Recent Activity

Aug 24 2021

gussmith23 accepted D108667: [mlir][sparse] enable a few vectorized runs in integration tests.
Aug 24 2021, 3:45 PM · Restricted Project

Aug 4 2021

gussmith23 committed rG0bd2d4c4b163: [mlir][sparse] Remove comment w/ code in it (authored by gussmith23).
[mlir][sparse] Remove comment w/ code in it
Aug 4 2021, 2:42 PM
gussmith23 closed D107484: [mlir][sparse] Remove comment w/ code in it.
Aug 4 2021, 2:41 PM · Restricted Project
gussmith23 updated the diff for D107484: [mlir][sparse] Remove comment w/ code in it.

matrix -> tensor

Aug 4 2021, 10:59 AM · Restricted Project
gussmith23 added a reviewer for D107484: [mlir][sparse] Remove comment w/ code in it: aartbik.
Aug 4 2021, 10:40 AM · Restricted Project
gussmith23 requested review of D107484: [mlir][sparse] Remove comment w/ code in it.
Aug 4 2021, 10:40 AM · Restricted Project

Aug 2 2021

gussmith23 accepted D107310: [mlir][sparse] use consistent type for COO object and sparse tensor storage.
Aug 2 2021, 3:18 PM · Restricted Project

Jul 30 2021

gussmith23 accepted D107001: [mlir][sparse] template the memory resident coordinate scheme storage.

I left a comment re: naming, but everything looks good otherwise!

Jul 30 2021, 9:38 AM · Restricted Project

Jul 28 2021

gussmith23 accepted D106904: [mlir][sparse] use proper type alias for filename ptr.
Jul 28 2021, 10:06 AM · Restricted Project

Jul 27 2021

gussmith23 accepted D106841: [mlir][sparse] fixed bug in verification.

Great catch!

Jul 27 2021, 6:23 AM · Restricted Project

Jul 16 2021

gussmith23 accepted D106108: [mlir][sparse] minor cleanup of Merger.
Jul 16 2021, 10:19 AM · Restricted Project
gussmith23 added a comment to D106108: [mlir][sparse] minor cleanup of Merger.

Looks good, though still worried about bugs arising from kOpSymbols! See comment

Jul 16 2021, 8:03 AM · Restricted Project

Jul 15 2021

gussmith23 accepted D106016: [mlir][sparse] add int64 storage type to sparse tensor runtime support library.
Jul 15 2021, 12:05 PM · Restricted Project
gussmith23 added a comment to D106016: [mlir][sparse] add int64 storage type to sparse tensor runtime support library.

Just one question, otherwise looks good!

Jul 15 2021, 9:21 AM · Restricted Project
gussmith23 accepted D106002: [mlir][sparse] add shift ops support.

This looks good -- I have some minor comments, do with them what you will!

Jul 15 2021, 9:16 AM · Restricted Project

Jul 13 2021

gussmith23 accepted D105928: [mlir][sparse] add support for std unary operations.
Jul 13 2021, 2:10 PM · Restricted Project
gussmith23 added a comment to D105928: [mlir][sparse] add support for std unary operations.

Comments/questions, but otherwise this looks good!

Jul 13 2021, 1:38 PM · Restricted Project

Jul 12 2021

gussmith23 accepted D105851: [mlir][sparse] add support for AND and OR operations.

Looks good! Very cool how easy it is to add new ops!

Jul 12 2021, 4:31 PM · Restricted Project
gussmith23 accepted D105731: [mlir][sparse] add restrictive versions of division support.

This looks good to me!

Jul 12 2021, 2:42 PM · Restricted Project
gussmith23 added inline comments to D105731: [mlir][sparse] add restrictive versions of division support.
Jul 12 2021, 2:28 PM · Restricted Project
gussmith23 committed rG40843347b37c: [mlir][sparse] Add Merger unit tests (with gcc5 build fix) (authored by gussmith23).
[mlir][sparse] Add Merger unit tests (with gcc5 build fix)
Jul 12 2021, 1:36 PM
gussmith23 closed D105828: [mlir][sparse] Add Merger unit tests (with gcc5 build fix).
Jul 12 2021, 1:36 PM · Restricted Project
gussmith23 added a comment to D105828: [mlir][sparse] Add Merger unit tests (with gcc5 build fix).

See this relevant stackoverflow:
https://stackoverflow.com/questions/32084706/why-initialization-doesnt-work-for-tuple

Jul 12 2021, 11:19 AM · Restricted Project
gussmith23 updated the diff for D105828: [mlir][sparse] Add Merger unit tests (with gcc5 build fix).

Apply fix (tuple -> pair)

Jul 12 2021, 11:19 AM · Restricted Project
gussmith23 requested review of D105828: [mlir][sparse] Add Merger unit tests (with gcc5 build fix).
Jul 12 2021, 11:16 AM · Restricted Project

Jul 8 2021

gussmith23 committed rG0d0cff3ace39: [mlir][sparse] Add Merger unit tests (authored by gussmith23).
[mlir][sparse] Add Merger unit tests
Jul 8 2021, 4:11 PM
gussmith23 closed D104956: [mlir][sparse] Add Merger unit tests.
Jul 8 2021, 4:10 PM · Restricted Project
gussmith23 added inline comments to D104956: [mlir][sparse] Add Merger unit tests.
Jul 8 2021, 3:44 PM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Remove children struct

Jul 8 2021, 3:44 PM · Restricted Project
gussmith23 added inline comments to D104956: [mlir][sparse] Add Merger unit tests.
Jul 8 2021, 2:23 PM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Convert to shared_ptr, add output tensor

Jul 8 2021, 2:22 PM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Fix comments

Jul 8 2021, 11:38 AM · Restricted Project
gussmith23 added inline comments to D104956: [mlir][sparse] Add Merger unit tests.
Jul 8 2021, 11:22 AM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Address partial ordering; clean up unused code

Jul 8 2021, 11:17 AM · Restricted Project
gussmith23 added inline comments to D104956: [mlir][sparse] Add Merger unit tests.
Jul 8 2021, 9:46 AM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Address all of Aart's comments except for partial ordering

Jul 8 2021, 9:46 AM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Address some of Aart's comments (not all)

Jul 8 2021, 8:28 AM · Restricted Project
gussmith23 accepted D105599: [mlir][sparse] updated setter/getter comments.

Thanks for this clarification :)

Jul 8 2021, 7:35 AM · Restricted Project

Jul 6 2021

gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Rebase and fix clang-tidy

Jul 6 2021, 8:31 AM · Restricted Project
gussmith23 retitled D104956: [mlir][sparse] Add Merger unit tests from Add Merger unit tests to [mlir][sparse] Add Merger unit tests.
Jul 6 2021, 7:37 AM · Restricted Project
gussmith23 updated the summary of D104956: [mlir][sparse] Add Merger unit tests.
Jul 6 2021, 7:37 AM · Restricted Project

Jul 2 2021

gussmith23 added inline comments to D104956: [mlir][sparse] Add Merger unit tests.
Jul 2 2021, 2:53 PM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.
  • Simplify tests (test 2-arg add and mul, rather than 4-arg)
  • Use a test fixture, move logic into test fixture class
  • Make tests a bit more readable (though still needs work)
    • The main change here is that we now use helper functions to check that lattice point expressions and bits equal what we expect them to equal. Those helpers are designed to take a more readable set of arguments, e.g. a prefix-notation expression to test against, in the case of the expression checker.
  • Check for a specific ordering of lattice points (this may break in the future!)
    • If we were really thorough, we'd check for a partial ordering on the lattice points. However, we just check for an absolute ordering.
Jul 2 2021, 2:48 PM · Restricted Project
gussmith23 accepted D105306: [mlir][sparse] support for negation and subtractions.
Jul 2 2021, 2:28 PM · Restricted Project
gussmith23 requested changes to D105306: [mlir][sparse] support for negation and subtractions.

Just small changes left.

Jul 2 2021, 1:06 PM · Restricted Project
gussmith23 added a comment to D105306: [mlir][sparse] support for negation and subtractions.

Finished reading through everything. Just have some questions, but for the most part everything looks good!

Jul 2 2021, 12:48 PM · Restricted Project
gussmith23 added inline comments to D105306: [mlir][sparse] support for negation and subtractions.
Jul 2 2021, 12:48 PM · Restricted Project
gussmith23 added inline comments to D105306: [mlir][sparse] support for negation and subtractions.
Jul 2 2021, 11:43 AM · Restricted Project
gussmith23 added a comment to D105306: [mlir][sparse] support for negation and subtractions.

Initial set of comments. Not yet done with review, but I figured I should give you some comments to read through!

Jul 2 2021, 10:28 AM · Restricted Project
gussmith23 committed rG4569c14ac347: Refactor TensorExp parameters into a union (authored by gussmith23).
Refactor TensorExp parameters into a union
Jul 2 2021, 7:46 AM
gussmith23 closed D105303: Refactor TensorExp parameters into a union.
Jul 2 2021, 7:46 AM · Restricted Project

Jul 1 2021

gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Fix after rebase

Jul 1 2021, 10:01 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Rebase

Jul 1 2021, 5:17 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Move struct outside

Jul 1 2021, 2:45 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Again, attempt to fix clang-tidy

Jul 1 2021, 2:21 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Fix clang-tidy

Jul 1 2021, 1:47 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Rebase

Jul 1 2021, 1:11 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Remove comment

Jul 1 2021, 1:01 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Make struct anonymous

Jul 1 2021, 12:55 PM · Restricted Project
gussmith23 updated the diff for D105303: Refactor TensorExp parameters into a union.

Make union anonymous; rename tensor_num->tensor

Jul 1 2021, 12:45 PM · Restricted Project
gussmith23 requested review of D105303: Refactor TensorExp parameters into a union.
Jul 1 2021, 11:48 AM · Restricted Project
gussmith23 accepted D105219: [mlir][sparse] move tensor expression builder into Merger utility.
Jul 1 2021, 9:23 AM · Restricted Project

Jun 29 2021

gussmith23 added inline comments to D104956: [mlir][sparse] Add Merger unit tests.
Jun 29 2021, 5:38 PM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Rebase

Jun 29 2021, 5:38 PM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

Address one of Aart's comments

Jun 29 2021, 5:36 PM · Restricted Project

Jun 28 2021

gussmith23 added inline comments to D104956: [mlir][sparse] Add Merger unit tests.
Jun 28 2021, 4:30 PM · Restricted Project
gussmith23 updated the diff for D104956: [mlir][sparse] Add Merger unit tests.

More thorough checking in tests

Jun 28 2021, 4:29 PM · Restricted Project

Jun 25 2021

gussmith23 committed rG043ce4e6bdd3: [MLIR][Sparse] Move `buildLattices` into Merger (authored by gussmith23).
[MLIR][Sparse] Move `buildLattices` into Merger
Jun 25 2021, 10:05 PM
gussmith23 closed D104879: [MLIR][Sparse] Move `buildLattices` into Merger.
Jun 25 2021, 10:05 PM · Restricted Project
gussmith23 updated the diff for D104879: [MLIR][Sparse] Move `buildLattices` into Merger.

Rebase

Jun 25 2021, 8:59 PM · Restricted Project
gussmith23 updated the diff for D104879: [MLIR][Sparse] Move `buildLattices` into Merger.

Rebase

Jun 25 2021, 4:38 PM · Restricted Project
gussmith23 requested review of D104956: [mlir][sparse] Add Merger unit tests.
Jun 25 2021, 3:47 PM · Restricted Project
gussmith23 updated the diff for D104879: [MLIR][Sparse] Move `buildLattices` into Merger.

Rebase

Jun 25 2021, 3:44 PM · Restricted Project
gussmith23 added inline comments to D104879: [MLIR][Sparse] Move `buildLattices` into Merger.
Jun 25 2021, 3:37 PM · Restricted Project
gussmith23 updated the diff for D104879: [MLIR][Sparse] Move `buildLattices` into Merger.

Address Aart's comment -- add syntheticTensor

Jun 25 2021, 3:36 PM · Restricted Project
gussmith23 added inline comments to D104879: [MLIR][Sparse] Move `buildLattices` into Merger.
Jun 25 2021, 2:44 PM · Restricted Project
gussmith23 updated the diff for D104879: [MLIR][Sparse] Move `buildLattices` into Merger.

Address Aart's comments

Jun 25 2021, 2:44 PM · Restricted Project
gussmith23 accepted D104939: [mlir][sparse] add print methods to Merger (for debugging).
Jun 25 2021, 12:55 PM · Restricted Project

Jun 24 2021

gussmith23 committed rG744146f60bbf: [MLIR][Sparse] Refactor lattice code into its own file (authored by gussmith23).
[MLIR][Sparse] Refactor lattice code into its own file
Jun 24 2021, 4:04 PM
gussmith23 closed D104757: [MLIR][Sparse] Refactor lattice code into its own file.
Jun 24 2021, 4:03 PM · Restricted Project
gussmith23 retitled D104879: [MLIR][Sparse] Move `buildLattices` into Merger from Move `buildLattices` into Merger to [MLIR][Sparse] Move `buildLattices` into Merger.
Jun 24 2021, 3:35 PM · Restricted Project
gussmith23 requested review of D104879: [MLIR][Sparse] Move `buildLattices` into Merger.
Jun 24 2021, 3:34 PM · Restricted Project
gussmith23 added inline comments to D104757: [MLIR][Sparse] Refactor lattice code into its own file.
Jun 24 2021, 3:23 PM · Restricted Project
gussmith23 updated the diff for D104757: [MLIR][Sparse] Refactor lattice code into its own file.

Re-introduce includes, cmake fix

Jun 24 2021, 3:22 PM · Restricted Project
gussmith23 updated the diff for D104757: [MLIR][Sparse] Refactor lattice code into its own file.

Address Aart's comments

Jun 24 2021, 2:51 PM · Restricted Project
gussmith23 updated the diff for D104757: [MLIR][Sparse] Refactor lattice code into its own file.

Address Aart's comments

Jun 24 2021, 1:55 PM · Restricted Project
gussmith23 added inline comments to D104757: [MLIR][Sparse] Refactor lattice code into its own file.
Jun 24 2021, 1:25 PM · Restricted Project
gussmith23 updated the diff for D104757: [MLIR][Sparse] Refactor lattice code into its own file.

Address Aart's comments

Jun 24 2021, 1:23 PM · Restricted Project
gussmith23 updated the diff for D104757: [MLIR][Sparse] Refactor lattice code into its own file.

Updates from Aart reviews on Critique

Jun 24 2021, 12:57 PM · Restricted Project

Jun 22 2021

gussmith23 retitled D104757: [MLIR][Sparse] Refactor lattice code into its own file from Refactor lattice code into its own file to [MLIR][Sparse] Refactor lattice code into its own file.
Jun 22 2021, 4:35 PM · Restricted Project
gussmith23 requested review of D104757: [MLIR][Sparse] Refactor lattice code into its own file.
Jun 22 2021, 4:34 PM · Restricted Project
gussmith23 accepted D104577: [mlir][sparse] add support for "simply dynamic" sparse tensor expressions.
Jun 22 2021, 1:22 PM · Restricted Project
gussmith23 accepted D104583: [mlir][sparse] integration test for "simply dynamic" sparse output tensors.
Jun 22 2021, 11:05 AM · Restricted Project
gussmith23 accepted D104577: [mlir][sparse] add support for "simply dynamic" sparse tensor expressions.

No major changes requested from me. See minor comments, questions, and fixes!

Jun 22 2021, 10:59 AM · Restricted Project

Jun 17 2021

gussmith23 committed rG22911585bb38: [mlir][sparse] Add Matricized Tensor Times Khatri-Rao Product (MTTKRP)… (authored by gussmith23).
[mlir][sparse] Add Matricized Tensor Times Khatri-Rao Product (MTTKRP)…
Jun 17 2021, 9:53 AM
gussmith23 closed D104417: [mlir][sparse] Add Matricized Tensor Times Khatri-Rao Product (MTTKRP) integration test.
Jun 17 2021, 9:53 AM · Restricted Project

Jun 16 2021

gussmith23 added inline comments to D104417: [mlir][sparse] Add Matricized Tensor Times Khatri-Rao Product (MTTKRP) integration test.
Jun 16 2021, 2:09 PM · Restricted Project
gussmith23 updated the diff for D104417: [mlir][sparse] Add Matricized Tensor Times Khatri-Rao Product (MTTKRP) integration test.

Address Aart's comments: line length, add periods, make code comment stand out

Jun 16 2021, 2:09 PM · Restricted Project
gussmith23 requested review of D104417: [mlir][sparse] Add Matricized Tensor Times Khatri-Rao Product (MTTKRP) integration test.
Jun 16 2021, 12:54 PM · Restricted Project
gussmith23 added inline comments to D104334: Add sparse matrix multiplication integration test.
Jun 16 2021, 11:31 AM · Restricted Project