Page MenuHomePhabricator

[mlir][docs] A friendlier improvement for the Toy tutorial chapter 4.
ClosedPublic

Authored by LyricZ_THU on Aug 13 2021, 4:06 AM.

Details

Summary

Add notes for discarding private-visible functions in the Toy tutorial chapter 4.

Diff Detail

Event Timeline

LyricZ_THU created this revision.Aug 13 2021, 4:06 AM
LyricZ_THU requested review of this revision.Aug 13 2021, 4:06 AM

Hi, I'm a first-time contributor without the commit accesses. This commit was inspired while I'm following the tutorial to make the Toy language. After I finished the chapter 4, I found my compiler could not discard the function body of func @multiply_transpose, so that the shape inference pass would fail in this function. I'm a beginner for LLVM, it really took me a long time to read the MLIR code and find the visibility problem of my Toy compiler. So I'm wondering whether we could put this note into the docs for friendliness. Thanks!

mehdi_amini accepted this revision.Aug 19 2021, 3:56 PM
This revision is now accepted and ready to land.Aug 19 2021, 3:56 PM

@mehdi_amini Thanks for your reviews! I'm sorry that I am a first-time contributor without a commit access. Could you help me with committing the changes? Thanks :)