Correct openmp-offload-builders lld, openmp

[ronlieb]

Summary

Remove openmp from depends_on_projects, as it incorrectly builds amdgpu runtime stack corruption at runtime.
We need to use -DLLVM_ENABLE_RUNTIMES=openmp instead, and its presence conflicts if openmp is present.
Also adding "-DCLANG_DEFAULT_LINKER=lld" as it seems harmless.
Adding 'lld' to depends_on_projects so it gets built.

[david-salinas]

LGTM

[Meinersbur]

The enable_runtimes=['openmp'], parameter already sets -DLLVM_ENABLE_RUNTIMES=openmp (and ensures that changes to openmp triggers a build). Do not add it separately.

If you do not want support a LLVM_ENABLE_PROJECT=openmp build, remove the openmp-offload-amdgpu-project builder instead. There is no point in two builders doing the same thing.

[ronlieb]

i reverted it, sent email to galina requesting update to master. and requested info on a better way to test locally ...

buildbot/osuosl/master/config/builders.py

 # OpenMP AMDGPU Builders
     {'name' : "openmp-offload-amdgpu-project",
     'tags'  : ["openmp"],
     'workernames' : ["omp-vega20-0"],
     'builddir': "openmp-offload-amdgpu-project",
     'factory' : OpenMPBuilder.getOpenMPCMakeBuildFactory(
                         clean=False,
                         enable_runtimes=[],
-                        depends_on_projects=['llvm','clang','openmp'],
+                        depends_on_projects=['llvm','clang','lld'],
                         extraCmakeArgs=[
                             "-DCMAKE_BUILD_TYPE=Release",
+                            "-DCLANG_DEFAULT_LINKER=lld",
                             "-DLLVM_TARGETS_TO_BUILD=X86;AMDGPU",
                             "-DLLVM_ENABLE_ASSERTIONS=ON",
+                            "-DLLVM_ENABLE_RUNTIMES=openmp",
                             ],
                         install=True,
                         testsuite=True,
                         testsuite_sollvevv=False,
                         extraTestsuiteCmakeArgs=[
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS=-fopenmp-targets=amdgcn-amd-amdhsa;-Xopenmp-target=amdgcn-amd-amdhsa",
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_LDLAGS=-fopenmp-targets=amdgcn-amd-amdhsa;-Xopenmp-target=amdgcn-amd-amdhsa",
                         ],
                     )},
 
     {'name' : "openmp-offload-amdgpu-runtime",
     'tags'  : ["openmp"],
     'workernames' : ["omp-vega20-0"],
     'builddir': "openmp-offload-amdgpu-runtime",
     'factory' : OpenMPBuilder.getOpenMPCMakeBuildFactory(
                         clean=True,
                         enable_runtimes=['openmp'],
-                        depends_on_projects=['llvm','clang','openmp'],
+                        depends_on_projects=['llvm','clang','lld'],
                         extraCmakeArgs=[
                             "-DCMAKE_BUILD_TYPE=Release",
+                            "-DCLANG_DEFAULT_LINKER=lld",
                             "-DLLVM_TARGETS_TO_BUILD=X86;AMDGPU",
                             "-DLLVM_ENABLE_ASSERTIONS=ON",
+                            "-DLLVM_ENABLE_RUNTIMES=openmp",
                             ],
                         install=True,
                         testsuite=True,
                         testsuite_sollvevv=False,
                         extraTestsuiteCmakeArgs=[
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS=-fopenmp-targets=amdgcn-amd-amdhsa;-Xopenmp-target=amdgcn-amd-amdhsa",
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_LDLAGS=-fopenmp-targets=amdgcn-amd-amdhsa;-Xopenmp-target=amdgcn-amd-amdhsa",
                         ],