This is an archive of the discontinued LLVM Phabricator instance.

Differential D107699

[mlir] Avoid including <alloca.h> on FreeBSD and NetBSD
ClosedPublic

Authored by dim on Aug 7 2021, 1:00 PM.

Details

Reviewers
aartbik
akuegel
emaste
herhut
nikic
bondhugula
Commits
rGab4b4684a26c: [mlir] Avoid including <alloca.h> on FreeBSD and NetBSD
Summary

Instead, include <cstdlib> which is the canonical header containing
the declaration of alloca().

Diff Detail

Event Timeline

dim created this revision.Aug 7 2021, 1:00 PM
Herald added subscribers: wrengr, Chia-hungDuan, dcaballe and 18 others. · View Herald TranscriptAug 7 2021, 1:00 PM
dim requested review of this revision.Aug 7 2021, 1:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2021, 1:00 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B118517: Diff 364978.Aug 7 2021, 2:05 PM
bondhugula accepted this revision.Aug 7 2021, 9:27 PM
This revision is now accepted and ready to land.Aug 7 2021, 9:27 PM
Closed by commit rGab4b4684a26c: [mlir] Avoid including <alloca.h> on FreeBSD and NetBSD (authored by dim). · Explain WhyAug 8 2021, 4:33 AM
This revision was automatically updated to reflect the committed changes.
dim added a commit: rGab4b4684a26c: [mlir] Avoid including <alloca.h> on FreeBSD and NetBSD.

Revision Contents

PathSize
mlir/
lib/
ExecutionEngine/
4 lines

Diff 365013

mlir/lib/ExecutionEngine/CRunnerUtils.cpp

Show All 9 Lines
// runtime. Entities in this file are meant to be retargetable, including on // runtime. Entities in this file are meant to be retargetable, including on
// targets without a C++ runtime, and must be kept C compatible. // targets without a C++ runtime, and must be kept C compatible.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "mlir/ExecutionEngine/CRunnerUtils.h" #include "mlir/ExecutionEngine/CRunnerUtils.h"
#ifndef _WIN32 #ifndef _WIN32
#if defined(__FreeBSD__) || defined(__NetBSD__)
#include <cstdlib>
#else
#include <alloca.h> #include <alloca.h>
#endif
#include <sys/time.h> #include <sys/time.h>
#else #else
#include "malloc.h" #include "malloc.h"
#endif // _WIN32 #endif // _WIN32
#include <cinttypes> #include <cinttypes>
#include <cstdio> #include <cstdio>
#include <string.h> #include <string.h>
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines