User Details
- User Since
- Feb 4 2016, 7:52 AM (258 w, 4 d)
Sun, Jan 10
Fri, Jan 8
Wed, Dec 23
Dec 14 2020
Thanks :)
Dec 13 2020
Thanks :)
Dec 11 2020
Friendly ping?
Friendly ping?
Dec 10 2020
Dec 9 2020
Ok, I just checked the recent presubmit results, and all seem to fail on Windows:
https://buildkite.com/llvm-project/premerge-checks/builds
Frederik, it looks like there was an error on Windows during the pre-merge checks. Does that look familiar to the one you saw? Do you know if this is for real?
I have copied the Sqrt test for the GPUToNVVM lowering and adapted it.
Add test.
Working on a test now.
Fixed copy/paste bug.
Nov 11 2020
Thanks for the review comments :)
Address review comments.
Oct 15 2020
Jul 17 2020
Jul 16 2020
Mar 20 2020
Mar 19 2020
Mar 17 2020
Mar 6 2020
Addressed review comments.
Mar 5 2020
Landed as revision 91acb5b3e1c3
Unforunately I forgot to reset the link to this review, after I had accidentally created https://reviews.llvm.org/D75353
Mar 4 2020
Sorry for not following up sooner, I was busy with other stuff yesterday. Today, with some help by Stephan I was able to make this work. I copied the handling with unrolling multi-dimensional vectors from the generic elementwise op handling. This could potentially be refactored, especially I wonder whether Tanh should also use this.
Handle vector types.
Mar 2 2020
PTAL. The tests seem to work now.
Fix type issues.
Don't hard-code constant to have type F32.
Feb 28 2020
Fix ClangTidy warnings.
Sorry, I accidentally created a new patch instead of updating the old one. Abandoning this.
Feb 27 2020
Landed as 39e1c1fa9ee03e91751e505d747275e58069e6de
Feb 12 2020
Ok, seems we should not have this in the LLVM dialect, so I will abandon this.
Feb 11 2020
Jan 14 2020
I fixed the clang-format error in a followup commit.
Sorry for not noticing it sooner :-(
Addressed River's review comments.
Jan 13 2020
Addressed review comments.
Jan 10 2020
Ran git-clang-format.
Address review comments.
Jan 9 2020
Fix copy/paste issue.
Addressed review comments.
Jan 8 2020
Also add description for loop.yield (thanks herhut@)
Improved description of parallel loop operation.
Rebased to head.
Jun 19 2018
Jun 13 2018
Friendly ping?
Jun 8 2018
Addressed review comments:
- renamed method to getRaw
- added more comments regarding supported types and endianness