Page MenuHomePhabricator

akuegel (Adrian Kuegel)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2016, 7:52 AM (281 w, 13 h)

Recent Activity

Tue, Jun 15

akuegel committed rGf112bd61ebf3: [mlir] Add SignOp to complex dialect. (authored by akuegel).
[mlir] Add SignOp to complex dialect.
Tue, Jun 15, 6:22 AM
akuegel closed D104292: [mlir] Add SignOp to complex dialect..
Tue, Jun 15, 6:22 AM · Restricted Project
akuegel updated the diff for D104292: [mlir] Add SignOp to complex dialect..

Address review comments.

Tue, Jun 15, 5:47 AM · Restricted Project
akuegel requested review of D104292: [mlir] Add SignOp to complex dialect..
Tue, Jun 15, 5:16 AM · Restricted Project
akuegel committed rG662e074d9043: [mlir] Add NegOp to complex dialect. (authored by akuegel).
[mlir] Add NegOp to complex dialect.
Tue, Jun 15, 3:16 AM
akuegel closed D104284: [mlir] Add NegOp to complex dialect..
Tue, Jun 15, 3:16 AM · Restricted Project
akuegel requested review of D104284: [mlir] Add NegOp to complex dialect..
Tue, Jun 15, 2:46 AM · Restricted Project

Sun, Jun 13

akuegel committed rG2116eadf0994: [mlir] Remove traits that require vector type support from ops in Complex… (authored by akuegel).
[mlir] Remove traits that require vector type support from ops in Complex…
Sun, Jun 13, 11:30 PM
akuegel closed D104103: [mlir] Remove traits that require vector type support from ops in Complex dialect..
Sun, Jun 13, 11:30 PM · Restricted Project
akuegel committed rG73cbc91c93dd: [mlir] Add ExpOp to Complex dialect. (authored by akuegel).
[mlir] Add ExpOp to Complex dialect.
Sun, Jun 13, 11:09 PM
akuegel closed D104108: [mlir] Add ExpOp to Complex dialect..
Sun, Jun 13, 11:09 PM · Restricted Project
akuegel added inline comments to D104108: [mlir] Add ExpOp to Complex dialect..
Sun, Jun 13, 10:54 PM · Restricted Project
akuegel updated the diff for D104108: [mlir] Add ExpOp to Complex dialect..

Address review comment.

Sun, Jun 13, 10:53 PM · Restricted Project

Fri, Jun 11

akuegel requested review of D104108: [mlir] Add ExpOp to Complex dialect..
Fri, Jun 11, 4:46 AM · Restricted Project
akuegel requested review of D104103: [mlir] Remove traits that require vector type support from ops in Complex dialect..
Fri, Jun 11, 3:38 AM · Restricted Project
akuegel committed rGf98b7796142d: [mlir] Refactor ComplexOps.td [NFC] (authored by akuegel).
[mlir] Refactor ComplexOps.td [NFC]
Fri, Jun 11, 1:54 AM
akuegel closed D104095: [mlir] Refactor ComplexOps.td [NFC].
Fri, Jun 11, 1:53 AM · Restricted Project
akuegel retitled D104095: [mlir] Refactor ComplexOps.td [NFC] from [mlir] Refactor ComplexOps.td to [mlir] Refactor ComplexOps.td [NFC].
Fri, Jun 11, 12:50 AM · Restricted Project
akuegel added a comment to D104095: [mlir] Refactor ComplexOps.td [NFC].

Nice! Thanks!

Fri, Jun 11, 12:49 AM · Restricted Project
akuegel updated the diff for D104095: [mlir] Refactor ComplexOps.td [NFC].

Actually make it a NFC.

Fri, Jun 11, 12:48 AM · Restricted Project
akuegel requested review of D104095: [mlir] Refactor ComplexOps.td [NFC].
Fri, Jun 11, 12:37 AM · Restricted Project

Wed, Jun 2

akuegel committed rG942be7cb4d98: [mlir] Add DivOp lowering from Complex dialect to Standard/Math dialect. (authored by akuegel).
[mlir] Add DivOp lowering from Complex dialect to Standard/Math dialect.
Wed, Jun 2, 2:16 AM
akuegel closed D103507: [mlir] Add DivOp lowering from Complex dialect to Standard/Math dialect..
Wed, Jun 2, 2:16 AM · Restricted Project
akuegel requested review of D103507: [mlir] Add DivOp lowering from Complex dialect to Standard/Math dialect..
Wed, Jun 2, 1:35 AM · Restricted Project

Mon, May 31

akuegel added a comment to D103248: [MLIR] Add dialect prefix to all operations from Math.

Not sure why some of the unit tests fail. To me this looks unrelated to the patch. Is there any way to trigger re-running the tests?

Mon, May 31, 4:10 AM · Restricted Project

Wed, May 26

akuegel committed rGdee46d08293f: [mlir] Fold complex.create(complex.re(op), complex.im(op)) (authored by akuegel).
[mlir] Fold complex.create(complex.re(op), complex.im(op))
Wed, May 26, 5:03 AM
akuegel closed D103148: [mlir] Fold complex.create(complex.re(op), complex.im(op)).
Wed, May 26, 5:03 AM · Restricted Project
akuegel updated the diff for D103148: [mlir] Fold complex.create(complex.re(op), complex.im(op)).

Fix CHECK-LABEL line in test to check the full function name.

Wed, May 26, 3:36 AM · Restricted Project
akuegel updated the diff for D103148: [mlir] Fold complex.create(complex.re(op), complex.im(op)).

Sync to HEAD.

Wed, May 26, 3:32 AM · Restricted Project
akuegel requested review of D103148: [mlir] Fold complex.create(complex.re(op), complex.im(op)).
Wed, May 26, 3:29 AM · Restricted Project
akuegel added inline comments to D103141: [mlir] Fold complex.re(complex.create) and complex.im(complex.create).
Wed, May 26, 2:01 AM · Restricted Project
akuegel committed rGcb65419b1ac0: [mlir] Simplify folding code (NFC) (authored by akuegel).
[mlir] Simplify folding code (NFC)
Wed, May 26, 2:00 AM
akuegel added inline comments to D103141: [mlir] Fold complex.re(complex.create) and complex.im(complex.create).
Wed, May 26, 1:55 AM · Restricted Project
akuegel committed rGb99f892b025b: [mlir] Fold complex.re(complex.create) and complex.im(complex.create) (authored by akuegel).
[mlir] Fold complex.re(complex.create) and complex.im(complex.create)
Wed, May 26, 1:54 AM
akuegel closed D103141: [mlir] Fold complex.re(complex.create) and complex.im(complex.create).
Wed, May 26, 1:53 AM · Restricted Project
akuegel requested review of D103141: [mlir] Fold complex.re(complex.create) and complex.im(complex.create).
Wed, May 26, 12:46 AM · Restricted Project

May 25 2021

akuegel accepted D102681: [mlir] Support buffer hoisting on allocas.
May 25 2021, 5:23 AM · Restricted Project

May 21 2021

akuegel committed rG28844212fe40: [mlir] Add additional traits to EqualOp and NotEqualOp. (authored by akuegel).
[mlir] Add additional traits to EqualOp and NotEqualOp.
May 21 2021, 6:05 AM
akuegel closed D102916: [mlir] Add additional traits to EqualOp and NotEqualOp..
May 21 2021, 6:05 AM · Restricted Project
akuegel requested review of D102916: [mlir] Add additional traits to EqualOp and NotEqualOp..
May 21 2021, 6:01 AM · Restricted Project
akuegel added a comment to D102905: [mlir] Add convenience builders for EqualOp and NotEqualOp..

Fixed in https://reviews.llvm.org/rGa1a429dc1d95

May 21 2021, 2:46 AM · Restricted Project
akuegel committed rGa1a429dc1d95: [mlir] NFC - Use builder.getI1Type() (authored by akuegel).
[mlir] NFC - Use builder.getI1Type()
May 21 2021, 2:45 AM
akuegel added inline comments to D102905: [mlir] Add convenience builders for EqualOp and NotEqualOp..
May 21 2021, 2:43 AM · Restricted Project
akuegel committed rG7eb85cdb103e: [mlir] Add convenience builders for EqualOp and NotEqualOp. (authored by akuegel).
[mlir] Add convenience builders for EqualOp and NotEqualOp.
May 21 2021, 2:33 AM
akuegel closed D102905: [mlir] Add convenience builders for EqualOp and NotEqualOp..
May 21 2021, 2:32 AM · Restricted Project
akuegel added a reviewer for D102905: [mlir] Add convenience builders for EqualOp and NotEqualOp.: pifon2a.
May 21 2021, 2:19 AM · Restricted Project
akuegel committed rGfb8b2b86d3d1: [mlir] Add conversion from Complex to Standard dialect for NotEqualOp. (authored by akuegel).
[mlir] Add conversion from Complex to Standard dialect for NotEqualOp.
May 21 2021, 1:47 AM
akuegel closed D102902: [mlir] Add conversion from Complex to Standard dialect for NotEqualOp..
May 21 2021, 1:47 AM · Restricted Project
akuegel requested review of D102905: [mlir] Add convenience builders for EqualOp and NotEqualOp..
May 21 2021, 1:39 AM · Restricted Project
akuegel added inline comments to D102902: [mlir] Add conversion from Complex to Standard dialect for NotEqualOp..
May 21 2021, 1:06 AM · Restricted Project
akuegel updated the diff for D102902: [mlir] Add conversion from Complex to Standard dialect for NotEqualOp..

Derive result combination op type via std::conditional_t from comparison op type.

May 21 2021, 1:06 AM · Restricted Project
akuegel requested review of D102902: [mlir] Add conversion from Complex to Standard dialect for NotEqualOp..
May 21 2021, 12:18 AM · Restricted Project

May 20 2021

akuegel committed rGac00cb0d2ad5: [mlir] Add conversion from complex to standard dialect for EqualOp. (authored by akuegel).
[mlir] Add conversion from complex to standard dialect for EqualOp.
May 20 2021, 5:26 AM
akuegel closed D102840: [mlir] Add conversion from complex to standard dialect for EqualOp..
May 20 2021, 5:26 AM · Restricted Project
akuegel requested review of D102840: [mlir] Add conversion from complex to standard dialect for EqualOp..
May 20 2021, 5:01 AM · Restricted Project
akuegel committed rGa28fe17d7315: [mlir] Add EqualOp and NotEqualOp to complex dialect. (authored by akuegel).
[mlir] Add EqualOp and NotEqualOp to complex dialect.
May 20 2021, 4:26 AM
akuegel added inline comments to D102838: [mlir] Add EqualOp and NotEqualOp to complex dialect..
May 20 2021, 4:13 AM · Restricted Project
akuegel retitled D102838: [mlir] Add EqualOp and NotEqualOp to complex dialect. from [mlir] Add IsEqualOp and IsNotEqualOp to complex dialect. to [mlir] Add EqualOp and NotEqualOp to complex dialect..
May 20 2021, 4:13 AM · Restricted Project
akuegel updated the diff for D102838: [mlir] Add EqualOp and NotEqualOp to complex dialect..

Rename to EqualOp and NotEqualOp.

May 20 2021, 4:13 AM · Restricted Project
akuegel requested review of D102838: [mlir] Add EqualOp and NotEqualOp to complex dialect..
May 20 2021, 3:56 AM · Restricted Project

May 18 2021

akuegel committed rGfa765a094402: [mlir] Add folder for complex.ReOp and complex.ImOp. (authored by akuegel).
[mlir] Add folder for complex.ReOp and complex.ImOp.
May 18 2021, 2:28 AM
akuegel closed D102616: [mlir] Add folder for complex.ReOp and complex.ImOp..
May 18 2021, 2:28 AM · Restricted Project
akuegel updated the diff for D102616: [mlir] Add folder for complex.ReOp and complex.ImOp..

Add assert and check size of array attr.

May 18 2021, 1:41 AM · Restricted Project

May 17 2021

akuegel requested review of D102616: [mlir] Add folder for complex.ReOp and complex.ImOp..
May 17 2021, 5:06 AM · Restricted Project
akuegel added a comment to D102609: [mlir] Add folder for complex.ReOp and complex.ImOp..

Sorry, I was careless and didn't test the other tests apart from the ones I added in this patch.
I reverted this patch, and will look into why some other tests are failing.

May 17 2021, 4:52 AM · Restricted Project
akuegel added a reverting change for rG6b49834d652b: [mlir] Add folder for complex.ReOp and complex.ImOp.: rG967f07f5476a: Revert "[mlir] Add folder for complex.ReOp and complex.ImOp.".
May 17 2021, 4:50 AM
akuegel committed rG967f07f5476a: Revert "[mlir] Add folder for complex.ReOp and complex.ImOp." (authored by akuegel).
Revert "[mlir] Add folder for complex.ReOp and complex.ImOp."
May 17 2021, 4:50 AM
akuegel added a reverting change for D102609: [mlir] Add folder for complex.ReOp and complex.ImOp.: rG967f07f5476a: Revert "[mlir] Add folder for complex.ReOp and complex.ImOp.".
May 17 2021, 4:50 AM · Restricted Project
akuegel committed rG6b49834d652b: [mlir] Add folder for complex.ReOp and complex.ImOp. (authored by akuegel).
[mlir] Add folder for complex.ReOp and complex.ImOp.
May 17 2021, 4:36 AM
akuegel closed D102609: [mlir] Add folder for complex.ReOp and complex.ImOp..
May 17 2021, 4:36 AM · Restricted Project
akuegel requested review of D102609: [mlir] Add folder for complex.ReOp and complex.ImOp..
May 17 2021, 4:21 AM · Restricted Project
akuegel committed rG5ef21506b98c: Add support for complex constants to MLIR core. (authored by akuegel).
Add support for complex constants to MLIR core.
May 17 2021, 12:14 AM
akuegel closed D101908: Add support for complex constants to MLIR core..
May 17 2021, 12:14 AM · Restricted Project

May 14 2021

akuegel updated the diff for D101908: Add support for complex constants to MLIR core..

Fix ClangTidy warning.

May 14 2021, 5:06 AM · Restricted Project
akuegel added a comment to D101908: Add support for complex constants to MLIR core..

It seems one of the tests I have added triggered an assertion error. I added a check that the FloatAttr has the correct type before calling ConstantFP::get.

May 14 2021, 4:04 AM · Restricted Project
akuegel updated the diff for D101908: Add support for complex constants to MLIR core..

Fix assertion error triggered in new test.

May 14 2021, 4:01 AM · Restricted Project

May 12 2021

akuegel added inline comments to D101908: Add support for complex constants to MLIR core..
May 12 2021, 5:41 AM · Restricted Project
akuegel updated the diff for D101908: Add support for complex constants to MLIR core..

Improve verifier logic, add tests.

May 12 2021, 5:32 AM · Restricted Project

May 11 2021

akuegel added a comment to D101908: Add support for complex constants to MLIR core..

Thanks for the review comments :) And sorry for taking so long to respond. I was busy with some other tasks.

May 11 2021, 5:24 AM · Restricted Project
akuegel updated the diff for D101908: Add support for complex constants to MLIR core..

Address review comments. Start adding more tests.

May 11 2021, 5:15 AM · Restricted Project

May 9 2021

akuegel accepted D102068: [MLIR][Shape] Concretize broadcast result type if possible.
May 9 2021, 11:20 PM · Restricted Project
akuegel committed rG9ba661f91276: [mlir] Fix compile error. (authored by akuegel).
[mlir] Fix compile error.
May 9 2021, 10:51 PM

May 5 2021

akuegel added a comment to D101908: Add support for complex constants to MLIR core..

I probably need to add more tests, and maybe need to improve some things. Still, I wanted to already send this out to get feedback on the general approach here.
The RFC with more discussion is here:
https://llvm.discourse.group/t/rfc-add-a-builtin-complexattr/3316/28

May 5 2021, 7:29 AM · Restricted Project
akuegel requested review of D101908: Add support for complex constants to MLIR core..
May 5 2021, 7:27 AM · Restricted Project

May 4 2021

akuegel committed rG93537fabcee8: [mlir] Add lowering from math.expm1 to LLVM. (authored by akuegel).
[mlir] Add lowering from math.expm1 to LLVM.
May 4 2021, 5:22 AM
akuegel closed D96776: [mlir] Add lowering from math.expm1 to LLVM..
May 4 2021, 5:22 AM · Restricted Project
akuegel added a comment to D96776: [mlir] Add lowering from math.expm1 to LLVM..

Like I said, I won't block this (and I haven't blocked https://reviews.llvm.org/D98662 either), but let's try and find time across teams to proceed with the refactoring -- it's not a priority for me either, but maintaining an ever-growing list of patterns may become hard.

May 4 2021, 5:21 AM · Restricted Project
akuegel added a comment to D96776: [mlir] Add lowering from math.expm1 to LLVM..

Ping.
I just added log1p's approximation (https://reviews.llvm.org/D101765). I'd like this patch to go in so that I can also add expm1's approximation.

May 4 2021, 3:49 AM · Restricted Project
akuegel updated the diff for D96776: [mlir] Add lowering from math.expm1 to LLVM..

Rebase

May 4 2021, 3:31 AM · Restricted Project

Apr 28 2021

akuegel committed rG2ea7fb7b1c04: [MLIR] Add ComplexToStandard conversion pass. (authored by akuegel).
[MLIR] Add ComplexToStandard conversion pass.
Apr 28 2021, 5:18 AM
akuegel closed D101442: [MLIR] Add ComplexToStandard conversion pass..
Apr 28 2021, 5:18 AM · Restricted Project
akuegel added inline comments to D101442: [MLIR] Add ComplexToStandard conversion pass..
Apr 28 2021, 5:16 AM · Restricted Project
akuegel updated the diff for D101442: [MLIR] Add ComplexToStandard conversion pass..

Address review comments.

Apr 28 2021, 5:15 AM · Restricted Project
akuegel requested review of D101442: [MLIR] Add ComplexToStandard conversion pass..
Apr 28 2021, 4:16 AM · Restricted Project

Mar 22 2021

akuegel added a comment to D99059: [mlir] Add an option to still use bottom-up traversal.

No test? For a revision touching the core infrastructure this is a bit light and looked a bit rushed in right now.

Mar 22 2021, 8:25 AM · Restricted Project
akuegel committed rGc691b9686b77: [mlir] Add an option to still use bottom-up traversal (authored by akuegel).
[mlir] Add an option to still use bottom-up traversal
Mar 22 2021, 1:59 AM
akuegel closed D99059: [mlir] Add an option to still use bottom-up traversal.
Mar 22 2021, 1:59 AM · Restricted Project
akuegel requested review of D99059: [mlir] Add an option to still use bottom-up traversal.
Mar 22 2021, 1:49 AM · Restricted Project

Mar 17 2021

akuegel committed rG4a8c01a02b46: Move BaseOpWithOffsetSizesAndStrides to OpBase.td (authored by akuegel).
Move BaseOpWithOffsetSizesAndStrides to OpBase.td
Mar 17 2021, 5:54 AM
akuegel closed D98777: Move BaseOpWithOffsetSizesAndStrides to OpBase.td.
Mar 17 2021, 5:54 AM · Restricted Project