Page MenuHomePhabricator
People akuegel

akuegel (Adrian Kuegel)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2016, 7:52 AM (217 w, 4 d)

Recent Activity
View All

Fri, Mar 20

akuegel added a reverting change for rGe9f22fd4293a: [TableGen][GlobalISel] Account for HwMode in RegisterBank register sizes: rGbaa6f6a7828a: Revert "[TableGen][GlobalISel] Account for HwMode in RegisterBank register….
Fri, Mar 20, 3:13 AM
akuegel committed rGbaa6f6a7828a: Revert "[TableGen][GlobalISel] Account for HwMode in RegisterBank register… (authored by akuegel).
Revert "[TableGen][GlobalISel] Account for HwMode in RegisterBank register…
Fri, Mar 20, 3:13 AM
akuegel added inline comments to D76007: [WIP][TableGen][GlobalISel] Account for HwMode in RegisterBank register sizes.
Fri, Mar 20, 3:13 AM · Restricted Project

Thu, Mar 19

akuegel added a reverting change for rG79a7ed92a9b1: CFGDiff: Simplify/common the begin/end implementations to use a common range…: rG4a7f2032a350: Revert "CFGDiff: Simplify/common the begin/end implementations to use a common….
Thu, Mar 19, 3:45 AM
akuegel committed rG4a7f2032a350: Revert "CFGDiff: Simplify/common the begin/end implementations to use a common… (authored by akuegel).
Revert "CFGDiff: Simplify/common the begin/end implementations to use a common…
Thu, Mar 19, 3:45 AM

Tue, Mar 17

akuegel committed rG5156e38eb1d3: Fix memtag test. (authored by akuegel).
Fix memtag test.
Tue, Mar 17, 3:44 AM
akuegel closed D76272: Fix memtag test..
Tue, Mar 17, 3:44 AM · Restricted Project
akuegel created D76272: Fix memtag test..
Tue, Mar 17, 3:00 AM · Restricted Project
akuegel added a reviewer for D76272: Fix memtag test.: bkramer.
Tue, Mar 17, 3:00 AM · Restricted Project

Mar 6 2020

akuegel committed rG86306df7dd2a: Extract common code to deal with multidimensional vectors. (authored by akuegel).
Extract common code to deal with multidimensional vectors.
Mar 6 2020, 4:59 AM
akuegel closed D75733: Extract common code to deal with multidimensional vectors..
Mar 6 2020, 4:59 AM · Restricted Project
akuegel added inline comments to D75733: Extract common code to deal with multidimensional vectors..
Mar 6 2020, 4:57 AM · Restricted Project
akuegel updated the diff for D75733: Extract common code to deal with multidimensional vectors..

Addressed review comments.

Mar 6 2020, 4:57 AM · Restricted Project
akuegel added inline comments to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Mar 6 2020, 4:24 AM · Restricted Project
akuegel created D75733: Extract common code to deal with multidimensional vectors..
Mar 6 2020, 4:24 AM · Restricted Project

Mar 5 2020

akuegel closed D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Landed as revision 91acb5b3e1c3
Unforunately I forgot to reset the link to this review, after I had accidentally created https://reviews.llvm.org/D75353

Mar 5 2020, 6:35 AM · Restricted Project

Mar 4 2020

akuegel committed rG91acb5b3e1c3: Add rsqrt op to Standard dialect and lower it to LLVM dialect. (authored by akuegel).
Add rsqrt op to Standard dialect and lower it to LLVM dialect.
Mar 4 2020, 4:34 AM
akuegel added a comment to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Sorry for not following up sooner, I was busy with other stuff yesterday. Today, with some help by Stephan I was able to make this work. I copied the handling with unrolling multi-dimensional vectors from the generic elementwise op handling. This could potentially be refactored, especially I wonder whether Tanh should also use this.

Mar 4 2020, 3:59 AM · Restricted Project
akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Handle vector types.

Mar 4 2020, 3:58 AM · Restricted Project

Mar 2 2020

akuegel added a comment to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

PTAL. The tests seem to work now.

Mar 2 2020, 5:29 AM · Restricted Project
akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Fix type issues.

Mar 2 2020, 5:29 AM · Restricted Project
akuegel added inline comments to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Mar 2 2020, 5:02 AM · Restricted Project
akuegel added inline comments to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Mar 2 2020, 5:02 AM · Restricted Project
akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Don't hard-code constant to have type F32.

Mar 2 2020, 5:02 AM · Restricted Project

Feb 28 2020

akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Fix ClangTidy warnings.

Feb 28 2020, 7:17 AM · Restricted Project
akuegel abandoned D75353: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Sorry, I accidentally created a new patch instead of updating the old one. Abandoning this.

Feb 28 2020, 7:17 AM · Restricted Project
akuegel created D75353: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Feb 28 2020, 7:06 AM · Restricted Project
akuegel created D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Feb 28 2020, 7:05 AM · Restricted Project

Feb 27 2020

akuegel committed rG39e1c1fa9ee0: Add GPU lowerings for the different log ops. (authored by akuegel).
Add GPU lowerings for the different log ops.
Feb 27 2020, 9:50 AM
akuegel closed D75239: Add GPU lowerings for the different log ops..

Landed as 39e1c1fa9ee03e91751e505d747275e58069e6de

Feb 27 2020, 6:33 AM · Restricted Project
akuegel created D75239: Add GPU lowerings for the different log ops..
Feb 27 2020, 4:05 AM · Restricted Project

Feb 12 2020

akuegel abandoned D74406: Add RsqrtOp to LLVM dialect..

Ok, seems we should not have this in the LLVM dialect, so I will abandon this.

Feb 12 2020, 1:20 AM · Restricted Project

Feb 11 2020

akuegel updated the summary of D74406: Add RsqrtOp to LLVM dialect..
Feb 11 2020, 6:37 AM · Restricted Project
akuegel created D74406: Add RsqrtOp to LLVM dialect..
Feb 11 2020, 6:37 AM · Restricted Project

Jan 14 2020

akuegel added a comment to D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

I fixed the clang-format error in a followup commit.
Sorry for not noticing it sooner :-(

Jan 14 2020, 2:48 AM · Restricted Project
akuegel committed rG5a6eae3dea23: [mlir] Ran git-clang-format. (authored by akuegel).
[mlir] Ran git-clang-format.
Jan 14 2020, 2:46 AM
akuegel committed rG018b042593f0: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations. (authored by akuegel).
[mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations.
Jan 14 2020, 2:38 AM
akuegel closed D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 14 2020, 2:37 AM · Restricted Project
akuegel retitled D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations. from [mlir] Add skeleton implementation of loop.parallel, loop.yield and loop.yield.return operations. to [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 14 2020, 2:00 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Addressed River's review comments.

Jan 14 2020, 1:34 AM · Restricted Project

Jan 13 2020

akuegel added inline comments to D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 13 2020, 1:57 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Addressed review comments.

Jan 13 2020, 1:57 AM · Restricted Project

Jan 10 2020

akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Ran git-clang-format.

Jan 10 2020, 4:21 AM · Restricted Project
akuegel added inline comments to D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 10 2020, 3:58 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Address review comments.

Jan 10 2020, 3:58 AM · Restricted Project

Jan 9 2020

akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Fix copy/paste issue.

Jan 9 2020, 6:56 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Addressed review comments.

Jan 9 2020, 6:37 AM · Restricted Project

Jan 8 2020

akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Also add description for loop.yield (thanks herhut@)

Jan 8 2020, 7:12 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Improved description of parallel loop operation.

Jan 8 2020, 7:03 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Rebased to head.

Jan 8 2020, 5:41 AM · Restricted Project
akuegel created D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 8 2020, 5:14 AM · Restricted Project

Jun 19 2018

akuegel committed rL335028: Add a factory method to ConstantDataArray that allows to pass in the data as….
Add a factory method to ConstantDataArray that allows to pass in the data as…
Jun 19 2018, 1:17 AM
akuegel closed D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.
Jun 19 2018, 1:17 AM

Jun 13 2018

akuegel added a comment to D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.

Friendly ping?

Jun 13 2018, 1:42 AM

Jun 8 2018

akuegel updated the diff for D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.

Addressed review comments:

  • renamed method to getRaw
  • added more comments regarding supported types and endianness
Jun 8 2018, 3:07 AM

Jun 7 2018

akuegel added a reviewer for D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef: efriedma.
Jun 7 2018, 7:22 AM

Jun 5 2018

akuegel added a comment to D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.

We want to use it for XLA, simplifying the ConvertLiteralToIrConstant method:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/service/llvm_ir/llvm_util.cc#L374
Essentially we already have a buffer that we want to store as-is, and we can compute the type we want to store based on the XLA PrimitiveType. Then we could get rid of the switch, and it would make our code easier.

Jun 5 2018, 12:36 AM

Jun 4 2018

akuegel created D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.
Jun 4 2018, 4:42 AM

Nov 24 2016

akuegel committed rL287862: Remove \x13 (^S) character that was likely added by mistake..
Remove \x13 (^S) character that was likely added by mistake.
Nov 24 2016, 2:11 AM
akuegel closed D26973: Remove \x13 (^S) character that was likely added by mistake. by committing rL287862: Remove \x13 (^S) character that was likely added by mistake..
Nov 24 2016, 2:11 AM

Nov 22 2016

akuegel retitled D26973: Remove \x13 (^S) character that was likely added by mistake. from to Remove \x13 (^S) character that was likely added by mistake..
Nov 22 2016, 7:27 AM

Nov 21 2016

akuegel added a comment to D26910: Adjust arm64-irtranslator.ll test to changes from r287368.

No, I don't have commit access yet. Can you please land this for me?

Nov 21 2016, 5:18 AM
akuegel retitled D26910: Adjust arm64-irtranslator.ll test to changes from r287368 from to Adjust arm64-irtranslator.ll test to changes from r287368.
Nov 21 2016, 5:14 AM

Aug 22 2016

akuegel added inline comments to D23492: Make function local tags visible..
Aug 22 2016, 10:14 AM
akuegel added inline comments to D23492: Make function local tags visible..
Aug 22 2016, 7:16 AM

Aug 3 2016

akuegel added a comment to D23119: Fix quadratic runtime when adding items to tooling::Replacements..

lg

Aug 3 2016, 7:09 AM

Feb 17 2016

akuegel added a comment to D17195: Added a check for forward declaration in the potentially wrong namespace in clang-tidy [misc-forward-declaration-namespace].

LGTM
(you need someone else to approve this change though).

Feb 17 2016, 5:35 AM
akuegel added inline comments to D17195: Added a check for forward declaration in the potentially wrong namespace in clang-tidy [misc-forward-declaration-namespace].
Feb 17 2016, 4:53 AM

Feb 15 2016

akuegel added inline comments to D17195: Added a check for forward declaration in the potentially wrong namespace in clang-tidy [misc-forward-declaration-namespace].
Feb 15 2016, 6:00 AM
akuegel added a comment to D17195: Added a check for forward declaration in the potentially wrong namespace in clang-tidy [misc-forward-declaration-namespace].

In general, please make sure all comments you write are a complete phrase, don't abbreviate. See also http://llvm.org/docs/CodingStandards.html#commenting

Feb 15 2016, 1:29 AM

Feb 12 2016

akuegel added a comment to D17195: Added a check for forward declaration in the potentially wrong namespace in clang-tidy [misc-forward-declaration-namespace].

Just a couple of nits in the first round.

Feb 12 2016, 5:09 AM