Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Adding the header include #include "mlir/Bytecode/BytecodeOpInterface.h" creates a dependency cycle between "BytecodeOpInterface" and "IR" in bazel build. I wonder how CMake handles this.

Jun 5 2023, 2:32 AM · Restricted Project, Restricted Project

akuegel committed rGbc7f65cbd87f: [mlir][Bazel] Adjust BUILD files for a9d003ef855ff7ed1bf4f8229ee9944b55936e6f (authored by akuegel).

[mlir][Bazel] Adjust BUILD files for a9d003ef855ff7ed1bf4f8229ee9944b55936e6f

Jun 5 2023, 12:58 AM · Restricted Project

May 31 2023

akuegel committed rG6118cb4bd43f: [mlir][Bazel] Adapt Bazel BUILD for ce954e1cda5c9b55325903d51285cd742152a0c3 (authored by akuegel).

[mlir][Bazel] Adapt Bazel BUILD for ce954e1cda5c9b55325903d51285cd742152a0c3

May 31 2023, 1:13 AM · Restricted Project

May 22 2023

akuegel committed rGcd0e9383fc34: [mlir] Apply ClangTidy performance finding (NFC) (authored by akuegel).

[mlir] Apply ClangTidy performance finding (NFC)

May 22 2023, 11:54 PM · Restricted Project, Restricted Project

May 4 2023

akuegel committed rGf248fc375fa3: [mlir][Bazel] Update BUILD.bazel file for… (authored by akuegel).

[mlir][Bazel] Update BUILD.bazel file for…

May 4 2023, 1:47 AM · Restricted Project

akuegel closed D149823: [mlir][Bazel] Update BUILD.bazel file for cc4703745ffa398b66f985b483cb8b61eb2ed425.

May 4 2023, 1:46 AM · Restricted Project, Restricted Project

akuegel updated the diff for D149823: [mlir][Bazel] Update BUILD.bazel file for cc4703745ffa398b66f985b483cb8b61eb2ed425.

Add missing dependency.

May 4 2023, 1:37 AM · Restricted Project, Restricted Project

akuegel requested review of D149823: [mlir][Bazel] Update BUILD.bazel file for cc4703745ffa398b66f985b483cb8b61eb2ed425.

May 4 2023, 1:10 AM · Restricted Project, Restricted Project

May 1 2023

akuegel committed rG3c83afb68bb1: [mlir][Bazel] Adjust BUILD file for changes in… (authored by akuegel).

[mlir][Bazel] Adjust BUILD file for changes in…

May 1 2023, 11:50 PM · Restricted Project

Apr 27 2023

akuegel accepted D149326: [bazel][mlir] update build for mem2reg f88f8fd0bca34dc8e5571cb828b1a159a50fd504.

Thank you :)

Apr 27 2023, 1:57 AM · Restricted Project, Restricted Project

Apr 24 2023

akuegel accepted D149056: [bazel] test files for IRDL 8ac8c922fb3f15706f5cb1db2cc655d30b095766.

Apr 24 2023, 5:03 AM · Restricted Project, Restricted Project

Apr 20 2023

akuegel accepted D148862: [bazel] Update Bazel version to 6.1.2..

Apr 20 2023, 11:50 PM · Restricted Project, Restricted Project

Apr 19 2023

akuegel accepted D148738: [bazel] Fix the bazel build for llvmorg-17-init-8629-ga443b3d18ef4.

Apr 19 2023, 11:15 PM · Restricted Project, Restricted Project

Apr 18 2023

akuegel committed rGa91f44271b46: [clang][Bazel] Add missing dependency after 310ee08d5d4 (authored by akuegel).

[clang][Bazel] Add missing dependency after 310ee08d5d4

Apr 18 2023, 10:57 PM · Restricted Project

Apr 17 2023

akuegel added a comment to D101442: [MLIR] Add ComplexToStandard conversion pass..

In D101442#4257833, @kiranchandramohan wrote:

The conversion of AbsOp in this patch does not account for underflows or overflows. Since it does not use higher precisions for computing the intermediate results, it might not be precise as well. We are hitting an underflow issue in Flang due to using this conversion. https://github.com/llvm/llvm-project/issues/62011
What are the plans for this pass? Would you accept fixes to improve precision or is the assumption that we should only use this pass where preciseness is not important?
Thanks in advance.

Apr 17 2023, 5:19 AM · Restricted Project, Restricted Project

akuegel committed rG418c8cbcdd8a: [mlir] Apply ClangTidy fix. (authored by akuegel).

[mlir] Apply ClangTidy fix.

Apr 17 2023, 4:51 AM · Restricted Project, Restricted Project

akuegel committed rGfa1ab9edd254: [mlir] Remove unused using llvm::Twine declaration (NFC). (authored by akuegel).

[mlir] Remove unused using llvm::Twine declaration (NFC).

Apr 17 2023, 4:16 AM · Restricted Project, Restricted Project

Apr 3 2023

akuegel committed rG4301178299e4: [mlir][spirv-cpu-runner] Add missing call to registerPassManagerCLOptions(). (authored by akuegel).

[mlir][spirv-cpu-runner] Add missing call to registerPassManagerCLOptions().

Apr 3 2023, 3:53 AM · Restricted Project, Restricted Project

Apr 2 2023

akuegel committed rG443e562f3645: [mlir] Fix ignoring return value warning. (authored by akuegel).

[mlir] Fix ignoring return value warning.

Apr 2 2023, 11:28 PM · Restricted Project, Restricted Project

Mar 30 2023

akuegel committed rG4cc248fb9f3f: [mlir] Apply ClangTidy readability fix (NFC). (authored by akuegel).

[mlir] Apply ClangTidy readability fix (NFC).

Mar 30 2023, 1:44 AM · Restricted Project, Restricted Project

Mar 28 2023

akuegel committed rGcf115f30bb36: [mlir][Bazel] Adjust BUILD file for 586cebef271f627e80c3535e7cd201915f88b349 (authored by akuegel).

[mlir][Bazel] Adjust BUILD file for 586cebef271f627e80c3535e7cd201915f88b349

Mar 28 2023, 2:57 AM · Restricted Project

akuegel committed rG25613507ccd8: [llvm][Bazel] Add missing dependency. (authored by akuegel).

[llvm][Bazel] Add missing dependency.

Mar 28 2023, 2:50 AM · Restricted Project

akuegel committed rGcdeaeeeb6430: [mlir] Apply ClangTidy readability fix (NFC) (authored by akuegel).

[mlir] Apply ClangTidy readability fix (NFC)

Mar 28 2023, 12:48 AM · Restricted Project, Restricted Project

Mar 27 2023

akuegel committed rGad09cd3f0dad: [mlir][ClangTidy] Remove redundant return (NFC). (authored by akuegel).

[mlir][ClangTidy] Remove redundant return (NFC).

Mar 27 2023, 4:04 AM · Restricted Project, Restricted Project

Mar 22 2023

akuegel committed rG57c128e4c038: [mlir][Bazel] Add missing dependency. (authored by akuegel).

[mlir][Bazel] Add missing dependency.

Mar 22 2023, 1:21 AM · Restricted Project

Mar 21 2023

akuegel committed rGdc9d2e588dd2: [mlir] Add missing registrations to runners. (authored by akuegel).

[mlir] Add missing registrations to runners.

Mar 21 2023, 7:18 AM · Restricted Project, Restricted Project

akuegel committed rG16b192f497c8: [mlir][Bazel] Adjust BUILD files to 0e9523efda8a4ad95ecb1d5b5e65e10bcc3711f5 (authored by akuegel).

[mlir][Bazel] Adjust BUILD files to 0e9523efda8a4ad95ecb1d5b5e65e10bcc3711f5

Mar 21 2023, 7:00 AM · Restricted Project

Mar 20 2023

akuegel committed rGcc69d58d7923: [mlir][Bazel] Adjust BUILD file for 930744fcdad7b326dd0337622b6e8dc99efcfa60 (authored by akuegel).

[mlir][Bazel] Adjust BUILD file for 930744fcdad7b326dd0337622b6e8dc99efcfa60

Mar 20 2023, 7:11 AM · Restricted Project

akuegel committed rGa348ba21f8d8: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC. (authored by akuegel).

[mlir][Bazel] Avoid __attribute__((weak)) for MSVC.

Mar 20 2023, 2:18 AM · Restricted Project

akuegel closed D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC..

Mar 20 2023, 2:17 AM · Restricted Project, Restricted Project

akuegel committed rG499e1a54f5bf: [mlir] Apply ClangTidy performance finding (NFC). (authored by akuegel).

[mlir] Apply ClangTidy performance finding (NFC).

Mar 20 2023, 2:14 AM · Restricted Project, Restricted Project

akuegel updated the diff for D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC..

Fix comment.

Mar 20 2023, 2:10 AM · Restricted Project, Restricted Project

akuegel updated the diff for D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC..

Add comment to explain that it might not work correctly.

Mar 20 2023, 2:09 AM · Restricted Project, Restricted Project

akuegel added a comment to D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC..

In D146405#4205618, @csigg wrote:

It seems this would result in duplicate definitions of mlir::registerGpuSerializeToCubinPass() on Windows.

Maybe we could use /alternatename?
I'm not sure how to handle mangled names though.

Alternatively, the above article also links to this approach, but getting bazel (and CMake) to link in a specific way might be tricky.