Page MenuHomePhabricator
People akuegel

akuegel (Adrian Kuegel)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2016, 7:52 AM (258 w, 4 d)

Recent Activity
View All

Sun, Jan 10

akuegel committed rGaf339f89a142: Remove redundant casts. (authored by akuegel).
Remove redundant casts.
Sun, Jan 10, 11:52 PM
akuegel closed D94305: Remove redundant casts..
Sun, Jan 10, 11:52 PM · Restricted Project

Fri, Jan 8

akuegel requested review of D94305: Remove redundant casts..
Fri, Jan 8, 6:38 AM · Restricted Project

Wed, Dec 23

akuegel added a reverting change for rGd3bf0bb18952: PR24076, PR33655, C++ CWG 1558: Consider the instantiation-dependence of: rG25a02c3d1a68: Revert "PR24076, PR33655, C++ CWG 1558: Consider the instantiation-dependence….
Wed, Dec 23, 3:42 AM
akuegel committed rG25a02c3d1a68: Revert "PR24076, PR33655, C++ CWG 1558: Consider the instantiation-dependence… (authored by akuegel).
Revert "PR24076, PR33655, C++ CWG 1558: Consider the instantiation-dependence…
Wed, Dec 23, 3:42 AM

Dec 14 2020

akuegel accepted D93124: [MLIR] Add atan and atan2 lowerings to CUDA intrinsics.

Thanks :)

Dec 14 2020, 12:02 AM · Restricted Project

Dec 13 2020

akuegel accepted D93123: [MLIR] Add lowerings for atan and atan2 to ROCDL intrinsics.

Thanks :)

Dec 13 2020, 11:44 PM · Restricted Project

Dec 11 2020

akuegel committed rG91220705632e: [mlir] Expose target configuration for lowering to ROCDL. (authored by akuegel).
[mlir] Expose target configuration for lowering to ROCDL.
Dec 11 2020, 4:27 AM
akuegel closed D93028: [mlir] Expose target configuration for lowering to ROCDL..
Dec 11 2020, 4:27 AM · Restricted Project
akuegel committed rGada4c7a35171: Add rsqrt lowering from standard to ROCDL. (authored by akuegel).
Add rsqrt lowering from standard to ROCDL.
Dec 11 2020, 4:20 AM
akuegel closed D93011: Add rsqrt lowering from standard to ROCDL..
Dec 11 2020, 4:20 AM · Restricted Project
akuegel added a comment to D93011: Add rsqrt lowering from standard to ROCDL..

Friendly ping?

Dec 11 2020, 3:52 AM · Restricted Project
akuegel added a comment to D93028: [mlir] Expose target configuration for lowering to ROCDL..

Friendly ping?

Dec 11 2020, 3:52 AM · Restricted Project

Dec 10 2020

akuegel updated the summary of D93028: [mlir] Expose target configuration for lowering to ROCDL..
Dec 10 2020, 5:04 AM · Restricted Project
akuegel requested review of D93028: [mlir] Expose target configuration for lowering to ROCDL..
Dec 10 2020, 5:03 AM · Restricted Project
akuegel requested review of D93011: Add rsqrt lowering from standard to ROCDL..
Dec 10 2020, 1:48 AM · Restricted Project
akuegel committed rG09f717b929ae: Add sqrt lowering from standard to ROCDL (authored by akuegel).
Add sqrt lowering from standard to ROCDL
Dec 10 2020, 12:48 AM
akuegel closed D92921: Add sqrt lowering from standard to ROCDL.
Dec 10 2020, 12:48 AM · Restricted Project
akuegel added inline comments to D92921: Add sqrt lowering from standard to ROCDL.
Dec 10 2020, 12:43 AM · Restricted Project

Dec 9 2020

akuegel added a comment to D92921: Add sqrt lowering from standard to ROCDL.

Ok, I just checked the recent presubmit results, and all seem to fail on Windows:
https://buildkite.com/llvm-project/premerge-checks/builds

Dec 9 2020, 6:09 AM · Restricted Project
akuegel added a comment to D92921: Add sqrt lowering from standard to ROCDL.

Frederik, it looks like there was an error on Windows during the pre-merge checks. Does that look familiar to the one you saw? Do you know if this is for real?

Dec 9 2020, 6:05 AM · Restricted Project
akuegel added a reviewer for D92921: Add sqrt lowering from standard to ROCDL: frgossen.
Dec 9 2020, 6:04 AM · Restricted Project
akuegel added a comment to D92921: Add sqrt lowering from standard to ROCDL.

I have copied the Sqrt test for the GPUToNVVM lowering and adapted it.

Dec 9 2020, 2:16 AM · Restricted Project
akuegel updated the diff for D92921: Add sqrt lowering from standard to ROCDL.

Add test.

Dec 9 2020, 2:15 AM · Restricted Project
akuegel added a comment to D92921: Add sqrt lowering from standard to ROCDL.

Working on a test now.

Dec 9 2020, 2:02 AM · Restricted Project
akuegel added inline comments to D92921: Add sqrt lowering from standard to ROCDL.
Dec 9 2020, 2:01 AM · Restricted Project
akuegel updated the diff for D92921: Add sqrt lowering from standard to ROCDL.

Fixed copy/paste bug.

Dec 9 2020, 2:00 AM · Restricted Project
akuegel requested review of D92921: Add sqrt lowering from standard to ROCDL.
Dec 9 2020, 1:47 AM · Restricted Project

Nov 11 2020

akuegel committed rGa719eef73ec4: MLIR: Remove TanhOp from ops list. It caused a build failure. (authored by akuegel).
MLIR: Remove TanhOp from ops list. It caused a build failure.
Nov 11 2020, 6:00 AM
akuegel committed rG5248047c9396: MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64 (authored by akuegel).
MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64
Nov 11 2020, 5:40 AM
akuegel closed D91252: MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64.
Nov 11 2020, 5:39 AM · Restricted Project
akuegel added a comment to D91252: MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64.

Thanks for the review comments :)

Nov 11 2020, 5:30 AM · Restricted Project
akuegel updated the diff for D91252: MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64.

Address review comments.

Nov 11 2020, 5:29 AM · Restricted Project
akuegel added a reviewer for D91252: MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64: ftynse.
Nov 11 2020, 5:22 AM · Restricted Project
akuegel requested review of D91252: MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64.
Nov 11 2020, 5:18 AM · Restricted Project

Oct 15 2020

akuegel committed rGead2aa7098cf: Fix unused variable warning when compiling with asserts disabled. (authored by akuegel).
Fix unused variable warning when compiling with asserts disabled.
Oct 15 2020, 3:56 AM
akuegel closed D89454: Fix unused variable warning when compiling with asserts disabled..
Oct 15 2020, 3:56 AM · Restricted Project
akuegel added a reviewer for D89454: Fix unused variable warning when compiling with asserts disabled.: bkramer.
Oct 15 2020, 3:52 AM · Restricted Project
akuegel requested review of D89454: Fix unused variable warning when compiling with asserts disabled..
Oct 15 2020, 3:50 AM · Restricted Project

Jul 17 2020

akuegel committed rGde0c6bd56b41: Add -o /dev/null to make it explicit that we don't care about the compiler… (authored by akuegel).
Add -o /dev/null to make it explicit that we don't care about the compiler…
Jul 17 2020, 5:23 AM

Jul 16 2020

akuegel committed rG1067d3e176ea: Revert "[NFCI] createCFGSimplificationPass(): migrate to also take… (authored by akuegel).
Revert "[NFCI] createCFGSimplificationPass(): migrate to also take…
Jul 16 2020, 1:58 AM
akuegel added a reverting change for rGb2018198c32a: [NFCI] createCFGSimplificationPass(): migrate to also take SimplifyCFGOptions: rG1067d3e176ea: Revert "[NFCI] createCFGSimplificationPass(): migrate to also take….
Jul 16 2020, 1:58 AM
akuegel committed rG5831e8619096: Revert "[NFC] SimplifyCFGOptions: drop multi-parameter ctor, use default member… (authored by akuegel).
Revert "[NFC] SimplifyCFGOptions: drop multi-parameter ctor, use default member…
Jul 16 2020, 1:51 AM
akuegel added a reverting change for rG90c1b0442a03: [NFC] SimplifyCFGOptions: drop multi-parameter ctor, use default member-init: rG5831e8619096: Revert "[NFC] SimplifyCFGOptions: drop multi-parameter ctor, use default member….
Jul 16 2020, 1:51 AM

Mar 20 2020

akuegel added a reverting change for rGe9f22fd4293a: [TableGen][GlobalISel] Account for HwMode in RegisterBank register sizes: rGbaa6f6a7828a: Revert "[TableGen][GlobalISel] Account for HwMode in RegisterBank register….
Mar 20 2020, 3:13 AM
akuegel committed rGbaa6f6a7828a: Revert "[TableGen][GlobalISel] Account for HwMode in RegisterBank register… (authored by akuegel).
Revert "[TableGen][GlobalISel] Account for HwMode in RegisterBank register…
Mar 20 2020, 3:13 AM
akuegel added inline comments to D76007: [WIP][TableGen][GlobalISel] Account for HwMode in RegisterBank register sizes.
Mar 20 2020, 3:13 AM · Restricted Project

Mar 19 2020

akuegel added a reverting change for rG79a7ed92a9b1: CFGDiff: Simplify/common the begin/end implementations to use a common range…: rG4a7f2032a350: Revert "CFGDiff: Simplify/common the begin/end implementations to use a common….
Mar 19 2020, 3:45 AM
akuegel committed rG4a7f2032a350: Revert "CFGDiff: Simplify/common the begin/end implementations to use a common… (authored by akuegel).
Revert "CFGDiff: Simplify/common the begin/end implementations to use a common…
Mar 19 2020, 3:45 AM

Mar 17 2020

akuegel committed rG5156e38eb1d3: Fix memtag test. (authored by akuegel).
Fix memtag test.
Mar 17 2020, 3:44 AM
akuegel closed D76272: Fix memtag test..
Mar 17 2020, 3:44 AM · Restricted Project
akuegel created D76272: Fix memtag test..
Mar 17 2020, 3:00 AM · Restricted Project
akuegel added a reviewer for D76272: Fix memtag test.: bkramer.
Mar 17 2020, 3:00 AM · Restricted Project

Mar 6 2020

akuegel committed rG86306df7dd2a: Extract common code to deal with multidimensional vectors. (authored by akuegel).
Extract common code to deal with multidimensional vectors.
Mar 6 2020, 4:59 AM
akuegel closed D75733: Extract common code to deal with multidimensional vectors..
Mar 6 2020, 4:59 AM · Restricted Project
akuegel added inline comments to D75733: Extract common code to deal with multidimensional vectors..
Mar 6 2020, 4:57 AM · Restricted Project
akuegel updated the diff for D75733: Extract common code to deal with multidimensional vectors..

Addressed review comments.

Mar 6 2020, 4:57 AM · Restricted Project
akuegel added inline comments to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Mar 6 2020, 4:24 AM · Restricted Project
akuegel created D75733: Extract common code to deal with multidimensional vectors..
Mar 6 2020, 4:24 AM · Restricted Project

Mar 5 2020

akuegel closed D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Landed as revision 91acb5b3e1c3
Unforunately I forgot to reset the link to this review, after I had accidentally created https://reviews.llvm.org/D75353

Mar 5 2020, 6:35 AM · Restricted Project

Mar 4 2020

akuegel committed rG91acb5b3e1c3: Add rsqrt op to Standard dialect and lower it to LLVM dialect. (authored by akuegel).
Add rsqrt op to Standard dialect and lower it to LLVM dialect.
Mar 4 2020, 4:34 AM
akuegel added a comment to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Sorry for not following up sooner, I was busy with other stuff yesterday. Today, with some help by Stephan I was able to make this work. I copied the handling with unrolling multi-dimensional vectors from the generic elementwise op handling. This could potentially be refactored, especially I wonder whether Tanh should also use this.

Mar 4 2020, 3:59 AM · Restricted Project
akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Handle vector types.

Mar 4 2020, 3:58 AM · Restricted Project

Mar 2 2020

akuegel added a comment to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

PTAL. The tests seem to work now.

Mar 2 2020, 5:29 AM · Restricted Project
akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Fix type issues.

Mar 2 2020, 5:29 AM · Restricted Project
akuegel added inline comments to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Mar 2 2020, 5:02 AM · Restricted Project
akuegel added inline comments to D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Mar 2 2020, 5:02 AM · Restricted Project
akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Don't hard-code constant to have type F32.

Mar 2 2020, 5:02 AM · Restricted Project

Feb 28 2020

akuegel updated the diff for D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Fix ClangTidy warnings.

Feb 28 2020, 7:17 AM · Restricted Project
akuegel abandoned D75353: Add rsqrt op to Standard dialect and lower it to LLVM dialect..

Sorry, I accidentally created a new patch instead of updating the old one. Abandoning this.

Feb 28 2020, 7:17 AM · Restricted Project
akuegel created D75353: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Feb 28 2020, 7:06 AM · Restricted Project
akuegel created D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect..
Feb 28 2020, 7:05 AM · Restricted Project

Feb 27 2020

akuegel committed rG39e1c1fa9ee0: Add GPU lowerings for the different log ops. (authored by akuegel).
Add GPU lowerings for the different log ops.
Feb 27 2020, 9:50 AM
akuegel closed D75239: Add GPU lowerings for the different log ops..

Landed as 39e1c1fa9ee03e91751e505d747275e58069e6de

Feb 27 2020, 6:33 AM · Restricted Project
akuegel created D75239: Add GPU lowerings for the different log ops..
Feb 27 2020, 4:05 AM · Restricted Project

Feb 12 2020

akuegel abandoned D74406: Add RsqrtOp to LLVM dialect..

Ok, seems we should not have this in the LLVM dialect, so I will abandon this.

Feb 12 2020, 1:20 AM · Restricted Project

Feb 11 2020

akuegel updated the summary of D74406: Add RsqrtOp to LLVM dialect..
Feb 11 2020, 6:37 AM · Restricted Project
akuegel created D74406: Add RsqrtOp to LLVM dialect..
Feb 11 2020, 6:37 AM · Restricted Project

Jan 14 2020

akuegel added a comment to D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

I fixed the clang-format error in a followup commit.
Sorry for not noticing it sooner :-(

Jan 14 2020, 2:48 AM · Restricted Project
akuegel committed rG5a6eae3dea23: [mlir] Ran git-clang-format. (authored by akuegel).
[mlir] Ran git-clang-format.
Jan 14 2020, 2:46 AM
akuegel committed rG018b042593f0: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations. (authored by akuegel).
[mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations.
Jan 14 2020, 2:38 AM
akuegel closed D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 14 2020, 2:37 AM · Restricted Project
akuegel retitled D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations. from [mlir] Add skeleton implementation of loop.parallel, loop.yield and loop.yield.return operations. to [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 14 2020, 2:00 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Addressed River's review comments.

Jan 14 2020, 1:34 AM · Restricted Project

Jan 13 2020

akuegel added inline comments to D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 13 2020, 1:57 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Addressed review comments.

Jan 13 2020, 1:57 AM · Restricted Project

Jan 10 2020

akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Ran git-clang-format.

Jan 10 2020, 4:21 AM · Restricted Project
akuegel added inline comments to D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 10 2020, 3:58 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Address review comments.

Jan 10 2020, 3:58 AM · Restricted Project

Jan 9 2020

akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Fix copy/paste issue.

Jan 9 2020, 6:56 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Addressed review comments.

Jan 9 2020, 6:37 AM · Restricted Project

Jan 8 2020

akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Also add description for loop.yield (thanks herhut@)

Jan 8 2020, 7:12 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Improved description of parallel loop operation.

Jan 8 2020, 7:03 AM · Restricted Project
akuegel updated the diff for D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..

Rebased to head.

Jan 8 2020, 5:41 AM · Restricted Project
akuegel created D72394: [mlir] Add loop.parallel, loop.reduce and loop.reduce.return operations..
Jan 8 2020, 5:14 AM · Restricted Project

Jun 19 2018

akuegel committed rL335028: Add a factory method to ConstantDataArray that allows to pass in the data as….
Add a factory method to ConstantDataArray that allows to pass in the data as…
Jun 19 2018, 1:17 AM
akuegel closed D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.
Jun 19 2018, 1:17 AM

Jun 13 2018

akuegel added a comment to D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.

Friendly ping?

Jun 13 2018, 1:42 AM

Jun 8 2018

akuegel updated the diff for D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef.

Addressed review comments:

  • renamed method to getRaw
  • added more comments regarding supported types and endianness
Jun 8 2018, 3:07 AM

Jun 7 2018

akuegel added a reviewer for D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef: efriedma.
Jun 7 2018, 7:22 AM