Page MenuHomePhabricator

[BitcodeAnalyzer] allow a motivated user to dump BLOCKINFO
Needs ReviewPublic

Authored by woodruffw on Aug 4 2021, 10:15 PM.

Details

Summary

This adds the --dump-blockinfo flag to llvm-bcanalyzer, allowing a sufficiently motivated user to dump (parts of) the BLOCKINFO_BLOCK block. The default behavior is unchanged, and --dump-blockinfo only takes effect in the same context as other flags that control dump behavior (i.e., requires that --dump is also passed).

Diff Detail

Event Timeline

woodruffw created this revision.Aug 4 2021, 10:15 PM
woodruffw requested review of this revision.Aug 4 2021, 10:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 10:15 PM
woodruffw updated this revision to Diff 364348.Aug 4 2021, 10:22 PM

Sorry for the churn; rebased the commit so that it sits on the latest main instead of an old one.

woodruffw updated this revision to Diff 364557.Aug 5 2021, 11:10 AM

Fixed the diff tests.

Gentle ping for review on this!

Another gentle ping for review here. Please let me know if there's anything else I can do.

Another ping for review.

xgupta added reviewers: dexonsmith, tejohnson.EditedTue, Sep 14, 11:21 AM
xgupta added a subscriber: xgupta.

To make it convenient to get reviewing, please upload the patches with context, see documentation - https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
git show HEAD -U999999 > mypatch.patch or arc diff HEAD~

Added context to the patch.

Thanks! I've updated the diff to include context.