This is an archive of the discontinued LLVM Phabricator instance.

Differential D107287

[MLIR][NFC] Get DiagnosticEngine as a reference in doc
ClosedPublic

Authored by gAlfonso-bit on Aug 2 2021, 9:34 AM.

Details

Reviewers
rdzhabarov
Commits
rGfb27e8c76e04: [MLIR][NFC] Get DiagnosticEngine as a reference in doc
Summary

'mlir::DiagnosticEngine::DiagnosticEngine(const mlir::DiagnosticEngine&)' is implicitly deleted because the default definition would be ill-formed.

Diff Detail

Event Timeline

gAlfonso-bit created this revision.Aug 2 2021, 9:34 AM
Herald added subscribers: Chia-hungDuan, dcaballe, cota and 17 others. · View Herald TranscriptAug 2 2021, 9:34 AM
gAlfonso-bit requested review of this revision.Aug 2 2021, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2021, 9:34 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
gAlfonso-bit added a reviewer: Restricted Project.Aug 2 2021, 9:35 AM
rdzhabarov accepted this revision.Aug 2 2021, 10:10 AM

Nit:

[MLIR] get DiagnosticEngine as a reference

could you add [NFC] as well.

This revision is now accepted and ready to land.Aug 2 2021, 10:10 AM
GMNGeoffrey removed a reviewer: Restricted Project.Aug 2 2021, 10:11 AM
gAlfonso-bit retitled this revision from [MLIR] get DiagnosticEngine as a reference to [MLIR][NFC] get DiagnosticEngine as a reference.Aug 2 2021, 10:11 AM

Done! Maybe we can also cherry pick this to release 13 too since its a NFC change?

Harbormaster completed remote builds in B117469: Diff 363497.Aug 2 2021, 10:29 AM
gAlfonso-bit edited the summary of this revision. (Show Details)Aug 2 2021, 11:20 AM
gAlfonso-bit edited the summary of this revision. (Show Details)
gAlfonso-bit retitled this revision from [MLIR][NFC] get DiagnosticEngine as a reference to [MLIR][NFC] Get DiagnosticEngine as a reference in doc.
gAlfonso-bit added a comment.EditedAug 4 2021, 8:01 AM

Any updates? @rdzhabarov

Herald added a subscriber: wrengr. · View Herald TranscriptAug 4 2021, 8:01 AM
rdzhabarov added a comment.Aug 4 2021, 11:38 AM
In D107287#2925507, @gAlfonso-bit wrote:

Any updates? @rdzhabarov

Looks like I need to get your "First Last <first.last@domain.tld>" in order to get this diff merged.
I'm not sure about the release aspect you are asking.

gAlfonso-bit added a comment.Aug 4 2021, 11:46 AM
This comment was removed by gAlfonso-bit.
Closed by commit rGfb27e8c76e04: [MLIR][NFC] Get DiagnosticEngine as a reference in doc (authored by gAlfonso-bit, committed by rdzhabarov). · Explain WhyAug 4 2021, 12:01 PM
This revision was automatically updated to reflect the committed changes.
rdzhabarov added a commit: rGfb27e8c76e04: [MLIR][NFC] Get DiagnosticEngine as a reference in doc.
rdzhabarov added a comment.Aug 4 2021, 12:03 PM
In D107287#2926374, @gAlfonso-bit wrote:

release 13 I mean (since this is just a doc update), and it is "Alfsonso Gregory <gfunni234@gmail.com>" @rdzhabarov

Merged, but I'm not sure about the policies around releases. @mehdi_amini

Revision Contents

PathSize
mlir/
docs/
2 lines

Diff 363497

mlir/docs/Diagnostics.md

Context not available.
can be interfaced with via an `MLIRContext` instance. can be interfaced with via an `MLIRContext` instance.
```c++ ```c++
DiagnosticEngine engine = ctx->getDiagEngine(); DiagnosticEngine& engine = ctx->getDiagEngine();
/// Handle the reported diagnostic. /// Handle the reported diagnostic.
// Return success to signal that the diagnostic has either been fully processed, // Return success to signal that the diagnostic has either been fully processed,
Context not available.