This is an archive of the discontinued LLVM Phabricator instance.

Differential D106964

[Security] Replace a Sony member
ClosedPublic

Authored by probinson on Jul 28 2021, 7:57 AM.

Details

Reviewers
ab
apilipenko
dim
emaste
kristof.beyls
mattdr
ojhunt
peter.smith
pietroalbini
serge-sans-paille
Shayne
steveklabnik
george.burgess.iv
Summary

Josh Eads, a member from Sony's Security team, is leaving the company.
He nominates Tim Penge from his former group as his replacement.

Presuming D106917 is accepted, I've added [] as a placeholder for Tim's Phabricator account. I'll contact Tim about that and fill it in as appropriate.

Diff Detail

Unit TestsFailed

TimeTest
1,220 msx64 windows > Clang.ClangScanDeps::modules-full.cpp

Event Timeline

probinson requested review of this revision.Jul 28 2021, 7:57 AM
probinson created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 7:57 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B116696: Diff 362386.Jul 28 2021, 9:00 AM
dim accepted this revision.Jul 28 2021, 1:39 PM

LGTM

This revision is now accepted and ready to land.Jul 28 2021, 1:39 PM
pietroalbini accepted this revision.Jul 28 2021, 2:09 PM
emaste accepted this revision.Jul 28 2021, 2:12 PM
emaste added inline comments.
llvm/docs/Security.rst
51

To be pedantic we should land D106917 first or leave the [] out and add it with that change

mattdr accepted this revision.Jul 28 2021, 10:41 PM

Happy to welcome Tim, agree with @emaste 's comment

peter.smith accepted this revision.Jul 29 2021, 7:47 AM

LGTM too.

probinson added inline comments.Jul 29 2021, 2:58 PM
llvm/docs/Security.rst
51

I admire your pedantry and intend to wait for the other to land.

george.burgess.iv accepted this revision.Jul 29 2021, 3:50 PM

Welcome! :)

llvm/docs/Security.rst
51

As a fellow average pedantry enjoyer, it just landed as 4c98e9455aadee2629dd4f117b6c4e7e9e87cc01 :)

kristof.beyls accepted this revision.Aug 9 2021, 5:07 AM
probinson updated this revision to Diff 365188.Aug 9 2021, 8:13 AM

Rebase

Harbormaster completed remote builds in B118679: Diff 365188.Aug 9 2021, 8:41 AM
probinson added a subscriber: tpenge.Aug 10 2021, 9:53 AM
probinson closed this revision.Aug 10 2021, 9:56 AM

Committed as https://github.com/llvm/llvm-project/commit/ca58d9af738a3d70c0740130a874b4a84935e6ea
(sorry forgot to add the Differential Revision tag to the commit message).

Revision Contents

PathSize
llvm/
docs/
2 lines

Diff 362386

llvm/docs/Security.rst

Show All 32 Lines
The members of the group represent a wide cross-section of the community, and meet the criteria for inclusion below. The members of the group represent a wide cross-section of the community, and meet the criteria for inclusion below.
* Ahmed Bougacha (Apple) * Ahmed Bougacha (Apple)
* Artur Pilipenko (Azul Systems Inc) * Artur Pilipenko (Azul Systems Inc)
* Dimitry Andric (individual; FreeBSD) * Dimitry Andric (individual; FreeBSD)
* Ed Maste (individual; FreeBSD) * Ed Maste (individual; FreeBSD)
* George Burgess IV (Google) * George Burgess IV (Google)
* Josh Eads (Sony)
* Kate McInnes (Apple) * Kate McInnes (Apple)
* Kristof Beyls (ARM) * Kristof Beyls (ARM)
* Matthew Riley (Google) * Matthew Riley (Google)
* Oliver Hunt (Apple) * Oliver Hunt (Apple)
* Paul Robinson (Sony) * Paul Robinson (Sony)
* Peter Smith (ARM) * Peter Smith (ARM)
* Pietro Albini (individual; Rust) * Pietro Albini (individual; Rust)
* Serge Guelton (RedHat) * Serge Guelton (RedHat)
* Shayne Hiet-Block (Microsoft) * Shayne Hiet-Block (Microsoft)
* Steve Klabnik (Oxide Computer Company; Rust) * Steve Klabnik (Oxide Computer Company; Rust)
* Tim Penge (Sony) []
emasteUnsubmitted
Not Done
ReplyInline Actions

To be pedantic we should land D106917 first or leave the [] out and add it with that change

emaste: To be pedantic we should land D106917 first or leave the [] out and add it with that change
probinsonAuthorUnsubmitted
Done
ReplyInline Actions

I admire your pedantry and intend to wait for the other to land.

probinson: I admire your pedantry and intend to wait for the other to land.
george.burgess.ivUnsubmitted
Done
ReplyInline Actions

As a fellow average pedantry enjoyer, it just landed as 4c98e9455aadee2629dd4f117b6c4e7e9e87cc01 :)

george.burgess.iv: As a fellow average pedantry enjoyer, it just landed as…
Criteria Criteria
-------- --------
* Nominees for LLVM Security Group membership should fall in one of these groups: * Nominees for LLVM Security Group membership should fall in one of these groups:
- Individual contributors: - Individual contributors:
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines