[mlir] Truncate/skip long strings in ViewOpGraph.cpp

[springerm]

Summary

• New pass option max-label-len: Truncate attributes/result types that have more #chars.
• New pass option print-attrs: Activate/deactivate rendering of attributes.
• New pass option printResultTypes: Activate/deactivate rendering of result types.

Depends On D106253

[springerm]

rebase

[springerm]

address comments

[springerm]

minor update

[rriddle]

mlir/include/mlir/Transforms/Passes.td

704

The name here is a bit confusing, this isn't just attributes. Can you change this to something more general?

[springerm]

rebase

[springerm]

rebase

[springerm]

rebase

mlir/include/mlir/Transforms/Passes.td

let description = [{
 
     - Operations are represented as nodes;
     - Uses as edges;
     - Regions/blocks as subgraphs.
 
     Note: See https://www.graphviz.org/doc/info/lang.html for more information
     about the Graphviz DOT language.
   }];
+  let options = [
+    Option<"maxLabelLen", "max-label-len", "unsigned",
+            /*default=*/"20", "Limit attribute/type length to number of chars">,
+    Option<"printAttrs", "print-attrs", "bool",
+           /*default=*/"true", "Print attributes of operations">,
+    Option<"printResultTypes", "print-result-types", "bool",
+            /*default=*/"true", "Print result types of operations">
+  ];
   let constructor = "mlir::createPrintOpGraphPass()";
 }
 
 #endif // MLIR_TRANSFORMS_PASSES

mlir/lib/Transforms/ViewOpGraph.cpp

void emitMlirAttr(raw_ostream &os, Attribute attr) {
 
     auto array = attr.dyn_cast<ArrayAttr>();
     if (array && static_cast<int64_t>(array.size()) > largeAttrLimit) {
       os << "[...]";
       return;
     }
 
     // Print all other attributes.
-    attr.print(os);
+    std::string buf;
+    llvm::raw_string_ostream ss(buf);
+    attr.print(ss);
+    os << truncateString(ss.str());
   }
 
   /// Append an edge to the list of edges.
   /// Note: Edges are written to the output stream via `emitAllEdgeStmts`.
   void emitEdgeStmt(Node n1, Node n2, std::string label,
                     StringRef style = kLineStyleDataFlow) {
     AttributeMap attrs;
     attrs["style"] = style.str();
Node emitNodeStmt(std::string label, StringRef shape = kShapeNode) {
     os << ";\n";
     return Node(nodeId);
   }
 
   /// Generate a label for an operation.
   std::string getLabel(Operation *op) {
     return strFromOs([&](raw_ostream &os) {
       // Print operation name and type.
-      os << op->getName() << " : (";
-      interleaveComma(op->getResultTypes(), os);
-      os << ")\n";
+      os << op->getName();
+      if (printResultTypes) {
+        os << " : (";
+        std::string buf;
+        llvm::raw_string_ostream ss(buf);
+        interleaveComma(op->getResultTypes(), ss);
+        os << truncateString(ss.str()) << ")";
+        os << ")";
+      }
 
       // Print attributes.
+      if (printAttrs) {
+        os << "\n";
         for (const NamedAttribute &attr : op->getAttrs()) {
           os << '\n' << attr.first << ": ";
           emitMlirAttr(os, attr.second);
         }
+      }
     });
   }
 
   /// Generate a label for a block argument.
   std::string getLabel(BlockArgument arg) {
     return "arg" + std::to_string(arg.getArgNumber());
   }
 
private:
   }
 
   /// Process a region.
   void processRegion(Region &region) {
     for (Block &block : region.getBlocks())
       processBlock(block);
   }
 
+  /// Truncate long strings.
+  std::string truncateString(std::string str) {
+    if (str.length() <= maxLabelLen)
+      return str;
+    return str.substr(0, maxLabelLen) + "...";
+  }
+
   /// Output stream to write DOT file to.
   raw_indented_ostream os;
   /// A list of edges. For simplicity, should be emitted after all nodes were
   /// emitted.
   std::vector<std::string> edges;
   /// Mapping of SSA values to Graphviz nodes/clusters.
   DenseMap<Value, Node> valueToNode;
   /// Counter for generating unique node/subgraph identifiers.