This is an archive of the discontinued LLVM Phabricator instance.

Differential D106093

SubstTemplateTypeParmType can contain an 'auto' type in their replacement type
ClosedPublic

Authored by serge-sans-paille on Jul 15 2021, 1:08 PM.

Details

Reviewers
rsmith
aaron.ballman
Commits
rG8ada884cbc2f: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type
Summary

This fixes bug 36064

Diff Detail

Unit TestsFailed

TimeTest
2,510 msx64 debian > libarcher.critical::critical.c
2,460 msx64 debian > libarcher.critical::lock-nested.c
2,610 msx64 debian > libarcher.critical::lock.c
2,630 msx64 debian > libarcher.races::critical-unrelated.c
2,820 msx64 debian > libarcher.races::lock-nested-unrelated.c
View Full Test Results (20 Failed)

Event Timeline

serge-sans-paille created this revision.Jul 15 2021, 1:08 PM
Herald added a subscriber: kristof.beyls. · View Herald TranscriptJul 15 2021, 1:08 PM
serge-sans-paille requested review of this revision.Jul 15 2021, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2021, 1:08 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B114332: Diff 359101.Jul 15 2021, 2:58 PM
aaron.ballman accepted this revision.Jul 16 2021, 5:13 AM

LGTM aside from a style nit, thanks for the fix!

clang/lib/AST/Type.cpp
1804
This revision is now accepted and ready to land.Jul 16 2021, 5:13 AM
This revision was landed with ongoing or failed builds.Jul 16 2021, 5:36 AM
Closed by commit rG8ada884cbc2f: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type (authored by serge-sans-paille). · Explain Why
This revision was automatically updated to reflect the committed changes.
serge-sans-paille added a commit: rG8ada884cbc2f: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type.

Revision Contents

PathSize
clang/
lib/
AST/
3 lines
test/
SemaCXX/
8 lines

Diff 359101

clang/lib/AST/Type.cpp

Show First 20 Lines • Show All 1,795 Lines • ▼ Show 20 Lines public:
} }
// The deduced type itself. // The deduced type itself.
Type *VisitDeducedType(const DeducedType *AT) { Type *VisitDeducedType(const DeducedType *AT) {
return const_cast<DeducedType*>(AT); return const_cast<DeducedType*>(AT);
} }
// Only these types can contain the desired 'auto' type. // Only these types can contain the desired 'auto' type.
Type *VisitSubstTemplateTypeParmType(SubstTemplateTypeParmType const *T) {
aaron.ballmanUnsubmitted
Not Done
ReplyInline Actions
// Only these types can contain the desired 'auto' type.
- Type *VisitSubstTemplateTypeParmType(SubstTemplateTypeParmType const *T) {
+ Type *VisitSubstTemplateTypeParmType(const SubstTemplateTypeParmType *T) {
return Visit(T->getReplacementType());
aaron.ballman:
return Visit(T->getReplacementType());
}
Type *VisitElaboratedType(const ElaboratedType *T) { Type *VisitElaboratedType(const ElaboratedType *T) {
return Visit(T->getNamedType()); return Visit(T->getNamedType());
} }
Type *VisitPointerType(const PointerType *T) { Type *VisitPointerType(const PointerType *T) {
return Visit(T->getPointeeType()); return Visit(T->getPointeeType());
} }
▲ Show 20 Lines • Show All 2,609 Lines • Show Last 20 Lines

clang/test/SemaCXX/crash-auto-36064.cpp

  • This file was added.
// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify
template <typename A, decltype(new A)> // expected-error{{new expression for type 'auto' requires a constructor argument}}
struct b;
struct d {
static auto c = ; // expected-error{{expected expression}}
decltype(b<decltype(c), int>); // expected-error{{expected '(' for function-style cast or type construction}}
// expected-note@-1{{while substituting prior template arguments into non-type template parameter [with A = auto]}}
};