Page MenuHomePhabricator

[ARM][llvm-objdump] Annotate PC-relative memory operands
ClosedPublic

Authored by ikudrin on Jul 14 2021, 7:17 AM.

Details

Summary

This implements MCInstrAnalysis::evaluateMemoryOperandAddress() for Arm so that the disassembler can print the target address of memory operands that use PC+immediate addressing.

Diff Detail

Event Timeline

ikudrin created this revision.Jul 14 2021, 7:17 AM
ikudrin requested review of this revision.Jul 14 2021, 7:17 AM
MaskRay added a comment.EditedJul 24 2021, 2:18 PM

LGTM. I added similar things for other targets but I don't have time to learn the implications of 32-bit ARM :( But I am happy to see this.
(Can't accept because there is quite a bit of ARM code which needs someone with more knowledge to review this.)

ikudrin updated this revision to Diff 363396.Aug 2 2021, 1:37 AM
  • Fix Lint warnings

Thanks, @MaskRay!

Ping.

MaskRay accepted this revision.Aug 3 2021, 7:05 PM
This revision is now accepted and ready to land.Aug 3 2021, 7:05 PM