This is an archive of the discontinued LLVM Phabricator instance.

Differential D105783

[test] Move AMDGPU reloc test from Object to tools/llvm-readobj and simplify it
ClosedPublic

Authored by MaskRay on Jul 11 2021, 11:26 AM.

Details

Reviewers
abidh
dp
arsenm
jhenderson
tstellar
Commits
rGa95f56f60089: [test] Move AMDGPU reloc test from Object to tools/llvm-readobj and simplify it
Summary

We already have some reloc-types-elf-*.test serving the similar purpose.

Diff Detail

Unit TestsFailed

TimeTest
2,730 msx64 debian > libarcher.critical::critical.c
2,970 msx64 debian > libarcher.races::critical-unrelated.c
3,010 msx64 debian > libarcher.races::lock-nested-unrelated.c
2,750 msx64 debian > libarcher.races::lock-unrelated.c
3,020 msx64 debian > libarcher.races::parallel-simple.c
View Full Test Results (15 Failed)

Event Timeline

MaskRay created this revision.Jul 11 2021, 11:26 AM
Herald added subscribers: kerbowa, rupprecht, t-tye and 8 others. · View Herald TranscriptJul 11 2021, 11:26 AM
MaskRay requested review of this revision.Jul 11 2021, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2021, 11:26 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B113416: Diff 357813.Jul 11 2021, 11:59 AM
jhenderson accepted this revision.Jul 12 2021, 4:12 AM

LGTM.

This revision is now accepted and ready to land.Jul 12 2021, 4:12 AM
This revision was landed with ongoing or failed builds.Jul 12 2021, 10:04 AM
Closed by commit rGa95f56f60089: [test] Move AMDGPU reloc test from Object to tools/llvm-readobj and simplify it (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rGa95f56f60089: [test] Move AMDGPU reloc test from Object to tools/llvm-readobj and simplify it.

Revision Contents

PathSize
llvm/
test/
Object/
AMDGPU/
tools/
llvm-readobj/
ELF/
45 lines

Diff 357813

llvm/test/Object/AMDGPU/elf64-relocs.yaml

  • This file was deleted.
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj -r %t | FileCheck %s
# CHECK: Relocations [
# CHECK: Section (2) .rela.text {
# CHECK: 0x0 R_AMDGPU_NONE - 0x0
# CHECK: 0x2 R_AMDGPU_ABS32_LO - 0x0
# CHECK: 0x4 R_AMDGPU_ABS32_HI - 0x0
# CHECK: 0x6 R_AMDGPU_ABS64 - 0x0
# CHECK: 0x8 R_AMDGPU_REL32 - 0x0
# CHECK: 0x10 R_AMDGPU_REL64 - 0x0
# CHECK: 0x12 R_AMDGPU_ABS32 - 0x0
# CHECK: 0x14 R_AMDGPU_GOTPCREL - 0x0
# CHECK: 0x16 R_AMDGPU_GOTPCREL32_LO - 0x0
# CHECK: 0x18 R_AMDGPU_GOTPCREL32_HI - 0x0
# CHECK: 0x20 R_AMDGPU_REL32_LO - 0x0
# CHECK: 0x22 R_AMDGPU_REL32_HI - 0x0
# CHECK: 0x24 R_AMDGPU_RELATIVE64 - 0x0
# CHECK: }
# CHECK: ]
!ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_AMDGPU
Sections:
- Type: SHT_PROGBITS
Name: .text
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
AddressAlign: 0x08
Content: 0000000000000000
- Type: SHT_RELA
Name: .rela.text
Link: .symtab
Info: .text
AddressAlign: 0x08
Relocations:
- Type: R_AMDGPU_NONE
- Offset: 0x2
Type: R_AMDGPU_ABS32_LO
- Offset: 0x4
Type: R_AMDGPU_ABS32_HI
- Offset: 0x6
Type: R_AMDGPU_ABS64
- Offset: 0x8
Type: R_AMDGPU_REL32
- Offset: 0x10
Type: R_AMDGPU_REL64
- Offset: 0x12
Type: R_AMDGPU_ABS32
- Offset: 0x14
Type: R_AMDGPU_GOTPCREL
- Offset: 0x16
Type: R_AMDGPU_GOTPCREL32_LO
- Offset: 0x18
Type: R_AMDGPU_GOTPCREL32_HI
- Offset: 0x20
Type: R_AMDGPU_REL32_LO
- Offset: 0x22
Type: R_AMDGPU_REL32_HI
- Offset: 0x24
Type: R_AMDGPU_RELATIVE64
Symbols:
- Name: .text
Type: STT_SECTION
Section: .text
- Name: main
Type: STT_FUNC
Section: .text
Size: 0x08
Binding: STB_GLOBAL

llvm/test/tools/llvm-readobj/ELF/reloc-types-elf-amdgpu.test

  • This file was added.
## Test that llvm-readobj/llvm-readelf shows proper relocation type
## names and values for AMDGPU target.
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj -r %t | FileCheck %s
# CHECK: Section ({{.*}}) .rela.text {
# CHECK-NEXT: 0x0 R_AMDGPU_NONE - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_ABS32_LO - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_ABS32_HI - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_ABS64 - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_REL32 - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_REL64 - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_ABS32 - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_GOTPCREL - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_GOTPCREL32_LO - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_GOTPCREL32_HI - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_REL32_LO - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_REL32_HI - 0x0
# CHECK-NEXT: 0x0 R_AMDGPU_RELATIVE64 - 0x0
# CHECK-NEXT: }
!ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_AMDGPU
Sections:
- Name: .rela.text
Type: SHT_RELA
Relocations:
- Type: R_AMDGPU_NONE
- Type: R_AMDGPU_ABS32_LO
- Type: R_AMDGPU_ABS32_HI
- Type: R_AMDGPU_ABS64
- Type: R_AMDGPU_REL32
- Type: R_AMDGPU_REL64
- Type: R_AMDGPU_ABS32
- Type: R_AMDGPU_GOTPCREL
- Type: R_AMDGPU_GOTPCREL32_LO
- Type: R_AMDGPU_GOTPCREL32_HI
- Type: R_AMDGPU_REL32_LO
- Type: R_AMDGPU_REL32_HI
- Type: R_AMDGPU_RELATIVE64