This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][GlobalISel]Legalise some vector types for min/max
ClosedPublic

Authored by Rin on Jun 30 2021, 8:41 AM.

Details

Summary

This patch adds some vector types for the min/max instructions.

Diff Detail

Event Timeline

Rin created this revision.Jun 30 2021, 8:41 AM
Rin requested review of this revision.Jun 30 2021, 8:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2021, 8:41 AM
Rin edited the summary of this revision. (Show Details)Jun 30 2021, 8:42 AM
Rin added reviewers: dmgreen, SjoerdMeijer.
paquette accepted this revision.Jun 30 2021, 9:40 AM

LGTM with one nit on the testcase.

llvm/test/CodeGen/AArch64/GlobalISel/legalize-min-max.mir
2

Run the verifier?

This revision is now accepted and ready to land.Jun 30 2021, 9:40 AM
Rin added inline comments.Jun 30 2021, 9:50 AM
llvm/test/CodeGen/AArch64/GlobalISel/legalize-min-max.mir
2

Sorry about that, I'll add it to the tests.

Rin updated this revision to Diff 355801.Jul 1 2021, 2:07 AM

Run the verifier

Rin marked an inline comment as done.Jul 1 2021, 2:07 AM
This revision was landed with ongoing or failed builds.Jul 1 2021, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Thanks Irina, we appreciate the help here 🙂.