Page MenuHomePhabricator

Rin (Irina Dobrescu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 4 2020, 6:38 AM (45 w, 3 h)

Recent Activity

Thu, Jun 10

Rin committed rGde79919e9ec9: [AArch64] Add cost tests for bitreverse (authored by Rin).
[AArch64] Add cost tests for bitreverse
Thu, Jun 10, 7:20 AM
Rin closed D102755: [AArch64] Add cost tests for bitreverse.
Thu, Jun 10, 7:20 AM · Restricted Project
Rin added inline comments to D102755: [AArch64] Add cost tests for bitreverse.
Thu, Jun 10, 2:47 AM · Restricted Project
Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Address review comment

Thu, Jun 10, 2:47 AM · Restricted Project

Wed, Jun 9

Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Address nit comment

Wed, Jun 9, 6:13 AM · Restricted Project
Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Remove unused typed from cost model table

Wed, Jun 9, 5:52 AM · Restricted Project
Rin added inline comments to D102755: [AArch64] Add cost tests for bitreverse.
Wed, Jun 9, 5:27 AM · Restricted Project
Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Address review comments

Wed, Jun 9, 4:40 AM · Restricted Project
Rin added a comment to D102755: [AArch64] Add cost tests for bitreverse.

Hey @Rin,
I don't think you need bitreverse-cost-model.ll, you can use only bitreverse.ll.
Why some costs are not being changed in bitreverse.ll?

Wed, Jun 9, 2:31 AM · Restricted Project

Mon, Jun 7

Rin updated the diff for D102755: [AArch64] Add cost tests for bitreverse.

Add adequate costs for bitreverse operations

Mon, Jun 7, 4:50 AM · Restricted Project

Wed, Jun 2

Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.
Wed, Jun 2, 7:35 AM · Restricted Project
Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

Since this change LLVM :: Analysis/CostModel/AArch64/bitreverse.ll is failing.

https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/5/logs/FAIL__LLVM__bitreverse_ll

In case it's not just a forgotten test (didn't fail in buildkite which is odd), you can find the config used here https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/3/logs/stdio.

Wed, Jun 2, 7:04 AM · Restricted Project
Rin committed rGff6fe93f2196: [AArch64][NFC] Fix failing cost-model test (authored by Rin).
[AArch64][NFC] Fix failing cost-model test
Wed, Jun 2, 7:01 AM
Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

If it takes a while to fix, can we revert this in the meantime to get the bots back to green?

Wed, Jun 2, 6:53 AM · Restricted Project
Rin added a comment to D103105: [AArch64] Optimise bitreverse lowering in ISel.

Since this change LLVM :: Analysis/CostModel/AArch64/bitreverse.ll is failing.

https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/5/logs/FAIL__LLVM__bitreverse_ll

In case it's not just a forgotten test (didn't fail in buildkite which is odd), you can find the config used here https://lab.llvm.org/buildbot/#/builders/43/builds/6828/steps/3/logs/stdio.

Wed, Jun 2, 6:11 AM · Restricted Project
Rin committed rGe971099a9b9b: [AArch64] Optimise bitreverse lowering in ISel (authored by Rin).
[AArch64] Optimise bitreverse lowering in ISel
Wed, Jun 2, 4:51 AM
Rin closed D103105: [AArch64] Optimise bitreverse lowering in ISel.
Wed, Jun 2, 4:51 AM · Restricted Project

Tue, Jun 1

Rin updated the diff for D103105: [AArch64] Optimise bitreverse lowering in ISel.

Address review comments

Tue, Jun 1, 4:18 AM · Restricted Project
Rin added inline comments to D103105: [AArch64] Optimise bitreverse lowering in ISel.
Tue, Jun 1, 12:53 AM · Restricted Project

Wed, May 26

Rin added inline comments to D103105: [AArch64] Optimise bitreverse lowering in ISel.
Wed, May 26, 5:57 AM · Restricted Project
Rin updated the diff for D103105: [AArch64] Optimise bitreverse lowering in ISel.

Add optimisation for v2i32 and v1i64 bitreverse lowering and respond to review comments

Wed, May 26, 5:56 AM · Restricted Project
Rin added inline comments to D103105: [AArch64] Optimise bitreverse lowering in ISel.
Wed, May 26, 3:44 AM · Restricted Project

Tue, May 25

Rin updated the summary of D103105: [AArch64] Optimise bitreverse lowering in ISel.
Tue, May 25, 11:27 AM · Restricted Project
Rin requested review of D103105: [AArch64] Optimise bitreverse lowering in ISel.
Tue, May 25, 11:24 AM · Restricted Project

Wed, May 19

Rin updated the summary of D102755: [AArch64] Add cost tests for bitreverse.
Wed, May 19, 3:02 AM · Restricted Project
Rin requested review of D102755: [AArch64] Add cost tests for bitreverse.
Wed, May 19, 2:54 AM · Restricted Project

Mon, May 17

Rin committed rG50511df32edf: [AArch64] Lower bitreverse in ISel (authored by Rin).
[AArch64] Lower bitreverse in ISel
Mon, May 17, 5:40 AM
Rin closed D102397: [AArch64] Lower bitreverse in ISel.
Mon, May 17, 5:40 AM · Restricted Project, Restricted Project

May 14 2021

Rin updated the diff for D102397: [AArch64] Lower bitreverse in ISel.

Add AutoUpgrade test and move bitreverse lowering

May 14 2021, 9:37 AM · Restricted Project, Restricted Project
Rin updated the diff for D102397: [AArch64] Lower bitreverse in ISel.

Remove unnecessary comment and add more bitreverse tests

May 14 2021, 5:36 AM · Restricted Project, Restricted Project

May 13 2021

Rin added a reviewer for D102397: [AArch64] Lower bitreverse in ISel: SjoerdMeijer.
May 13 2021, 6:07 AM · Restricted Project, Restricted Project
Rin updated the summary of D102397: [AArch64] Lower bitreverse in ISel.
May 13 2021, 6:03 AM · Restricted Project, Restricted Project
Rin requested review of D102397: [AArch64] Lower bitreverse in ISel.
May 13 2021, 5:59 AM · Restricted Project, Restricted Project

Dec 18 2020

Rin added inline comments to D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the summary of D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.

Remove unnecessary comments

Dec 18 2020, 8:58 AM · Restricted Project, Restricted Project, Restricted Project
Rin retitled D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive from Add Fortran Specific Semantic Checks for Allocate Directive to [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 8:56 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the summary of D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 8:55 AM · Restricted Project, Restricted Project, Restricted Project
Rin requested review of D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive.
Dec 18 2020, 8:54 AM · Restricted Project, Restricted Project, Restricted Project
Rin commandeered D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:48 AM · Restricted Project, Restricted Project
Rin changed the edit policy for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:46 AM · Restricted Project, Restricted Project
Rin changed the edit policy for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:45 AM · Restricted Project, Restricted Project
Rin added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 3:53 AM · Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Remove unnecessary global variables and add variable check and test for ExecutableAllocateDirective case

Dec 18 2020, 3:45 AM · Restricted Project, Restricted Project

Dec 14 2020

Rin added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 14 2020, 9:53 AM · Restricted Project, Restricted Project

Dec 11 2020

Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Get rid of conflicts

Dec 11 2020, 8:40 AM · Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Get rid of conflicts

Dec 11 2020, 6:17 AM · Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Rebase with Parser for Allocate Directive patch

Dec 11 2020, 4:46 AM · Restricted Project, Restricted Project

Dec 10 2020

Rin committed rGc9e967af3fc7: [flang]Add Parser Support for Allocate Directive (authored by Rin).
[flang]Add Parser Support for Allocate Directive
Dec 10 2020, 8:25 AM
Rin closed D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 10 2020, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Add comment

Dec 10 2020, 4:37 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 10 2020, 2:10 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Add DeclarativeAllocateDirective as a list within the ExecutableAllocateDirective construct

Dec 8 2020, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 8 2020, 8:36 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 8 2020, 8:25 AM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2020

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 7 2020, 2:29 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Remove white spaces

Dec 7 2020, 2:29 AM · Restricted Project, Restricted Project, Restricted Project

Dec 3 2020

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 3 2020, 6:14 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 3 2020, 6:13 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Order Enter clase function in alphabetical order

Dec 1 2020, 4:22 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Dec 1 2020, 2:37 AM · Restricted Project, Restricted Project, Restricted Project

Nov 26 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Remove unnecessary node

Nov 26 2020, 9:03 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2020

Rin updated the summary of D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Nov 25 2020, 3:22 AM · Restricted Project, Restricted Project
Rin updated the summary of D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Nov 25 2020, 3:14 AM · Restricted Project, Restricted Project
Rin retitled D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive from [flang]Add Semantic Checks for Allocate Directive to [flang]Add General Semantic Checks for Allocate Directive.
Nov 25 2020, 3:13 AM · Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Add semantic check for allocate directives within target region

Nov 25 2020, 3:12 AM · Restricted Project, Restricted Project

Nov 24 2020

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Nov 24 2020, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Nov 20 2020

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Nov 20 2020, 8:13 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Nov 20 2020, 8:11 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Add support for list of OMP allocates and add additional checks in tests.

Nov 20 2020, 4:07 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2020

Rin added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

I) Are you handling only a subset of the restrictions here? I see the following in,

  1. General restrictions.

-> allocate directives that appear in a target region must specify an allocator clause unless a requires directive with the dynamic_allocators clause is present in the same compilation unit.

  1. Fortran specific restrictions.

-> List items specified in the allocate directive must not have the ALLOCATABLE attribute unless the directive is associated with an allocate statement.
-> List items specified in an allocate directive that is associated with an allocate statement must be variables that are allocated by the allocate statement.
-> Multiple directives can only be associated with an allocate statement if list items are specified on each allocate directive.
-> If a list item has the SAVE attribute, is a common block name, or is declared in the scope of a module, then only predefined memory allocator parameters can be used in the allocator clause.
-> A type parameter inquiry cannot appear in an allocate directive.

Since the requires directive is not there I am assuming that only a subset of the check in the general restrictions can be checked now.
Please provide a clarification saying that only a subset of checks are implemented or implement the above checks.

II) A few files have no newline at end of file.

Nov 17 2020, 2:43 AM · Restricted Project, Restricted Project

Nov 11 2020

Rin updated the summary of D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Nov 11 2020, 6:44 AM · Restricted Project, Restricted Project
Rin added a comment to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Does this look okay @clementval ?

Nov 11 2020, 6:38 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Fix failing test

Nov 11 2020, 3:29 AM · Restricted Project, Restricted Project

Nov 10 2020

Rin added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Nov 10 2020, 6:43 AM · Restricted Project, Restricted Project
Rin added reviewers for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive: kiranchandramohan, clementval, kiranktp, klausler, sscalpone.
Nov 10 2020, 6:42 AM · Restricted Project, Restricted Project
Rin retitled D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive from [flang] Add Semantic Checks for Allocate Directive to [flang]Add Semantic Checks for Allocate Directive.
Nov 10 2020, 6:40 AM · Restricted Project, Restricted Project
Rin requested review of D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Nov 10 2020, 6:38 AM · Restricted Project, Restricted Project

Oct 27 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Remove unnecessary comment and add newline to test

Oct 27 2020, 9:14 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Oct 27 2020, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Oct 27 2020, 7:24 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Address review comments

Oct 27 2020, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2020

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Add Allocator Clause, Additional Tests and make the OmpObjectList optional for the Executable Allocate Clause

Oct 20 2020, 8:22 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2020

Rin updated the summary of D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Oct 19 2020, 4:09 AM · Restricted Project, Restricted Project, Restricted Project

Oct 16 2020

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Oct 16 2020, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
Rin retitled D89562: [flang]Add Parser Support for OpenMP Allocate Directive from [flang]Add Parser Support for Allocate Directive to [flang]Add Parser Support for OpenMP Allocate Directive.
Oct 16 2020, 10:00 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

clang-format

Oct 16 2020, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
Rin requested review of D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Oct 16 2020, 9:56 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2020

Rin committed rG65b9b9aa5014: Add Allocate Clause to MLIR Parallel Operation Definition (authored by Rin).
Add Allocate Clause to MLIR Parallel Operation Definition
Oct 14 2020, 9:14 AM
Rin closed D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Oct 14 2020, 9:14 AM · Restricted Project

Oct 9 2020

Rin added a reviewer for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition: rriddle.
Oct 9 2020, 9:41 AM · Restricted Project
Rin added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Oct 9 2020, 9:40 AM · Restricted Project
Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Add aditional check and remove unnecessary test

Oct 9 2020, 9:37 AM · Restricted Project
Rin committed rG63ca276dc64f: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp… (authored by Rin).
[mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp…
Oct 9 2020, 7:22 AM
Rin closed D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Oct 9 2020, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Oct 8 2020

Rin added a comment to D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

@clementval Does this look alright?

Oct 8 2020, 1:14 AM · Restricted Project, Restricted Project, Restricted Project

Oct 5 2020

Rin updated the diff for D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

Address review comments

Oct 5 2020, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Oct 5 2020, 9:12 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

Clang-format

Oct 5 2020, 9:11 AM · Restricted Project, Restricted Project, Restricted Project
Rin retitled D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition from [mlir]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition to [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Oct 5 2020, 9:09 AM · Restricted Project, Restricted Project, Restricted Project