Page MenuHomePhabricator

Rin (Irina Dobrescu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 4 2020, 6:38 AM (11 w, 6 d)

Recent Activity

Tue, Oct 20

Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Add Allocator Clause, Additional Tests and make the OmpObjectList optional for the Executable Allocate Clause

Tue, Oct 20, 8:22 AM · Restricted Project, Restricted Project

Mon, Oct 19

Rin updated the summary of D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Mon, Oct 19, 4:09 AM · Restricted Project, Restricted Project

Fri, Oct 16

Rin added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Fri, Oct 16, 10:03 AM · Restricted Project, Restricted Project
Rin retitled D89562: [flang]Add Parser Support for OpenMP Allocate Directive from [flang]Add Parser Support for Allocate Directive to [flang]Add Parser Support for OpenMP Allocate Directive.
Fri, Oct 16, 10:00 AM · Restricted Project, Restricted Project
Rin updated the diff for D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

clang-format

Fri, Oct 16, 9:59 AM · Restricted Project, Restricted Project
Rin requested review of D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Fri, Oct 16, 9:56 AM · Restricted Project, Restricted Project

Wed, Oct 14

Rin committed rG65b9b9aa5014: Add Allocate Clause to MLIR Parallel Operation Definition (authored by Rin).
Add Allocate Clause to MLIR Parallel Operation Definition
Wed, Oct 14, 9:14 AM
Rin closed D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Wed, Oct 14, 9:14 AM · Restricted Project

Fri, Oct 9

Rin added a reviewer for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition: rriddle.
Fri, Oct 9, 9:41 AM · Restricted Project
Rin added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Fri, Oct 9, 9:40 AM · Restricted Project
Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Add aditional check and remove unnecessary test

Fri, Oct 9, 9:37 AM · Restricted Project
Rin committed rG63ca276dc64f: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp… (authored by Rin).
[mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp…
Fri, Oct 9, 7:22 AM
Rin closed D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Fri, Oct 9, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Oct 8

Rin added a comment to D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

@clementval Does this look alright?

Thu, Oct 8, 1:14 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Oct 5

Rin updated the diff for D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

Address review comments

Mon, Oct 5, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Mon, Oct 5, 9:12 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

Clang-format

Mon, Oct 5, 9:11 AM · Restricted Project, Restricted Project, Restricted Project
Rin retitled D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition from [mlir]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition to [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Mon, Oct 5, 9:09 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

Address review comments

Mon, Oct 5, 9:09 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Oct 2

Rin added a comment to D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

Can you flag this commit message with [openmp] and maybe [NFC]?

Fri, Oct 2, 9:08 AM · Restricted Project, Restricted Project, Restricted Project
Rin added reviewers for D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition: kiranchandramohan, DavidTruby.
Fri, Oct 2, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.

Clang-format

Fri, Oct 2, 8:31 AM · Restricted Project, Restricted Project, Restricted Project
Rin requested review of D88740: [mlir][openmp][NFC]Remove unnecessary brackets and rephrase ParallelOp description in mlir definition.
Fri, Oct 2, 8:29 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 29

Rin added a comment to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

@ftynse Does the patch look alright?

Tue, Sep 29, 7:15 AM · Restricted Project

Mon, Sep 28

Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Address review comments

Mon, Sep 28, 9:28 AM · Restricted Project

Sep 23 2020

Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Add verifier

Sep 23 2020, 8:15 AM · Restricted Project

Sep 22 2020

Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Address review comments

Sep 22 2020, 2:50 AM · Restricted Project

Sep 21 2020

Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Address review comments.

Sep 21 2020, 7:50 AM · Restricted Project
Rin added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Sep 21 2020, 7:46 AM · Restricted Project

Sep 18 2020

Rin added reviewers for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition: kiranktp, clementval.
Sep 18 2020, 6:39 AM · Restricted Project
Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Fix Failing Test

Sep 18 2020, 3:26 AM · Restricted Project

Sep 16 2020

Rin retitled D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition from [flang]Add Allocate Clause to MLIR Parallel Operation Definition to [mlir]Add Allocate Clause to MLIR Parallel Operation Definition.
Sep 16 2020, 6:48 AM · Restricted Project
Rin retitled D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition from Add Allocate Clause to MLIR Parallel Operation Definition to [flang]Add Allocate Clause to MLIR Parallel Operation Definition.
Sep 16 2020, 1:16 AM · Restricted Project
Rin added a reviewer for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition: ftynse.
Sep 16 2020, 1:15 AM · Restricted Project
Rin updated the diff for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

Address review comments

Sep 16 2020, 1:15 AM · Restricted Project

Sep 15 2020

Rin added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Sep 15 2020, 8:24 AM · Restricted Project
Rin added reviewers for D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition: kiranchandramohan, DavidTruby.
Sep 15 2020, 4:16 AM · Restricted Project
Rin requested review of D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Sep 15 2020, 4:15 AM · Restricted Project

Sep 8 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Remove unnecessary include

Sep 8 2020, 9:31 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Sep 8 2020, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
Rin added a comment to D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Could someone outside of ARM review this patch as well please?

Sep 8 2020, 8:45 AM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Remove unnecessary print statement

Sep 4 2020, 4:05 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Change set of names to vector of names

Sep 4 2020, 3:49 AM · Restricted Project, Restricted Project, Restricted Project

Sep 3 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Change set of allocate symbols to set of allocate names

Sep 3 2020, 1:47 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Minor Updates

Sep 1 2020, 4:11 AM · Restricted Project, Restricted Project, Restricted Project

Aug 28 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Remove OpenMP 5.0 Version Check for Allocate Clause

Aug 28 2020, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Aug 28 2020, 8:39 AM · Restricted Project, Restricted Project, Restricted Project
Rin added a reviewer for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause: tskeith.
Aug 28 2020, 6:12 AM · Restricted Project, Restricted Project, Restricted Project

Aug 27 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Remove extra line

Aug 27 2020, 7:45 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Additional test and minor updates

Aug 27 2020, 1:10 AM · Restricted Project, Restricted Project, Restricted Project

Aug 26 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Semantic Check fix

Aug 26 2020, 5:12 AM · Restricted Project, Restricted Project, Restricted Project
Rin added inline comments to D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Aug 26 2020, 3:29 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Minor Changes

Aug 26 2020, 3:28 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Additional tests and fixed semantic checks.

Aug 26 2020, 2:39 AM · Restricted Project, Restricted Project, Restricted Project

Aug 20 2020

Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Remove unnecessary set

Aug 20 2020, 2:06 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Updates to Semantic Check

Aug 20 2020, 1:43 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

Rin added inline comments to D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Aug 19 2020, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
Rin updated the diff for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

Update Allocate Clause

Aug 19 2020, 8:29 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2020

Rin added a reviewer for D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause: kiranchandramohan.
Aug 17 2020, 2:17 AM · Restricted Project, Restricted Project, Restricted Project
Rin retitled D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause from Add Semantic Checks for OpenMP Allocate Clause to [flang]Add Semantic Checks for OpenMP Allocate Clause.
Aug 17 2020, 2:14 AM · Restricted Project, Restricted Project, Restricted Project
Rin added projects to D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause: Restricted Project, Restricted Project.
Aug 17 2020, 2:14 AM · Restricted Project, Restricted Project, Restricted Project
Rin requested review of D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Aug 17 2020, 2:13 AM · Restricted Project, Restricted Project, Restricted Project

Aug 6 2020

Rin added a comment to D85212: [flang] Add parser support for OpenMP allocate clause.

Do you have a negative test that checks for an out-of-place allocate?

Aug 6 2020, 3:06 AM · Restricted Project, Restricted Project

Aug 5 2020

Rin updated the diff for D85212: [flang] Add parser support for OpenMP allocate clause.

Update to get rid of formatting issues

Aug 5 2020, 2:22 AM · Restricted Project, Restricted Project
Rin updated the diff for D85212: [flang] Add parser support for OpenMP allocate clause.

[flang][OpenMP]Add parser support for OpenMP Allocate Clause Update
Added a test to check behaviour when handling a custom allocator as well as fixing formatting issues

  1. Updating D85212: Add parser support for OpenMP allocate clause #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.
Aug 5 2020, 1:36 AM · Restricted Project, Restricted Project

Aug 4 2020

Rin added reviewers for D85212: [flang] Add parser support for OpenMP allocate clause: kiranktp, klausler.
Aug 4 2020, 8:05 AM · Restricted Project, Restricted Project
Rin added a reviewer for D85212: [flang] Add parser support for OpenMP allocate clause: kiranchandramohan.
Aug 4 2020, 7:49 AM · Restricted Project, Restricted Project
Rin requested review of D85212: [flang] Add parser support for OpenMP allocate clause.
Aug 4 2020, 7:48 AM · Restricted Project, Restricted Project