Page MenuHomePhabricator

[libcxx][NFC] replaces `<functional>` includes with specific headers
Changes PlannedPublic

Authored by cjdb on Jun 26 2021, 11:05 AM.


Group Reviewers
Restricted Project

Depends on D104980.

Diff Detail

Unit TestsFailed

2,320 mslibcxx CI Windows (Static) > libc++.std/thread/thread_threads/thread_thread_class/thread_thread_member::detach.pass.cpp
Script: -- : 'COMPILED WITH'; "C:/Program Files/LLVM/bin\clang++.EXE" C:\ws\w7\llvm-project\libcxx-ci\libcxx\test\std\thread\thread.threads\thread.thread.class\thread.thread.member\detach.pass.cpp -v --target=x86_64-pc-windows-msvc -nostdinc++ -IC:/ws/w7/llvm-project/libcxx-ci/build/windows-static/include/c++/v1 -IC:/ws/w7/llvm-project/libcxx-ci/build/windows-static\include\c++build -IC:/ws/w7/llvm-project/libcxx-ci/libcxx\test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -DNOMINMAX -D_LIBCPP_HAS_NO_INT128 -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -llibc++experimental -L C:\BuildTools\VC\Tools\MSVC\14.28.29910\ATLMFC\lib\x64 -L C:\BuildTools\VC\Tools\MSVC\14.28.29910\lib\x64 -L "C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" -L "C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64" -L "C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64" -LC:/ws/w7/llvm-project/libcxx-ci/build/windows-static/lib -LC:/ws/w7/llvm-project/libcxx-ci/build/windows-static/lib -nodefaultlibs -nostdlib C:/ws/w7/llvm-project/libcxx-ci/build/windows-static/lib\libc++.lib -lvcruntime -lucrt -lmsvcrt -lmsvcprt -loldnames -o C:\ws\w7\llvm-project\libcxx-ci\build\windows-static\test\std\thread\thread.threads\thread.thread.class\thread.thread.member\Output\detach.pass.cpp.dir\t.tmp.exe

Event Timeline

cjdb requested review of this revision.Jun 26 2021, 11:05 AM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2021, 11:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb updated this revision to Diff 354707.Jun 26 2021, 2:01 PM

adds missing header (not sure why it wasn't caught earlier)

cjdb updated this revision to Diff 354713.Jun 26 2021, 4:24 PM

rebases to activate CI

cjdb updated this revision to Diff 354717.Jun 26 2021, 7:17 PM

fixes C++03 mode

cjdb updated this revision to Diff 354721.Jun 26 2021, 8:08 PM

rebases to activate CI

ldionne accepted this revision.Jun 28 2021, 9:02 AM

LGTM assuming you rebase onto the other reviews (which means that things like the 10 includes of __functional/<operation>.h will turn into a single include).

This revision is now accepted and ready to land.Jun 28 2021, 9:02 AM
cjdb updated this revision to Diff 356206.Jul 2 2021, 10:02 AM

rebases, catches a few stragglers, removes headers <functional> directly pulls in (ATTN @ldionne)

cjdb updated this revision to Diff 356293.Jul 2 2021, 4:13 PM

rebases to activate CI

cjdb updated this revision to Diff 356350.Jul 3 2021, 11:35 AM

rebases onto main

cjdb planned changes to this revision.Jul 7 2021, 1:18 PM

Blocked by D104980.