Page MenuHomePhabricator

AdvenamTacet (Tacet)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2022, 3:36 AM (17 w, 5 d)

Recent Activity

Mon, Nov 28

AdvenamTacet accepted D138771: [asan] Add unaligned double ended container support.

D138771 LGTM; I was looking on a support for unaligned double ended containers (with shared granules) in parallel, so I tested that implementation on an alternative test case I wrote independently.

Mon, Nov 28, 9:01 PM · Restricted Project, Restricted Project
AdvenamTacet accepted D138773: [NFC][asan] Cleanup comments.
Mon, Nov 28, 6:39 PM · Restricted Project, Restricted Project

Tue, Nov 8

AdvenamTacet updated the diff for D136765: [ASan][libcxx] Annotating std::vector with all allocators.

With that change, new tests were introduced instead of modifying the old one.

Tue, Nov 8, 7:10 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Nov 7

AdvenamTacet added inline comments to D136765: [ASan][libcxx] Annotating std::vector with all allocators.
Mon, Nov 7, 4:53 PM · Restricted Project, Restricted Project, Restricted Project

Nov 2 2022

AdvenamTacet updated the diff for D136765: [ASan][libcxx] Annotating std::vector with all allocators.

Turning on old check for llvm without new annotation implementation.
(Check for _LIBCPP_CLANG_VER.)

Nov 2 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2022

AdvenamTacet retitled D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory from [1b/3][compiler-rt][ASan] API for annotating objects memory to [1b/3][ASan][compiler-rt] API for annotating objects memory.
Oct 26 2022, 6:31 AM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added a project to D136765: [ASan][libcxx] Annotating std::vector with all allocators: Restricted Project.
Oct 26 2022, 6:30 AM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet requested review of D136765: [ASan][libcxx] Annotating std::vector with all allocators.
Oct 26 2022, 6:27 AM · Restricted Project, Restricted Project, Restricted Project

Oct 25 2022

AdvenamTacet updated the diff for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

Suggestions from the code review implemented.

  • Updated annotation function to support non-aligned beginning and end.
  • Implemented tests for non-aligned buffers in compiler-rt/test/asan/TestCases/contiguous_container
    • objects before buffer with different sizes
    • objects after buffer with different sizes
    • objects accessible and poisoned
  • Updated and fixed compiler-rt/test/asan/TestCases/contiguous_container_crash.cpp as requested.
Oct 25 2022, 8:19 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the summary of D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.
Oct 25 2022, 6:23 PM · Restricted Project, Restricted Project, Restricted Project

Oct 17 2022

AdvenamTacet updated the summary of D132090: [1a/3][ASan][compiler-rt] API for double ended containers.
Oct 17 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Fixes:

  • code style (suggested changes)
  • removes additional (non-interface) functions
  • AddrIsAlignedByGranularity used
  • Comment descriptions updated
Oct 17 2022, 4:02 PM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2022

AdvenamTacet updated the summary of D132090: [1a/3][ASan][compiler-rt] API for double ended containers.
Sep 22 2022, 12:17 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Call to TestDoubleEndedContainer is now made.

Sep 22 2022, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added inline comments to D132769: [2b/3][ASan][libcxx] std::basic_string annotations.
Sep 22 2022, 5:26 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2022

AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.

Formatting.

Sep 21 2022, 7:20 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.

API change from D132522 - no new function, annotating function changed.

Sep 21 2022, 7:19 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added a comment to D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

I will try your method, thank you!

Sep 21 2022, 7:14 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added a comment to D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

@vitalybuka yes, sorry for that. Now correct files are here. I think I have to change my workflow... now I have to be in a correct repo and write correct revision id in arc diff --update <id>, and clearly it's not easy for me. Sorry for the confusion.

Sep 21 2022, 7:13 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

Correct revision update, previous files are for deque...

Sep 21 2022, 7:08 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added inline comments to D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.
Sep 21 2022, 7:02 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

Big change: now annotations work without changing API.

Sep 21 2022, 7:01 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added a comment to D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Hey, I believe I fixed all issues from the code review. Is there anything else to change? What else should I do before upstreaming? I would be very happy to close it, to fully focus on revisions depending on it.

Sep 21 2022, 6:46 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Fixing naming and formatting.

Sep 21 2022, 6:37 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet requested review of D134406: [3/3][ASan] integration test for std::deque and std::basic_string annotations.
Sep 21 2022, 6:29 PM · Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

Moving libc++ code from D132090.

Sep 21 2022, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Clang format and moving libcxx part.

Sep 21 2022, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added inline comments to D132090: [1a/3][ASan][compiler-rt] API for double ended containers.
Sep 21 2022, 4:39 PM · Restricted Project, Restricted Project, Restricted Project

Sep 19 2022

AdvenamTacet added inline comments to D132090: [1a/3][ASan][compiler-rt] API for double ended containers.
Sep 19 2022, 6:50 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.

Previous push was designed for a different revision. Sorry for it.

Sep 19 2022, 6:47 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

Previous push was designed for a different revision. Sorry for it.

Sep 19 2022, 6:44 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

Update of API. (A change was requested in review for D132090 and this
patch is reflecting that change - only one function is in API.)

Sep 19 2022, 6:42 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.
Sep 19 2022, 6:40 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.
Sep 19 2022, 6:38 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.
Sep 19 2022, 6:37 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Update to API: only one new function added instead of two.

Sep 19 2022, 6:34 PM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

AdvenamTacet added a comment to D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Hey @ldionne, thank you for your interest in my patches. I think your proposition is fundamentally different from ASan.

  • ASan is not designed to work on production and as far as I know, using it may increase attack surface.
  • With ASan, almost every memory access is instrumented, while with "smart iterators" only accesses with those iterators are checked.
Sep 8 2022, 10:53 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2022

AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Order of arguments changed, new order is:

  • storage_beg
  • storage_end
  • old_container_beg
  • old_container_end
  • new_value (based on function beg/end)
Sep 7 2022, 1:11 AM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2022

AdvenamTacet added inline comments to D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.
Aug 31 2022, 9:26 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

AdvenamTacet added inline comments to D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.
Aug 30 2022, 5:54 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added a comment to D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

can you please organize all of them into a stack? It supports multiple deps like for 3.

Aug 30 2022, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added inline comments to D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.
Aug 30 2022, 3:07 PM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2022

AdvenamTacet planned changes to D132090: [1a/3][ASan][compiler-rt] API for double ended containers.
Aug 29 2022, 8:15 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Formatting.

Aug 29 2022, 8:15 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Changes based on the review.
Next update will contain:

  • test in compiler-rt/test/asan/TestCases/contiguous_container.cpp
  • argument order change
Aug 29 2022, 8:14 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

clang-format (sorry for double update)

Aug 29 2022, 7:24 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

Changin _de_ in names into _double_ended_, based on a review for compiler-rt part.
There will be one more change based on the review.

Aug 29 2022, 7:23 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet requested review of D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

I stacked them, deque changes and string changes are independent.

Aug 29 2022, 6:39 PM · Restricted Project, Restricted Project, Restricted Project

Aug 26 2022

AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.

TODO comment removed.

Aug 26 2022, 4:38 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.

Code formatting and naming imporvements.

Aug 26 2022, 4:35 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.
Aug 26 2022, 4:15 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet requested review of D132769: [2b/3][ASan][libcxx] std::basic_string annotations.
Aug 26 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2022

AdvenamTacet added a reviewer for D132090: [1a/3][ASan][compiler-rt] API for double ended containers: Restricted Project.
Aug 24 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

Fixing argument alignment (code formating).

Aug 24 2022, 8:13 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2022

AdvenamTacet updated the diff for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.

Removing bool type, because unit tests are failing.

Aug 23 2022, 7:27 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132090: [1a/3][ASan][compiler-rt] API for double ended containers.

Fixing comments.

Aug 23 2022, 7:16 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet added a reviewer for D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory: Restricted Project.
Aug 23 2022, 7:14 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet requested review of D132522: [1b/3][ASan][compiler-rt] API for annotating objects memory.
Aug 23 2022, 6:52 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

This update adds clang version check (_LIBCPP_CLANG_VER >= 16000),
because the change requires compiler-rt functions from a parent revision.

Aug 23 2022, 3:44 PM · Restricted Project, Restricted Project, Restricted Project

Aug 22 2022

AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

This update should fix failure of C++03 tests and a format check test.

Aug 22 2022, 7:20 AM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

Duplicated file removed.

Aug 22 2022, 6:26 AM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

This update should fix failing unit tests and improve code quality.
Content:

  • Fixed includes (thx philnik for pointing that)
  • Improved variable names (more consistent)
  • Values passed to compiler-rt functions are correct now. (There

was an optimization depending on compiler-rt implementation, now
it should be correct even when implementation is extended.)

Aug 22 2022, 6:23 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2022

AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.

The udpate is fixing issues mentioned in the code review.
Content:

  • fixed formating,
  • use of _LIBCPP_HIDE_FROM_ABI,
  • names and style improvements.
Aug 18 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2022

AdvenamTacet updated the diff for D132092: [2a/3][ASan][libcxx] std::deque annotations.
Aug 17 2022, 6:28 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet requested review of D132092: [2a/3][ASan][libcxx] std::deque annotations.
Aug 17 2022, 6:19 PM · Restricted Project, Restricted Project, Restricted Project
AdvenamTacet requested review of D132090: [1a/3][ASan][compiler-rt] API for double ended containers.
Aug 17 2022, 6:05 PM · Restricted Project, Restricted Project, Restricted Project