This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][NFC] replaces `<functional>` includes with specific headers
AbandonedPublic

Authored by cjdb on Jun 26 2021, 11:05 AM.

Details

Reviewers
ldionne
zoecarver
Mordante
Group Reviewers
Restricted Project
Summary

Depends on D104980.

Diff Detail

Event Timeline

cjdb requested review of this revision.Jun 26 2021, 11:05 AM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2021, 11:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb updated this revision to Diff 354707.Jun 26 2021, 2:01 PM

adds missing header (not sure why it wasn't caught earlier)

cjdb updated this revision to Diff 354713.Jun 26 2021, 4:24 PM

rebases to activate CI

cjdb updated this revision to Diff 354717.Jun 26 2021, 7:17 PM

fixes C++03 mode

cjdb updated this revision to Diff 354721.Jun 26 2021, 8:08 PM

rebases to activate CI

ldionne accepted this revision.Jun 28 2021, 9:02 AM

LGTM assuming you rebase onto the other reviews (which means that things like the 10 includes of __functional/<operation>.h will turn into a single include).

This revision is now accepted and ready to land.Jun 28 2021, 9:02 AM
cjdb updated this revision to Diff 356206.Jul 2 2021, 10:02 AM

rebases, catches a few stragglers, removes headers <functional> directly pulls in (ATTN @ldionne)

cjdb updated this revision to Diff 356293.Jul 2 2021, 4:13 PM

rebases to activate CI

cjdb updated this revision to Diff 356350.Jul 3 2021, 11:35 AM

rebases onto main

cjdb planned changes to this revision.Jul 7 2021, 1:18 PM

Blocked by D104980.

cjdb abandoned this revision.Sep 7 2022, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 10:59 AM