Page MenuHomePhabricator

[libcxx][NFC] replaces `<algorithm>` includes with specific headers
Changes PlannedPublic

Authored by cjdb on Jun 26 2021, 1:43 PM.

Details

Reviewers
ldionne
zoecarver
Mordante
Group Reviewers
Restricted Project
Restricted Project
Summary

Depends on D104982.

Diff Detail

Event Timeline

cjdb requested review of this revision.Jun 26 2021, 1:43 PM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2021, 1:43 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb updated this revision to Diff 354708.Jun 26 2021, 2:02 PM

rebases to cancel and reactivate CI

cjdb updated this revision to Diff 354714.Jun 26 2021, 4:24 PM

rebases to activate CI

cjdb updated this revision to Diff 354718.Jun 26 2021, 7:18 PM

rebases to reactivate CI

cjdb updated this revision to Diff 354722.Jun 26 2021, 8:08 PM

rebases to activate CI

cjdb updated this revision to Diff 354729.Jun 26 2021, 11:20 PM

fixes a C++03 only failure

cjdb updated this revision to Diff 354756.EditedJun 27 2021, 10:05 AM

fixes inclusion issues that weren't being replicated locally

The libc++abi test diff is literally + #include <algorithm>\n, but Arcanist said the following and forced it to be treated as a binary:

Diff for 'libcxxabi/test/test_demangle.pass.cpp' with context is
5,403,317 bytes in length. Generally, source changes should not be this
large. If the file is not a text file, you can mark it 'binary'. Mark
this file as 'binary' and continue?
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2021, 10:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jun 28 2021, 9:05 AM

LGTM but I'd like to understand the modulemap changes.

libcxx/include/module.modulemap
235

Why do those export unwrap_iter?

This revision is now accepted and ready to land.Jun 28 2021, 9:05 AM
cjdb added inline comments.Jun 28 2021, 9:36 AM
libcxx/include/module.modulemap
235

Something to do with Clang modules not exporting them properly, which leads to linker errors regarding __rewrap_iter. I don't have a good answer.

cjdb updated this revision to Diff 356207.Jul 2 2021, 10:03 AM

rebases to activate CI

cjdb updated this revision to Diff 356294.Jul 2 2021, 4:13 PM

rebases to activate CI

cjdb updated this revision to Diff 356351.Jul 3 2021, 11:35 AM

rebases onto main

cjdb planned changes to this revision.Jul 7 2021, 1:18 PM

Blocked by D104980.