This is an archive of the discontinued LLVM Phabricator instance.

koutheir retitled this revision from Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API. The LLVM C API function is called `LLVMDIBuilderFinalizeSubprogram()`. to Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API.Jun 23 2021, 10:06 AM

koutheir edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B110659: Diff 354010.Jun 23 2021, 10:54 AM

The build failures seem unrelated to this patch. Can someone review, please?

lattner resigned from this revision.Jun 24 2021, 12:22 PM

LGTM

Thanks

This revision is now accepted and ready to land.Jun 25 2021, 6:14 AM

@CodaFi, can you please commit this accepted change?

Is there still an issue preventing committing of this change?

Is this patch uninteresting to commit?

This revision was landed with ongoing or failed builds.Sep 30 2021, 9:00 PM

Closed by commit rG16661b1a3c4c: Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API (authored by koutheir, committed by dblaikie). · Explain Why

This revision was automatically updated to reflect the committed changes.

dblaikie added a commit: rG16661b1a3c4c: Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API.

In D104794#2960537, @koutheir wrote:

Is this patch uninteresting to commit?

Committed, sorry for the delay!

Revision Contents

Path

Size

llvm/

include/

llvm-c/

DebugInfo.h

7 lines

lib/

IR/

DebugInfo.cpp

5 lines

Diff 354010

llvm/include/llvm-c/DebugInfo.h

	Show First 20 Lines • Show All 221 Lines • ▼ Show 20 Lines
	void LLVMDisposeDIBuilder(LLVMDIBuilderRef Builder);			void LLVMDisposeDIBuilder(LLVMDIBuilderRef Builder);

	/**			/**
	* Construct any deferred debug info descriptors.			* Construct any deferred debug info descriptors.
	*/			*/
	void LLVMDIBuilderFinalize(LLVMDIBuilderRef Builder);			void LLVMDIBuilderFinalize(LLVMDIBuilderRef Builder);

	/**			/**
				* Finalize a specific subprogram.
				* No new variables may be added to this subprogram afterwards.
				*/
				void LLVMDIBuilderFinalizeSubprogram(LLVMDIBuilderRef Builder,
				Lint: Pre-merge checks Inline Actions clang-tidy: warning: invalid case style for function 'LLVMDIBuilderFinalizeSubprogram' [readability-identifier-naming] not useful Lint: Pre-merge checks: clang-tidy: warning: invalid case style for function 'LLVMDIBuilderFinalizeSubprogram'…
				LLVMMetadataRef Subprogram);

				/**
	* A CompileUnit provides an anchor for all debugging			* A CompileUnit provides an anchor for all debugging
	* information generated during this instance of compilation.			* information generated during this instance of compilation.
	* \param Lang Source programming language, eg.			* \param Lang Source programming language, eg.
	* \c LLVMDWARFSourceLanguageC99			* \c LLVMDWARFSourceLanguageC99
	* \param FileRef File info.			* \param FileRef File info.
	* \param Producer Identify the producer of debugging information			* \param Producer Identify the producer of debugging information
	* and code. Usually this is a compiler			* and code. Usually this is a compiler
	* version string.			* version string.
	▲ Show 20 Lines • Show All 1,128 Lines • Show Last 20 Lines

llvm/lib/IR/DebugInfo.cpp

	Show First 20 Lines • Show All 903 Lines • ▼ Show 20 Lines
	void LLVMDisposeDIBuilder(LLVMDIBuilderRef Builder) {			void LLVMDisposeDIBuilder(LLVMDIBuilderRef Builder) {
	delete unwrap(Builder);			delete unwrap(Builder);
	}			}

	void LLVMDIBuilderFinalize(LLVMDIBuilderRef Builder) {			void LLVMDIBuilderFinalize(LLVMDIBuilderRef Builder) {
	unwrap(Builder)->finalize();			unwrap(Builder)->finalize();
	}			}

				void LLVMDIBuilderFinalizeSubprogram(LLVMDIBuilderRef Builder,
				LLVMMetadataRef subprogram) {
				Lint: Pre-merge checks Inline Actions clang-tidy: warning: invalid case style for parameter 'subprogram' [readability-identifier-naming] not useful Lint: Pre-merge checks: clang-tidy: warning: invalid case style for parameter 'subprogram' [readability-identifier…
				unwrap(Builder)->finalizeSubprogram(unwrapDI<DISubprogram>(subprogram));
				}

	LLVMMetadataRef LLVMDIBuilderCreateCompileUnit(			LLVMMetadataRef LLVMDIBuilderCreateCompileUnit(
	LLVMDIBuilderRef Builder, LLVMDWARFSourceLanguage Lang,			LLVMDIBuilderRef Builder, LLVMDWARFSourceLanguage Lang,
	LLVMMetadataRef FileRef, const char *Producer, size_t ProducerLen,			LLVMMetadataRef FileRef, const char *Producer, size_t ProducerLen,
	LLVMBool isOptimized, const char *Flags, size_t FlagsLen,			LLVMBool isOptimized, const char *Flags, size_t FlagsLen,
	unsigned RuntimeVer, const char *SplitName, size_t SplitNameLen,			unsigned RuntimeVer, const char *SplitName, size_t SplitNameLen,
	LLVMDWARFEmissionKind Kind, unsigned DWOId, LLVMBool SplitDebugInlining,			LLVMDWARFEmissionKind Kind, unsigned DWOId, LLVMBool SplitDebugInlining,
	LLVMBool DebugInfoForProfiling, const char *SysRoot, size_t SysRootLen,			LLVMBool DebugInfoForProfiling, const char *SysRoot, size_t SysRootLen,
	const char *SDK, size_t SDKLen) {			const char *SDK, size_t SDKLen) {
	▲ Show 20 Lines • Show All 693 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

Expose `DIBuilder::finalizeSubprogram()` through the LLVM C APIClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 354010

llvm/include/llvm-c/DebugInfo.h

llvm/lib/IR/DebugInfo.cpp

Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API
ClosedPublic