CodaFi (Robert Widmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2017, 7:43 PM (57 w, 2 d)

Recent Activity

Mon, May 21

CodaFi added a comment to D47179: [LLVM-C] Add Bindings For Named Metadata.

@aprantl Let me know if this is the right way to address that FIXME. There didn't seem to be any consequences of the small change I've got here which could be very good or very bad from my naive perspective.

Mon, May 21, 10:37 PM
CodaFi created D47179: [LLVM-C] Add Bindings For Named Metadata.
Mon, May 21, 10:36 PM
CodaFi committed rL332850: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.
[LLVM-C] Add DIBuilder Bindings For ObjC Classes
Mon, May 21, 9:31 AM
CodaFi closed D47123: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.
Mon, May 21, 9:31 AM

Sun, May 20

CodaFi committed rL332826: [LLVM-C] Improve Bindings For Aliases.
[LLVM-C] Improve Bindings For Aliases
Sun, May 20, 4:53 PM
CodaFi closed D46808: [LLVM-C] Improve Bindings For Aliases.
Sun, May 20, 4:53 PM
CodaFi created D47123: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.
Sun, May 20, 4:51 PM
CodaFi updated the diff for D46808: [LLVM-C] Improve Bindings For Aliases.
Sun, May 20, 10:31 AM

Sat, May 19

CodaFi committed rL332810: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
[LLVM-C] Use Length-Providing Value Name Getters and Setters
Sat, May 19, 8:13 AM
CodaFi closed D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
Sat, May 19, 8:13 AM

Fri, May 18

CodaFi updated the summary of D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
Fri, May 18, 7:25 PM
CodaFi updated the diff for D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
Fri, May 18, 6:56 PM
CodaFi added a comment to D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.

First, the naming here is absurdly confusing. Second, it's also inconsistent with all other functions, e.g. LLVMGetSourceFileName/LLVMSetSourceFileName.

Use LLVMGetValueName2 and LLVMSetValueName2, since this is what we do when updating function signatures in the C API.

Fri, May 18, 6:45 PM

Tue, May 15

CodaFi created D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
Tue, May 15, 9:32 AM

Mon, May 14

CodaFi committed rL332219: [LLVM-C] Add Bindings For Module Flags.
[LLVM-C] Add Bindings For Module Flags
Mon, May 14, 1:12 AM
CodaFi closed D46792: [LLVM-C] Add Bindings For Module Flags.
Mon, May 14, 1:12 AM

Sun, May 13

CodaFi updated the diff for D46792: [LLVM-C] Add Bindings For Module Flags.
Sun, May 13, 10:56 PM
CodaFi added inline comments to D46808: [LLVM-C] Improve Bindings For Aliases.
Sun, May 13, 10:51 PM
CodaFi added inline comments to D46792: [LLVM-C] Add Bindings For Module Flags.
Sun, May 13, 10:49 PM
CodaFi created D46808: [LLVM-C] Improve Bindings For Aliases.
Sun, May 13, 12:08 PM

Sat, May 12

CodaFi updated the diff for D46792: [LLVM-C] Add Bindings For Module Flags.
Sat, May 12, 11:39 AM

Fri, May 11

CodaFi updated the diff for D46792: [LLVM-C] Add Bindings For Module Flags.
Fri, May 11, 9:21 PM
CodaFi created D46792: [LLVM-C] Add Bindings For Module Flags.
Fri, May 11, 9:17 PM

Thu, May 10

CodaFi committed rL332041: [LLVM-C] Consolidate llgo's DIBuilder Bindings.
[LLVM-C] Consolidate llgo's DIBuilder Bindings
Thu, May 10, 2:14 PM
CodaFi closed D46725: [LLVM-C] Consolidate llgo's DIBuilder Bindings.
Thu, May 10, 2:13 PM
CodaFi created D46725: [LLVM-C] Consolidate llgo's DIBuilder Bindings.
Thu, May 10, 2:02 PM
CodaFi committed rL332014: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
[LLVM-C] Add Accessors for Common DIType and DILocation Properties
Thu, May 10, 11:27 AM
CodaFi closed D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
Thu, May 10, 11:27 AM
CodaFi added a comment to D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.

You could write the same tests as in llvm-c-test/echo.cpp. But I would not block merging on this.

Thu, May 10, 11:22 AM
CodaFi committed rL332010: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
[LLVM-C] Move DIBuilder Bindings For Temporary MDNodes
Thu, May 10, 11:13 AM
CodaFi closed D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
Thu, May 10, 11:13 AM

Wed, May 9

CodaFi added a comment to D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.

Any tests?

Wed, May 9, 8:22 PM
CodaFi added a comment to D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.

llvm::Value::replaceAllUsesWith and llvm::MDNode::replaceAllUsesWith are distinct operations. The former assumes the source and replacement values are the same type, the latter assumes that you're trying to build up a graph of dummy metadata for an incomplete or recursive definition that you will eventually finalize by replacing it with real nodes.

Wed, May 9, 8:19 PM
CodaFi updated the diff for D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
Wed, May 9, 8:18 PM
CodaFi created D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
Wed, May 9, 12:12 AM

Tue, May 8

CodaFi committed rL331850: [LLVM-C] Correct types in Go bindings.
[LLVM-C] Correct types in Go bindings
Tue, May 8, 11:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, May 8, 11:49 PM
CodaFi created D46631: [LLVM-C] Correct types in Go bindings.
Tue, May 8, 11:47 PM
CodaFi updated the diff for D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
Tue, May 8, 10:01 PM
CodaFi updated the diff for D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
Tue, May 8, 9:54 PM
CodaFi created D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
Tue, May 8, 9:53 PM

Sat, Apr 28

CodaFi added a comment to rL331132: [LLVM-C] Eliminate an unused variable in a test..

Thanks!

Sat, Apr 28, 7:07 PM
CodaFi committed rL331123: [LLVM-C] Add DIBuilder bindings to create import declarations.
[LLVM-C] Add DIBuilder bindings to create import declarations
Sat, Apr 28, 3:35 PM
CodaFi closed D46167: [LLVM-C] Add DIBuilder bindings to create import declarations.
Sat, Apr 28, 3:35 PM
CodaFi committed rL331114: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.
[LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings
Sat, Apr 28, 11:19 AM
CodaFi closed D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.
Sat, Apr 28, 11:19 AM

Fri, Apr 27

CodaFi added a comment to D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.

Unless there has been a release since 6.0(.1), we should be free to change these. We merged the referenced patch after that.

Fri, Apr 27, 11:59 PM
CodaFi added a comment to D46166: [LLVM-C] Add accessor to retrieve DINode's tag.

I've only seen it used to discriminate between different kinds of DIScopes. If it's really an implementation detail, I can abandon this patch.

Fri, Apr 27, 9:25 AM

Thu, Apr 26

CodaFi created D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.
Thu, Apr 26, 7:58 PM
CodaFi created D46167: [LLVM-C] Add DIBuilder bindings to create import declarations.
Thu, Apr 26, 7:30 PM
CodaFi created D46166: [LLVM-C] Add accessor to retrieve DINode's tag.
Thu, Apr 26, 6:48 PM

Apr 23 2018

CodaFi committed rL330661: [LLVM-C] DIBuilder Bindings For Variable Expressions.
[LLVM-C] DIBuilder Bindings For Variable Expressions
Apr 23 2018, 3:35 PM
CodaFi closed D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions.
Apr 23 2018, 3:35 PM
CodaFi added a comment to D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions.

A note from the test: I removed foo_inner_scope because I no longer need it to anchor the lexical block scope now that I can declare variables.

Apr 23 2018, 12:15 PM
CodaFi added a reviewer for D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions: whitequark.
Apr 23 2018, 12:15 PM
CodaFi created D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions.
Apr 23 2018, 12:15 PM
CodaFi committed rL330594: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
[LLVM-C] DIBuilderBindings for Subrange and Arrays
Apr 23 2018, 7:35 AM
CodaFi closed D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
Apr 23 2018, 7:35 AM
CodaFi updated the diff for D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
Apr 23 2018, 7:29 AM
CodaFi committed rL330591: [LLVM-C] Finish Up Scope Bindings.
[LLVM-C] Finish Up Scope Bindings
Apr 23 2018, 6:57 AM
CodaFi closed D45934: [LLVM-C] Finish Up Scope Bindings.
Apr 23 2018, 6:57 AM

Apr 22 2018

CodaFi added a comment to D45934: [LLVM-C] Finish Up Scope Bindings.

This is expected to conflict with D45933. Whichever lands first, I'll rebase the other.

Apr 22 2018, 3:03 PM
CodaFi created D45934: [LLVM-C] Finish Up Scope Bindings.
Apr 22 2018, 3:03 PM
CodaFi created D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
Apr 22 2018, 1:59 PM
CodaFi committed rL330555: [LLVM-C] Add DIBuilder Bindings For Variable Creation.
[LLVM-C] Add DIBuilder Bindings For Variable Creation
Apr 22 2018, 12:30 PM
CodaFi closed D45928: [LLVM-C] Add DIBuilder Bindings For Variable Creation.
Apr 22 2018, 12:30 PM
CodaFi created D45928: [LLVM-C] Add DIBuilder Bindings For Variable Creation.
Apr 22 2018, 5:29 AM

Apr 10 2018

CodaFi committed rL329731: [LLVM-C] Add Missing 'break's in InlineAsm bindings.
[LLVM-C] Add Missing 'break's in InlineAsm bindings
Apr 10 2018, 11:13 AM
CodaFi closed D45496: [LLVM-C] Add Missing 'break's in InlineAsm bindings.
Apr 10 2018, 11:13 AM
CodaFi added a comment to D45496: [LLVM-C] Add Missing 'break's in InlineAsm bindings.

Going to commit this immediately to fix the bots.

Apr 10 2018, 11:12 AM
CodaFi created D45496: [LLVM-C] Add Missing 'break's in InlineAsm bindings.
Apr 10 2018, 11:09 AM

Apr 7 2018

CodaFi committed rL329505: [llgo] Move SetSubprogram.
[llgo] Move SetSubprogram
Apr 7 2018, 9:32 AM
CodaFi closed D45402: [llgo] Move SetSubprogram.
Apr 7 2018, 9:32 AM
CodaFi created D45402: [llgo] Move SetSubprogram.
Apr 7 2018, 12:44 AM

Apr 6 2018

CodaFi committed rL329488: [LLVM-C] Move DIBuilder Bindings For Block Scopes.
[LLVM-C] Move DIBuilder Bindings For Block Scopes
Apr 6 2018, 11:11 PM
CodaFi closed D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.
Apr 6 2018, 11:11 PM
CodaFi added inline comments to D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.
Apr 6 2018, 7:01 PM
CodaFi updated the diff for D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.
Apr 6 2018, 12:02 PM

Apr 5 2018

CodaFi added a comment to D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.

I'll need to move the Function scope API as well to write a coherent test.

Apr 5 2018, 9:12 PM
CodaFi committed rL329373: [LLVM-C] Fill Out LLVMCallConv.
[LLVM-C] Fill Out LLVMCallConv
Apr 5 2018, 9:05 PM
CodaFi closed D45347: [LLVM-C] Fill Out LLVMCallConv.
Apr 5 2018, 9:05 PM
CodaFi created D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes.
Apr 5 2018, 9:03 PM
CodaFi committed rL329369: [LLVM-C] Audit Inline Assembly APIs for Consistency.
[LLVM-C] Audit Inline Assembly APIs for Consistency
Apr 5 2018, 7:35 PM
CodaFi closed D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.
Apr 5 2018, 7:35 PM
CodaFi created D45347: [LLVM-C] Fill Out LLVMCallConv.
Apr 5 2018, 7:29 PM
CodaFi updated the diff for D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.
Apr 5 2018, 7:24 PM
CodaFi added inline comments to D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.
Apr 5 2018, 7:16 PM
CodaFi added a comment to D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.

The original API for LLVMSetModuleInlineAsm implies that only C-style strings can be passed here, but the implementation is copying to a std::string under the hood anyhow. If that's the invariant that we want to maintain here, I will revert the deprecation and add documentation.

Apr 5 2018, 7:00 PM
CodaFi updated the diff for D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.
Apr 5 2018, 6:51 PM
CodaFi created D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency.
Apr 5 2018, 6:48 PM

Mar 30 2018

CodaFi committed rL328883: [LLVM-C] Finish exception instruction bindings - Round 2.
[LLVM-C] Finish exception instruction bindings - Round 2
Mar 30 2018, 10:52 AM
CodaFi closed D45100: [LLVM-C] Finish exception instruction bindings - Round 2.
Mar 30 2018, 10:52 AM
CodaFi created D45100: [LLVM-C] Finish exception instruction bindings - Round 2.
Mar 30 2018, 10:41 AM

Mar 28 2018

CodaFi committed rL328759: [LLVM-C] Finish exception instruction bindings.
[LLVM-C] Finish exception instruction bindings
Mar 28 2018, 8:47 PM
CodaFi closed D44496: [LLVM-C] Finish exception instruction bindings.
Mar 28 2018, 8:47 PM
CodaFi updated the diff for D44496: [LLVM-C] Finish exception instruction bindings.

Respond to review nits

Mar 28 2018, 8:42 PM

Mar 21 2018

CodaFi committed rL328173: Improve -Winfinite-recursion.
Improve -Winfinite-recursion
Mar 21 2018, 8:20 PM
CodaFi committed rC328173: Improve -Winfinite-recursion.
Improve -Winfinite-recursion
Mar 21 2018, 8:20 PM
CodaFi closed D43737: Improve -Winfinite-recursion.
Mar 21 2018, 8:20 PM
CodaFi added a comment to D44496: [LLVM-C] Finish exception instruction bindings.

@echristo Ping.

Mar 21 2018, 10:31 AM