CodaFi (Robert Widmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2017, 7:43 PM (78 w, 3 d)

Recent Activity

Mon, Oct 1

CodaFi committed rL343469: [LLVM-C] Add an accessor for the kind of a Metadata Node.
[LLVM-C] Add an accessor for the kind of a Metadata Node
Mon, Oct 1, 6:17 AM
CodaFi closed D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Mon, Oct 1, 6:17 AM

Sat, Sep 29

CodaFi added a comment to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.

@whitequark Done.

Sat, Sep 29, 2:40 PM
CodaFi updated the diff for D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sat, Sep 29, 2:24 PM
CodaFi added inline comments to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sat, Sep 29, 8:47 AM
CodaFi created D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sat, Sep 29, 8:38 AM

Fri, Sep 28

CodaFi committed rL343363: [LLVM-C] Add an accessor for the "value type" of a global.
[LLVM-C] Add an accessor for the "value type" of a global
Fri, Sep 28, 1:56 PM
CodaFi closed D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Fri, Sep 28, 1:56 PM
CodaFi updated the summary of D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Fri, Sep 28, 9:25 AM
CodaFi updated the summary of D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Fri, Sep 28, 9:25 AM
CodaFi created D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Fri, Sep 28, 9:24 AM
CodaFi committed rL343334: [LLVM-C] Fix broken build bots.
[LLVM-C] Fix broken build bots
Fri, Sep 28, 9:05 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Sep 28, 9:05 AM
CodaFi created D52657: [LLVM-C] Fix broken build bots.
Fri, Sep 28, 9:00 AM
CodaFi committed rL343330: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
[LLVM-C] Add more debug information accessors to GlobalObject and Instruction
Fri, Sep 28, 8:39 AM
CodaFi closed D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Fri, Sep 28, 8:39 AM
CodaFi abandoned D46166: [LLVM-C] Add accessor to retrieve DINode's tag.

Abandoning this revision to keep it out of the review queue.

Fri, Sep 28, 8:35 AM
CodaFi added a comment to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

@whitequark Ping

Fri, Sep 28, 8:00 AM

Sep 10 2018

CodaFi added a comment to D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal..

The regression tests are only against the text of the driver's cc1 commands. It's not actually testing if we can compile.

Sep 10 2018, 5:36 PM
CodaFi added a comment to D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal..

@kristina They're having linker troubles because this driver is hardcoding an incorrect linker flag for libbuiltin on the arm-baremetal triple. D33259 introduced this behavior by smashing together the -lclang_rt.builtins-$ARCH flag with the proper resource-directory-relative absolute path <RESOURCE_DIR>/lib/libclang_rt.builtins-$ARCH.a which resulted in the incorrect flag -libclang_rt.builtins-$ARCH.a. With that path, the linker is going to try to look for "libclang_rt.builtins-$ARCH.a.a" in the link libraries search paths. The driver should be forming an exact path to this library relative to the resource directory. If users wish to override this behavior, they need to pass -nostdlib or -nodefaultlibs

Sep 10 2018, 5:32 PM
CodaFi added a comment to D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal..

Two things:

Sep 10 2018, 5:11 PM

Aug 31 2018

CodaFi updated the diff for D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Aug 31 2018, 10:22 AM

Aug 30 2018

CodaFi added a comment to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

How is a user of this API supposed to map the unsigned Kind values to something meaningful? We don't have an enum LLVMMetadataKind, do we?

Aug 30 2018, 8:40 PM
CodaFi created D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Aug 30 2018, 4:03 PM
CodaFi committed rL341085: [LLVM-C] Add Bindings For Named Metadata.
[LLVM-C] Add Bindings For Named Metadata
Aug 30 2018, 10:13 AM
CodaFi closed D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 30 2018, 10:12 AM
CodaFi added a comment to D47179: [LLVM-C] Add Bindings For Named Metadata.

@whitequark Could I get another once-over on the C API here?

Aug 30 2018, 9:46 AM

Aug 27 2018

CodaFi updated the diff for D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 27 2018, 11:44 AM
CodaFi added inline comments to D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 27 2018, 11:36 AM
CodaFi added inline comments to D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 27 2018, 10:21 AM

Aug 25 2018

CodaFi updated the diff for D47179: [LLVM-C] Add Bindings For Named Metadata.

Spoke with @aprantl in person about this, and we came to the conclusion that named metadata nodes are different enough that the original TODO doesn't make any sense. For one, it would mean that you could use named metadata nodes to create more kinds of cycles. It would also mean the verifier would have to be extended to reject any usage of named metadata nodes as operand metadata.

Aug 25 2018, 4:33 PM
CodaFi updated the summary of D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 25 2018, 4:25 PM
CodaFi committed rL340691: [C-API][DIBuilder] Use NameLen in LLVMDIBuilderCreateParameterVariable.
[C-API][DIBuilder] Use NameLen in LLVMDIBuilderCreateParameterVariable
Aug 25 2018, 12:55 PM
CodaFi closed D51141: [C-API][DIBuilder] Use NameLen in LLVMDIBuilderCreateParameterVariable.
Aug 25 2018, 12:55 PM

Aug 23 2018

CodaFi accepted D51141: [C-API][DIBuilder] Use NameLen in LLVMDIBuilderCreateParameterVariable.

Thanks for catching this! On top of respecting our API contract, it's good to be safe around C strings.

Aug 23 2018, 2:10 PM

May 21 2018

CodaFi added a comment to D47179: [LLVM-C] Add Bindings For Named Metadata.

@aprantl Let me know if this is the right way to address that FIXME. There didn't seem to be any consequences of the small change I've got here which could be very good or very bad from my naive perspective.

May 21 2018, 10:37 PM
CodaFi created D47179: [LLVM-C] Add Bindings For Named Metadata.
May 21 2018, 10:36 PM
CodaFi committed rL332850: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.
[LLVM-C] Add DIBuilder Bindings For ObjC Classes
May 21 2018, 9:31 AM
CodaFi closed D47123: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.
May 21 2018, 9:31 AM

May 20 2018

CodaFi committed rL332826: [LLVM-C] Improve Bindings For Aliases.
[LLVM-C] Improve Bindings For Aliases
May 20 2018, 4:53 PM
CodaFi closed D46808: [LLVM-C] Improve Bindings For Aliases.
May 20 2018, 4:53 PM
CodaFi created D47123: [LLVM-C] Add DIBuilder Bindings For ObjC Classes.
May 20 2018, 4:51 PM
CodaFi updated the diff for D46808: [LLVM-C] Improve Bindings For Aliases.
May 20 2018, 10:31 AM

May 19 2018

CodaFi committed rL332810: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
[LLVM-C] Use Length-Providing Value Name Getters and Setters
May 19 2018, 8:13 AM
CodaFi closed D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
May 19 2018, 8:13 AM

May 18 2018

CodaFi updated the summary of D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
May 18 2018, 7:25 PM
CodaFi updated the diff for D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
May 18 2018, 6:56 PM
CodaFi added a comment to D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.

First, the naming here is absurdly confusing. Second, it's also inconsistent with all other functions, e.g. LLVMGetSourceFileName/LLVMSetSourceFileName.

Use LLVMGetValueName2 and LLVMSetValueName2, since this is what we do when updating function signatures in the C API.

May 18 2018, 6:45 PM

May 15 2018

CodaFi created D46890: [LLVM-C] Use Length-Providing Value Name Getters and Setters.
May 15 2018, 9:32 AM

May 14 2018

CodaFi committed rL332219: [LLVM-C] Add Bindings For Module Flags.
[LLVM-C] Add Bindings For Module Flags
May 14 2018, 1:12 AM
CodaFi closed D46792: [LLVM-C] Add Bindings For Module Flags.
May 14 2018, 1:12 AM

May 13 2018

CodaFi updated the diff for D46792: [LLVM-C] Add Bindings For Module Flags.
May 13 2018, 10:56 PM
CodaFi added inline comments to D46808: [LLVM-C] Improve Bindings For Aliases.
May 13 2018, 10:51 PM
CodaFi added inline comments to D46792: [LLVM-C] Add Bindings For Module Flags.
May 13 2018, 10:49 PM
CodaFi created D46808: [LLVM-C] Improve Bindings For Aliases.
May 13 2018, 12:08 PM

May 12 2018

CodaFi updated the diff for D46792: [LLVM-C] Add Bindings For Module Flags.
May 12 2018, 11:39 AM

May 11 2018

CodaFi updated the diff for D46792: [LLVM-C] Add Bindings For Module Flags.
May 11 2018, 9:21 PM
CodaFi created D46792: [LLVM-C] Add Bindings For Module Flags.
May 11 2018, 9:17 PM

May 10 2018

CodaFi committed rL332041: [LLVM-C] Consolidate llgo's DIBuilder Bindings.
[LLVM-C] Consolidate llgo's DIBuilder Bindings
May 10 2018, 2:14 PM
CodaFi closed D46725: [LLVM-C] Consolidate llgo's DIBuilder Bindings.
May 10 2018, 2:13 PM
CodaFi created D46725: [LLVM-C] Consolidate llgo's DIBuilder Bindings.
May 10 2018, 2:02 PM
CodaFi committed rL332014: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
[LLVM-C] Add Accessors for Common DIType and DILocation Properties
May 10 2018, 11:27 AM
CodaFi closed D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
May 10 2018, 11:27 AM
CodaFi added a comment to D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.

You could write the same tests as in llvm-c-test/echo.cpp. But I would not block merging on this.

May 10 2018, 11:22 AM
CodaFi committed rL332010: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
[LLVM-C] Move DIBuilder Bindings For Temporary MDNodes
May 10 2018, 11:13 AM
CodaFi closed D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
May 10 2018, 11:13 AM

May 9 2018

CodaFi added a comment to D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.

Any tests?

May 9 2018, 8:22 PM
CodaFi added a comment to D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.

llvm::Value::replaceAllUsesWith and llvm::MDNode::replaceAllUsesWith are distinct operations. The former assumes the source and replacement values are the same type, the latter assumes that you're trying to build up a graph of dummy metadata for an incomplete or recursive definition that you will eventually finalize by replacing it with real nodes.

May 9 2018, 8:19 PM
CodaFi updated the diff for D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
May 9 2018, 8:18 PM
CodaFi created D46632: [LLVM-C] Move DIBuilder Bindings For Temporary MDNodes.
May 9 2018, 12:12 AM

May 8 2018

CodaFi committed rL331850: [LLVM-C] Correct types in Go bindings.
[LLVM-C] Correct types in Go bindings
May 8 2018, 11:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.
May 8 2018, 11:49 PM
CodaFi created D46631: [LLVM-C] Correct types in Go bindings.
May 8 2018, 11:47 PM
CodaFi updated the diff for D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
May 8 2018, 10:01 PM
CodaFi updated the diff for D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
May 8 2018, 9:54 PM
CodaFi created D46627: [LLVM-C] Add Accessors for Common DIType and DILocation Properties.
May 8 2018, 9:53 PM

Apr 28 2018

CodaFi added a comment to rL331132: [LLVM-C] Eliminate an unused variable in a test..

Thanks!

Apr 28 2018, 7:07 PM
CodaFi committed rL331123: [LLVM-C] Add DIBuilder bindings to create import declarations.
[LLVM-C] Add DIBuilder bindings to create import declarations
Apr 28 2018, 3:35 PM
CodaFi closed D46167: [LLVM-C] Add DIBuilder bindings to create import declarations.
Apr 28 2018, 3:35 PM
CodaFi committed rL331114: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.
[LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings
Apr 28 2018, 11:19 AM
CodaFi closed D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.
Apr 28 2018, 11:19 AM

Apr 27 2018

CodaFi added a comment to D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.

Unless there has been a release since 6.0(.1), we should be free to change these. We merged the referenced patch after that.

Apr 27 2018, 11:59 PM
CodaFi added a comment to D46166: [LLVM-C] Add accessor to retrieve DINode's tag.

I've only seen it used to discriminate between different kinds of DIScopes. If it's really an implementation detail, I can abandon this patch.

Apr 27 2018, 9:25 AM

Apr 26 2018

CodaFi created D46168: [LLVM-C] Miscellaneous Cleanups in DIBuilder Bindings.
Apr 26 2018, 7:58 PM
CodaFi created D46167: [LLVM-C] Add DIBuilder bindings to create import declarations.
Apr 26 2018, 7:30 PM
CodaFi created D46166: [LLVM-C] Add accessor to retrieve DINode's tag.
Apr 26 2018, 6:48 PM

Apr 23 2018

CodaFi committed rL330661: [LLVM-C] DIBuilder Bindings For Variable Expressions.
[LLVM-C] DIBuilder Bindings For Variable Expressions
Apr 23 2018, 3:35 PM
CodaFi closed D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions.
Apr 23 2018, 3:35 PM
CodaFi added a comment to D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions.

A note from the test: I removed foo_inner_scope because I no longer need it to anchor the lexical block scope now that I can declare variables.

Apr 23 2018, 12:15 PM
CodaFi added a reviewer for D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions: whitequark.
Apr 23 2018, 12:15 PM
CodaFi created D45979: [LLVM-C] DIBuilder Bindings For Variable Expressions.
Apr 23 2018, 12:15 PM
CodaFi committed rL330594: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
[LLVM-C] DIBuilderBindings for Subrange and Arrays
Apr 23 2018, 7:35 AM
CodaFi closed D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
Apr 23 2018, 7:35 AM
CodaFi updated the diff for D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
Apr 23 2018, 7:29 AM
CodaFi committed rL330591: [LLVM-C] Finish Up Scope Bindings.
[LLVM-C] Finish Up Scope Bindings
Apr 23 2018, 6:57 AM
CodaFi closed D45934: [LLVM-C] Finish Up Scope Bindings.
Apr 23 2018, 6:57 AM

Apr 22 2018

CodaFi added a comment to D45934: [LLVM-C] Finish Up Scope Bindings.

This is expected to conflict with D45933. Whichever lands first, I'll rebase the other.

Apr 22 2018, 3:03 PM
CodaFi created D45934: [LLVM-C] Finish Up Scope Bindings.
Apr 22 2018, 3:03 PM
CodaFi created D45933: [LLVM-C] DIBuilderBindings for Subrange and Arrays.
Apr 22 2018, 1:59 PM
CodaFi committed rL330555: [LLVM-C] Add DIBuilder Bindings For Variable Creation.
[LLVM-C] Add DIBuilder Bindings For Variable Creation
Apr 22 2018, 12:30 PM