Page MenuHomePhabricator

CodaFi (Robert Widmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2017, 7:43 PM (126 w, 3 d)

Recent Activity

Aug 14 2019

CodaFi added a comment to D66061: Expose TailCallKind via the LLVM C API.

Y’all can revert it. I’ll resubmit the patch with updated tests tomorrow.

Aug 14 2019, 8:47 PM · Restricted Project
CodaFi committed rG708c4605a16b: Expose TailCallKind via the LLVM C API (authored by CodaFi).
Expose TailCallKind via the LLVM C API
Aug 14 2019, 4:55 PM
CodaFi committed rL368945: Expose TailCallKind via the LLVM C API.
Expose TailCallKind via the LLVM C API
Aug 14 2019, 4:54 PM
CodaFi closed D66061: Expose TailCallKind via the LLVM C API.
Aug 14 2019, 4:54 PM · Restricted Project
CodaFi created D66237: [LLVM-C] Add Bindings to the Globals Mod/Ref Alias Analysis Pass.
Aug 14 2019, 11:54 AM · Restricted Project

Aug 10 2019

CodaFi accepted D66061: Expose TailCallKind via the LLVM C API.
Aug 10 2019, 10:55 PM · Restricted Project

Jul 26 2019

CodaFi added inline comments to D65070: [LLVM-C][OCaml] Add a fast linker binding.
Jul 26 2019, 6:45 PM · Restricted Project

Jul 24 2019

CodaFi added inline comments to D65070: [LLVM-C][OCaml] Add a fast linker binding.
Jul 24 2019, 7:29 AM · Restricted Project

Jul 23 2019

CodaFi requested changes to D65070: [LLVM-C][OCaml] Add a fast linker binding.
Jul 23 2019, 9:10 AM · Restricted Project

Jul 22 2019

CodaFi committed rGfcf3c55a8cd2: [LLVM-C] Improve Bindings to The Internalize Pass (authored by CodaFi).
[LLVM-C] Improve Bindings to The Internalize Pass
Jul 22 2019, 9:58 PM
CodaFi committed rL366777: [LLVM-C] Improve Bindings to The Internalize Pass.
[LLVM-C] Improve Bindings to The Internalize Pass
Jul 22 2019, 9:57 PM
CodaFi closed D62456: [LLVM-C] Improve Bindings to The Internalize Pass.
Jul 22 2019, 9:57 PM · Restricted Project

Jun 14 2019

CodaFi accepted D63056: [bindings/go] Add debug information accessors.

We spoke out of band about the troubles I’m having verifying this locally, but the patch looks good and my limitations shouldn’t hold it back any longer.

Jun 14 2019, 1:49 PM · Restricted Project

May 25 2019

CodaFi updated the diff for D62456: [LLVM-C] Improve Bindings to The Internalize Pass.

Document the lifetime of the context parameter

May 25 2019, 4:37 PM · Restricted Project
CodaFi created D62456: [LLVM-C] Improve Bindings to The Internalize Pass.
May 25 2019, 2:20 PM · Restricted Project
CodaFi committed rGb0fd12b68929: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices (authored by CodaFi).
[LLVM-C] Add Accessor for Mach-O Universal Binary Slices
May 25 2019, 9:47 AM
CodaFi committed rL361705: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.
[LLVM-C] Add Accessor for Mach-O Universal Binary Slices
May 25 2019, 9:47 AM
CodaFi closed D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.
May 25 2019, 9:47 AM · Restricted Project
CodaFi updated the diff for D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.

[NFC] Rebase

May 25 2019, 9:43 AM · Restricted Project

Apr 24 2019

CodaFi committed rG09c5b883cb7a: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions (authored by CodaFi).
[LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions
Apr 24 2019, 10:05 AM
CodaFi committed rL359114: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.
[LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions
Apr 24 2019, 10:05 AM
CodaFi closed D60524: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.
Apr 24 2019, 10:05 AM · Restricted Project

Apr 22 2019

CodaFi committed rGff8febcb6dfd: [LLVM-C] Add accessors to the default floating-point metadata node (authored by CodaFi).
[LLVM-C] Add accessors to the default floating-point metadata node
Apr 22 2019, 6:12 AM
CodaFi committed rL358883: [LLVM-C] Add accessors to the default floating-point metadata node.
[LLVM-C] Add accessors to the default floating-point metadata node
Apr 22 2019, 6:11 AM
CodaFi closed D60527: [LLVM-C] Add accessors to the default floating-point metadata node.
Apr 22 2019, 6:11 AM · Restricted Project

Apr 17 2019

CodaFi committed rGd909a5ed8d60: [LLVM-C] Add DIFile Field Accesssors (authored by CodaFi).
[LLVM-C] Add DIFile Field Accesssors
Apr 17 2019, 6:28 AM
CodaFi committed rL358577: [LLVM-C] Add DIFile Field Accesssors.
[LLVM-C] Add DIFile Field Accesssors
Apr 17 2019, 6:27 AM
CodaFi closed D60489: [LLVM-C] Add DIFile Field Accesssors.
Apr 17 2019, 6:27 AM · Restricted Project

Apr 16 2019

CodaFi added a comment to D60489: [LLVM-C] Add DIFile Field Accesssors.

@jberdine Any further comments?

Apr 16 2019, 2:50 PM · Restricted Project
CodaFi updated the diff for D60489: [LLVM-C] Add DIFile Field Accesssors.
Apr 16 2019, 2:50 PM · Restricted Project
CodaFi committed rGd6eb4bb80107: [LLVM-C] Add Accessors For Global Variable Metadata Properties (authored by CodaFi).
[LLVM-C] Add Accessors For Global Variable Metadata Properties
Apr 16 2019, 2:40 PM
CodaFi committed rL358532: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
[LLVM-C] Add Accessors For Global Variable Metadata Properties
Apr 16 2019, 2:39 PM
CodaFi closed D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 2:39 PM · Restricted Project
CodaFi added a comment to D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.

@whitequark Could I get your stamp of approval as well?

Apr 16 2019, 2:34 PM · Restricted Project
CodaFi updated the diff for D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 2:33 PM · Restricted Project
CodaFi added a comment to D60795: [LLVM-C] Add LLVMDISubprogramGetLine accessor.

This patch doesn't apply cleanly to my checkout, so I'm going to fold it into D60725.

Apr 16 2019, 2:25 PM · Restricted Project
CodaFi changed the repository for D60795: [LLVM-C] Add LLVMDISubprogramGetLine accessor from rL LLVM to rG LLVM Github Monorepo.
Apr 16 2019, 2:16 PM · Restricted Project
CodaFi updated the diff for D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 1:42 PM · Restricted Project
CodaFi accepted D60795: [LLVM-C] Add LLVMDISubprogramGetLine accessor.

LGTM

Apr 16 2019, 1:41 PM · Restricted Project
CodaFi added inline comments to D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 1:36 PM · Restricted Project

Apr 15 2019

CodaFi added a comment to D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.

@jberdine This patch handles the global variable side of things. You should be able to replace those accessors in Core with a call to LLVMGlobalCopyAllMetadata. You can filter for !dbg and dig out the global variable expression. From there, you locate from global variable expression to global variable with LLVMDIGlobalVariableExpressionGetVariable and from global variable to line with LLVMDIVariableGetLine.

Apr 15 2019, 10:41 AM · Restricted Project
CodaFi created D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 15 2019, 10:39 AM · Restricted Project
CodaFi added a comment to D60489: [LLVM-C] Add DIFile Field Accesssors.

A DISubprogram is a kind of DIScope so you can use LLVMDIScopeGetFile and the rest of the accessors to poke at their metadata. For Global Variables, the idea should be to add corresponding accessors for the scope, file, name, source, and directory since these nodes do not store DILocations. It seems like the latter is pressing, so I'll make a patch for it in a bit.

Apr 15 2019, 7:23 AM · Restricted Project
CodaFi added inline comments to D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets.
Apr 15 2019, 6:38 AM · Restricted Project

Apr 10 2019

CodaFi created D60527: [LLVM-C] Add accessors to the default floating-point metadata node.
Apr 10 2019, 11:33 AM · Restricted Project
CodaFi created D60524: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.
Apr 10 2019, 11:25 AM · Restricted Project
CodaFi committed rGcce47418c93b: [LLVM-C] Correct The Current Debug Location Accessors (Again) (authored by CodaFi).
[LLVM-C] Correct The Current Debug Location Accessors (Again)
Apr 10 2019, 7:18 AM
CodaFi committed rL358086: [LLVM-C] Correct The Current Debug Location Accessors (Again).
[LLVM-C] Correct The Current Debug Location Accessors (Again)
Apr 10 2019, 7:17 AM
CodaFi closed D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).
Apr 10 2019, 7:17 AM · Restricted Project
CodaFi updated the diff for D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).

Add an accessor for the "inlined at" location

Apr 10 2019, 7:14 AM · Restricted Project
CodaFi added a comment to D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).

All this is reminding me I need to go back through and remove this header. The Go bindings do not need special treatment, and any new bindings they have need to be merged into LLVM-C

Apr 10 2019, 6:43 AM · Restricted Project
CodaFi created D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).
Apr 10 2019, 6:42 AM · Restricted Project
CodaFi added a comment to D60484: [LLVM-C] Correct The Current Debug Location Accessors.

*sigh*, I'll resubmit this and nuke the ones in the Go bindings then.

Apr 10 2019, 6:30 AM · Restricted Project

Apr 9 2019

CodaFi updated the diff for D60489: [LLVM-C] Add DIFile Field Accesssors.

Retarget from DIScope to DIFile since we can retrieve the file object for a scope now.

Apr 9 2019, 4:01 PM · Restricted Project
CodaFi added a comment to D60489: [LLVM-C] Add DIFile Field Accesssors.

@jberdine Are these bindings missing anything for your current use-case? I want to make sure you're covered before I deprecate them.

Apr 9 2019, 3:32 PM · Restricted Project
CodaFi created D60489: [LLVM-C] Add DIFile Field Accesssors.
Apr 9 2019, 3:32 PM · Restricted Project
CodaFi committed rG50f726d73a41: [LLVM-C] Correct The Current Debug Location Accessors (authored by CodaFi).
[LLVM-C] Correct The Current Debug Location Accessors
Apr 9 2019, 3:31 PM
CodaFi committed rL358039: [LLVM-C] Correct The Current Debug Location Accessors.
[LLVM-C] Correct The Current Debug Location Accessors
Apr 9 2019, 3:31 PM
CodaFi closed D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 3:31 PM · Restricted Project
CodaFi committed rGbec0a45ddce6: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc (authored by CodaFi).
[LLVM-C] Add Bindings to Access an Instruction's DebugLoc
Apr 9 2019, 3:27 PM
CodaFi committed rL358038: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
[LLVM-C] Add Bindings to Access an Instruction's DebugLoc
Apr 9 2019, 3:26 PM
CodaFi closed D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 3:26 PM · Restricted Project
CodaFi updated the diff for D60484: [LLVM-C] Correct The Current Debug Location Accessors.

Add documentation to LLVMSetInstDebugLocation

Apr 9 2019, 3:25 PM · Restricted Project
CodaFi updated the diff for D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 3:03 PM · Restricted Project
CodaFi added inline comments to D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 3:02 PM · Restricted Project
CodaFi updated the diff for D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 3:02 PM · Restricted Project
CodaFi added inline comments to D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 2:59 PM · Restricted Project
CodaFi committed rGd1ba3b13f83e: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries (authored by CodaFi).
[LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries
Apr 9 2019, 2:53 PM
CodaFi committed rL358037: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.
[LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries
Apr 9 2019, 2:53 PM
CodaFi closed D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.
Apr 9 2019, 2:53 PM · Restricted Project
CodaFi added a comment to D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

Thanks!

Apr 9 2019, 2:49 PM · Restricted Project
CodaFi added a comment to D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

@whitequark Could you give it one more look. Had to fix a corner-case.

Apr 9 2019, 2:41 PM · Restricted Project
CodaFi added a reviewer for D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets: phosek.

+@phosek Who seems to be the last significant contributor to this file.

Apr 9 2019, 2:25 PM · Restricted Project
CodaFi updated the diff for D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

The ELF section and symbol iterators can produce error values which turn into NULL underlying data in the iterators. Propagate this out as a NULL returned iterator.

Apr 9 2019, 2:08 PM · Restricted Project
CodaFi created D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 1:35 PM · Restricted Project
CodaFi updated the summary of D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 1:27 PM · Restricted Project
CodaFi updated the diff for D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.

Correctly handle the NULL location

Apr 9 2019, 1:27 PM · Restricted Project
CodaFi created D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 1:04 PM · Restricted Project
CodaFi updated the diff for D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.

Correct a typo in the header

Apr 9 2019, 12:58 PM · Restricted Project
CodaFi added a comment to D52239: [OCaml] Add OCaml APIs to access DebugLoc info.

My concern is that we’re building parallel API hierarchies here. The old hat way of wrapping metadata nodes in a value and casting out to an LLVMValueRef makes no sense if we have APIs to manipulate metadata more directly.

Apr 9 2019, 11:31 AM · Restricted Project

Apr 8 2019

CodaFi created D60407: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.
Apr 8 2019, 7:01 AM · Restricted Project

Apr 7 2019

CodaFi created D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.
Apr 7 2019, 11:23 AM · Restricted Project
CodaFi committed rGa51883cfab4e: [LLVM-C] Allow Access to the Type of a Binary (authored by CodaFi).
[LLVM-C] Allow Access to the Type of a Binary
Apr 7 2019, 11:20 AM
CodaFi committed rL357872: [LLVM-C] Allow Access to the Type of a Binary.
[LLVM-C] Allow Access to the Type of a Binary
Apr 7 2019, 11:20 AM
CodaFi closed D60366: [LLVM-C] Allow Access to the Type of a Binary.
Apr 7 2019, 11:20 AM · Restricted Project

Apr 6 2019

CodaFi created D60366: [LLVM-C] Allow Access to the Type of a Binary.
Apr 6 2019, 11:29 AM · Restricted Project

Apr 5 2019

CodaFi committed rGc76b6215302f: [LLVM-C] Begin to Expose A More General Binary Interface (authored by CodaFi).
[LLVM-C] Begin to Expose A More General Binary Interface
Apr 5 2019, 2:38 PM
CodaFi committed rL357822: [LLVM-C] Begin to Expose A More General Binary Interface.
[LLVM-C] Begin to Expose A More General Binary Interface
Apr 5 2019, 2:38 PM
CodaFi closed D60322: [LLVM-C] Begin to Expose A More General Binary Interface.
Apr 5 2019, 2:38 PM · Restricted Project
CodaFi updated the diff for D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

Rename LLVMBinaryGetMemoryBuffer to LLVMBinaryCopyMemoryBuffer to better convey ownership semantics. Update the docs.

Apr 5 2019, 1:51 PM · Restricted Project
CodaFi added inline comments to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.
Apr 5 2019, 1:41 PM · Restricted Project
CodaFi committed rGb4baa5602d15: [LLVM-C] Add bindings to insert basic blocks (authored by CodaFi).
[LLVM-C] Add bindings to insert basic blocks
Apr 5 2019, 1:33 PM
CodaFi committed rL357812: [LLVM-C] Add bindings to insert basic blocks.
[LLVM-C] Add bindings to insert basic blocks
Apr 5 2019, 1:32 PM
CodaFi closed D59658: [LLVM-C] Add bindings to insert basic blocks.
Apr 5 2019, 1:32 PM · Restricted Project
CodaFi updated the diff for D59658: [LLVM-C] Add bindings to insert basic blocks.
Apr 5 2019, 1:13 PM · Restricted Project
CodaFi added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

A (verbose) compromise: LLVMInsertExistingBasicBlockAfterInsertBlock?

Apr 5 2019, 1:03 PM · Restricted Project
CodaFi added inline comments to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.
Apr 5 2019, 12:47 PM · Restricted Project
CodaFi added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

I think the names are confusing. Why not something like LLVMInsertExistingBasicBlock and LLVMAppendExistingBasicBlock?

Apr 5 2019, 12:44 PM · Restricted Project
CodaFi added a comment to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

The ObjectFile APIs seem to have rotted a bit. There's a bunch of pitfalls when working with the thing like the fact that it goes out of its way to move the input buffer despite the create APIs taking non-owning references to the buffer in C++, accessors that no longer do anything useful (LLVMGetRelocationValueString) and inconsistent error handling routines (some functions return NULL, LLVMGetSymbolName and LLVMGetSymbolName reports a fatal error). On top of that, it's not actually a general interface to ObjectFile - it can't handle Mach-O Universal binaries as inputs for one.

Apr 5 2019, 12:38 PM · Restricted Project
CodaFi updated the diff for D58733: [LLVM-C] Move and Clean Up The Instrumentation Pass Bindings.

Remove support for Efficiency Sanitizer

Apr 5 2019, 8:56 AM · Restricted Project