Page MenuHomePhabricator

CodaFi (Robert Widmann)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2017, 7:43 PM (178 w, 5 d)

Recent Activity

Fri, Aug 28

CodaFi updated the diff for D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules.
Fri, Aug 28, 5:18 PM · Restricted Project
CodaFi requested review of D86823: [clang][Modules] Perform an Extra Consistency Check When Searching The ModuleManager's Cache For Implicit Modules.
Fri, Aug 28, 4:25 PM · Restricted Project
CodaFi abandoned D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

We have tested this proposed change out on our CI systems and have seen no relief from the symptoms of inode reuse with this approach. Abandoning this revision in favor of a more narrow fix.

Fri, Aug 28, 4:21 PM · Restricted Project

Aug 19 2020

CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 19 2020, 5:45 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 19 2020, 3:40 PM · Restricted Project

Aug 18 2020

CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

@aprantl Good idea. Updated.

Aug 18 2020, 7:36 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 7:35 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 11:06 AM · Restricted Project
CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

Switched tactics here. Rather than just change the source of the entropy, let's increase it from just inodes to (64-bits of inode) plus (file size) plus (mod time). It is still possible to defeat this scheme, but it means an attacker would have to replace the PCM with one that has been padded out to the same size then backdate its modtime to match the one in the cache - or some cascading failure of the syscalls providing these data conspires to make this happen.

Aug 18 2020, 10:19 AM · Restricted Project
CodaFi updated the summary of D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 10:12 AM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 18 2020, 10:12 AM · Restricted Project

Aug 17 2020

CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

Figured it out for myself. The test is forming paths that are using non-canonical path separators. Naively using those as keys means that the subsequent canonicalization done by the ASTWriter renders the keys useless for lookups into these structures. I'm going to switch to FileEntry::tryGetRealPathName since it's quite literally what ASTWriter is doing as part of its canonicalization phase. I worry about that as a solution in general though. In the future, it would be great to expose the canonicalization utilities in the ASTWriter as a more general kind of facility that could be shared between the implementations so we don't desync things again.

Aug 17 2020, 10:32 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 17 2020, 10:19 PM · Restricted Project

Aug 15 2020

CodaFi updated subscribers of D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.

Okay, I'm done throwing revisions at the bots. This windows-only failure is bizarre. @rsmith Do you have any insight into what's going wrong here?

Aug 15 2020, 7:49 PM · Restricted Project
CodaFi added inline comments to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 7:35 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 7:26 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 6:38 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 5:33 PM · Restricted Project
CodaFi updated the diff for D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 3:57 PM · Restricted Project
CodaFi added a comment to D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 15 2020, 1:03 PM · Restricted Project

Aug 14 2020

CodaFi requested review of D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys.
Aug 14 2020, 10:55 AM · Restricted Project

Jun 9 2020

CodaFi added a comment to D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter..

C API changes LGTM. My one request is to update the echo llvm-c-test to use the new API.

Jun 9 2020, 12:40 PM · Restricted Project, Restricted Project

May 31 2020

CodaFi added a comment to D78599: [SVE] Add Scalable vector support to C api.

I see you’ve already abandoned the revision, but I want to say that if you wish to do this, please make a separate entry point in the C API for creating scalable vectors. We are still committed to ABI stability in the core bindings.

May 31 2020, 2:54 PM · Restricted Project

May 1 2020

CodaFi requested changes to D78746: [LLVM-C] Match C-API integer types to the underlying used CPP-API.

We are committed to ABI stability in the core bindings. If you wish to pursue this change, you will need to seek consensus on the mailing list. I'm personally not opposed to an ABI break, but it *must* be done in the open.

May 1 2020, 5:13 PM · Restricted Project
CodaFi added a comment to D72207: [LLVM-C][bindings/go] Get metadata from a value.

Why not change the behavior of LLVMGetMetadata instead? It's an ABI-compatible change, and expanding the API to cover more cases instead of crashing is API-compatible.

May 1 2020, 5:13 PM · Restricted Project

Mar 11 2020

CodaFi abandoned D58733: [LLVM-C] Move and Clean Up The Instrumentation Pass Bindings.
Mar 11 2020, 8:31 AM · Restricted Project

Dec 27 2019

CodaFi accepted D71942: Update LLVMCallConv.
Dec 27 2019, 2:19 PM · Restricted Project

Nov 21 2019

CodaFi added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

C binding changes LGTM. Don’t worry about changing them, they are marked as experimental and subject to change at any time.

Nov 21 2019, 9:01 AM · Restricted Project, Restricted Project, debug-info

Oct 23 2019

CodaFi added a reviewer for D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets: compnerd.
Oct 23 2019, 3:03 PM · Restricted Project
CodaFi added a comment to D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal..

@MaskRay I have a refactoring in https://reviews.llvm.org/D59425 that covers that.

Oct 23 2019, 3:01 PM

Oct 22 2019

CodaFi added a reviewer for D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal.: compnerd.
Oct 22 2019, 5:58 PM

Aug 14 2019

CodaFi added a comment to D66061: Expose TailCallKind via the LLVM C API.

Y’all can revert it. I’ll resubmit the patch with updated tests tomorrow.

Aug 14 2019, 8:47 PM · Restricted Project
CodaFi committed rG708c4605a16b: Expose TailCallKind via the LLVM C API (authored by CodaFi).
Expose TailCallKind via the LLVM C API
Aug 14 2019, 4:55 PM
CodaFi committed rL368945: Expose TailCallKind via the LLVM C API.
Expose TailCallKind via the LLVM C API
Aug 14 2019, 4:54 PM
CodaFi closed D66061: Expose TailCallKind via the LLVM C API.
Aug 14 2019, 4:54 PM · Restricted Project
CodaFi created D66237: [LLVM-C] Add Bindings to the Globals Mod/Ref Alias Analysis Pass.
Aug 14 2019, 11:54 AM · Restricted Project

Aug 10 2019

CodaFi accepted D66061: Expose TailCallKind via the LLVM C API.
Aug 10 2019, 10:55 PM · Restricted Project

Jul 26 2019

CodaFi added inline comments to D65070: [LLVM-C][OCaml] Add a fast linker binding.
Jul 26 2019, 6:45 PM · Restricted Project

Jul 24 2019

CodaFi added inline comments to D65070: [LLVM-C][OCaml] Add a fast linker binding.
Jul 24 2019, 7:29 AM · Restricted Project

Jul 23 2019

CodaFi requested changes to D65070: [LLVM-C][OCaml] Add a fast linker binding.
Jul 23 2019, 9:10 AM · Restricted Project

Jul 22 2019

CodaFi committed rGfcf3c55a8cd2: [LLVM-C] Improve Bindings to The Internalize Pass (authored by CodaFi).
[LLVM-C] Improve Bindings to The Internalize Pass
Jul 22 2019, 9:58 PM
CodaFi committed rL366777: [LLVM-C] Improve Bindings to The Internalize Pass.
[LLVM-C] Improve Bindings to The Internalize Pass
Jul 22 2019, 9:57 PM
CodaFi closed D62456: [LLVM-C] Improve Bindings to The Internalize Pass.
Jul 22 2019, 9:57 PM · Restricted Project

Jun 14 2019

CodaFi accepted D63056: [bindings/go] Add debug information accessors.

We spoke out of band about the troubles I’m having verifying this locally, but the patch looks good and my limitations shouldn’t hold it back any longer.

Jun 14 2019, 1:49 PM · Restricted Project

May 25 2019

CodaFi updated the diff for D62456: [LLVM-C] Improve Bindings to The Internalize Pass.

Document the lifetime of the context parameter

May 25 2019, 4:37 PM · Restricted Project
CodaFi created D62456: [LLVM-C] Improve Bindings to The Internalize Pass.
May 25 2019, 2:20 PM · Restricted Project
CodaFi committed rGb0fd12b68929: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices (authored by CodaFi).
[LLVM-C] Add Accessor for Mach-O Universal Binary Slices
May 25 2019, 9:47 AM
CodaFi committed rL361705: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.
[LLVM-C] Add Accessor for Mach-O Universal Binary Slices
May 25 2019, 9:47 AM
CodaFi closed D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.
May 25 2019, 9:47 AM · Restricted Project
CodaFi updated the diff for D60378: [LLVM-C] Add Accessor for Mach-O Universal Binary Slices.

[NFC] Rebase

May 25 2019, 9:43 AM · Restricted Project

Apr 24 2019

CodaFi committed rG09c5b883cb7a: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions (authored by CodaFi).
[LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions
Apr 24 2019, 10:05 AM
CodaFi committed rL359114: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.
[LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions
Apr 24 2019, 10:05 AM
CodaFi closed D60524: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.
Apr 24 2019, 10:05 AM · Restricted Project

Apr 22 2019

CodaFi committed rGff8febcb6dfd: [LLVM-C] Add accessors to the default floating-point metadata node (authored by CodaFi).
[LLVM-C] Add accessors to the default floating-point metadata node
Apr 22 2019, 6:12 AM
CodaFi committed rL358883: [LLVM-C] Add accessors to the default floating-point metadata node.
[LLVM-C] Add accessors to the default floating-point metadata node
Apr 22 2019, 6:11 AM
CodaFi closed D60527: [LLVM-C] Add accessors to the default floating-point metadata node.
Apr 22 2019, 6:11 AM · Restricted Project

Apr 17 2019

CodaFi committed rGd909a5ed8d60: [LLVM-C] Add DIFile Field Accesssors (authored by CodaFi).
[LLVM-C] Add DIFile Field Accesssors
Apr 17 2019, 6:28 AM
CodaFi committed rL358577: [LLVM-C] Add DIFile Field Accesssors.
[LLVM-C] Add DIFile Field Accesssors
Apr 17 2019, 6:27 AM
CodaFi closed D60489: [LLVM-C] Add DIFile Field Accesssors.
Apr 17 2019, 6:27 AM · Restricted Project

Apr 16 2019

CodaFi added a comment to D60489: [LLVM-C] Add DIFile Field Accesssors.

@jberdine Any further comments?

Apr 16 2019, 2:50 PM · Restricted Project
CodaFi updated the diff for D60489: [LLVM-C] Add DIFile Field Accesssors.
Apr 16 2019, 2:50 PM · Restricted Project
CodaFi committed rGd6eb4bb80107: [LLVM-C] Add Accessors For Global Variable Metadata Properties (authored by CodaFi).
[LLVM-C] Add Accessors For Global Variable Metadata Properties
Apr 16 2019, 2:40 PM
CodaFi committed rL358532: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
[LLVM-C] Add Accessors For Global Variable Metadata Properties
Apr 16 2019, 2:39 PM
CodaFi closed D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 2:39 PM · Restricted Project
CodaFi added a comment to D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.

@whitequark Could I get your stamp of approval as well?

Apr 16 2019, 2:34 PM · Restricted Project
CodaFi updated the diff for D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 2:33 PM · Restricted Project
CodaFi added a comment to D60795: [LLVM-C] Add LLVMDISubprogramGetLine accessor.

This patch doesn't apply cleanly to my checkout, so I'm going to fold it into D60725.

Apr 16 2019, 2:25 PM · Restricted Project
CodaFi changed the repository for D60795: [LLVM-C] Add LLVMDISubprogramGetLine accessor from rL LLVM to rG LLVM Github Monorepo.
Apr 16 2019, 2:16 PM · Restricted Project
CodaFi updated the diff for D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 1:42 PM · Restricted Project
CodaFi accepted D60795: [LLVM-C] Add LLVMDISubprogramGetLine accessor.

LGTM

Apr 16 2019, 1:41 PM · Restricted Project
CodaFi added inline comments to D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 16 2019, 1:36 PM · Restricted Project

Apr 15 2019

CodaFi added a comment to D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.

@jberdine This patch handles the global variable side of things. You should be able to replace those accessors in Core with a call to LLVMGlobalCopyAllMetadata. You can filter for !dbg and dig out the global variable expression. From there, you locate from global variable expression to global variable with LLVMDIGlobalVariableExpressionGetVariable and from global variable to line with LLVMDIVariableGetLine.

Apr 15 2019, 10:41 AM · Restricted Project
CodaFi created D60725: [LLVM-C] Add Accessors For Global Variable Metadata Properties.
Apr 15 2019, 10:39 AM · Restricted Project
CodaFi added a comment to D60489: [LLVM-C] Add DIFile Field Accesssors.

A DISubprogram is a kind of DIScope so you can use LLVMDIScopeGetFile and the rest of the accessors to poke at their metadata. For Global Variables, the idea should be to add corresponding accessors for the scope, file, name, source, and directory since these nodes do not store DILocations. It seems like the latter is pressing, so I'll make a patch for it in a bit.

Apr 15 2019, 7:23 AM · Restricted Project
CodaFi added inline comments to D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets.
Apr 15 2019, 6:38 AM · Restricted Project

Apr 10 2019

CodaFi created D60527: [LLVM-C] Add accessors to the default floating-point metadata node.
Apr 10 2019, 11:33 AM · Restricted Project
CodaFi created D60524: [LLVM-C] Deprecate the LLVMValueRef-returning metadata creation functions.
Apr 10 2019, 11:25 AM · Restricted Project
CodaFi committed rGcce47418c93b: [LLVM-C] Correct The Current Debug Location Accessors (Again) (authored by CodaFi).
[LLVM-C] Correct The Current Debug Location Accessors (Again)
Apr 10 2019, 7:18 AM
CodaFi committed rL358086: [LLVM-C] Correct The Current Debug Location Accessors (Again).
[LLVM-C] Correct The Current Debug Location Accessors (Again)
Apr 10 2019, 7:17 AM
CodaFi closed D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).
Apr 10 2019, 7:17 AM · Restricted Project
CodaFi updated the diff for D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).

Add an accessor for the "inlined at" location

Apr 10 2019, 7:14 AM · Restricted Project
CodaFi added a comment to D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).

All this is reminding me I need to go back through and remove this header. The Go bindings do not need special treatment, and any new bindings they have need to be merged into LLVM-C

Apr 10 2019, 6:43 AM · Restricted Project
CodaFi created D60511: [LLVM-C] Correct The Current Debug Location Accessors (Again).
Apr 10 2019, 6:42 AM · Restricted Project
CodaFi added a comment to D60484: [LLVM-C] Correct The Current Debug Location Accessors.

*sigh*, I'll resubmit this and nuke the ones in the Go bindings then.

Apr 10 2019, 6:30 AM · Restricted Project

Apr 9 2019

CodaFi updated the diff for D60489: [LLVM-C] Add DIFile Field Accesssors.

Retarget from DIScope to DIFile since we can retrieve the file object for a scope now.

Apr 9 2019, 4:01 PM · Restricted Project
CodaFi added a comment to D60489: [LLVM-C] Add DIFile Field Accesssors.

@jberdine Are these bindings missing anything for your current use-case? I want to make sure you're covered before I deprecate them.

Apr 9 2019, 3:32 PM · Restricted Project
CodaFi created D60489: [LLVM-C] Add DIFile Field Accesssors.
Apr 9 2019, 3:32 PM · Restricted Project
CodaFi committed rG50f726d73a41: [LLVM-C] Correct The Current Debug Location Accessors (authored by CodaFi).
[LLVM-C] Correct The Current Debug Location Accessors
Apr 9 2019, 3:31 PM
CodaFi committed rL358039: [LLVM-C] Correct The Current Debug Location Accessors.
[LLVM-C] Correct The Current Debug Location Accessors
Apr 9 2019, 3:31 PM
CodaFi closed D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 3:31 PM · Restricted Project
CodaFi committed rGbec0a45ddce6: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc (authored by CodaFi).
[LLVM-C] Add Bindings to Access an Instruction's DebugLoc
Apr 9 2019, 3:27 PM
CodaFi committed rL358038: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
[LLVM-C] Add Bindings to Access an Instruction's DebugLoc
Apr 9 2019, 3:26 PM
CodaFi closed D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 3:26 PM · Restricted Project
CodaFi updated the diff for D60484: [LLVM-C] Correct The Current Debug Location Accessors.

Add documentation to LLVMSetInstDebugLocation

Apr 9 2019, 3:25 PM · Restricted Project
CodaFi updated the diff for D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 3:03 PM · Restricted Project
CodaFi added inline comments to D60484: [LLVM-C] Correct The Current Debug Location Accessors.
Apr 9 2019, 3:02 PM · Restricted Project
CodaFi updated the diff for D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 3:02 PM · Restricted Project
CodaFi added inline comments to D60481: [LLVM-C] Add Bindings to Access an Instruction's DebugLoc.
Apr 9 2019, 2:59 PM · Restricted Project
CodaFi committed rGd1ba3b13f83e: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries (authored by CodaFi).
[LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries
Apr 9 2019, 2:53 PM
CodaFi committed rL358037: [LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries.
[LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries
Apr 9 2019, 2:53 PM