Page MenuHomePhabricator

koutheir (Koutheir Attouchi)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2021, 11:57 AM (13 w, 1 d)

Recent Activity

Fri, Jul 16

koutheir added a comment to D104794: Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API.

Is there still an issue preventing committing of this change?

Fri, Jul 16, 8:50 AM · Restricted Project

Wed, Jul 7

koutheir requested review of D105604: Generate DW_TAG_class_type when calling DIBuilder::createClassType()..
Wed, Jul 7, 8:06 PM · Restricted Project
koutheir added a comment to D104794: Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API.

Can someone commit this accepted change?

Wed, Jul 7, 4:56 PM · Restricted Project

Jun 24 2021

koutheir added a comment to D104794: Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API.

The build failures seem unrelated to this patch. Can someone review, please?

Jun 24 2021, 8:25 AM · Restricted Project

Jun 23 2021

koutheir abandoned D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.
Jun 23 2021, 10:12 AM · Restricted Project
koutheir abandoned D104759: Indicate ABI in ARM ELF header flags.
Jun 23 2021, 10:12 AM · Restricted Project
koutheir retitled D104794: Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API from Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API. The LLVM C API function is called `LLVMDIBuilderFinalizeSubprogram()`. to Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API.
Jun 23 2021, 10:06 AM · Restricted Project
koutheir requested review of D104794: Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API.
Jun 23 2021, 10:06 AM · Restricted Project
koutheir added a comment to D104759: Indicate ABI in ARM ELF header flags.

@peter.smith, thank you for the analysis! I'm consequently backing out of this patch.

Jun 23 2021, 8:55 AM · Restricted Project
koutheir added inline comments to D104759: Indicate ABI in ARM ELF header flags.
Jun 23 2021, 8:46 AM · Restricted Project

Jun 22 2021

koutheir added inline comments to D104759: Indicate ABI in ARM ELF header flags.
Jun 22 2021, 10:39 PM · Restricted Project
koutheir requested review of D104759: Indicate ABI in ARM ELF header flags.
Jun 22 2021, 5:44 PM · Restricted Project
koutheir added a comment to D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.

And what about this: https://bugs.llvm.org/show_bug.cgi?id=50721

Jun 22 2021, 9:32 AM · Restricted Project
koutheir added a comment to D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.

Back ends are expected to crash when given invalid IR.

Jun 22 2021, 9:20 AM · Restricted Project
koutheir added a comment to D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.

And how should the crash be fixed? Or shouldn't it?

Jun 22 2021, 8:47 AM · Restricted Project

Jun 15 2021

koutheir added a comment to D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.

Not quite. Address spaces in LLVM are a somewhat opaque concept, and can mean anything. I'm just not sure they are exchangeable like you propose on all cases.

Jun 15 2021, 10:03 AM · Restricted Project
koutheir updated the diff for D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.
Jun 15 2021, 8:06 AM · Restricted Project
koutheir updated the diff for D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.
Jun 15 2021, 8:04 AM · Restricted Project
koutheir added a comment to D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.

Basically, what that's saying is that *all* access to *any* address space is the same as an access through the default address space.

It may be true for your case, but not necessarily others. Your code would make it true for all.

Jun 15 2021, 7:56 AM · Restricted Project
koutheir updated the diff for D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.
Jun 15 2021, 7:18 AM · Restricted Project
koutheir added a comment to D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.

I'm not an expert on atomics or the various uses of address spaces in the wild,...

Jun 15 2021, 6:17 AM · Restricted Project
koutheir added a comment to D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.

I'm not an expert on atomics or the various uses of address spaces in the wild, but I'm curious as to what your use case is.

Jun 15 2021, 6:08 AM · Restricted Project

Jun 14 2021

koutheir updated the summary of D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.
Jun 14 2021, 1:45 PM · Restricted Project
koutheir retitled D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM from Fix atomic loads and stores of 64-bit integers in non-default address spaces on ARM. Performing an atomic load or store of a 64-bit value, using an address outside the default address space, triggers an assertion failure on ARM. The ARM back-end... to Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.
Jun 14 2021, 1:45 PM · Restricted Project
koutheir requested review of D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM.
Jun 14 2021, 1:44 PM · Restricted Project

Jun 11 2021

koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

The build builders/53/builds/3020 fails due a time out. I don't think this is an actual failure. Maybe someone could increase the time out value for certain long-running tests.

Jun 11 2021, 5:45 PM · Restricted Project
koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

The commit 789708617d20 caused two failures:

Jun 11 2021, 8:25 AM · Restricted Project

Jun 9 2021

koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

@rengolin: Can you please commit this updated patch on my behalf?

Jun 9 2021, 3:34 PM · Restricted Project
koutheir updated the diff for D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..
Jun 9 2021, 2:31 PM · Restricted Project
koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

I'll do that from now on. I'm sorry for the confusion.

Jun 9 2021, 1:11 PM · Restricted Project
koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

@rengolin I tested the ARM tests that I thought would be affected. This appears to be affecting other tests.

Jun 9 2021, 12:39 PM · Restricted Project
koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

@rengolin: I don't have commit access. Can you please commit this patch on my behalf?

Jun 9 2021, 6:12 AM · Restricted Project

Jun 8 2021

koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

Doesn't this depend on which runtime library you're using? No Arm32 library implement that?

I remember a patch to add 128-bit arithmetic into Armv7 many years ago (from Android) but I'm not sure it ever got into compiler-rt.

Jun 8 2021, 9:52 AM · Restricted Project
koutheir added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

This patch is intended to solve the bug 20871 for the ARM back-end.

Jun 8 2021, 9:25 AM · Restricted Project
koutheir updated the summary of D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..
Jun 8 2021, 9:19 AM · Restricted Project
koutheir retitled D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM. from Do not generate calls to the 128-bit function __multi3() on 32-bit ARM. The function __multi3() is undefined on 32-bit ARM, so a call to it should never be emitted. Instead, plain instructions need to be generated to perform 128-bit multiplications. to Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..
Jun 8 2021, 9:19 AM · Restricted Project
koutheir requested review of D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..
Jun 8 2021, 9:18 AM · Restricted Project

Jun 3 2021

koutheir updated koutheir.
Jun 3 2021, 2:33 PM