Page MenuHomePhabricator

[OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.
ClosedPublic

Authored by ABataev on Jun 14 2021, 10:04 AM.

Details

Summary

Added support for CXXRewrittenBinaryOperator as a condition in ranged
for loops. This is a new kind of expression, need to extend support for

C++20 constructs.

It fixes PR49970: range-based for compilation fails for libstdc++ vector
with -std=c++20.

Diff Detail

Unit TestsFailed

TimeTest
6,210 msx64 debian > libarcher.races::lock-unrelated.c
Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp 2>&1 | tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp.log | /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c

Event Timeline

ABataev created this revision.Jun 14 2021, 10:04 AM
ABataev requested review of this revision.Jun 14 2021, 10:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 10:04 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
jdoerfert accepted this revision.Jun 14 2021, 11:06 AM

LG, thanks

This revision is now accepted and ready to land.Jun 14 2021, 11:06 AM
This revision was landed with ongoing or failed builds.Jun 14 2021, 11:59 AM
This revision was automatically updated to reflect the committed changes.