Page MenuHomePhabricator

[lit][test] Improve testing of use_llvm_tool
ClosedPublic

Authored by jhenderson on May 26 2021, 4:06 AM.

Diff Detail

Unit TestsFailed

TimeTest
1,460 msx64 windows > lit.lit::use-llvm-tool.py
Script: -- : 'RUN: at line 7'; env -u FILECHECK_OPTS "C:\Python39\python.exe" C:/ws/w7/llvm-project/premerge-checks/llvm\utils\lit\lit.py C:/ws/w7/llvm-project/premerge-checks/build/utils/lit/tests\Inputs/use-llvm-tool 2>&1 | FileCheck C:\ws\w7\llvm-project\premerge-checks\build\utils\lit\tests\use-llvm-tool.py -DDIR=C:\ws\w7\llvm-project\premerge-checks\build\utils\lit\tests

Event Timeline

jhenderson created this revision.May 26 2021, 4:06 AM
jhenderson requested review of this revision.May 26 2021, 4:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 4:06 AM

Fix some stale comments.

Fix another comment.

MaskRay accepted this revision.May 26 2021, 6:53 PM

I just understand what D102630 and this do. Now rm $build/bin/ld.lld; llvm-lit something.s will not pick a ld.lld from PATH. Looks great!

curl -L 'https://reviews.llvm.org/D103154?download=1' | patch -p1
ninja check-lit

says use-llvm-tool.py fails.

This revision is now accepted and ready to land.May 26 2021, 6:53 PM

I just understand what D102630 and this do. Now rm $build/bin/ld.lld; llvm-lit something.s will not pick a ld.lld from PATH. Looks great!

curl -L 'https://reviews.llvm.org/D103154?download=1' | patch -p1
ninja check-lit

says use-llvm-tool.py fails.

I stuffed up the diff somehow. The changes in config.py should be part of D103156, not here. I suspect that's what's breaking the test. Will investigate and fix.

Remove unrelated changes.

I'm still investigating the cause of the test failure - it doesn't fail for me locally on my windows machine.

Remove unrelated changes.

I'm still investigating the cause of the test failure - it doesn't fail for me locally on my windows machine.

The latest pre-merge test hasn't failed with this test as a failure, and the test passes on my Linux machine. I'm going to assume that the failure was just due to the broken diff and commit this as-is.

This revision was landed with ongoing or failed builds.May 27 2021, 3:31 AM
This revision was automatically updated to reflect the committed changes.