Page MenuHomePhabricator

kkleine (Konrad Kleine)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2019, 10:03 AM (130 w, 3 d)

I'm a dad and husband, music lover, play the acoustic guitar, sing, and like to go out with my photo camera.

Recent Activity

Oct 26 2020

kkleine added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@njames93 I could do that but the original Macros had were defined without a semicolon at the end and one had to add it manually. See this revision in which I replaced some occurrences of DISALLOW_COPY_AND_ASSIGN: eaebcbc67926a18befaa297f1778edde63baec9b. What do you suggest? Keep the semicolon to more closely match the original macros or remove it to make the test happy?

Oct 26 2020, 5:13 AM · Restricted Project, Restricted Project
kkleine added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@dblaikie sorry for the late feedback. The LLVM_ENABLE_WERROR:BOOL will "Stop and fail the build, if a compiler warning is triggered. Defaults to OFF." I wonder if any other test fails from clang tidy because. My test explicitly checks that a warning is issued (e.g. // CHECK-MESSAGES-DEFAULT: :[[@LINE-2]]:3: warning: prefer deleting) and when the LLVM_ENABLE_WERROR propagates to this piece, it will indeed fail the build. But I wonder why this doesn't happen to the other clang-tidy checks. @njames93 @Eugene.Zelenko any ideas?

Oct 26 2020, 2:06 AM · Restricted Project, Restricted Project

Sep 20 2020

kkleine added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

Hi @dblaikie . I did run ninja check-all and /bin/llvm-lit -av ../clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp on this very new revision (abd70fb3983f342bc1c90f9c70a7b59790ad5206) manually but I don't see this error coming up. Can you please try to test if you see the error on a fresh build?

Sep 20 2020, 10:18 PM · Restricted Project, Restricted Project
kkleine added a comment to D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro.

@dblaikie sorry for not getting to it for so long. I'm taking a look at the problem you've described now.

Sep 20 2020, 9:25 PM · Restricted Project, Restricted Project

May 9 2019

kkleine added a reviewer for D61737: [lldb] add -ex CLI option as alias to --one-line: JDevlieghere.
May 9 2019, 8:47 AM · Restricted Project

May 8 2019

kkleine added a comment to D61483: [www] list command: lldb run <args>.

@labath @jingham @teemperor I've updated the documentation in both, the new and the old places. Can you please merge this?

May 8 2019, 3:04 AM · Restricted Project

May 5 2019

kkleine updated the diff for D61483: [www] list command: lldb run <args>.
  • [www] move run <args> command down for educational purposes
  • Add documentation to docs/use/map.rst
May 5 2019, 11:34 PM · Restricted Project

May 3 2019

kkleine updated the diff for D61483: [www] list command: lldb run <args>.
  • [www] move run <args> command down for educational purposes
May 3 2019, 3:07 AM · Restricted Project
kkleine updated the diff for D61483: [www] list command: lldb run <args>.

Amend previous commit with copy paste error.

May 3 2019, 3:05 AM · Restricted Project
kkleine created D61483: [www] list command: lldb run <args>.
May 3 2019, 3:05 AM · Restricted Project
kkleine updated the diff for D61440: C.128 override, virtual keyword handling.
May 3 2019, 12:04 AM · Restricted Project, Restricted Project

May 2 2019

kkleine updated the diff for D61440: C.128 override, virtual keyword handling.
May 2 2019, 12:50 PM · Restricted Project, Restricted Project
kkleine updated the diff for D61440: C.128 override, virtual keyword handling.
May 2 2019, 12:31 PM · Restricted Project, Restricted Project
kkleine created D61440: C.128 override, virtual keyword handling.
May 2 2019, 6:32 AM · Restricted Project, Restricted Project

May 1 2019

kkleine created D61368: Fix build URL in new LLDB website.
May 1 2019, 12:58 AM · Restricted Project, Restricted Project

Apr 9 2019

kkleine added a reviewer for D60443: Fix doxygen warning about function argument: JDevlieghere.
Apr 9 2019, 1:43 AM · Restricted Project
kkleine updated the summary of D60442: Add missing space between \btrue.
Apr 9 2019, 1:43 AM · Restricted Project
kkleine created D60443: Fix doxygen warning about function argument.
Apr 9 2019, 1:43 AM · Restricted Project
kkleine retitled D60442: Add missing space between \btrue from Fix doxygen warnings for lldb-cpp-doc target to Add missing space between \btrue.
Apr 9 2019, 1:38 AM · Restricted Project
kkleine retitled D60442: Add missing space between \btrue from Add missing space between \btrue to Fix doxygen warnings for lldb-cpp-doc target.
Apr 9 2019, 1:35 AM · Restricted Project
kkleine updated the diff for D60442: Add missing space between \btrue.
  • Fix doxygen warning about function argument
Apr 9 2019, 1:32 AM · Restricted Project
kkleine added a comment to D60442: Add missing space between \btrue.

Please let me know if you don't have commit access (yet) and need someone to commit this for you.

Apr 9 2019, 1:24 AM · Restricted Project
kkleine updated the summary of D60442: Add missing space between \btrue.
Apr 9 2019, 12:55 AM · Restricted Project
kkleine updated the diff for D60442: Add missing space between \btrue.

Updated summary to reflect what doxygen error was addressed.

Apr 9 2019, 12:54 AM · Restricted Project
kkleine updated the summary of D60442: Add missing space between \btrue.
Apr 9 2019, 12:54 AM · Restricted Project
kkleine updated the summary of D60442: Add missing space between \btrue.
Apr 9 2019, 12:54 AM · Restricted Project
kkleine created D60442: Add missing space between \btrue.
Apr 9 2019, 12:48 AM · Restricted Project