This is an archive of the discontinued LLVM Phabricator instance.

Differential D101354

Remove unimplemented interfaces for Character[Min|Max][Val|Loc]. NFC
ClosedPublic

Authored by rovka on Apr 27 2021, 4:28 AM.

Details

Reviewers
klausler
tskeith
Commits
rGa58f362fb5dd: [flang] Remove interfaces for Character[Min|Max][Val|Loc]. NFC
Summary

MAXVAL, MINVAL, MAXLOC and MINLOC are already implemented in extrema.cpp
as MaxvalCharacter, MinvalDim etc. Therefore, the interfaces in
character.h are redundant and should be removed to avoid confusion.

Diff Detail

Event Timeline

rovka requested review of this revision.Apr 27 2021, 4:28 AM
rovka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 4:28 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B101129: Diff 340791.Apr 27 2021, 5:06 AM
klausler accepted this revision.Apr 27 2021, 9:55 AM
This revision is now accepted and ready to land.Apr 27 2021, 9:55 AM
Closed by commit rGa58f362fb5dd: [flang] Remove interfaces for Character[Min|Max][Val|Loc]. NFC (authored by rovka). · Explain WhyApr 28 2021, 12:58 AM
This revision was automatically updated to reflect the committed changes.
rovka added a commit: rGa58f362fb5dd: [flang] Remove interfaces for Character[Min|Max][Val|Loc]. NFC.
jhenderson added a child revision: D103156: [lit] Fix testing of standalone clang and lld builds.May 26 2021, 4:53 AM
teemperor mentioned this in D103156: [lit] Fix testing of standalone clang and lld builds.May 26 2021, 5:10 AM

Revision Contents

PathSize
flang/
runtime/
12 lines
3 lines

Diff 341090

flang/runtime/character.h

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Linesvoid RTNAME(Repeat)(Descriptor &result, const Descriptor &string,
std::size_t ncopies, const char *sourceFile = nullptr, int sourceLine = 0); std::size_t ncopies, const char *sourceFile = nullptr, int sourceLine = 0);
void RTNAME(Trim)(Descriptor &result, const Descriptor &string, void RTNAME(Trim)(Descriptor &result, const Descriptor &string,
const char *sourceFile = nullptr, int sourceLine = 0); const char *sourceFile = nullptr, int sourceLine = 0);
void RTNAME(CharacterMax)(Descriptor &accumulator, const Descriptor &x, void RTNAME(CharacterMax)(Descriptor &accumulator, const Descriptor &x,
const char *sourceFile = nullptr, int sourceLine = 0); const char *sourceFile = nullptr, int sourceLine = 0);
void RTNAME(CharacterMin)(Descriptor &accumulator, const Descriptor &x, void RTNAME(CharacterMin)(Descriptor &accumulator, const Descriptor &x,
const char *sourceFile = nullptr, int sourceLine = 0); const char *sourceFile = nullptr, int sourceLine = 0);
void RTNAME(CharacterMaxVal)(Descriptor &result, const Descriptor &x,
int dim = 0, const Descriptor *mask = nullptr,
const char *sourceFile = nullptr, int sourceLine = 0);
void RTNAME(CharacterMinVal)(Descriptor &result, const Descriptor &x,
int dim = 0, const Descriptor *mask = nullptr,
const char *sourceFile = nullptr, int sourceLine = 0);
void RTNAME(CharacterMaxLoc)(Descriptor &result, const Descriptor &x,
int dim = 0, const Descriptor *mask = nullptr, int kind = sizeof(int),
bool back = false, const char *sourceFile = nullptr, int sourceLine = 0);
void RTNAME(CharacterMinLoc)(Descriptor &result, const Descriptor &x,
int dim = 0, const Descriptor *mask = nullptr, int kind = sizeof(int),
bool back = false, const char *sourceFile = nullptr, int sourceLine = 0);
std::size_t RTNAME(Index1)(const char *, std::size_t, const char *substring, std::size_t RTNAME(Index1)(const char *, std::size_t, const char *substring,
std::size_t, bool back = false); std::size_t, bool back = false);
std::size_t RTNAME(Index2)(const char16_t *, std::size_t, std::size_t RTNAME(Index2)(const char16_t *, std::size_t,
const char16_t *substring, std::size_t, bool back = false); const char16_t *substring, std::size_t, bool back = false);
std::size_t RTNAME(Index4)(const char32_t *, std::size_t, std::size_t RTNAME(Index4)(const char32_t *, std::size_t,
const char32_t *substring, std::size_t, bool back = false); const char32_t *substring, std::size_t, bool back = false);
void RTNAME(Index)(Descriptor &result, const Descriptor &string, void RTNAME(Index)(Descriptor &result, const Descriptor &string,
Show All 25 Lines

flang/runtime/character.cpp

Show First 20 Lines • Show All 1,018 Lines • ▼ Show 20 Linesvoid RTNAME(CharacterMax)(Descriptor &accumulator, const Descriptor &x,
const char *sourceFile, int sourceLine) { const char *sourceFile, int sourceLine) {
MaxMin<false>(accumulator, x, sourceFile, sourceLine); MaxMin<false>(accumulator, x, sourceFile, sourceLine);
} }
void RTNAME(CharacterMin)(Descriptor &accumulator, const Descriptor &x, void RTNAME(CharacterMin)(Descriptor &accumulator, const Descriptor &x,
const char *sourceFile, int sourceLine) { const char *sourceFile, int sourceLine) {
MaxMin<true>(accumulator, x, sourceFile, sourceLine); MaxMin<true>(accumulator, x, sourceFile, sourceLine);
} }
// TODO: Character MAXVAL/MINVAL
// TODO: Character MAXLOC/MINLOC
} }
} // namespace Fortran::runtime } // namespace Fortran::runtime