Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td | ||
---|---|---|
698–711 | Side note: This much C++ code shouldn't have been put in a .td file. It's hard for a developer to also notice such errors via in-editor syntax checkers, code completion engines, etc. This op is full of long C++ code. git blame shows @pifon2a for all these lines. Do we have a policy here? @rriddle @mehdi_amini |
Side note: This much C++ code shouldn't have been put in a .td file. It's hard for a developer to also notice such errors via in-editor syntax checkers, code completion engines, etc. This op is full of long C++ code. git blame shows @pifon2a for all these lines. Do we have a policy here? @rriddle @mehdi_amini