Page MenuHomePhabricator

[mlir][linalg][nfc] Fix signed/unsigned comparison warning in header
ClosedPublic

Authored by Hardcode84 on May 22 2021, 5:11 AM.

Diff Detail

Event Timeline

Hardcode84 created this revision.May 22 2021, 5:11 AM
Hardcode84 requested review of this revision.May 22 2021, 5:11 AM
bondhugula accepted this revision.May 22 2021, 7:03 AM
This revision is now accepted and ready to land.May 22 2021, 7:03 AM
bondhugula added inline comments.
mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td
698–711

Side note: This much C++ code shouldn't have been put in a .td file. It's hard for a developer to also notice such errors via in-editor syntax checkers, code completion engines, etc. This op is full of long C++ code. git blame shows @pifon2a for all these lines. Do we have a policy here? @rriddle @mehdi_amini