Page MenuHomePhabricator

Hardcode84 (Ivan Butygin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2020, 2:39 AM (6 w, 3 d)

Recent Activity

Yesterday

Hardcode84 added a comment to D94769: [Support] Format provider improvements.

Why I am here? What's going on?

Fri, Jan 15, 8:03 AM · Restricted Project

Thu, Jan 7

Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

Ivan Butygin ivan.butygin@intel.com

Thu, Jan 7, 4:37 AM · Restricted Project
Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

Can someone merge this, please?

Thu, Jan 7, 1:19 AM · Restricted Project

Tue, Jan 5

Hardcode84 added inline comments to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.
Tue, Jan 5, 1:01 PM · Restricted Project
Hardcode84 updated the diff for D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.
Tue, Jan 5, 12:59 PM · Restricted Project

Wed, Dec 30

Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

Updated: make a custom printers which won't print fastmath flags if they are equal to the default value, to avoid changes in unrelated tests

Wed, Dec 30, 4:28 AM · Restricted Project
Hardcode84 updated the diff for D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.
Wed, Dec 30, 4:25 AM · Restricted Project
Hardcode84 added inline comments to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.
Wed, Dec 30, 4:17 AM · Restricted Project
Hardcode84 updated the diff for D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.
Wed, Dec 30, 4:06 AM · Restricted Project

Dec 16 2020

Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

I mean the only change I need is to have tblgen to generate

if (fmf != <default value>)
  odsState.addAttribute("fmf", ::mlir::LLVM::FMFAttr::get(fmf, odsBuilder.getContext()));

instead of unconditional

odsState.addAttribute("fmf", ::mlir::LLVM::FMFAttr::get(fmf, odsBuilder.getContext()));

in build methods for DefaultValuedAttr.
In that case IR with default flags should look like exactly as before without OptionalAttr.
Does it make sense?
Is it worth an RFC?

Dec 16 2020, 5:50 AM · Restricted Project
Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

let's make the attribute optional, so the absence thereof indicates there are no flags

Dec 16 2020, 3:27 AM · Restricted Project

Dec 15 2020

Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

Some more comments:

Dec 15 2020, 10:09 AM · Restricted Project
Hardcode84 updated the diff for D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

Updated. Went with custom attribute approach as there aren't any good decision how to handle build methods with bunch of unit attrs.

Dec 15 2020, 10:01 AM · Restricted Project

Dec 2 2020

Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

Thanks for the patch. I would recommend sending an RFC to https://llvm.discourse.group/ to discuss the proposed design. Personally, I would expect us to have something like a set of unit attributes with appropriate names as opposed to array-of-str-enum. It is not clear if we want a trait or an interface for this purpose (note that you cannot dyn_cast to a trait class, and unit attribute accessors are generated automatically).

Dec 2 2020, 11:09 AM · Restricted Project
Hardcode84 added a comment to D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.

tests TBD

Dec 2 2020, 7:25 AM · Restricted Project
Hardcode84 requested review of D92485: [mlir] Add fastmath flags support to some LLVM dialect ops.
Dec 2 2020, 7:24 AM · Restricted Project