- User Since
- Dec 2 2020, 2:39 AM (6 w, 3 d)
Why I am here? What's going on?
Thu, Jan 7
Ivan Butygin firstname.lastname@example.org
Can someone merge this, please?
Tue, Jan 5
Wed, Dec 30
Updated: make a custom printers which won't print fastmath flags if they are equal to the default value, to avoid changes in unrelated tests
Dec 16 2020
I mean the only change I need is to have tblgen to generate
if (fmf != <default value>) odsState.addAttribute("fmf", ::mlir::LLVM::FMFAttr::get(fmf, odsBuilder.getContext()));
instead of unconditional
odsState.addAttribute("fmf", ::mlir::LLVM::FMFAttr::get(fmf, odsBuilder.getContext()));
in build methods for DefaultValuedAttr.
In that case IR with default flags should look like exactly as before without OptionalAttr.
Does it make sense?
Is it worth an RFC?
let's make the attribute optional, so the absence thereof indicates there are no flags
Dec 15 2020
Some more comments:
Updated. Went with custom attribute approach as there aren't any good decision how to handle build methods with bunch of unit attrs.
Dec 2 2020