Page MenuHomePhabricator

Hardcode84 (Ivan Butygin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2020, 2:39 AM (28 w, 5 d)

Recent Activity

Fri, Jun 18

Hardcode84 added a comment to D104289: First crack at foor loop range folding pass..

Is there any reason to make this separate pass instead of ForOp canonicalization? Also, diff looks incomplete

Fri, Jun 18, 8:19 AM · Restricted Project
Hardcode84 added a comment to D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

someone?

Fri, Jun 18, 6:34 AM · Restricted Project

Tue, Jun 15

Hardcode84 added a comment to D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

Not sure who is the right person to review this

Tue, Jun 15, 5:17 PM · Restricted Project
Hardcode84 added a reviewer for D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst.: mehdi_amini.
Tue, Jun 15, 5:16 PM · Restricted Project
Hardcode84 updated the diff for D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

Do not use getOperand

Tue, Jun 15, 5:14 PM · Restricted Project

Mon, Jun 14

Hardcode84 updated the diff for D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

newline

Mon, Jun 14, 12:47 PM · Restricted Project
Hardcode84 requested review of D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..
Mon, Jun 14, 12:44 PM · Restricted Project

Sun, May 30

Hardcode84 committed rGbb542f2a76d4: [mlir] StandardToLLVM: option to disable AllocOp lowering (authored by Hardcode84).
[mlir] StandardToLLVM: option to disable AllocOp lowering
Sun, May 30, 7:58 AM
Hardcode84 closed D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.
Sun, May 30, 7:58 AM · Restricted Project
Hardcode84 updated the diff for D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.

rebase, rerun tests

Sun, May 30, 6:58 AM · Restricted Project

Thu, May 27

Hardcode84 updated the diff for D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.

review comments

Thu, May 27, 8:35 AM · Restricted Project
Hardcode84 requested review of D103237: [mlir] StandardToLLVM: option to disable AllocOp lowering.
Thu, May 27, 3:52 AM · Restricted Project

Wed, May 26

Hardcode84 committed rG91e0cb6598f4: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot… (authored by Hardcode84).
[mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot…
Wed, May 26, 2:07 AM
Hardcode84 closed D102557: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot determine better.
Wed, May 26, 2:07 AM · Restricted Project

May 22 2021

Hardcode84 committed rG0dd36f81b9f8: [mlir][linalg][nfc] Fix signed/unsigned comparison warning in header (authored by Hardcode84).
[mlir][linalg][nfc] Fix signed/unsigned comparison warning in header
May 22 2021, 7:24 AM
Hardcode84 closed D102968: [mlir][linalg][nfc] Fix signed/unsigned comparison warning in header.
May 22 2021, 7:24 AM · Restricted Project
Hardcode84 requested review of D102968: [mlir][linalg][nfc] Fix signed/unsigned comparison warning in header.
May 22 2021, 5:11 AM · Restricted Project
Hardcode84 committed rG4184018253e7: [mlir][SCF] Canonicalize nested ParallelOp's (authored by Hardcode84).
[mlir][SCF] Canonicalize nested ParallelOp's
May 22 2021, 4:01 AM
Hardcode84 closed D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 22 2021, 4:00 AM · Restricted Project
Hardcode84 committed rG9afbca746b6c: [mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public (authored by Hardcode84).
[mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public
May 22 2021, 2:58 AM
Hardcode84 closed D102932: [mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public.
May 22 2021, 2:58 AM · Restricted Project

May 21 2021

Hardcode84 requested review of D102932: [mlir] ConvertStandardToLLVM: make AllocLikeOpLowering public.
May 21 2021, 9:25 AM · Restricted Project

May 20 2021

Hardcode84 updated the diff for D102799: [mlir][SCF] Canonicalize nested ParallelOps's.

check outer iter vars not used as bounds/steps for inner loop

May 20 2021, 11:26 AM · Restricted Project
Hardcode84 added a comment to D102799: [mlir][SCF] Canonicalize nested ParallelOps's.

Anyway, there is another issue, I should also add check that outer block iter vars not being used as inner loop bounds/steps

May 20 2021, 8:49 AM · Restricted Project
Hardcode84 added inline comments to D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 20 2021, 8:45 AM · Restricted Project
Hardcode84 added inline comments to D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 20 2021, 8:35 AM · Restricted Project

May 19 2021

Hardcode84 requested review of D102799: [mlir][SCF] Canonicalize nested ParallelOps's.
May 19 2021, 12:10 PM · Restricted Project

May 15 2021

Hardcode84 added a reviewer for D102557: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot determine better: rriddle.
May 15 2021, 10:41 AM · Restricted Project
Hardcode84 requested review of D102557: [mlir] LocalAliasAnalysis: Assume allocation scope to function scope if cannot determine better.
May 15 2021, 10:40 AM · Restricted Project

May 8 2021

Hardcode84 committed rGe2a77644817f: [mlir] Debug print pattern before and after matchAndRewrite call (authored by Hardcode84).
[mlir] Debug print pattern before and after matchAndRewrite call
May 8 2021, 3:14 AM
Hardcode84 closed D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
May 8 2021, 3:13 AM · Restricted Project

May 7 2021

Hardcode84 updated the diff for D101443: [mlir] Debug print pattern before and after matchAndRewrite call.

review comments

May 7 2021, 3:13 AM · Restricted Project

May 6 2021

Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
May 6 2021, 11:32 AM · Restricted Project
Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
May 6 2021, 4:09 AM · Restricted Project
Hardcode84 updated the diff for D101443: [mlir] Debug print pattern before and after matchAndRewrite call.

Renamed to setDebugName, moved to public, FnPattern handling

May 6 2021, 4:08 AM · Restricted Project

Apr 29 2021

Hardcode84 added a comment to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.

Actually, maybe just rename those methods to get/setDebugName() or setPrettyName(), make them public and say explicitly in doc that it should be used only for debugging purposes? So 'proper' pattern name or tags can be added later separately if needed.

Apr 29 2021, 2:41 PM · Restricted Project

Apr 28 2021

Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
Apr 28 2021, 11:01 AM · Restricted Project
Hardcode84 added inline comments to D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
Apr 28 2021, 10:31 AM · Restricted Project
Hardcode84 requested review of D101443: [mlir] Debug print pattern before and after matchAndRewrite call.
Apr 28 2021, 5:06 AM · Restricted Project

Apr 26 2021

Hardcode84 updated the diff for D101253: Intel SVML calling conventions.

clang-format

Apr 26 2021, 4:47 AM · Restricted Project

Apr 25 2021

Hardcode84 requested review of D101253: Intel SVML calling conventions.
Apr 25 2021, 6:53 AM · Restricted Project

Apr 23 2021

Hardcode84 committed rGf22d3813850f: [mlir] Canonicalize AllocOp's with only store and dealloc uses (authored by Hardcode84).
[mlir] Canonicalize AllocOp's with only store and dealloc uses
Apr 23 2021, 11:55 PM
Hardcode84 closed D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.
Apr 23 2021, 11:55 PM · Restricted Project
Hardcode84 updated the diff for D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

rebase, rewiew comments

Apr 23 2021, 3:49 PM · Restricted Project
Hardcode84 abandoned D101040: [mlir] Template helper for analyses with dependencies.
Apr 23 2021, 11:36 AM · Restricted Project
Hardcode84 added a comment to D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

ping

Apr 23 2021, 2:31 AM · Restricted Project

Apr 22 2021

Hardcode84 updated the diff for D101040: [mlir] Template helper for analyses with dependencies.

FIx copypaste in license header

Apr 22 2021, 3:01 AM · Restricted Project
Hardcode84 requested review of D101040: [mlir] Template helper for analyses with dependencies.
Apr 22 2021, 2:54 AM · Restricted Project

Apr 21 2021

Hardcode84 committed rG85740ee108f1: [mlir] Assume terminators in nested regions are always legal in… (authored by Hardcode84).
[mlir] Assume terminators in nested regions are always legal in…
Apr 21 2021, 1:56 AM
Hardcode84 closed D100832: [mlir] Assume terminators in nested regions are always legal in FuncBufferizePass.
Apr 21 2021, 1:56 AM · Restricted Project

Apr 20 2021

Hardcode84 committed rGcd94f18ec1ba: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can… (authored by Hardcode84).
[mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can…
Apr 20 2021, 9:19 AM
Hardcode84 closed D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.
Apr 20 2021, 9:19 AM · Restricted Project
Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

update docs

Apr 20 2021, 4:37 AM · Restricted Project
Hardcode84 added a reviewer for D100832: [mlir] Assume terminators in nested regions are always legal in FuncBufferizePass: silvas.
Apr 20 2021, 2:29 AM · Restricted Project
Hardcode84 requested review of D100832: [mlir] Assume terminators in nested regions are always legal in FuncBufferizePass.
Apr 20 2021, 2:27 AM · Restricted Project

Apr 16 2021

Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

fix code in docs

Apr 16 2021, 12:42 PM · Restricted Project
Hardcode84 updated the summary of D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.
Apr 16 2021, 12:40 PM · Restricted Project
Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

review comments, docs

Apr 16 2021, 12:39 PM · Restricted Project
Hardcode84 added a comment to D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

https://mlir.llvm.org/docs/PassManagement/#analysis-management
Docs probably also need to be updated and I will need some help with that. Should it go to separate review?

Apr 16 2021, 10:52 AM · Restricted Project
Hardcode84 added a comment to D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

@bondhugula ping

Apr 16 2021, 3:18 AM · Restricted Project

Apr 14 2021

Hardcode84 added inline comments to D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.
Apr 14 2021, 3:51 PM · Restricted Project
Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

MapVector, comments

Apr 14 2021, 3:47 PM · Restricted Project

Apr 13 2021

Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

Properly handle analysis dependency chains

Apr 13 2021, 2:55 PM · Restricted Project
Hardcode84 committed rGeb3154006673: [mlir] Canonicalize single-iteration ParallelOp (authored by Hardcode84).
[mlir] Canonicalize single-iteration ParallelOp
Apr 13 2021, 3:43 AM
Hardcode84 closed D100248: [mlir] Canonicalize single-iteration ParallelOp.
Apr 13 2021, 3:43 AM · Restricted Project
Hardcode84 added a comment to D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

You'll also need to make sure that when an analysis is invalidated that all of the things that depend on it check to see if they also need to be invalidated. I would take a look at the Analysis Manager in LLVM as an inspiration for inter-analysis dependencies.

Apr 13 2021, 2:07 AM · Restricted Project

Apr 12 2021

Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

Templates fix

Apr 12 2021, 12:30 PM · Restricted Project
Hardcode84 added inline comments to D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.
Apr 12 2021, 9:16 AM · Restricted Project

Apr 11 2021

Hardcode84 updated the diff for D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.

fix getAnalysis

Apr 11 2021, 3:53 PM · Restricted Project
Hardcode84 requested review of D100274: [mlir] Pass AnalysisManager as optional parameter to analysis ctor, so it can request any other analysis as dependency.
Apr 11 2021, 2:25 PM · Restricted Project
Hardcode84 updated the diff for D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

review comments

Apr 11 2021, 10:54 AM · Restricted Project
Hardcode84 updated the diff for D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.

clang-format

Apr 11 2021, 9:49 AM · Restricted Project
Hardcode84 requested review of D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.
Apr 11 2021, 8:59 AM · Restricted Project
Hardcode84 updated the diff for D100248: [mlir] Canonicalize single-iteration ParallelOp.

Apply review comment

Apr 11 2021, 4:50 AM · Restricted Project

Apr 10 2021

Hardcode84 requested review of D100248: [mlir] Canonicalize single-iteration ParallelOp.
Apr 10 2021, 9:51 AM · Restricted Project

Apr 4 2021

Hardcode84 committed rG6e96de8abf27: [mlir][NFC] Fully spell mlir types names in LoopLikeOpInterface, so it can be… (authored by Hardcode84).
[mlir][NFC] Fully spell mlir types names in LoopLikeOpInterface, so it can be…
Apr 4 2021, 2:26 AM
Hardcode84 closed D99844: [mlir][NFC] Fully spell mlir types names in LoopLikeOpInterface, so it can be used in ops defined outside mlir namespace.
Apr 4 2021, 2:26 AM · Restricted Project

Apr 3 2021

Hardcode84 requested review of D99844: [mlir][NFC] Fully spell mlir types names in LoopLikeOpInterface, so it can be used in ops defined outside mlir namespace.
Apr 3 2021, 12:09 PM · Restricted Project

Mar 20 2021

Hardcode84 committed rG7219b31d40f1: [mlir] Additional folding for SelectOp (authored by Hardcode84).
[mlir] Additional folding for SelectOp
Mar 20 2021, 3:42 AM
Hardcode84 closed D98576: [mlir] Additional folding for SelectOp.
Mar 20 2021, 3:42 AM · Restricted Project
Hardcode84 committed rG5657f93e788f: [mlir] Canonicalize IfOp with trivial `then` and `else` bodies to list of… (authored by Hardcode84).
[mlir] Canonicalize IfOp with trivial `then` and `else` bodies to list of…
Mar 20 2021, 2:20 AM
Hardcode84 closed D98592: [mlir] Canonicalize IfOp with trivial `then` and `else` bodies to list of SelectOp's.
Mar 20 2021, 2:19 AM · Restricted Project

Mar 19 2021

Hardcode84 added a comment to D98576: [mlir] Additional folding for SelectOp.

Will merge tomorrow

Mar 19 2021, 4:51 PM · Restricted Project
Hardcode84 committed rGa531bbd9adfc: [MLIR] Test pattern benefit sorting between operation specific and operation… (authored by Hardcode84).
[MLIR] Test pattern benefit sorting between operation specific and operation…
Mar 19 2021, 1:14 PM
Hardcode84 closed D98513: [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns..
Mar 19 2021, 1:14 PM · Restricted Project

Mar 18 2021

Hardcode84 updated the diff for D98592: [mlir] Canonicalize IfOp with trivial `then` and `else` bodies to list of SelectOp's.

Rebase

Mar 18 2021, 6:46 AM · Restricted Project
Hardcode84 updated the diff for D98576: [mlir] Additional folding for SelectOp.

Rebase

Mar 18 2021, 5:10 AM · Restricted Project
Hardcode84 updated the diff for D98513: [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns..

It seems this was already fixed upstream, only test remained

Mar 18 2021, 3:34 AM · Restricted Project

Mar 17 2021

Hardcode84 added a comment to D98513: [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns..

I don't have commit access, can you please merge this

Mar 17 2021, 4:07 PM · Restricted Project
Hardcode84 updated the diff for D98513: [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns..

Added comment to test

Mar 17 2021, 4:04 PM · Restricted Project
Hardcode84 updated the diff for D98513: [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns..

Use PatternApplicator directly instead of applyPatternsAndFoldGreedely

Mar 17 2021, 4:52 AM · Restricted Project

Mar 14 2021

Hardcode84 added inline comments to D98592: [mlir] Canonicalize IfOp with trivial `then` and `else` bodies to list of SelectOp's.
Mar 14 2021, 1:46 AM · Restricted Project
Hardcode84 updated the diff for D98592: [mlir] Canonicalize IfOp with trivial `then` and `else` bodies to list of SelectOp's.

Review comments, more tests, added some asserts

Mar 14 2021, 1:43 AM · Restricted Project

Mar 13 2021

Hardcode84 requested review of D98592: [mlir] Canonicalize IfOp with trivial `then` and `else` bodies to list of SelectOp's.
Mar 13 2021, 3:27 PM · Restricted Project
Hardcode84 added a comment to D98576: [mlir] Additional folding for SelectOp.

@mehdi_amini I don't have commit access, if you ok with this patch can you please merge it

Mar 13 2021, 2:13 PM · Restricted Project
Hardcode84 updated the diff for D98576: [mlir] Additional folding for SelectOp.

Added example

Mar 13 2021, 12:45 PM · Restricted Project
Hardcode84 requested review of D98576: [mlir] Additional folding for SelectOp.
Mar 13 2021, 3:08 AM · Restricted Project

Mar 12 2021

Hardcode84 retitled D98513: [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns. from Fix pattern benefit sorting between operation specific and operation agnostic patterns. to [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns..
Mar 12 2021, 8:12 AM · Restricted Project
Hardcode84 requested review of D98513: [MLIR] Fix pattern benefit sorting between operation specific and operation agnostic patterns..
Mar 12 2021, 8:11 AM · Restricted Project

Jan 15 2021

Hardcode84 added a comment to D94769: [Support] Format provider improvements.

Why I am here? What's going on?

Jan 15 2021, 8:03 AM · Restricted Project