This is an archive of the discontinued LLVM Phabricator instance.

[docs] Collate CMake options
ClosedPublic

Authored by urnathan on May 14 2021, 4:47 AM.

Details

Summary

I found the documentation of the various CMake variables difficult to navigate, because they are unsorted. I can see they've grown organically with new clusters of somewhat-related options, but the result is hard to use. This collates them (treating '_' as space).

Diff Detail

Event Timeline

urnathan created this revision.May 14 2021, 4:47 AM
urnathan requested review of this revision.May 14 2021, 4:47 AM
Herald added a project: Restricted Project. · View Herald Transcript

Thank you for rearranging this, I think using an alphabetical ordering for most of the cases makes a ton of sense.

FWIW, I also agree the most frequently used options should include: LLVM_TARGETS_TO_BUILD, LLVM_PARALLEL_COMPILE_JOBS, LLVM_PARALLEL_LINK_JOBS, LLVM_ENABLE_PROJECTS, and perhaps LLVM_USE_LINKER as well. I'm sure we can bikeshed on what the most commonly used options are, but those seem like they are ones that most impact anyone getting started with the project.

urnathan edited the summary of this revision. (Show Details)Jun 7 2021, 5:11 AM
urnathan edited reviewers, added: void, tstellar, delcypher; removed: jdoerfert, chandlerc.

Thanks for looking at this. Ordering the CMake options makes a lot of sense. You probably should clean up the commit description to only be about the change you're making here and handle "Frequently used options" to a separate patch. Other than that LGTM.

urnathan edited the summary of this revision. (Show Details)Jun 9 2021, 11:24 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2021, 11:25 AM
This revision was automatically updated to reflect the committed changes.