[flang] Enable export of FIR includes into the install tree

[Renaud-K]

Summary

This makes it possible to build out-of-tree just pointing to an install tree.
It is consistent with MLIR.

Essentially it installs
./include/flang/Optimizer/CodeGen/CGOps.h.inc
./include/flang/Optimizer/CodeGen/CGPasses.h.inc
./include/flang/Optimizer/Dialect/FIROps.h.inc
./include/flang/Optimizer/Dialect/FIROpsTypes.h.inc
./include/flang/Optimizer/Transforms/Passes.h.inc

side-by-side with their .h counterparts which have a dependency with them.

[PeteSteinfeld]

@Renaud-K, I'm not sure what the use-case is that this fixes. Can you please describe it in more detail, and I'll try a build with that exact use case to verify that this fixes it.

[PeteSteinfeld]

I have tested full shared and non-shared builds with this change, and both look good.

[Renaud-K]

A use-case would be an out-of-tree build with a Jenkins build for instance, which only keep the install tree around. MLIR enables this already.

[awarzynski]

@Renaud-K I'm guessing that this change is required to make sure that Flang header files are installed alongside other install components, right?

• Are these any specific headers?
• In what way is this change FIR specific?

[Renaud-K]

My apologies. I should have blown away my build tree prior to testing this, otherwise cmake still somehow finds its way to the *.h.inc files

This change is more straightforward. It simply installs:
./include/flang/Optimizer/CodeGen/CGOps.h.inc
./include/flang/Optimizer/CodeGen/CGPasses.h.inc
./include/flang/Optimizer/Dialect/FIROps.h.inc
./include/flang/Optimizer/Dialect/FIROpsTypes.h.inc
./include/flang/Optimizer/Transforms/Passes.h.inc

side-by-side with their .h counterparts which have a dependency with them.

[awarzynski]

This makes it possible to build out-of-tree

Do you mean out-of-tree as in here: https://github.com/llvm/llvm-project/tree/main/flang#building-flang-out-of-tree ? I'm not familiar with this part of CMake, so I'm just trying to better understand the rationale. I see that this is similar to what is happening in MLIR, so in this sense it makes sense.

[Renaud-K]

The link is about building flang with an external build/install of LLVM/MLIR.

This change is about building code with an external build/install of flang. This is helpful for small projects, out of the fir-dev tree, to quickly build and test against different versions of fir-dev.
The difference is building 10 files versus 3000.
I shall confess that this is more of an internal need because our Jenkins builds only leave install trees around. But thought this would be a change worth and acceptable to upstream because MLIR does something similar.

[awarzynski]

In D102040#2748571, @Renaud-K wrote:

The link is about building flang with an external build/install of LLVM/MLIR.

This change is about building code with an external build/install of flang. This is helpful for small projects, out of the fir-dev tree, to quickly build and test against different versions of fir-dev.
The difference is building 10 files versus 3000.
I shall confess that this is more of an internal need because our Jenkins builds only leave install trees around. But thought this would be a change worth and acceptable to upstream because MLIR does something similar.

Thank you for clarifying. You may want to be a bit more specific in the summary/commit message. Clearly out-of-tree is a bit ambiguous in the context of Flang :)

@PeteSteinfeld has already approved and to me this also makes sense (though I'm rather unfamiliar with this area). Please go ahead and merge.

flang/CMakeLists.txt

else()
   set(MLIR_MAIN_SRC_DIR ${LLVM_MAIN_SRC_DIR}/../mlir/include ) # --src-root
   set(MLIR_INCLUDE_DIR ${LLVM_MAIN_SRC_DIR}/../mlir/include ) # --includedir
   set(MLIR_TABLEGEN_OUTPUT_DIR ${CMAKE_BINARY_DIR}/tools/mlir/include)
   set(MLIR_TABLEGEN_EXE $<TARGET_FILE:mlir-tblgen>)
   include_directories(SYSTEM ${MLIR_INCLUDE_DIR})
   include_directories(SYSTEM ${MLIR_TABLEGEN_OUTPUT_DIR})
 endif()
 set(FLANG_INTRINSIC_MODULES_DIR ${CMAKE_BINARY_DIR}/include/flang)
+set(FLANG_INCLUDE_DIR ${FLANG_BINARY_DIR}/include)
 
 if(FLANG_BUILD_NEW_DRIVER)
     # TODO: Remove when libclangDriver is lifted out of Clang
     if(FLANG_STANDALONE_BUILD)
       set(CLANG_INCLUDE_DIR ${CLANG_INCLUDE_DIRS} )
       # No need to specify TableGen output dir as that's embedded in CLANG_DIR
     else()
       set(CLANG_INCLUDE_DIR ${LLVM_MAIN_SRC_DIR}/../clang/include )
install(DIRECTORY include/flang
     FILES_MATCHING
     PATTERN "*.def"
     PATTERN "*.h"
     PATTERN "*.inc"
     PATTERN "*.td"
     PATTERN "config.h" EXCLUDE
     PATTERN ".git"     EXCLUDE
     PATTERN "CMakeFiles" EXCLUDE)
+    
+  install(DIRECTORY ${FLANG_INCLUDE_DIR}/flang
+    DESTINATION include
+    COMPONENT flang-headers
+    FILES_MATCHING
+    PATTERN "*.inc"
+    )
 endif()