Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D101946

GlobalISel: Move AArch64 AssignFnVarArg to base class
ClosedPublic
Actions

Authored by arsenm on May 5 2021, 2:17 PM.

Details

Reviewers

paquette
aemerson
aditya_nandakumar
dsanders
cdevadas

Summary

We can handle the distinction easily enough in the generic code, and
this makes it easier to abstract the selection of type/location from
the code to insert code.

Diff Detail

Event Timeline

arsenm created this revision.May 5 2021, 2:17 PM

Herald added subscribers: danielkiss, hiraditya, kristof.beyls, rovka. · View Herald TranscriptMay 5 2021, 2:17 PM

arsenm requested review of this revision.May 5 2021, 2:17 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2021, 2:17 PM

Herald added a subscriber: wdng. · View Herald Transcript

Harbormaster completed remote builds in B102848: Diff 343190.May 5 2021, 2:18 PM

arsenm added a child revision: D101947: GlobalISel: Split ValueHandler into assignment and emission classes.May 7 2021, 10:12 AM

aemerson accepted this revision.May 7 2021, 4:52 PM

This revision is now accepted and ready to land.May 7 2021, 4:52 PM

2bdfcf0cac148ada8d3ec36f551c45efb604ac49

Revision Contents
Changeset List

Path

Size

llvm/

include/

llvm/

CodeGen/

GlobalISel/

CallLowering.h

39 lines

lib/

Target/

AArch64/

GISel/

AArch64CallLowering.cpp

10 lines

Diff 343190

View Options

llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h