[MLIR] Rename free function `verify` on OffsetSizeAndStrideOpInterface

[bondhugula]

Summary

Using a free function verify(<Op>) is error prone. Rename it.

[bondhugula]

@bollu Looks like you have a rule to add yourself as a reviewer on every MLIR revision. Was this intended?

[ftynse]

In D101886#2738166, @bondhugula wrote:

@bollu Looks like you have a rule to add yourself as a reviewer on every MLIR revision. Was this intended?

They have a rule to add themselves as a reviewer on _your_ revisions, and those of some other people - https://reviews.llvm.org/H267.

[rriddle]

mlir/include/mlir/Interfaces/ViewLikeInterface.h

32–35

Could we also move this to the detail namespace?

[bondhugula]

Move to detail namespace

mlir/include/mlir/Interfaces/ViewLikeInterface.h

 /// manipulate.
 struct Range {
   Value offset;
   Value size;
   Value stride;
 };
 
 class OffsetSizeAndStrideOpInterface;
-LogicalResult verify(OffsetSizeAndStrideOpInterface op);
+
+namespace detail {
+LogicalResult verifyOffsetSizeAndStrideOp(OffsetSizeAndStrideOpInterface op);
+} // namespace detail
 } // namespace mlir
 
 /// Include the generated interface declarations.
 #include "mlir/Interfaces/ViewLikeInterface.h.inc"
 
 namespace mlir {
 
 /// Printer hook for custom directive in assemblyFormat.

mlir/include/mlir/Interfaces/ViewLikeInterface.td

static ::llvm::ArrayRef<::llvm::StringRef> getSpecialAttrNames() {
         ::mlir::OffsetSizeAndStrideOpInterface::getStaticSizesAttrName(),
         ::mlir::OffsetSizeAndStrideOpInterface::getStaticStridesAttrName(),
         ::mlir::OpTrait::AttrSizedOperandSegments<void>::getOperandSegmentSizeAttr()};
       return names;
    }
   }];
 
   let verify = [{
-    return ::mlir::verify(::mlir::cast<::mlir::OffsetSizeAndStrideOpInterface>($_op));
+    return ::mlir::detail::verifyOffsetSizeAndStrideOp(
+        ::mlir::cast<::mlir::OffsetSizeAndStrideOpInterface>($_op));
   }];
 }
 
 #endif // MLIR_INTERFACES_VIEWLIKEINTERFACE

mlir/lib/Interfaces/ViewLikeInterface.cpp

unsigned expectedNumDynamicEntries =
         return isDynamic(attr.cast<IntegerAttr>().getInt());
       });
   if (values.size() != expectedNumDynamicEntries)
     return op->emitError("expected ")
            << expectedNumDynamicEntries << " dynamic " << name << " values";
   return success();
 }
 
-LogicalResult mlir::verify(OffsetSizeAndStrideOpInterface op) {
+LogicalResult
+mlir::detail::verifyOffsetSizeAndStrideOp(OffsetSizeAndStrideOpInterface op) {
   std::array<unsigned, 3> maxRanks = op.getArrayAttrMaxRanks();
   // Offsets can come in 2 flavors:
   //   1. Either single entry (when maxRanks == 1).
   //   2. Or as an array whose rank must match that of the mixed sizes.
   // So that the result type is well-formed.
   if (!(op.getMixedOffsets().size() == 1 && maxRanks[0] == 1) &&
       op.getMixedOffsets().size() != op.getMixedSizes().size())
     return op->emitError(