Page MenuHomePhabricator


Authored by Quuxplusone on Sun, Apr 18, 6:51 PM.



This was raised in D94511.
@ldionne, could this renaming cause any issues for users? Do users ever define _LIBCPP_NO_HAS_CHAR8_T? and if so, do we care about breaking them (more than we care about long-term consistency of naming)?

Diff Detail

Event Timeline

Quuxplusone created this revision.Sun, Apr 18, 6:51 PM
Quuxplusone requested review of this revision.Sun, Apr 18, 6:51 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Apr 18, 6:51 PM
ldionne accepted this revision.Mon, Apr 19, 5:51 AM

This won't cause any issue for users, they are not supposed to define that macro. Only macros that we explicitly say they can define should be defined, otherwise our API surface is way too high to make any change.

This has seemed mis-named to me for a while, thanks for doing this.

This revision is now accepted and ready to land.Mon, Apr 19, 5:51 AM