Page MenuHomePhabricator

kamleshbhalui (kamlesh kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2018, 2:05 AM (137 w, 14 h)

Recent Activity

Sun, Aug 30

kamleshbhalui committed rGdeb99610ab00: Improve doc comments for several methods returning bools (authored by kamleshbhalui).
Improve doc comments for several methods returning bools
Sun, Aug 30, 1:04 AM
kamleshbhalui closed D86848: [MLIR] Improving the Comment .
Sun, Aug 30, 1:03 AM · Unknown Object (Project)

Sat, Aug 29

kamleshbhalui requested review of D86848: [MLIR] Improving the Comment .
Sat, Aug 29, 10:51 PM · Unknown Object (Project)

Jul 31 2020

kamleshbhalui accepted D85002: [RISCV] eliminate the repetition declare of SDLoc DL.

LGTM!

Jul 31 2020, 12:53 AM · Restricted Project

Jul 30 2020

kamleshbhalui updated the diff for D81391: [RISC-V] Do not crash when using -ftrapping-math.

rebased with the master.

Jul 30 2020, 2:28 AM · Restricted Project

Jul 26 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @mhorne comments.

Jul 26 2020, 11:14 PM · Unknown Object (Project), Restricted Project

Jul 23 2020

kamleshbhalui added a comment to D81391: [RISC-V] Do not crash when using -ftrapping-math.

@asb and @luismarques do you suggest anything here ?

Jul 23 2020, 2:14 AM · Restricted Project
kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

ping?

Jul 23 2020, 2:04 AM · Unknown Object (Project), Restricted Project

Jun 29 2020

kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

ping?

Jun 29 2020, 3:12 AM · Unknown Object (Project), Restricted Project

Jun 24 2020

kamleshbhalui added inline comments to D82446: [clang] Fix duplicate warning.
Jun 24 2020, 6:59 AM · Restricted Project
kamleshbhalui created D82446: [clang] Fix duplicate warning.
Jun 24 2020, 3:44 AM · Restricted Project

Jun 22 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @mhorne and @MaskRay concerns.

Jun 22 2020, 9:07 AM · Unknown Object (Project), Restricted Project

Jun 19 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

rebased and cleaned up the diff.

Jun 19 2020, 9:44 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added a comment to D82171: [libc++] Require concepts support for <numbers>.

D77505 broke a bunch of bots. This fixes the regression.

I lack commit privileges. Please land as "Raul Tambre <raul@tambre.ee>"

Jun 19 2020, 6:59 AM · Unknown Object (Project)
kamleshbhalui committed rG4f6c4b473c4a: [libc++] Implement <numbers> (authored by tambre).
[libc++] Implement <numbers>
Jun 19 2020, 2:07 AM
kamleshbhalui closed D77505: [libc++] Implement <numbers>.
Jun 19 2020, 2:07 AM · Unknown Object (Project)
kamleshbhalui added a comment to D77505: [libc++] Implement <numbers>.

Please commit this for me in case no one else has objections. I lack commit privileges.

Jun 19 2020, 12:29 AM · Unknown Object (Project)

Jun 18 2020

kamleshbhalui committed rG7622ea5835f0: [RISCV64] Emit correct lib call for fp(float/double) to ui/si (authored by kamleshbhalui).
[RISCV64] Emit correct lib call for fp(float/double) to ui/si
Jun 18 2020, 7:35 AM
kamleshbhalui closed D80526: [RISCV64] emit correct lib call for fp(double) to ui/si.
Jun 18 2020, 7:35 AM · Restricted Project
kamleshbhalui added a reviewer for D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__: MaskRay.
Jun 18 2020, 2:41 AM · Restricted Project, Restricted Project

Jun 17 2020

kamleshbhalui updated the summary of D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui updated the summary of D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui created D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui updated the summary of D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui added a reviewer for D80526: [RISCV64] emit correct lib call for fp(double) to ui/si: efriedma.
Jun 17 2020, 7:31 AM · Restricted Project
kamleshbhalui updated the diff for D80526: [RISCV64] emit correct lib call for fp(double) to ui/si.

Addressed @efriedma comments.
added test for strictfp.

Jun 17 2020, 7:31 AM · Restricted Project

Jun 16 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

thanks @mhorne for reviewing.
addressed your comments.

Jun 16 2020, 6:38 PM · Unknown Object (Project), Restricted Project
kamleshbhalui added a reviewer for D81391: [RISC-V] Do not crash when using -ftrapping-math: lenary.
Jun 16 2020, 4:58 AM · Restricted Project
kamleshbhalui added inline comments to D81391: [RISC-V] Do not crash when using -ftrapping-math.
Jun 16 2020, 4:58 AM · Restricted Project

Jun 15 2020

kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

ping?

Jun 15 2020, 6:46 PM · Unknown Object (Project), Restricted Project
kamleshbhalui added a comment to D81391: [RISC-V] Do not crash when using -ftrapping-math.

ping?

Jun 15 2020, 6:46 PM · Restricted Project

Jun 14 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

Rebased

Jun 14 2020, 12:29 AM · Unknown Object (Project), Restricted Project

Jun 13 2020

kamleshbhalui updated the summary of D80690: [RISCV] Support libunwind for riscv32.
Jun 13 2020, 1:02 AM · Unknown Object (Project), Restricted Project

Jun 12 2020

kamleshbhalui added inline comments to D80690: [RISCV] Support libunwind for riscv32.
Jun 12 2020, 10:52 AM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @luismarques concerns.
This patch extends soft float case .

Jun 12 2020, 10:19 AM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the diff for D81391: [RISC-V] Do not crash when using -ftrapping-math.

enhanced and more testcases.

Jun 12 2020, 8:03 AM · Restricted Project

Jun 8 2020

kamleshbhalui added inline comments to D81391: [RISC-V] Do not crash when using -ftrapping-math.
Jun 8 2020, 8:48 AM · Restricted Project
kamleshbhalui created D81391: [RISC-V] Do not crash when using -ftrapping-math.
Jun 8 2020, 7:05 AM · Restricted Project

Jun 2 2020

kamleshbhalui added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

I do not have commit access,
can someone commit this for me?

Jun 2 2020, 10:25 AM · Restricted Project
kamleshbhalui added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

LGTM. But please give it some time for other people to chime in before you merge, they may disagree with this .inc approach.
I'm approving this assuming the generic test is actually ran against this implementation. @kamleshbhalui did you verify that was the case?

Jun 2 2020, 10:25 AM · Restricted Project

May 30 2020

kamleshbhalui updated the diff for D80465: [RISCV-V] Provide muldi3 builtins for riscv.

cleanup

May 30 2020, 6:52 AM · Restricted Project

May 28 2020

kamleshbhalui added 1 blocking reviewer(s) for D80690: [RISCV] Support libunwind for riscv32: Restricted Project.
May 28 2020, 10:56 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

@kamleshbhalui Just to be clear -- you need libunwind approval before you can submit a patch that touches libunwind. If you just wanted to iterate on this privately it's OK, but you'll need approval from the group before submitting.

May 28 2020, 10:23 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added a reviewer for D80690: [RISCV] Support libunwind for riscv32: Restricted Project.
May 28 2020, 10:23 AM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the summary of D80526: [RISCV64] emit correct lib call for fp(double) to ui/si.
May 28 2020, 8:07 AM · Restricted Project
kamleshbhalui updated the diff for D80465: [RISCV-V] Provide muldi3 builtins for riscv.

restructured the file. so it can be picked by lit test.

May 28 2020, 7:35 AM · Restricted Project
kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

defined _LIBUNWIND_CURSOR_SIZE
for all these below variants
ILP32 + "f" : xlen = 32, flen = 32 ===> 39
ILP32 + "fd" : xlen = 32, flen = 64 ===>55
LP64 + "f" : xlen = 64, flen = 32 ====>60
LP64 + "fd" : xlen = 64, flen = 64 ====>76 (was already done.)

May 28 2020, 7:02 AM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @luismarques comments.

May 28 2020, 2:08 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added inline comments to D80690: [RISCV] Support libunwind for riscv32.
May 28 2020, 1:02 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added inline comments to D80690: [RISCV] Support libunwind for riscv32.
May 28 2020, 1:02 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added inline comments to D80690: [RISCV] Support libunwind for riscv32.
May 28 2020, 1:02 AM · Unknown Object (Project), Restricted Project

May 27 2020

kamleshbhalui created D80690: [RISCV] Support libunwind for riscv32.
May 27 2020, 11:24 PM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the diff for D80465: [RISCV-V] Provide muldi3 builtins for riscv.

Addressed @luismarques concerns.

May 27 2020, 9:48 PM · Restricted Project
kamleshbhalui added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

You can generalize muldi3.c to implement __mulsi3.

looks like no one uses mulsi3 other than riscv32 which already has target specific implementation.
This patch adds
muldi3 target-specific implementation for riscv64 to get rid of problem shown in summary.

Still uneasy with the assembly implementation. .c works as well, doesn't it?

May 27 2020, 8:38 AM · Restricted Project
kamleshbhalui added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

ping?

May 27 2020, 2:39 AM · Restricted Project

May 25 2020

kamleshbhalui abandoned D80468: [ARM] select is not lowered in branching.

-ftrapping-math will do the work.
so abandoning it.

May 25 2020, 11:25 PM · Restricted Project
kamleshbhalui created D80526: [RISCV64] emit correct lib call for fp(double) to ui/si.
May 25 2020, 9:38 AM · Restricted Project

May 23 2020

kamleshbhalui updated the diff for D80468: [ARM] select is not lowered in branching.

fixed failing testcase.

May 23 2020, 6:02 PM · Restricted Project
kamleshbhalui created D80468: [ARM] select is not lowered in branching.
May 23 2020, 6:19 AM · Restricted Project
kamleshbhalui added a comment to D77505: [libc++] Implement <numbers>.

Borrow useful things from D78427:

  • A test
  • Version guard
  • Double include test

Rebased on master.

May 23 2020, 5:15 AM · Unknown Object (Project)
kamleshbhalui updated the summary of D80465: [RISCV-V] Provide muldi3 builtins for riscv.
May 23 2020, 2:36 AM · Restricted Project
kamleshbhalui updated the diff for D80465: [RISCV-V] Provide muldi3 builtins for riscv.

added CMakeLists.txt change for riscv64.

May 23 2020, 2:36 AM · Restricted Project
kamleshbhalui added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

You can generalize muldi3.c to implement __mulsi3.

May 23 2020, 2:36 AM · Restricted Project

May 22 2020

kamleshbhalui created D80465: [RISCV-V] Provide muldi3 builtins for riscv.
May 22 2020, 8:21 PM · Restricted Project
kamleshbhalui abandoned D78427: [libcxx] Add c++20 <numbers>.

duplicate of D77505

May 22 2020, 8:33 AM · Unknown Object (Project)
kamleshbhalui updated subscribers of D77505: [libc++] Implement <numbers>.

thanks @curdeius for pointing this.
Hi @tambre
I was unaware of this work and ended of doing same work.
please take things from here D78427 which seems reasonable.
and update the this review. so i can cancel my review.

May 22 2020, 8:33 AM · Unknown Object (Project)

May 11 2020

kamleshbhalui added a comment to D79504: [Clang] Wrong return type of atomic_is_lock_free.

What name and email do you want this committed with?

May 11 2020, 6:24 AM · Restricted Project

May 8 2020

kamleshbhalui added a comment to D79504: [Clang] Wrong return type of atomic_is_lock_free.

I do not have commit access.

May 8 2020, 2:39 AM · Restricted Project

May 6 2020

kamleshbhalui updated the diff for D78427: [libcxx] Add c++20 <numbers>.

Incorporated @curdeius suggestion.

May 6 2020, 7:20 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D79504: [Clang] Wrong return type of atomic_is_lock_free.

Addressed @rsmith concerns.

May 6 2020, 6:46 PM · Restricted Project
kamleshbhalui added a reviewer for D79504: [Clang] Wrong return type of atomic_is_lock_free: rnk.
May 6 2020, 10:46 AM · Restricted Project
kamleshbhalui updated the diff for D78427: [libcxx] Add c++20 <numbers>.

Thanks for review @curdeius
clang-formatted the diff.
and used http://mpmath.org/ for calculating all constants.

May 6 2020, 10:46 AM · Unknown Object (Project)
kamleshbhalui created D79504: [Clang] Wrong return type of atomic_is_lock_free.
May 6 2020, 10:46 AM · Restricted Project
kamleshbhalui updated the diff for D78427: [libcxx] Add c++20 <numbers>.

Thanks for the review @curdeius.
addressed your concerns.

May 6 2020, 4:16 AM · Unknown Object (Project)

May 3 2020

kamleshbhalui added a comment to D78427: [libcxx] Add c++20 <numbers>.

ping?

May 3 2020, 6:34 PM · Unknown Object (Project)

Apr 21 2020

kamleshbhalui updated the diff for D78427: [libcxx] Add c++20 <numbers>.

changed value to __value

Apr 21 2020, 6:25 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D78427: [libcxx] Add c++20 <numbers>.

Thanks for review.
added cxx2a _statu.html

Apr 21 2020, 6:25 PM · Unknown Object (Project)
kamleshbhalui added inline comments to D78427: [libcxx] Add c++20 <numbers>.
Apr 21 2020, 6:25 PM · Unknown Object (Project)
kamleshbhalui added inline comments to D78427: [libcxx] Add c++20 <numbers>.
Apr 21 2020, 5:54 PM · Unknown Object (Project)

Apr 18 2020

kamleshbhalui updated the summary of D78427: [libcxx] Add c++20 <numbers>.
Apr 18 2020, 10:04 PM · Unknown Object (Project)
kamleshbhalui added a reviewer for D78427: [libcxx] Add c++20 <numbers>: ldionne.
Apr 18 2020, 10:04 PM · Unknown Object (Project)
kamleshbhalui added a reviewer for D78427: [libcxx] Add c++20 <numbers>: Restricted Project.
Apr 18 2020, 9:32 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D78427: [libcxx] Add c++20 <numbers>.

Cleanup and
Add one more test.

Apr 18 2020, 9:32 PM · Unknown Object (Project)
kamleshbhalui removed a reviewer for D78427: [libcxx] Add c++20 <numbers>: Restricted Project.
Apr 18 2020, 6:19 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D78427: [libcxx] Add c++20 <numbers>.

Added test

Apr 18 2020, 12:54 PM · Unknown Object (Project)
kamleshbhalui created D78427: [libcxx] Add c++20 <numbers>.
Apr 18 2020, 7:32 AM · Unknown Object (Project)
kamleshbhalui updated the summary of D78427: [libcxx] Add c++20 <numbers>.
Apr 18 2020, 7:32 AM · Unknown Object (Project)

Apr 12 2020

kamleshbhalui accepted D77912: [builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract).

Thanks, LGTM.

Apr 12 2020, 6:42 PM · Restricted Project
kamleshbhalui abandoned D77744: __udivdi3 and __udivmoddi4 call each other and stuck in loop.

Replaced by D77912

Apr 12 2020, 6:42 PM · Restricted Project

Apr 11 2020

kamleshbhalui added a comment to D77912: [builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract).

for this input
a=3325549423267495579 ,b=2351357301745665781
and compiled with -O2 with clang-9.
it takes 299 ns.
while D77744 takes only 91ns.

Apr 11 2020, 4:32 PM · Restricted Project
kamleshbhalui added a comment to D77912: [builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract).

here is compiler detils i tried upon.

Apr 11 2020, 4:32 PM · Restricted Project
kamleshbhalui requested changes to D77912: [builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract).

it's still less optimal.

Apr 11 2020, 1:02 AM · Restricted Project

Apr 10 2020

kamleshbhalui requested changes to D77912: [builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract).

Code review in D77744 is performance-wise better than this.

Apr 10 2020, 6:53 PM · Restricted Project

Apr 8 2020

kamleshbhalui updated the diff for D77744: __udivdi3 and __udivmoddi4 call each other and stuck in loop.
Apr 8 2020, 5:56 PM · Restricted Project
kamleshbhalui created D77744: __udivdi3 and __udivmoddi4 call each other and stuck in loop.
Apr 8 2020, 10:51 AM · Restricted Project

Mar 27 2020

kamleshbhalui added a comment to D76828: [RISC-V] Support __builtin_thread_pointer .

Thanks @lenary for review.
I do not have commit access,
please commit this when you get time.

Mar 27 2020, 8:12 AM · Restricted Project

Mar 26 2020

kamleshbhalui updated the diff for D76828: [RISC-V] Support __builtin_thread_pointer .

nit test

Mar 26 2020, 9:45 AM · Restricted Project
kamleshbhalui updated the diff for D76828: [RISC-V] Support __builtin_thread_pointer .

nits and updated test.

Mar 26 2020, 7:33 AM · Restricted Project
kamleshbhalui updated the diff for D76828: [RISC-V] Support __builtin_thread_pointer .

Added rv32 run line.

Mar 26 2020, 6:28 AM · Restricted Project
kamleshbhalui updated the diff for D76828: [RISC-V] Support __builtin_thread_pointer .

nit and Added the tests.

Mar 26 2020, 5:55 AM · Restricted Project