Page MenuHomePhabricator

kamleshbhalui (kamlesh kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2018, 2:05 AM (166 w, 4 d)

Recent Activity

Yesterday

kamleshbhalui committed rG36c3918ec55b: [libc++] [C++20] [P0586] Implement safe integral comparisons (authored by Kamlesh Kumar <kamlesbhalui@gmail.com>).
[libc++] [C++20] [P0586] Implement safe integral comparisons
Mon, Apr 19, 4:26 PM
kamleshbhalui closed D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.
Mon, Apr 19, 4:26 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

updated generate_feature_test_macro_components.py.

Mon, Apr 19, 9:52 AM · Unknown Object (Project)
kamleshbhalui added a comment to D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

There are still quite some formatting errors, for example () , instead of (),, please use the instructions here to format the patch https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

Mon, Apr 19, 9:46 AM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

formatted intcmp.fail.cpp

Mon, Apr 19, 5:00 AM · Unknown Object (Project)

Sun, Apr 18

kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

formatted the tests as per @Quuxplusone comments

Sun, Apr 18, 10:37 PM · Unknown Object (Project)
kamleshbhalui added a reviewer for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons: Quuxplusone.
Sun, Apr 18, 5:14 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

incorporated @Quuxplusone comments

Sun, Apr 18, 5:13 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

fixed a typo.

Sun, Apr 18, 7:03 AM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

incorporated comments from @Quuxplusone, @Mordante and @curdeius

Sun, Apr 18, 6:59 AM · Unknown Object (Project)

Thu, Apr 8

kamleshbhalui updated the diff for D99580: [CLANG] [DebugInfo] Convert File name to native format.

Making changes effective only for windows

Thu, Apr 8, 4:05 AM · Restricted Project, Restricted Project

Wed, Apr 7

kamleshbhalui added a reviewer for D99580: [CLANG] [DebugInfo] Convert File name to native format: rnk.

ping?

Wed, Apr 7, 10:24 AM · Restricted Project, Restricted Project
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

Incorporated @Quuxplusone suggestions.

Wed, Apr 7, 10:15 AM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

Addressed @curdeius comments.

Wed, Apr 7, 8:35 AM · Unknown Object (Project)

Fri, Apr 2

kamleshbhalui updated the diff for D99580: [CLANG] [DebugInfo] Convert File name to native format.

Making changes effective only for windows

Fri, Apr 2, 7:24 AM · Restricted Project, Restricted Project

Tue, Mar 30

kamleshbhalui updated the diff for D99580: [CLANG] [DebugInfo] Convert File name to native format.

updated patch

Tue, Mar 30, 11:22 PM · Restricted Project, Restricted Project
kamleshbhalui updated the diff for D99580: [CLANG] [DebugInfo] Convert File name to native format.

clang formatting the patch.

Tue, Mar 30, 11:15 PM · Restricted Project, Restricted Project
kamleshbhalui updated the diff for D99580: [CLANG] [DebugInfo] Convert File name to native format.

Marked failed tests as unsupported on windows system
Because now clang emits native path for DIFile.

Tue, Mar 30, 9:40 PM · Restricted Project, Restricted Project
kamleshbhalui added a reviewer for D99580: [CLANG] [DebugInfo] Convert File name to native format: amccarth.
Tue, Mar 30, 6:52 PM · Restricted Project, Restricted Project
kamleshbhalui added a comment to D99580: [CLANG] [DebugInfo] Convert File name to native format.

@rnk @akhuang - I think we touched on this before maybe in some other thread/patch/discussion?

Ah, @probinson mentioned in the linked thread:

Is this https://bugs.llvm.org/show_bug.cgi?id=44170 which had a tentative patch at https://reviews.llvm.org/D71508 ?
The original complaint wasn't for Windows, but the lack of filepath canonicalization seems like a common symptom.

Might be best, @kamleshbhalui, if you could check if the other (D71508) patch relates to the same issue & if so, continue the discussion over there instead of forking it here.

Tue, Mar 30, 6:17 PM · Restricted Project, Restricted Project
kamleshbhalui added a comment to D99580: [CLANG] [DebugInfo] Convert File name to native format.

Another possible issue is that llvm::sys::path and other functions try to map Windows filesystem concepts to Posix ones. There are many cases where there isn't a perfect mapping. For example: Windows has a current working directory _per drive_, and so it can be hard to resolve paths like D:foo.ext, which are relative to something other than the "current working directory." Details like this can come into play in the immediate vicinity of the code change, so I have some trepidation.

Agree with you but this problem exist with and without this patch.

It looks like the code change is for everyone, but the new test is specific to mingw.

Tue, Mar 30, 3:48 PM · Restricted Project, Restricted Project
kamleshbhalui requested review of D99580: [CLANG] [DebugInfo] Convert File name to native format.
Tue, Mar 30, 5:16 AM · Restricted Project, Restricted Project

Sun, Mar 28

kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

Updated the tests

Sun, Mar 28, 9:35 PM · Unknown Object (Project)

Mar 5 2021

kamleshbhalui added a comment to D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined.

This doesn't answer my question unfortunately.
What configuration (platform/OS/compiler, cmake invocation etc.) you used when you found the failures?
What were these failures precisely?

Mar 5 2021, 7:20 AM · Unknown Object (Project)
kamleshbhalui added a comment to D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined.

Can you give some details please about the config on which these tests failed?

Mar 5 2021, 7:01 AM · Unknown Object (Project)
kamleshbhalui retitled D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined from Fixed test to Fixed Test for cases when DISABLE_NEW_COUNT is defined.
Mar 5 2021, 6:58 AM · Unknown Object (Project)
kamleshbhalui updated the diff for D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined.

Added one fixed test

Mar 5 2021, 1:29 AM · Unknown Object (Project)
kamleshbhalui updated the diff for D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined.

Fixed more tests

Mar 5 2021, 1:06 AM · Unknown Object (Project)

Mar 4 2021

kamleshbhalui added a reviewer for D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined: ldionne.
Mar 4 2021, 10:26 PM · Unknown Object (Project)
kamleshbhalui requested review of D98006: Fixed Test for cases when DISABLE_NEW_COUNT is defined.
Mar 4 2021, 10:25 PM · Unknown Object (Project)

Mar 2 2021

kamleshbhalui committed rG5c3fc5093aaf: [libunwind] [risc-v] This patch is for fixing (authored by kamleshbhalui).
[libunwind] [risc-v] This patch is for fixing
Mar 2 2021, 3:08 PM
kamleshbhalui closed D97762: [RISCV] fixes cross unwinding failure.
Mar 2 2021, 3:08 PM · Restricted Project, Unknown Object (Project)
kamleshbhalui requested review of D97762: [RISCV] fixes cross unwinding failure.
Mar 2 2021, 3:37 AM · Restricted Project, Unknown Object (Project)

Mar 1 2021

kamleshbhalui committed rGb17d46430fce: [libunwind] This adds support in libunwind for rv32 hard float (authored by kamleshbhalui).
[libunwind] This adds support in libunwind for rv32 hard float
Mar 1 2021, 5:33 PM
kamleshbhalui closed D80690: [RISCV] Support libunwind for riscv32.
Mar 1 2021, 5:32 PM · Unknown Object (Project), Restricted Project
kamleshbhalui abandoned D97750: Fix memleak for 5de2d189e6ad4.
Mar 1 2021, 5:02 PM · Restricted Project
kamleshbhalui requested review of D97750: Fix memleak for 5de2d189e6ad4.
Mar 1 2021, 5:01 PM · Restricted Project

Feb 14 2021

kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

addressed @Mordante comments.

Feb 14 2021, 4:25 PM · Unknown Object (Project)
kamleshbhalui added inline comments to D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.
Feb 14 2021, 3:23 PM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

used _LIBCPP_NO_HAS_CHAR8_T and _LIBCPP_HAS_NO_UNICODE_CHARS macro to guard char8_t, and char16_t, char32_t.

Feb 14 2021, 10:25 AM · Unknown Object (Project)
kamleshbhalui updated the diff for D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

addressed @curdeius comments.
added tests, few test snippets taken from the link given by @curdeius.

Feb 14 2021, 10:07 AM · Unknown Object (Project)

Jan 12 2021

kamleshbhalui requested review of D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.
Jan 12 2021, 9:28 AM · Unknown Object (Project)

Jan 4 2021

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

fixed a nit.

Jan 4 2021, 8:29 PM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

rebased with the main branch. do not see any conflict.
@ldionne or @abdulras can you please have a look at this, this patch is in this state for a long time.
FYI, I have been using this patch in VxWorks.

Jan 4 2021, 8:22 PM · Unknown Object (Project), Restricted Project

Nov 5 2020

kamleshbhalui accepted D90817: [RISCV] Use the 'si' lib call for (double (fp_to_sint/uint i32 X)) when F extension is enabled..

LGTM!

Nov 5 2020, 3:42 AM · Restricted Project

Oct 14 2020

kamleshbhalui added a comment to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

Is this a problem unique to vector? Do the other containers have the same constructor? Do those constructors have the same issue?
Checking ... list does not seem to have this problem. deque does not either. forward_list does not either.

<deque> has the following code:

template <class _InputIter>
    deque(_InputIter __f, _InputIter __l,
          typename enable_if<__is_cpp17_input_iterator<_InputIter>::value>::type* = 0);
template <class _InputIter>
    deque(_InputIter __f, _InputIter __l, const allocator_type& __a,
          typename enable_if<__is_cpp17_input_iterator<_InputIter>::value>::type* = 0);

I don't think that making vector different from the other containers is the right approach. Then again, I'm not 100% sure why the existing code is failing - so I should look at tha

Oct 14 2020, 9:10 AM · Unknown Object (Project)
kamleshbhalui added a comment to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

ping?

Oct 14 2020, 8:27 AM · Unknown Object (Project)

Oct 2 2020

kamleshbhalui updated the diff for D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

Added test suggested by @mclow.lists .

Oct 2 2020, 8:08 AM · Unknown Object (Project)
kamleshbhalui added a comment to D88727: vector (iterator,iterator) constructor doesn't deduce second arg.

So the actual problem in the bug report is that the first argument cannot be used to deduce the type.

I think it is not correct to remove the type restrictions here, they are there for a reason.

Oct 2 2020, 6:13 AM · Unknown Object (Project)
kamleshbhalui updated the summary of D88727: vector (iterator,iterator) constructor doesn't deduce second arg.
Oct 2 2020, 4:21 AM · Unknown Object (Project)
kamleshbhalui requested review of D88727: vector (iterator,iterator) constructor doesn't deduce second arg.
Oct 2 2020, 4:20 AM · Unknown Object (Project)

Aug 30 2020

kamleshbhalui committed rGdeb99610ab00: Improve doc comments for several methods returning bools (authored by kamleshbhalui).
Improve doc comments for several methods returning bools
Aug 30 2020, 1:04 AM
kamleshbhalui closed D86848: [MLIR] Improving the Comment .
Aug 30 2020, 1:03 AM · Unknown Object (Project)

Aug 29 2020

kamleshbhalui requested review of D86848: [MLIR] Improving the Comment .
Aug 29 2020, 10:51 PM · Unknown Object (Project)

Jul 31 2020

kamleshbhalui accepted D85002: [RISCV] eliminate the repetition declare of SDLoc DL.

LGTM!

Jul 31 2020, 12:53 AM · Restricted Project

Jul 30 2020

kamleshbhalui updated the diff for D81391: [RISC-V] Do not crash when using -ftrapping-math.

rebased with the master.

Jul 30 2020, 2:28 AM · Restricted Project

Jul 26 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @mhorne comments.

Jul 26 2020, 11:14 PM · Unknown Object (Project), Restricted Project

Jul 23 2020

kamleshbhalui added a comment to D81391: [RISC-V] Do not crash when using -ftrapping-math.

@asb and @luismarques do you suggest anything here ?

Jul 23 2020, 2:14 AM · Restricted Project
kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

ping?

Jul 23 2020, 2:04 AM · Unknown Object (Project), Restricted Project

Jun 29 2020

kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

ping?

Jun 29 2020, 3:12 AM · Unknown Object (Project), Restricted Project

Jun 24 2020

kamleshbhalui added inline comments to D82446: [clang] Fix duplicate warning.
Jun 24 2020, 6:59 AM · Restricted Project
kamleshbhalui created D82446: [clang] Fix duplicate warning.
Jun 24 2020, 3:44 AM · Restricted Project

Jun 22 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @mhorne and @MaskRay concerns.

Jun 22 2020, 9:07 AM · Unknown Object (Project), Restricted Project

Jun 19 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

rebased and cleaned up the diff.

Jun 19 2020, 9:44 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added a comment to D82171: [libc++] Require concepts support for <numbers>.

D77505 broke a bunch of bots. This fixes the regression.

I lack commit privileges. Please land as "Raul Tambre <raul@tambre.ee>"

Jun 19 2020, 6:59 AM · Unknown Object (Project)
kamleshbhalui committed rG4f6c4b473c4a: [libc++] Implement <numbers> (authored by tambre).
[libc++] Implement <numbers>
Jun 19 2020, 2:07 AM
kamleshbhalui closed D77505: [libc++] Implement <numbers>.
Jun 19 2020, 2:07 AM · Unknown Object (Project)
kamleshbhalui added a comment to D77505: [libc++] Implement <numbers>.

Please commit this for me in case no one else has objections. I lack commit privileges.

Jun 19 2020, 12:29 AM · Unknown Object (Project)

Jun 18 2020

kamleshbhalui committed rG7622ea5835f0: [RISCV64] Emit correct lib call for fp(float/double) to ui/si (authored by kamleshbhalui).
[RISCV64] Emit correct lib call for fp(float/double) to ui/si
Jun 18 2020, 7:35 AM
kamleshbhalui closed D80526: [RISCV64] emit correct lib call for fp(double) to ui/si.
Jun 18 2020, 7:35 AM · Restricted Project
kamleshbhalui added a reviewer for D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__: MaskRay.
Jun 18 2020, 2:41 AM · Restricted Project, Restricted Project

Jun 17 2020

kamleshbhalui updated the summary of D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui updated the summary of D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui created D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui updated the summary of D82014: [compiler-rt] Replaced __SOFT_FP__ with __SOFTFP__.
Jun 17 2020, 8:03 AM · Restricted Project, Restricted Project
kamleshbhalui added a reviewer for D80526: [RISCV64] emit correct lib call for fp(double) to ui/si: efriedma.
Jun 17 2020, 7:31 AM · Restricted Project
kamleshbhalui updated the diff for D80526: [RISCV64] emit correct lib call for fp(double) to ui/si.

Addressed @efriedma comments.
added test for strictfp.

Jun 17 2020, 7:31 AM · Restricted Project

Jun 16 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

thanks @mhorne for reviewing.
addressed your comments.

Jun 16 2020, 6:38 PM · Unknown Object (Project), Restricted Project
kamleshbhalui added a reviewer for D81391: [RISC-V] Do not crash when using -ftrapping-math: lenary.
Jun 16 2020, 4:58 AM · Restricted Project
kamleshbhalui added inline comments to D81391: [RISC-V] Do not crash when using -ftrapping-math.
Jun 16 2020, 4:58 AM · Restricted Project

Jun 15 2020

kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

ping?

Jun 15 2020, 6:46 PM · Unknown Object (Project), Restricted Project
kamleshbhalui added a comment to D81391: [RISC-V] Do not crash when using -ftrapping-math.

ping?

Jun 15 2020, 6:46 PM · Restricted Project

Jun 14 2020

kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

Rebased

Jun 14 2020, 12:29 AM · Unknown Object (Project), Restricted Project

Jun 13 2020

kamleshbhalui updated the summary of D80690: [RISCV] Support libunwind for riscv32.
Jun 13 2020, 1:02 AM · Unknown Object (Project), Restricted Project

Jun 12 2020

kamleshbhalui added inline comments to D80690: [RISCV] Support libunwind for riscv32.
Jun 12 2020, 10:52 AM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @luismarques concerns.
This patch extends soft float case .

Jun 12 2020, 10:19 AM · Unknown Object (Project), Restricted Project
kamleshbhalui updated the diff for D81391: [RISC-V] Do not crash when using -ftrapping-math.

enhanced and more testcases.

Jun 12 2020, 8:03 AM · Restricted Project

Jun 8 2020

kamleshbhalui added inline comments to D81391: [RISC-V] Do not crash when using -ftrapping-math.
Jun 8 2020, 8:48 AM · Restricted Project
kamleshbhalui created D81391: [RISC-V] Do not crash when using -ftrapping-math.
Jun 8 2020, 7:05 AM · Restricted Project

Jun 2 2020

kamleshbhalui added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

I do not have commit access,
can someone commit this for me?

Jun 2 2020, 10:25 AM · Restricted Project
kamleshbhalui added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

LGTM. But please give it some time for other people to chime in before you merge, they may disagree with this .inc approach.
I'm approving this assuming the generic test is actually ran against this implementation. @kamleshbhalui did you verify that was the case?

Jun 2 2020, 10:25 AM · Restricted Project

May 30 2020

kamleshbhalui updated the diff for D80465: [RISCV-V] Provide muldi3 builtins for riscv.

cleanup

May 30 2020, 6:52 AM · Restricted Project

May 28 2020

kamleshbhalui added 1 blocking reviewer(s) for D80690: [RISCV] Support libunwind for riscv32: Restricted Project.
May 28 2020, 10:56 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added a comment to D80690: [RISCV] Support libunwind for riscv32.

@kamleshbhalui Just to be clear -- you need libunwind approval before you can submit a patch that touches libunwind. If you just wanted to iterate on this privately it's OK, but you'll need approval from the group before submitting.

May 28 2020, 10:23 AM · Unknown Object (Project), Restricted Project
kamleshbhalui added a reviewer for D80690: [RISCV] Support libunwind for riscv32: Restricted Project.
May 28 2020, 10:23 AM · Restricted Project, Restricted Project
kamleshbhalui updated the summary of D80526: [RISCV64] emit correct lib call for fp(double) to ui/si.
May 28 2020, 8:07 AM · Restricted Project
kamleshbhalui updated the diff for D80465: [RISCV-V] Provide muldi3 builtins for riscv.

restructured the file. so it can be picked by lit test.

May 28 2020, 7:35 AM · Restricted Project
kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

defined _LIBUNWIND_CURSOR_SIZE
for all these below variants
ILP32 + "f" : xlen = 32, flen = 32 ===> 39
ILP32 + "fd" : xlen = 32, flen = 64 ===>55
LP64 + "f" : xlen = 64, flen = 32 ====>60
LP64 + "fd" : xlen = 64, flen = 64 ====>76 (was already done.)

May 28 2020, 7:02 AM · Restricted Project, Restricted Project
kamleshbhalui updated the diff for D80690: [RISCV] Support libunwind for riscv32.

addressed @luismarques comments.

May 28 2020, 2:08 AM · Restricted Project, Restricted Project
kamleshbhalui added inline comments to D80690: [RISCV] Support libunwind for riscv32.
May 28 2020, 1:02 AM · Restricted Project, Restricted Project