Page MenuHomePhabricator

X86/GlobalISel: Rely on default assignValueToRe
ClosedPublic

Authored by arsenm on Apr 17 2021, 10:00 AM.

Details

Summary

The resulting output is semantically closer to what the DAG emits and
is more compatible with the existing CCAssignFns.

The returns of f32 in f80 are clearly broken, but they were broken
before when using G_ANYEXT to go from f32 to f80.

Diff Detail

Event Timeline

arsenm created this revision.Apr 17 2021, 10:00 AM
arsenm requested review of this revision.Apr 17 2021, 10:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2021, 10:00 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm updated this revision to Diff 338325.Apr 17 2021, 10:15 AM
arsenm edited the summary of this revision. (Show Details)

Also handle the outgoing case. Changes f32 return promotion from broken, to different broken

paquette accepted this revision.May 4 2021, 9:35 AM

LGTM

This revision is now accepted and ready to land.May 4 2021, 9:35 AM