[flang][driver] Fine-tune `-fdebug-dump-symbols`

[awarzynski]

Summary

When generating output for -fdebug-dump-symbols, make sure that
BuildRuntimeDerivedTypeTables is also run. This change is needed in
order to make the implementation of -fdebug-dump-symbols in
flang-new consistent with f18. It also allows us to port more tests
to use the new driver whenever it is enabled.

[awarzynski]

Rebase on top of D100648

[awarzynski]

Remove D100648 as a dependency

D100648 was abandoned due to https://bugs.llvm.org/show_bug.cgi?id=50040. The latest revision of this patch takes 50040 into account. The behaviour implemented here matches that from f18.

[AMDChirag]

This comment was removed by AMDChirag.

[AMDChirag]

This comment was removed by AMDChirag.

[AMDChirag]

flang/lib/Frontend/FrontendActions.cpp

285

Shouldn't the local variables be named in PascalCase?

296

PascalCase here as well?

[awarzynski]

flang/lib/Frontend/FrontendActions.cpp

285

In LLVM/Clang - yes, in MLIR/Flang -no :) It's basically lowerCase everywhere in Flang. That's not really explicitly mentioned in the coding style, but that's the style used in this file and in other parts of Flang.

[AMDChirag]

flang/lib/Frontend/FrontendActions.cpp

285

Oh okay, my bad. Thanks for explaining :)
LGTM, but i'll let others take a look.

[awarzynski]

Rebase on top of main. Take the resolution of 50040 into account.

[ashermancinelli]

LGTM!

flang/lib/Frontend/FrontendActions.cpp

bool reportFatalSemanticErrors(const Fortran::semantics::Semantics &semantics,
   return false;
 }
 
 bool PrescanAction::BeginSourceFileAction(CompilerInstance &c1) {
   CompilerInstance &ci = this->instance();
   std::string currentInputPath{GetCurrentFileOrBufferName()};
   Fortran::parser::Options parserOptions = ci.invocation().fortranOpts();
 
-
   // Prescan. In case of failure, report and return.
   ci.parsing().Prescan(currentInputPath, parserOptions);
 
   if (!ci.parsing().messages().empty() &&
       (ci.invocation().warnAsErr() ||
           ci.parsing().messages().AnyFatalError())) {
     const unsigned diagID = ci.diagnostics().getCustomDiagID(
         clang::DiagnosticsEngine::Error, "Could not scan %0");
Fortran::semantics::UnparseWithSymbols(
       llvm::outs(), parseTree, /*encoding=*/Fortran::parser::Encoding::UTF_8);
 
   // Report fatal semantic errors
   reportFatalSemanticErrors(semantics(), this->instance().diagnostics(),
       GetCurrentFileOrBufferName());
 }
 
 void DebugDumpSymbolsAction::ExecuteAction() {
+  CompilerInstance &ci = this->instance();
   auto &semantics = this->semantics();
 
-  // Dump symbols
-  semantics.DumpSymbols(llvm::outs());
-  // Report fatal semantic errors
+  auto tables{Fortran::semantics::BuildRuntimeDerivedTypeTables(
+      instance().invocation().semanticsContext())};
+  // The runtime derived type information table builder may find and report
+  // semantic errors. So it is important that we report them _after_
+  // BuildRuntimeDerivedTypeTables is run.
   reportFatalSemanticErrors(
       semantics, this->instance().diagnostics(), GetCurrentFileOrBufferName());
+
+  if (!tables.schemata) {
+    unsigned DiagID =
+        ci.diagnostics().getCustomDiagID(clang::DiagnosticsEngine::Error,
+            "could not find module file for __fortran_type_info");
+    ci.diagnostics().Report(DiagID);
+    llvm::errs() << "\n";
+  }
+
+  // Dump symbols
+  semantics.DumpSymbols(llvm::outs());
 }
 
 void DebugDumpParseTreeNoSemaAction::ExecuteAction() {
   auto &parseTree{instance().parsing().parseTree()};
   Fortran::parser::AnalyzedObjectsAsFortran asFortran =
       Fortran::frontend::getBasicAsFortran();
 
   // Dump parse tree

flang/test/Semantics/typeinfo01.f90

-!RUN: %f18 -fdebug-dump-symbols %s | FileCheck %s
+!RUN: %flang_fc1 -fdebug-dump-symbols %s | FileCheck %s
 ! Tests for derived type runtime descriptions
 
 module m01
   type :: t1
     integer :: n
   end type
 !CHECK: .c.t1, SAVE, TARGET: ObjectEntity type: TYPE(component) shape: 0_8:0_8 init:[component::component(name=.n.n,genre=1_1,category=0_1,kind=4_1,rank=0_1,offset=0_8,characterlen=value(genre=1_1,value=0_8),derived=NULL(),lenvalue=NULL(),bounds=NULL(),initialization=NULL())]
 !CHECK: .dt.t1, SAVE, TARGET: ObjectEntity type: TYPE(derivedtype) init:derivedtype(binding=NULL(),name=.n.t1,sizeinbytes=4_8,parent=NULL(),uninstantiated=NULL(),kindparameter=NULL(),lenparameterkind=NULL(),component=.c.t1,procptr=NULL(),special=NULL())