Details

Reviewers

sscalpone
SouraVX
tskeith
Leporacanthicus
arnamoy10
ashermancinelli
kiranchandramohan
AMDChirag

Commits

rG499f1ed54853: [flang][driver] Fine-tune `-fdebug-dump-symbols`

Summary

When generating output for -fdebug-dump-symbols, make sure that
BuildRuntimeDerivedTypeTables is also run. This change is needed in
order to make the implementation of -fdebug-dump-symbols in
flang-new consistent with f18. It also allows us to port more tests
to use the new driver whenever it is enabled.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

awarzynski created this revision.Apr 16 2021, 7:42 AM

Herald added a reviewer: sscalpone. · View Herald TranscriptApr 16 2021, 7:42 AM

awarzynski requested review of this revision.Apr 16 2021, 7:42 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2021, 7:42 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

awarzynski added a parent revision: D100648: [flang][f18] Add an additional check for semantic errors.Apr 16 2021, 7:43 AM

Harbormaster completed remote builds in B99177: Diff 338112.Apr 16 2021, 8:39 AM

Rebase on top of D100648

Harbormaster completed remote builds in B99195: Diff 338136.Apr 16 2021, 9:59 AM

awarzynski removed a parent revision: D100648: [flang][f18] Add an additional check for semantic errors.Apr 20 2021, 8:53 AM

Remove D100648 as a dependency

D100648 was abandoned due to https://bugs.llvm.org/show_bug.cgi?id=50040. The latest revision of this patch takes 50040 into account. The behaviour implemented here matches that from f18.

Harbormaster completed remote builds in B99731: Diff 338886.Apr 20 2021, 9:25 AM

awarzynski added reviewers: SouraVX, tskeith, Leporacanthicus, arnamoy10, ashermancinelli, kiranchandramohan, AMDChirag.Apr 21 2021, 2:52 AM

awarzynski added a project: Restricted Project.

Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 21 2021, 2:52 AM

AMDChirag added a comment.Apr 21 2021, 10:14 PM

This comment was removed by AMDChirag.

AMDChirag accepted this revision.Apr 21 2021, 10:15 PM

This comment was removed by AMDChirag.

This revision is now accepted and ready to land.Apr 21 2021, 10:15 PM

AMDChirag requested changes to this revision.Apr 22 2021, 12:39 AM

AMDChirag added inline comments.

flang/lib/Frontend/FrontendActions.cpp
285	Shouldn't the local variables be named in PascalCase?
296	PascalCase here as well?

This revision now requires changes to proceed.Apr 22 2021, 12:39 AM

awarzynski added inline comments.Apr 22 2021, 6:24 AM

flang/lib/Frontend/FrontendActions.cpp
285	In LLVM/Clang - yes, in MLIR/Flang -no :) It's basically lowerCase everywhere in Flang. That's not really explicitly mentioned in the coding style, but that's the style used in this file and in other parts of Flang.