- User Since
- Feb 16 2021, 6:34 PM (145 w, 6 d)
Mar 18 2022
Thanks everyone for the helpful review. I've also tested with -O[0-3] as suggested by @EricWF. I will land this by the end of the day. Cheers!
Feb 14 2022
Rebase to trigger ci.
Feb 10 2022
Rebase to trigger CI.
Feb 9 2022
Fix tests with C++03 and rebase.
Enable tests when using appropriate standard versions.
Feb 8 2022
Thanks again for the thoughtful review!
- Use more readable == operand order in assertions
- Remove irrelevant test case
- Guard std::shared_ptr<T> specialization with check for standard version greater than or equal to C++14
Feb 7 2022
Re-add test I mistakenly removed.
- Bolster new and existing tests.
- Slight style fixes.
- Mark 3548 as complete in status file.
- Remove misguided addition to constraints on template parameter.
Dec 19 2021
Aug 19 2021
Aug 16 2021
Aug 13 2021
This introduces a very clean level of indirection imo. +1 for adapting the clang documentation as well!
Aug 6 2021
Rebase to ensure patch still builds cleanly.
Jul 30 2021
Jul 29 2021
Rebase to retrigger CI.
Thanks for the kind words @awarzynski! Glad I could help 🙂
Jul 28 2021
Rebase on main.
Jul 26 2021
Update comments and formatting in response to feedback and clang-tidy.
Jul 1 2021
Jun 18 2021
Update language to use cmake variables over ugly environment variable workaround.
Jun 17 2021
Document use of CMake variable GCC_INSTALL_PREFIX over ugly workaround.
I've hopefully addressed your comments. Thanks for the review @jhuber6!
Remove CMake example. Use more generic language.
Jun 15 2021
Jun 14 2021
Jun 11 2021
Add LLVM header comment to buffer test.
Jun 10 2021
Jun 9 2021
@awarzynski Sounds good! I'll add a few more reviewers and wait a bit before merging.
Jun 3 2021
May 17 2021
Update revision with supporting functionality test.
May 12 2021
@awarzynski This is just the minimum to pull the test into gtest. I would like to add documentation and death tests for failure conditions - do you have any suggestions for this? I think once we have those two criteria met we can add more reviewers.
Apr 27 2021
Apr 25 2021
Notice that in PrescanAndSemaAction, the first check fails with a scanning error, and the second with a parsing error. This is not the case for PrescanAndParseAction, which makes me think the second check should fail with a parsing error, and the tests should be adjusted in the same way.
Apr 23 2021
Thanks again for the rigorous review!
Pull all of previous test harness into current implementation.
Resolve warnings against const auto without &.
Apr 22 2021
Remove erroneous static qualifiers. Register all tests with crash handler.
Apr 20 2021
Merged in commit 080d48f279e2.
Resolve warnings by removing utility function.
Apr 19 2021
Merged in ccef0adc5968.
Apr 15 2021
Apr 14 2021
Apr 12 2021
Use more descriptive variable names.
@awarzynski Thanks again for the review! I have another patch ready to address this.
Apr 9 2021
@awarzynski Thank you for the fantastic review comments! I've tried to address most of them - please let me know if this looks good to you.
Use more descriptive variable names and better comment tests. Address clang-tidy warnings and phabricator reviews.
Apr 6 2021
Apr 5 2021
Break original test into two test cases. Add simple sanity-check test cases. Add death test to verify failure message.
Mar 30 2021
If deemed reasonable, I'm happy to extend this to test more of the api as well - I'm open to suggestions. I'm also happy to keep this patch very short.
Mar 29 2021
Use GTest EXPECT_EQ over potentially ambiguous return value, redirect SUT IO to stderr.
Mar 19 2021
Fix header include order.
Fix clang-format and clang-tidy warnings.
Mar 18 2021
@klausler D98652 hopefully demonstrates that runtime crashes are caught by death tests. This revision has been rebased on D98652 - I hope this sufficiently demonstrates that these tests accurately catch crashes. We could also work on another patch that intentionally crashes each of the APIs tested above not already tested in D98652.
Rebase on recent main branch to incorporate terminator crash tests
Mar 17 2021
Remove superfluous comments
Fix header guards to conform to LLVM style guide
Mar 16 2021
More thoroughly comment runtime crash tests.
Mar 15 2021
I have submitted D98652 to discuss similar efforts.
@awarzynski I've actually been working on a similar patch, perhaps we could merge our efforts?
These tests seem to adequately verify the runtime crash mechanism and would support other gtest tests that must catch runtime crashes.
Mar 14 2021
Mar 10 2021
@klausler I think I better understand your concerns now. How would you feel about this patch if I un-removed the original test, we refine this test, and ten
@klausler I reproduce all of the same test cases, so the test coverage should be identical and should catch all of the same bugs. I'd like to increase coverage, but the patch as-is should keep it the same.
Use fully qualified auto to address clang-tidy warnings.