Page MenuHomePhabricator

ashermancinelli (Asher Mancinelli)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2021, 6:34 PM (72 w, 1 d)

Recent Activity

Mar 18 2022

ashermancinelli committed rG34538dba9be6: [libc++] Make shared_ptr move unique_ptr's deleter (authored by ashermancinelli).
[libc++] Make shared_ptr move unique_ptr's deleter
Mar 18 2022, 10:55 AM · Restricted Project
ashermancinelli closed D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Mar 18 2022, 10:54 AM · Restricted Project, Restricted Project
ashermancinelli added a comment to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.

Thanks everyone for the helpful review. I've also tested with -O[0-3] as suggested by @EricWF. I will land this by the end of the day. Cheers!

Mar 18 2022, 10:51 AM · Restricted Project, Restricted Project

Feb 14 2022

ashermancinelli updated the diff for D119159: [libc++] Make shared_ptr move unique_ptr's deleter.

Rebase to trigger ci.

Feb 14 2022, 9:26 AM · Restricted Project, Restricted Project

Feb 10 2022

ashermancinelli updated the diff for D119159: [libc++] Make shared_ptr move unique_ptr's deleter.

Rebase to trigger CI.

Feb 10 2022, 7:34 AM · Restricted Project, Restricted Project

Feb 9 2022

ashermancinelli added inline comments to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 9 2022, 3:41 PM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D119159: [libc++] Make shared_ptr move unique_ptr's deleter.

Fix tests with C++03 and rebase.

Feb 9 2022, 3:37 PM · Restricted Project, Restricted Project
ashermancinelli added inline comments to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 9 2022, 3:12 PM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D119159: [libc++] Make shared_ptr move unique_ptr's deleter.

Enable tests when using appropriate standard versions.

Feb 9 2022, 10:08 AM · Restricted Project, Restricted Project

Feb 8 2022

ashermancinelli added a comment to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.

Thanks again for the thoughtful review!

Feb 8 2022, 2:21 PM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
  • Use more readable == operand order in assertions
  • Remove irrelevant test case
  • Guard std::shared_ptr<T[]> specialization with check for standard version greater than or equal to C++14
Feb 8 2022, 2:13 PM · Restricted Project, Restricted Project

Feb 7 2022

ashermancinelli updated the diff for D119159: [libc++] Make shared_ptr move unique_ptr's deleter.

Re-add test I mistakenly removed.

Feb 7 2022, 5:43 PM · Restricted Project, Restricted Project
ashermancinelli added inline comments to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 7 2022, 5:38 PM · Restricted Project, Restricted Project
ashermancinelli added inline comments to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 7 2022, 5:35 PM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
  • Bolster new and existing tests.
  • Slight style fixes.
  • Mark 3548 as complete in status file.
  • Remove misguided addition to constraints on template parameter.
Feb 7 2022, 5:32 PM · Restricted Project, Restricted Project
ashermancinelli added inline comments to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 7 2022, 11:56 AM · Restricted Project, Restricted Project
ashermancinelli added inline comments to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 7 2022, 11:27 AM · Restricted Project, Restricted Project
ashermancinelli added inline comments to D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 7 2022, 10:01 AM · Restricted Project, Restricted Project
ashermancinelli requested review of D119159: [libc++] Make shared_ptr move unique_ptr's deleter.
Feb 7 2022, 9:58 AM · Restricted Project, Restricted Project

Dec 19 2021

ashermancinelli added inline comments to D114001: [libc++][format] Adds formatter floating-point..
Dec 19 2021, 12:14 PM · Restricted Project

Aug 19 2021

ashermancinelli accepted D108390: [flang] Refine output file generation.

lgtm!

Aug 19 2021, 12:54 PM · Restricted Project, Restricted Project

Aug 16 2021

ashermancinelli added inline comments to D108130: [flang][nfc] Tweak the FrontendAction class.
Aug 16 2021, 11:46 AM · Restricted Project, Restricted Project
ashermancinelli accepted D108130: [flang][nfc] Tweak the FrontendAction class.
Aug 16 2021, 10:14 AM · Restricted Project, Restricted Project

Aug 13 2021

ashermancinelli accepted D108035: [flang][nfc] Move `Semantics` from `FrontendAction` to `CompilerInstance`.

This introduces a very clean level of indirection imo. +1 for adapting the clang documentation as well!

Aug 13 2021, 10:18 AM · Restricted Project, Restricted Project

Aug 6 2021

ashermancinelli committed rGdfce2909ee1e: [flang] Lift -Werror checks into local functions (authored by ashermancinelli).
[flang] Lift -Werror checks into local functions
Aug 6 2021, 11:43 AM
ashermancinelli closed D101261: [flang] Lift -Werror checks into local functions.
Aug 6 2021, 11:43 AM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D101261: [flang] Lift -Werror checks into local functions.

Rebase to ensure patch still builds cleanly.

Aug 6 2021, 11:21 AM · Restricted Project, Restricted Project

Jul 30 2021

ashermancinelli committed rG65436e6ba127: [flang] Move External IO tests to use GTest (authored by ashermancinelli).
[flang] Move External IO tests to use GTest
Jul 30 2021, 9:22 AM
ashermancinelli closed D105315: [flang] Move External IO tests to use GTest.
Jul 30 2021, 9:22 AM · Restricted Project

Jul 29 2021

ashermancinelli updated the diff for D105315: [flang] Move External IO tests to use GTest.

Rebase to retrigger CI.

Jul 29 2021, 2:11 PM · Restricted Project
ashermancinelli added a comment to D105315: [flang] Move External IO tests to use GTest.

Thanks for the kind words @awarzynski! Glad I could help 🙂

Jul 29 2021, 12:35 PM · Restricted Project
ashermancinelli updated the diff for D105315: [flang] Move External IO tests to use GTest.

Apply clang-format.

Jul 29 2021, 12:34 PM · Restricted Project

Jul 28 2021

ashermancinelli updated the diff for D105315: [flang] Move External IO tests to use GTest.

Rebase on main.

Jul 28 2021, 8:33 AM · Restricted Project

Jul 26 2021

ashermancinelli updated the diff for D105315: [flang] Move External IO tests to use GTest.

Update comments and formatting in response to feedback and clang-tidy.

Jul 26 2021, 3:15 PM · Restricted Project

Jul 1 2021

ashermancinelli requested review of D105315: [flang] Move External IO tests to use GTest.
Jul 1 2021, 2:03 PM · Restricted Project

Jun 18 2021

ashermancinelli committed rG5c189d30e60a: [OpenMP] Update FAQ for enabling cuda offloading (authored by ashermancinelli).
[OpenMP] Update FAQ for enabling cuda offloading
Jun 18 2021, 10:57 AM
ashermancinelli closed D104474: [OpenMP] Update FAQ with additional instructions for enabling cuda offloading.
Jun 18 2021, 10:57 AM · Restricted Project
ashermancinelli updated the diff for D104474: [OpenMP] Update FAQ with additional instructions for enabling cuda offloading.

Update language to use cmake variables over ugly environment variable workaround.

Jun 18 2021, 10:50 AM · Restricted Project

Jun 17 2021

ashermancinelli updated the diff for D104474: [OpenMP] Update FAQ with additional instructions for enabling cuda offloading.

Document use of CMake variable GCC_INSTALL_PREFIX over ugly workaround.

Jun 17 2021, 3:58 PM · Restricted Project
ashermancinelli added a comment to D104474: [OpenMP] Update FAQ with additional instructions for enabling cuda offloading.

I've hopefully addressed your comments. Thanks for the review @jhuber6!

Jun 17 2021, 11:36 AM · Restricted Project
ashermancinelli updated the diff for D104474: [OpenMP] Update FAQ with additional instructions for enabling cuda offloading.

Remove CMake example. Use more generic language.

Jun 17 2021, 11:35 AM · Restricted Project
ashermancinelli requested review of D104474: [OpenMP] Update FAQ with additional instructions for enabling cuda offloading.
Jun 17 2021, 10:20 AM · Restricted Project

Jun 15 2021

ashermancinelli accepted D104320: [flang] Move `external-hello-world` to flang/examples.
Jun 15 2021, 1:40 PM · Restricted Project, Restricted Project

Jun 14 2021

ashermancinelli committed rGc58cf692f419: [flang] Move buffer runtime test to GTest (authored by ashermancinelli).
[flang] Move buffer runtime test to GTest
Jun 14 2021, 10:16 AM
ashermancinelli closed D102335: [flang] Move buffer runtime test to GTest.
Jun 14 2021, 10:16 AM · Restricted Project, Restricted Project

Jun 11 2021

ashermancinelli updated the diff for D102335: [flang] Move buffer runtime test to GTest.

Add LLVM header comment to buffer test.

Jun 11 2021, 8:03 AM · Restricted Project, Restricted Project

Jun 10 2021

ashermancinelli added reviewers for D102335: [flang] Move buffer runtime test to GTest: klausler, tskeith.
Jun 10 2021, 10:35 AM · Restricted Project, Restricted Project

Jun 9 2021

ashermancinelli added a comment to D102335: [flang] Move buffer runtime test to GTest.

@awarzynski Sounds good! I'll add a few more reviewers and wait a bit before merging.

Jun 9 2021, 9:49 AM · Restricted Project, Restricted Project

Jun 3 2021

ashermancinelli accepted D103554: [flang][driver] Add checks for missing option arguments.

lgtm!

Jun 3 2021, 8:44 PM · Restricted Project, Restricted Project

May 17 2021

ashermancinelli updated the diff for D101261: [flang] Lift -Werror checks into local functions.

Update revision with supporting functionality test.

May 17 2021, 4:49 PM · Restricted Project, Restricted Project

May 12 2021

ashermancinelli added a comment to D102335: [flang] Move buffer runtime test to GTest.

@awarzynski This is just the minimum to pull the test into gtest. I would like to add documentation and death tests for failure conditions - do you have any suggestions for this? I think once we have those two criteria met we can add more reviewers.

May 12 2021, 10:12 AM · Restricted Project, Restricted Project
ashermancinelli requested review of D102335: [flang] Move buffer runtime test to GTest.
May 12 2021, 10:11 AM · Restricted Project, Restricted Project

Apr 27 2021

ashermancinelli committed rG4abba775a39a: [flang] Add format test to GTest suite (authored by ashermancinelli).
[flang] Add format test to GTest suite
Apr 27 2021, 7:46 AM
ashermancinelli closed D100765: [flang] Update format tests to use GTest.
Apr 27 2021, 7:46 AM · Restricted Project, Restricted Project

Apr 25 2021

ashermancinelli added a comment to D101261: [flang] Lift -Werror checks into local functions.

Notice that in PrescanAndSemaAction, the first check fails with a scanning error, and the second with a parsing error. This is not the case for PrescanAndParseAction, which makes me think the second check should fail with a parsing error, and the tests should be adjusted in the same way.

Apr 25 2021, 10:32 AM · Restricted Project, Restricted Project
ashermancinelli requested review of D101261: [flang] Lift -Werror checks into local functions.
Apr 25 2021, 10:30 AM · Restricted Project, Restricted Project

Apr 23 2021

ashermancinelli added a comment to D100765: [flang] Update format tests to use GTest.

Thanks again for the rigorous review!

Apr 23 2021, 7:37 AM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D100765: [flang] Update format tests to use GTest.

Pull all of previous test harness into current implementation.

Apr 23 2021, 7:36 AM · Restricted Project, Restricted Project
ashermancinelli accepted D100649: [flang][driver] Fine-tune `-fdebug-dump-symbols`.

LGTM!

Apr 23 2021, 7:03 AM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D100765: [flang] Update format tests to use GTest.

Resolve warnings against const auto without &.

Apr 23 2021, 6:57 AM · Restricted Project, Restricted Project

Apr 22 2021

ashermancinelli updated the diff for D100765: [flang] Update format tests to use GTest.

Remove erroneous static qualifiers. Register all tests with crash handler.

Apr 22 2021, 11:04 AM · Restricted Project, Restricted Project

Apr 20 2021

ashermancinelli added a comment to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Merged in commit 080d48f279e2.

Apr 20 2021, 2:45 PM · Restricted Project, Restricted Project
ashermancinelli committed rG080d48f279e2: [flang][msvc] Fix compilation of RuntimeGtest (authored by Mehdi Chinoune <MehdiChinoune>).
[flang][msvc] Fix compilation of RuntimeGtest
Apr 20 2021, 2:37 PM
ashermancinelli closed D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 20 2021, 2:37 PM · Restricted Project, Restricted Project
ashermancinelli added a comment to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Could someone push this change p, please.

Apr 20 2021, 11:56 AM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D100765: [flang] Update format tests to use GTest.

Resolve warnings by removing utility function.

Apr 20 2021, 11:46 AM · Restricted Project, Restricted Project

Apr 19 2021

ashermancinelli requested review of D100765: [flang] Update format tests to use GTest.
Apr 19 2021, 7:41 AM · Restricted Project, Restricted Project
ashermancinelli closed D99614: [flang] Update list-input test to use GTest.

Merged in ccef0adc5968.

Apr 19 2021, 7:39 AM · Restricted Project, Restricted Project

Apr 15 2021

ashermancinelli accepted D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 15 2021, 1:33 PM · Restricted Project, Restricted Project
ashermancinelli committed rGccef0adc5968: [flang] Add list input test to GTest suite (authored by ashermancinelli).
[flang] Add list input test to GTest suite
Apr 15 2021, 9:34 AM

Apr 14 2021

ashermancinelli added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 7:57 AM · Restricted Project, Restricted Project

Apr 12 2021

ashermancinelli updated the diff for D99614: [flang] Update list-input test to use GTest.

Use more descriptive variable names.

Apr 12 2021, 8:28 AM · Restricted Project, Restricted Project
ashermancinelli added a comment to D99614: [flang] Update list-input test to use GTest.

@awarzynski Thanks again for the review! I have another patch ready to address this.

Apr 12 2021, 8:28 AM · Restricted Project, Restricted Project

Apr 9 2021

ashermancinelli added a comment to D99614: [flang] Update list-input test to use GTest.

@awarzynski Thank you for the fantastic review comments! I've tried to address most of them - please let me know if this looks good to you.

Apr 9 2021, 4:54 PM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D99614: [flang] Update list-input test to use GTest.

Use more descriptive variable names and better comment tests. Address clang-tidy warnings and phabricator reviews.

Apr 9 2021, 4:52 PM · Restricted Project, Restricted Project

Apr 6 2021

ashermancinelli accepted D99645: [flang][driver] Add debug options not requiring semantic checks.
Apr 6 2021, 10:46 AM · Restricted Project, Restricted Project
ashermancinelli accepted D99353: [driver] Make `clang` warn rather then error on `flang` options.
Apr 6 2021, 10:22 AM · Restricted Project, Restricted Project
ashermancinelli added inline comments to D99645: [flang][driver] Add debug options not requiring semantic checks.
Apr 6 2021, 10:20 AM · Restricted Project, Restricted Project

Apr 5 2021

ashermancinelli updated the diff for D99614: [flang] Update list-input test to use GTest.

Break original test into two test cases. Add simple sanity-check test cases. Add death test to verify failure message.

Apr 5 2021, 2:24 PM · Restricted Project, Restricted Project

Mar 30 2021

ashermancinelli added a reviewer for D99614: [flang] Update list-input test to use GTest: klausler.
Mar 30 2021, 12:20 PM · Restricted Project, Restricted Project
ashermancinelli added a comment to D99614: [flang] Update list-input test to use GTest.

If deemed reasonable, I'm happy to extend this to test more of the api as well - I'm open to suggestions. I'm also happy to keep this patch very short.

Mar 30 2021, 11:38 AM · Restricted Project, Restricted Project
ashermancinelli requested review of D99614: [flang] Update list-input test to use GTest.
Mar 30 2021, 11:36 AM · Restricted Project, Restricted Project

Mar 29 2021

ashermancinelli updated the diff for D98303: [flang] Update output format test to use GTest.

Use GTest EXPECT_EQ over potentially ambiguous return value, redirect SUT IO to stderr.

Mar 29 2021, 8:53 AM · Restricted Project, Restricted Project

Mar 19 2021

ashermancinelli updated the diff for D98303: [flang] Update output format test to use GTest.

Fix header include order.

Mar 19 2021, 12:09 PM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D98303: [flang] Update output format test to use GTest.

Fix clang-format and clang-tidy warnings.

Mar 19 2021, 10:38 AM · Restricted Project, Restricted Project
ashermancinelli added a comment to D98303: [flang] Update output format test to use GTest.

@klausler D98652 hopefully demonstrates that runtime crashes are caught by death tests. This revision has been rebased on D98652 - I hope this sufficiently demonstrates that these tests accurately catch crashes. We could also work on another patch that intentionally crashes each of the APIs tested above not already tested in D98652.

I wasn't asking about crashes in the runtime. I was asking about catching incorrect results and reporting failures.

I will try again. If you modify the decimal or runtime library in such a way as to cause f18 to emit incorrectly formatted results, does your rewritten test fail? Let me know when you have confirmed this by observation.

Mar 19 2021, 10:35 AM · Restricted Project, Restricted Project

Mar 18 2021

ashermancinelli added a comment to D98303: [flang] Update output format test to use GTest.

@klausler D98652 hopefully demonstrates that runtime crashes are caught by death tests. This revision has been rebased on D98652 - I hope this sufficiently demonstrates that these tests accurately catch crashes. We could also work on another patch that intentionally crashes each of the APIs tested above not already tested in D98652.

Mar 18 2021, 4:08 PM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D98303: [flang] Update output format test to use GTest.

Rebase on recent main branch to incorporate terminator crash tests

Mar 18 2021, 4:05 PM · Restricted Project, Restricted Project

Mar 17 2021

ashermancinelli added inline comments to D98652: [flang] Unittests for runtime terminator.
Mar 17 2021, 10:33 AM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D98652: [flang] Unittests for runtime terminator.

Remove superfluous comments

Mar 17 2021, 10:30 AM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D98652: [flang] Unittests for runtime terminator.

Fix header guards to conform to LLVM style guide

Mar 17 2021, 10:26 AM · Restricted Project, Restricted Project

Mar 16 2021

ashermancinelli updated the diff for D98652: [flang] Unittests for runtime terminator.

More thoroughly comment runtime crash tests.

Mar 16 2021, 1:30 PM · Restricted Project, Restricted Project

Mar 15 2021

ashermancinelli added a comment to D98601: [flang][unittest] Add unit tests for runtime's crash handler.

I have submitted D98652 to discuss similar efforts.

Mar 15 2021, 12:49 PM · Restricted Project, Restricted Project
ashermancinelli requested review of D98652: [flang] Unittests for runtime terminator.
Mar 15 2021, 12:48 PM · Restricted Project, Restricted Project
ashermancinelli added a comment to D98601: [flang][unittest] Add unit tests for runtime's crash handler.

@awarzynski I've actually been working on a similar patch, perhaps we could merge our efforts?

Mar 15 2021, 11:30 AM · Restricted Project, Restricted Project
ashermancinelli added a comment to D98601: [flang][unittest] Add unit tests for runtime's crash handler.

These tests seem to adequately verify the runtime crash mechanism and would support other gtest tests that must catch runtime crashes.

Mar 15 2021, 7:16 AM · Restricted Project, Restricted Project

Mar 14 2021

ashermancinelli added a comment to D98553: [flang] Runtime: implement INDEX intrinsic function.

LGTM

Mar 14 2021, 2:43 PM · Restricted Project, Restricted Project

Mar 10 2021

ashermancinelli added a comment to D98303: [flang] Update output format test to use GTest.

@klausler I think I better understand your concerns now. How would you feel about this patch if I un-removed the original test, we refine this test, and ten

Mar 10 2021, 2:37 PM · Restricted Project, Restricted Project
ashermancinelli added a comment to D98303: [flang] Update output format test to use GTest.

@klausler I reproduce all of the same test cases, so the test coverage should be identical and should catch all of the same bugs. I'd like to increase coverage, but the patch as-is should keep it the same.

Mar 10 2021, 10:04 AM · Restricted Project, Restricted Project
ashermancinelli updated the diff for D98303: [flang] Update output format test to use GTest.

Use fully qualified auto to address clang-tidy warnings.

Mar 10 2021, 8:23 AM · Restricted Project, Restricted Project