- User Since
- Feb 16 2021, 6:34 PM (11 w, 2 d)
Tue, Apr 27
Sun, Apr 25
Notice that in PrescanAndSemaAction, the first check fails with a scanning error, and the second with a parsing error. This is not the case for PrescanAndParseAction, which makes me think the second check should fail with a parsing error, and the tests should be adjusted in the same way.
Fri, Apr 23
Thanks again for the rigorous review!
Pull all of previous test harness into current implementation.
Resolve warnings against const auto without &.
Thu, Apr 22
Remove erroneous static qualifiers. Register all tests with crash handler.
Tue, Apr 20
Merged in commit 080d48f279e2.
Resolve warnings by removing utility function.
Mon, Apr 19
Merged in ccef0adc5968.
Thu, Apr 15
Wed, Apr 14
Mon, Apr 12
Use more descriptive variable names.
@awarzynski Thanks again for the review! I have another patch ready to address this.
Fri, Apr 9
@awarzynski Thank you for the fantastic review comments! I've tried to address most of them - please let me know if this looks good to you.
Use more descriptive variable names and better comment tests. Address clang-tidy warnings and phabricator reviews.
Apr 6 2021
Apr 5 2021
Break original test into two test cases. Add simple sanity-check test cases. Add death test to verify failure message.
Mar 30 2021
If deemed reasonable, I'm happy to extend this to test more of the api as well - I'm open to suggestions. I'm also happy to keep this patch very short.
Mar 29 2021
Use GTest EXPECT_EQ over potentially ambiguous return value, redirect SUT IO to stderr.
Mar 19 2021
Fix header include order.
Fix clang-format and clang-tidy warnings.
Mar 18 2021
@klausler D98652 hopefully demonstrates that runtime crashes are caught by death tests. This revision has been rebased on D98652 - I hope this sufficiently demonstrates that these tests accurately catch crashes. We could also work on another patch that intentionally crashes each of the APIs tested above not already tested in D98652.
Rebase on recent main branch to incorporate terminator crash tests
Mar 17 2021
Remove superfluous comments
Fix header guards to conform to LLVM style guide
Mar 16 2021
More thoroughly comment runtime crash tests.
Mar 15 2021
I have submitted D98652 to discuss similar efforts.
@awarzynski I've actually been working on a similar patch, perhaps we could merge our efforts?
These tests seem to adequately verify the runtime crash mechanism and would support other gtest tests that must catch runtime crashes.
Mar 14 2021
Mar 10 2021
@klausler I think I better understand your concerns now. How would you feel about this patch if I un-removed the original test, we refine this test, and ten
@klausler I reproduce all of the same test cases, so the test coverage should be identical and should catch all of the same bugs. I'd like to increase coverage, but the patch as-is should keep it the same.
Use fully qualified auto to address clang-tidy warnings.
Mar 9 2021
Mar 8 2021
Mar 7 2021
ALL_CAPS is usually reserved for macros...
but we should follow the existing precedent in the project...
Mar 4 2021
I've added tests for scan and verify functions, and cleaned up the comparison tests. I think the std::get method is a bit cleaner than what we had before, but I would love to hear other opinions on this.
@awarzynski Sure! I'll add corresponding tests and have another patch up soon.
Mar 3 2021
It is unintuitive to me that we are mixing feature and action flags, however I don't have a better suggestion. LGTM.
Mar 1 2021
Updated documentation, added a new test case based on conversation in the previous diff, and removed old character tests.
Feb 28 2021
Feb 26 2021
- Templated character tests over all char types
- Removed unneeded fixture
- Documentation and better naming
Feb 25 2021
Thank you for the review! It appears that many of your comments are due to lack of attention to detail when moving the test bodies over from the old runtime tests directory to this one (eg your comments on lines 28 and 52) - I'll revisit all of your comments and see where I can improve upon the old tests as well.
Feb 24 2021
I no longer modify anything in the old runtime tests directory, so this patch should be much more straightforward.
@awarzynski Looks like I mistakenly abandoned the last revision for this. Should I keep this one open or should we stick to the abandoned one since you've already added other reviewers to it?