Page MenuHomePhabricator

[RISCV] Add helper function to share some of the code for isel of vector load/store intrinsics.
ClosedPublic

Authored by craig.topper on Apr 5 2021, 10:26 PM.

Details

Summary

Many of the operands are handled the same or in the same order
for all these intrinsics. Factor out the code for selecting and
pushing them into the Operands vector.

Diff Detail

Event Timeline

craig.topper created this revision.Apr 5 2021, 10:26 PM
craig.topper requested review of this revision.Apr 5 2021, 10:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2021, 10:26 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
This revision is now accepted and ready to land.Apr 5 2021, 11:55 PM
frasercrmck accepted this revision.Apr 6 2021, 12:53 AM

LGTM other than that nit.

llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
255–256

nit: having this function placed after its "load" uses but before its "store" uses is a little odd, and I think it's making the diff a little harder to read.