Page MenuHomePhabricator

[mlir][spirv] Add utilities for push constant value
ClosedPublic

Authored by antiagainst on Apr 1 2021, 6:48 AM.

Details

Summary

This commit add utility functions for creating push constant
storage variable and loading values from it.

Along the way, performs some clean up:

  • Deleted setABIAttrs, which is just a 4-liner function with one user.
  • Moved SPIRVConverstionTarget into mlir namespace, to be consistent with SPIRVTypeConverter and LLVMConversionTarget.

Diff Detail

Event Timeline

antiagainst created this revision.Apr 1 2021, 6:48 AM
antiagainst requested review of this revision.Apr 1 2021, 6:48 AM

These utility functions has been used in IREE for a while. Upstream them now.

antiagainst edited the summary of this revision. (Show Details)Apr 1 2021, 6:57 AM
mravishankar accepted this revision.Apr 1 2021, 2:30 PM
This revision is now accepted and ready to land.Apr 1 2021, 2:30 PM
This revision was automatically updated to reflect the committed changes.