This is an archive of the discontinued LLVM Phabricator instance.

[testsuite] Make testsuite more stable vs canonicalization change. NFC.
ClosedPublic

Authored by lattner on Mar 19 2021, 5:58 PM.

Diff Detail

Event Timeline

lattner created this revision.Mar 19 2021, 5:58 PM
lattner requested review of this revision.Mar 19 2021, 5:58 PM

This is staging in the mechanical testsuite parts of the canonicalizer change that got reverted in a way that works both before-and-after that change.

rriddle accepted this revision.Mar 19 2021, 6:01 PM

Can you link to the accompanying canonicalizer revision?

mlir/test/Conversion/VectorToSCF/vector-to-loops.mlir
383

Why drop these?

This revision is now accepted and ready to land.Mar 19 2021, 6:01 PM

The canonicalizer changes are from this patch (which got reverted):
https://reviews.llvm.org/rGb5d9a3c92358349d5444ab28de8ab5b2bee33a01

I'll reapply them in a follow-on. I'll also address the comments above, thanks!

lattner updated this revision to Diff 332045.Mar 19 2021, 6:09 PM
lattner marked an inline comment as done.

Fix dropped check lines

This revision was landed with ongoing or failed builds.Mar 19 2021, 6:12 PM
This revision was automatically updated to reflect the committed changes.