Page MenuHomePhabricator

[AMDGPU] Rename SIInsertSkips Pass
ClosedPublic

Authored by critson on Mar 18 2021, 8:20 PM.

Details

Summary

Pass no longer handles skips. Pass now removes unnecessary
unconditional branches and lowers early termination branches.
Hence rename to SILateBranchLowering.

Move code to handle returns to epilog from SIPreEmitPeephole
into SILateBranchLowering. This means SIPreEmitPeephole only
contains optional optimisations, and all required transforms
are in SILateBranchLowering.

Diff Detail

Event Timeline

critson created this revision.Mar 18 2021, 8:20 PM
critson requested review of this revision.Mar 18 2021, 8:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2021, 8:20 PM
foad added a comment.Mar 19 2021, 2:04 AM

Seems fine to me but I'll leave it for someone who knows this code better to accept it.

arsenm accepted this revision.Mar 19 2021, 6:13 AM

I still think something is off where we need yet another control flow lowering pass, but that's a battle for another day. This at least makes the name less misleading

This revision is now accepted and ready to land.Mar 19 2021, 6:13 AM
This revision was landed with ongoing or failed builds.Mar 19 2021, 7:56 PM
This revision was automatically updated to reflect the committed changes.