This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][CMake] Support powerpc32 on Linux
ClosedPublic

Authored by pattop on Mar 17 2021, 5:49 PM.

Download Raw Diff

Details

Reviewers

daltenty
chmeee
joerg
MaskRay

Commits

rG30029e7407c8: [compiler-rt][CMake] Support powerpc32 on Linux

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

pattop created this revision.Mar 17 2021, 5:49 PM

Herald added subscribers: shchenz, mgorny, dberris, nemanjai. · View Herald TranscriptMar 17 2021, 5:49 PM

pattop requested review of this revision.Mar 17 2021, 5:49 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2021, 5:49 PM

Herald added a subscriber: Restricted Project. · View Herald Transcript

Harbormaster completed remote builds in B94363: Diff 331428.Mar 17 2021, 6:46 PM

Can you please add a description to this patch describing what this is meant to acomplish, what PPC 32-bit platforms you plan to enable this on. Also, whether this is expected to increase build/test times on the PPC big endian bots, etc.

glaubitz added a subscriber: glaubitz.May 26 2021, 4:35 AM

pattop mentioned this in D98836: [compiler-rt][CMake] Support powerpcspe build.May 26 2021, 3:44 PM

Hi nemanjai, I needed this, D98836 and D98833 to put together a powerpcspe-linux toolchain.

I don't know anything about bots so can't help there sorry.

Supporting new configurations by deleting code is nice.

This revision is now accepted and ready to land.Nov 26 2021, 1:22 PM

MaskRay retitled this revision from [compiler-rt] support powerpc32 on Linux to [compiler-rt][CMake] Support powerpc32 on Linux.Nov 26 2021, 1:24 PM

Closed by commit rG30029e7407c8: [compiler-rt][CMake] Support powerpc32 on Linux (authored by pattop, committed by MaskRay). · Explain WhyNov 26 2021, 1:28 PM

This revision was automatically updated to reflect the committed changes.

MaskRay added a commit: rG30029e7407c8: [compiler-rt][CMake] Support powerpc32 on Linux.

Revision Contents

Path

Size

compiler-rt/

cmake/

base-config-ix.cmake

4 lines

Diff 390115

compiler-rt/cmake/base-config-ix.cmake

Show First 20 Lines • Show All 207 Lines • ▼ Show 20 Lines	elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "i[2-6]86\|x86\|amd64")
test_target_arch(i386 "" "")		test_target_arch(i386 "" "")
else()		else()
test_target_arch(x86_64 "" "")		test_target_arch(x86_64 "" "")
endif()		endif()
endif()		endif()
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc64le\|ppc64le")		elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc64le\|ppc64le")
test_target_arch(powerpc64le "" "-m64")		test_target_arch(powerpc64le "" "-m64")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc")		elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "powerpc")
if(CMAKE_SYSTEM_NAME MATCHES "AIX")
test_target_arch(powerpc "" "-m32")		test_target_arch(powerpc "" "-m32")
endif()
test_target_arch(powerpc64 "" "-m64")		test_target_arch(powerpc64 "" "-m64")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "s390x")		elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "s390x")
test_target_arch(s390x "" "")		test_target_arch(s390x "" "")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc")		elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc")
test_target_arch(sparc "" "-m32")		test_target_arch(sparc "" "-m32")
test_target_arch(sparcv9 "" "-m64")		test_target_arch(sparcv9 "" "-m64")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "mipsel\|mips64el")		elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "mipsel\|mips64el")
# Gcc doesn't accept -m32/-m64 so we do the next best thing and use		# Gcc doesn't accept -m32/-m64 so we do the next best thing and use
Show All 35 Lines