Page MenuHomePhabricator

pattop (Patrick Oppenlander)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2021, 4:31 PM (38 w, 6 d)

Recent Activity

Jul 13 2021

pattop added a comment to D105869: [Driver] fix PowerPC SPE musl dynamic linker name.

Here is the corresponding gcc patch:

Jul 13 2021, 4:48 PM · Restricted Project

Jul 12 2021

pattop requested review of D105869: [Driver] fix PowerPC SPE musl dynamic linker name.
Jul 12 2021, 10:03 PM · Restricted Project

May 26 2021

pattop added a comment to D98833: [compiler-rt] enable crt support on ppc32.

Hi nemanjai, not sure about PPC64. I needed this to put together a powerpcspe-linux toolchain.

May 26 2021, 4:06 PM · Restricted Project
pattop added a comment to D98831: [compiler-rt] support powerpc32 on Linux.

Hi nemanjai, I needed this, D98836 and D98833 to put together a powerpcspe-linux toolchain.

May 26 2021, 4:04 PM · Restricted Project
pattop added a comment to D98836: [compiler-rt] support powerpcspe build.

Hi Justin, I also needed D98831 and D98833 to get compiler-rt to build for a powerpcspe Linux toolchain.

May 26 2021, 3:44 PM · Restricted Project

May 18 2021

pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Another ping to see if there's anything else I can do to get this across the line.

May 18 2021, 9:58 PM · Restricted Project

Mar 17 2021

pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

I have cleaned up D95198 too. IMHO the change is now much clearer.

Mar 17 2021, 10:50 PM · Restricted Project
pattop updated the summary of D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.
Mar 17 2021, 10:47 PM · Restricted Project
pattop updated the summary of D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.
Mar 17 2021, 10:47 PM · Restricted Project
pattop updated the diff for D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

Reduce changes, update test, clarify intent.

Mar 17 2021, 10:46 PM · Restricted Project
pattop updated the diff for D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Minor fix - used CHECK instead of CHECK-NEXT in during rework.

Mar 17 2021, 8:49 PM · Restricted Project
pattop requested review of D98836: [compiler-rt] support powerpcspe build.
Mar 17 2021, 6:35 PM · Restricted Project
pattop requested review of D98833: [compiler-rt] enable crt support on ppc32.
Mar 17 2021, 5:57 PM · Restricted Project
pattop requested review of D98831: [compiler-rt] support powerpc32 on Linux.
Mar 17 2021, 5:49 PM · Restricted Project
pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

I have updated the description (summary?) to hopefully more clearly convey the intent.

Mar 17 2021, 5:26 PM · Restricted Project
pattop retitled D95199: [ELF] Improve compatibility with ld.bfd linker scripts from [ELF] Write output sections in PT_LOAD segment order to [ELF] Improve compatibility with ld.bfd linker scripts.
Mar 17 2021, 5:25 PM · Restricted Project
pattop updated the diff for D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Address MaskRay feedback.

Mar 17 2021, 5:24 PM · Restricted Project

Mar 16 2021

pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Just a quick ping on this to see if there's any more feedback.

Mar 16 2021, 4:34 PM · Restricted Project

Feb 17 2021

pattop added a comment to D96574: libcxxabi: add builtins to dynamic library link.

Patrick Oppenlander <patrick.oppenlander@gmail.com>

Feb 17 2021, 2:06 PM · Restricted Project
pattop added a comment to D96574: libcxxabi: add builtins to dynamic library link.

I don't have commit access so someone else will need to commit.

Feb 17 2021, 1:24 PM · Restricted Project

Feb 11 2021

pattop requested review of D96574: libcxxabi: add builtins to dynamic library link.
Feb 11 2021, 8:10 PM · Restricted Project

Feb 8 2021

pattop updated the diff for D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Thanks for the feedback!

Feb 8 2021, 9:22 PM · Restricted Project
pattop added inline comments to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.
Feb 8 2021, 3:22 PM · Restricted Project

Feb 4 2021

pattop updated the diff for D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Maintain section address order as much as possible when assigning file offsets.

Feb 4 2021, 9:42 PM · Restricted Project
pattop added inline comments to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.
Feb 4 2021, 9:35 PM · Restricted Project

Feb 1 2021

pattop updated the diff for D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

Use smaller address in test case.

Feb 1 2021, 2:53 PM · Restricted Project
pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Thanks for the update, I'll try and take a look later in the week. Will have to have a think about the zero size section case. If we haven't assigned it to a PT_LOAD and it defines no symbol it may be possible to not put it in the object file.

Feb 1 2021, 2:19 PM · Restricted Project

Jan 31 2021

pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I can think of a few times I've encountered this on nommu targets. Some examples:

Jan 31 2021, 10:44 PM · Restricted Project
pattop updated the diff for D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

Use a smaller address in test case. This means that if something goes wrong we don't try to make a huge file.

Jan 31 2021, 9:15 PM · Restricted Project
pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Not sure why my comments were automatically marked as done.

Jan 31 2021, 8:42 PM · Restricted Project
pattop updated the diff for D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Updated comments.
Add assertion that all sections in a load segment must be allocated.
Fix tbss.s test case.

Jan 31 2021, 8:40 PM · Restricted Project
pattop added inline comments to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.
Jan 31 2021, 8:22 PM · Restricted Project
pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

Thanks for taking the time to review.

Jan 31 2021, 7:19 PM · Restricted Project
pattop added inline comments to D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.
Jan 31 2021, 2:23 PM · Restricted Project

Jan 28 2021

pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I've also found no good reason why BFD ld forces the program headers to reside in the first PT_LOAD segment. This change was based on that logic.

Jan 28 2021, 5:08 PM · Restricted Project
pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I agree that the description could be better. Looks like I fixated on the "could not allocate headers" error message when I wrote it.

Jan 28 2021, 5:01 PM · Restricted Project

Jan 27 2021

pattop added a comment to D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

I forgot to mention that I do not have commit access. If this is acceptable someone else will need to commit on my behalf. Thanks again.

Jan 27 2021, 4:28 PM · Restricted Project
pattop added a comment to D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

Yes, this came from a real use case.

Jan 27 2021, 4:24 PM · Restricted Project
pattop requested review of D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.
Jan 27 2021, 3:35 PM · Restricted Project

Jan 26 2021

pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I'm not clear on what the requirements are here.

Jan 26 2021, 3:04 PM · Restricted Project

Jan 23 2021

pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

In fact, if https://reviews.llvm.org/D95198 is acceptable it is a separate justification for this change. In order to place program headers somewhere other than the lowest VMA in the program image something like this needs to happen.

Both this patch and D95198 look a bit arbitrary to me. Please see my question in D95198. Also adding @grimar who has improved linker scripts a lot.

Jan 23 2021, 12:28 AM · Restricted Project
pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

Thankyou for taking the time to review and comment.

Jan 23 2021, 12:03 AM · Restricted Project

Jan 21 2021

pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

In fact, if https://reviews.llvm.org/D95198 is acceptable it is a separate justification for this change. In order to place program headers somewhere other than the lowest VMA in the program image something like this needs to happen.

Jan 21 2021, 9:49 PM · Restricted Project
pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

If the direction of the patch is acceptable I can provide a detailed analysis of each required testcase adjustment.

Jan 21 2021, 9:39 PM · Restricted Project
pattop added a comment to D95199: [ELF] Improve compatibility with ld.bfd linker scripts.

For out-of-order-sections.s, you could just swap foo and bar.

Jan 21 2021, 9:36 PM · Restricted Project
pattop requested review of D95199: [ELF] Improve compatibility with ld.bfd linker scripts.
Jan 21 2021, 7:04 PM · Restricted Project
pattop requested review of D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.
Jan 21 2021, 7:03 PM · Restricted Project