- User Since
- Jan 21 2021, 4:31 PM (38 w, 6 d)
Jul 13 2021
Here is the corresponding gcc patch:
Jul 12 2021
May 26 2021
Hi nemanjai, not sure about PPC64. I needed this to put together a powerpcspe-linux toolchain.
May 18 2021
Another ping to see if there's anything else I can do to get this across the line.
Mar 17 2021
I have cleaned up D95198 too. IMHO the change is now much clearer.
Reduce changes, update test, clarify intent.
Minor fix - used CHECK instead of CHECK-NEXT in during rework.
I have updated the description (summary?) to hopefully more clearly convey the intent.
Address MaskRay feedback.
Mar 16 2021
Just a quick ping on this to see if there's any more feedback.
Feb 17 2021
Patrick Oppenlander <firstname.lastname@example.org>
I don't have commit access so someone else will need to commit.
Feb 11 2021
Feb 8 2021
Thanks for the feedback!
Feb 4 2021
Maintain section address order as much as possible when assigning file offsets.
Feb 1 2021
Use smaller address in test case.
Jan 31 2021
I can think of a few times I've encountered this on nommu targets. Some examples:
Use a smaller address in test case. This means that if something goes wrong we don't try to make a huge file.
Not sure why my comments were automatically marked as done.
Add assertion that all sections in a load segment must be allocated.
Fix tbss.s test case.
Thanks for taking the time to review.
Jan 28 2021
I've also found no good reason why BFD ld forces the program headers to reside in the first PT_LOAD segment. This change was based on that logic.
I agree that the description could be better. Looks like I fixated on the "could not allocate headers" error message when I wrote it.
Jan 27 2021
I forgot to mention that I do not have commit access. If this is acceptable someone else will need to commit on my behalf. Thanks again.
Yes, this came from a real use case.
Jan 26 2021
Jan 23 2021
Thankyou for taking the time to review and comment.
Jan 21 2021
In fact, if https://reviews.llvm.org/D95198 is acceptable it is a separate justification for this change. In order to place program headers somewhere other than the lowest VMA in the program image something like this needs to happen.
If the direction of the patch is acceptable I can provide a detailed analysis of each required testcase adjustment.