Page MenuHomePhabricator

[MLIR][SPIRV] Rename `spv.module` to `spv.mlir.module`.
AbandonedPublic

Authored by ergawy on Mar 5 2021, 1:10 AM.

Details

Summary

To unify the naming scheme across all ops in the SPIR-V dialect, we are
moving from spv.camelCase to spv.CamelCase everywhere. For ops that
don't have a SPIR-V spec counterpart, we use spv.mlir.snake_case.

Diff Detail

Unit TestsFailed

TimeTest
60 msx64 debian > LLVM.CodeGen/X86/AMX::amx-low-intrinsics-no-amx-bitcast.ll
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -mtriple=x86_64 -lower-amx-intrinsics /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/X86/AMX/amx-low-intrinsics-no-amx-bitcast.ll -S | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/X86/AMX/amx-low-intrinsics-no-amx-bitcast.ll
60 msx64 debian > LLVM.CodeGen/X86/AMX::amx-low-intrinsics.ll
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -mtriple=x86_64 -lower-amx-intrinsics /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/X86/AMX/amx-low-intrinsics.ll -S | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/X86/AMX/amx-low-intrinsics.ll

Event Timeline

ergawy created this revision.Mar 5 2021, 1:10 AM
ergawy requested review of this revision.Mar 5 2021, 1:10 AM

Actually we can probably keep spv.module as-is. Similarly to spv.func, they maintain consistency with other module/func op names. What do you think?

ergawy abandoned this revision.Mar 6 2021, 6:39 AM

Actually we can probably keep spv.module as-is. Similarly to spv.func, they maintain consistency with other module/func op names. What do you think?

Yes, that makes sense. I will abandon then.