User Details
- User Since
- Feb 9 2017, 1:26 AM (205 w, 1 d)
Sun, Jan 10
Nice! Actually last Friday I was looking into seeing whether doing the same would be beneficial for SPIRVOps.cpp. Using -ftime-trace shows that it takes ~19 seconds to cleanly compile it. Most of that time ~13 is spent in the backend. So I guess parallelized compilation can be beneficial here as well. If you aren't planning to do that already, I can split it.
Handle review comments.
Fri, Jan 8
Thu, Jan 7
Handle review comments:
Wed, Jan 6
Handle some formatting comments.
Tue, Jan 5
Add a new header for Op traits.
Mon, Jan 4
Rebase and bing! :).
Thu, Dec 24
Rebase.
Wed, Dec 23
Handle some minor clang-tidy comments.
Add missing header guard.
Remove empty line.
Fix file organization issue.
- Split GLSL-specific patterns in their own file.
- Add a test pass to test them.
Tue, Dec 22
Mon, Dec 21
2 things I still need to figure out/need to make sure I got right:
- How to enable these patterns only when the GLSL.std.450 extension is enabled?
- Whether you think it's suitable to consider these rewrites as canonicalization patterns or we should move them somewhere else?
Sun, Dec 20
Add more comments.
Dec 16 2020
Rebase to see if CI bug is resolved.
Dec 15 2020
Probably this hits a CI bug: https://github.com/google/llvm-premerge-checks/issues/268.
Rebase and erase extra space.
Revert unneeded changes.
- Add more traits to aid verification.
- Change custom syntax.
Dec 11 2020
Friendly reminder to land this :). I would like to add (de-)serialization support for OpSpecConstantOp and conflicts will be easier to handle if this patch is merged before I start. If you need to wait on this one for a bit more, then no problem I will work on my new patch and handle conflicts later.
Rebase.
Dec 9 2020
Dec 8 2020
Dec 7 2020
- Add IsolatedFromAbove trait to spv.SpecConstantOperation.
Dec 6 2020
Rebase.
Dec 2 2020
Handle review comments.
Dec 1 2020
I don't have commit access. Please commit on my behalf whenever you like.
Nov 30 2020
Rename to spv.mlir.yield.
Nov 27 2020
This is an initial patch to make sure I didn't anything disastrously wrong :D.
Nov 19 2020
Rename to endmodule.
- Rename to moduleend instead.
- Add missing check in deduplication code.
- Handle review comment.
- Rebase.
Nov 18 2020
Fix header guards.
Re-organize files a bit differently.
Nov 17 2020
Fix mistake due to batch editing using sed.
Fix mistake due to batch editing using sed.
Rename to addressof instead of address_of.
I think this should be actually renamed to spv.mlir.addressof to be truly consistent the style used in the llvm dialect. Are there any objections to this? If not, I will do as such.
Nov 16 2020
Nov 13 2020
Thanks for taking the time to review.
Handle further comments.
Handle review comments.
Nov 12 2020
Rebase.
Nov 10 2020
Nov 9 2020
Some minor re-formatting.
Rebase
Nov 6 2020
Abandoned in favor of: https://reviews.llvm.org/D90951
Abandoned in favor of: https://reviews.llvm.org/D90951
General comment regarding this patch as well as this: https://reviews.llvm.org/D90932.
Nov 5 2020
I am not familiar with the implicit conversion rules within the spv dialect (or MLIR in general). But, I was expecting that replacing all uses of bar with foo in the following to snippet to fail:
- Remove unneeded comment.