Page MenuHomePhabricator

ergawy (Kareem Ergawy)
Spy

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:26 AM (226 w, 4 d)

Recent Activity

Thu, Jun 3

ergawy requested review of D103594: [MLIR][SPIRV] Use getAsmResultName(...) hook for AddressOfOp..
Thu, Jun 3, 1:03 AM · Restricted Project

Thu, May 27

ergawy added inline comments to D103152: [MLIR][SPIRV] Use getAsmResultName(...) hook for ConstantOp..
Thu, May 27, 9:03 AM · Restricted Project
ergawy updated the diff for D103152: [MLIR][SPIRV] Use getAsmResultName(...) hook for ConstantOp..

Handle review comments.

Thu, May 27, 9:03 AM · Restricted Project

Wed, May 26

ergawy requested review of D103152: [MLIR][SPIRV] Use getAsmResultName(...) hook for ConstantOp..
Wed, May 26, 3:51 AM · Restricted Project

May 7 2021

ergawy abandoned D102050: [MLIR][LinAlg] Fix a small compilation error..

Abandoned in favor of: D102055.

May 7 2021, 7:01 AM · Restricted Project
ergawy accepted D102055: [mlir][linalg] Remove redundant indexOp builder..

Thanks I will abandon my review. This fixes the issue for me.

May 7 2021, 7:00 AM · Restricted Project
ergawy added a comment to D102050: [MLIR][LinAlg] Fix a small compilation error..

I use: Apple clang version 11.0.3.

May 7 2021, 12:46 AM · Restricted Project
ergawy added a comment to D102050: [MLIR][LinAlg] Fix a small compilation error..

I might have misunderstood something. Let me know if I should abandon this in case this a local issue on my machine or there is a better solution.

May 7 2021, 12:39 AM · Restricted Project
ergawy added inline comments to rG26e916334ebc: [mlir][linalg] Add IndexedGenericOp to GenericOp canonicalization..
May 7 2021, 12:35 AM
ergawy added a reviewer for D102050: [MLIR][LinAlg] Fix a small compilation error.: gysit.
May 7 2021, 12:33 AM · Restricted Project
ergawy requested review of D102050: [MLIR][LinAlg] Fix a small compilation error..
May 7 2021, 12:32 AM · Restricted Project
ergawy committed rGe4dee7e7309a: [MLIR][SPIRV] Properly (de-)serialize BranchConditionalOp. (authored by ergawy).
[MLIR][SPIRV] Properly (de-)serialize BranchConditionalOp.
May 7 2021, 12:01 AM
ergawy closed D101602: [MLIR][SPIRV] Properly (de-)serialize BranchConditionalOp..
May 7 2021, 12:01 AM · Restricted Project

May 6 2021

ergawy updated the diff for D101602: [MLIR][SPIRV] Properly (de-)serialize BranchConditionalOp..

Handle review comments.

May 6 2021, 11:58 PM · Restricted Project

Apr 30 2021

ergawy requested review of D101602: [MLIR][SPIRV] Properly (de-)serialize BranchConditionalOp..
Apr 30 2021, 1:18 AM · Restricted Project

Apr 20 2021

ergawy committed rG0b05207e45ef: [MLIR][LinAlg] Detensoring CF cost-model: look forward. (authored by ergawy).
[MLIR][LinAlg] Detensoring CF cost-model: look forward.
Apr 20 2021, 12:02 AM
ergawy closed D100457: [MLIR][LinAlg] Detensoring CF cost-model: look forward..
Apr 20 2021, 12:02 AM · Restricted Project
ergawy updated the diff for D100457: [MLIR][LinAlg] Detensoring CF cost-model: look forward..

Add more detailed docs.

Apr 20 2021, 12:00 AM · Restricted Project

Apr 16 2021

ergawy added inline comments to D100457: [MLIR][LinAlg] Detensoring CF cost-model: look forward..
Apr 16 2021, 12:37 AM · Restricted Project
ergawy updated the diff for D100457: [MLIR][LinAlg] Detensoring CF cost-model: look forward..

Handle review comments:

  • Fold the 2 phases of the cost-mode into one.
Apr 16 2021, 12:35 AM · Restricted Project

Apr 14 2021

ergawy added inline comments to D100457: [MLIR][LinAlg] Detensoring CF cost-model: look forward..
Apr 14 2021, 2:15 AM · Restricted Project
ergawy added a reviewer for D100457: [MLIR][LinAlg] Detensoring CF cost-model: look forward.: silvas.
Apr 14 2021, 2:13 AM · Restricted Project
ergawy requested review of D100457: [MLIR][LinAlg] Detensoring CF cost-model: look forward..
Apr 14 2021, 2:13 AM · Restricted Project

Apr 13 2021

ergawy committed rGaa6eb2af1009: [MLIR][LinAlg] Implement detensoring cost-modelling. (authored by ergawy).
[MLIR][LinAlg] Implement detensoring cost-modelling.
Apr 13 2021, 12:11 AM
ergawy closed D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..
Apr 13 2021, 12:10 AM · Restricted Project

Apr 10 2021

ergawy added inline comments to D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..
Apr 10 2021, 12:25 AM · Restricted Project
ergawy updated the diff for D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..

Handle review comments.

Apr 10 2021, 12:25 AM · Restricted Project

Apr 9 2021

ergawy added inline comments to D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..
Apr 9 2021, 1:29 AM · Restricted Project
ergawy added inline comments to D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..
Apr 9 2021, 1:26 AM · Restricted Project
ergawy updated the diff for D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..

Add more tests.

Apr 9 2021, 1:25 AM · Restricted Project
ergawy added inline comments to D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..
Apr 9 2021, 12:44 AM · Restricted Project
ergawy updated the diff for D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..

Handle Sean's comments:

  • Refactor control-flow model.
  • Dedeuce branch op detensoring from block argument detensoring.
  • Add more docs.
Apr 9 2021, 12:43 AM · Restricted Project

Apr 7 2021

ergawy updated the diff for D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..

Handle rridle's comments:

  • Use ArrayRef for argument type.
  • Use function_ref instead of DenseMap.
  • Remove unneeded includes.
  • Avoid dynamic memory allocation.
Apr 7 2021, 1:29 AM · Restricted Project

Apr 6 2021

ergawy added reviewers for D99945: [MLIR][LinAlg] Implement detensoring cost-modelling.: silvas, rriddle.
Apr 6 2021, 4:37 AM · Restricted Project
ergawy requested review of D99945: [MLIR][LinAlg] Implement detensoring cost-modelling..
Apr 6 2021, 4:37 AM · Restricted Project

Mar 28 2021

ergawy committed rGc52a5f2aa796: MLIR][STD] Fold trunci (sexti). (authored by ergawy).
MLIR][STD] Fold trunci (sexti).
Mar 28 2021, 11:49 PM
ergawy closed D99464: MLIR][STD] Fold trunci (sexti)..
Mar 28 2021, 11:49 PM · Restricted Project
ergawy updated the diff for D99464: MLIR][STD] Fold trunci (sexti)..
  • Rearrange code a bit.
Mar 28 2021, 3:00 AM · Restricted Project
ergawy added a reviewer for D99464: MLIR][STD] Fold trunci (sexti).: mehdi_amini.
Mar 28 2021, 2:56 AM · Restricted Project
ergawy requested review of D99464: MLIR][STD] Fold trunci (sexti)..
Mar 28 2021, 2:56 AM · Restricted Project

Mar 27 2021

ergawy committed rGe5f2898bc751: [MLIR][STD] Fold trunci (zexti). (authored by ergawy).
[MLIR][STD] Fold trunci (zexti).
Mar 27 2021, 11:41 AM
ergawy closed D99453: [MLIR][STD] Fold trunci (zexti)..
Mar 27 2021, 11:41 AM · Restricted Project
ergawy added a comment to D99453: [MLIR][STD] Fold trunci (zexti)..

Should be valid with sexti as well right?

Mar 27 2021, 11:37 AM · Restricted Project
ergawy updated the summary of D99453: [MLIR][STD] Fold trunci (zexti)..
Mar 27 2021, 11:36 AM · Restricted Project
ergawy added a comment to D99453: [MLIR][STD] Fold trunci (zexti)..

Your folder does not do that actually. It is just the framework that does not perform such replacement for all folders.
(side note, you could write simply : If the type of trunci's destination does not match zexti's source types, no folding takes place. ; the intermediate type does not matter here)

Mar 27 2021, 11:36 AM · Restricted Project
ergawy updated the diff for D99453: [MLIR][STD] Fold trunci (zexti)..
  • Handle review comments.
  • Rebase.
Mar 27 2021, 11:35 AM · Restricted Project
ergawy added a reviewer for D99453: [MLIR][STD] Fold trunci (zexti).: rriddle.
Mar 27 2021, 3:34 AM · Restricted Project
ergawy added a comment to D99453: [MLIR][STD] Fold trunci (zexti)..

I came across this pattern while working on detensoring in linalg-on-tensors for IREE. Let me know if there are any reasons why this might be a bad idea.

Mar 27 2021, 3:33 AM · Restricted Project
ergawy requested review of D99453: [MLIR][STD] Fold trunci (zexti)..
Mar 27 2021, 3:32 AM · Restricted Project

Mar 16 2021

ergawy planned changes to D98330: [MLIR][SPIRV] Towards a consistent assembly scheme: GlobalVariable..

We will halt working on this until a discussion on a good assembly scheme is discussed with a wider audience.

Mar 16 2021, 4:41 AM · Restricted Project

Mar 10 2021

ergawy added a comment to D98330: [MLIR][SPIRV] Towards a consistent assembly scheme: GlobalVariable..

@antiagainst, 2 points:

  • I adopted the set of rules you suggested, we can refine them as we discuss on the review.
  • I tried to define GlobalVariable using the declarative format, but it seems that is not possible due to the optional directives: bind and built_in. Let me know if I misunderstood something.
Mar 10 2021, 3:15 AM · Restricted Project
ergawy requested review of D98330: [MLIR][SPIRV] Towards a consistent assembly scheme: GlobalVariable..
Mar 10 2021, 3:13 AM · Restricted Project

Mar 6 2021

ergawy committed rG3fb384d50ee1: [MLIR][SPIRV] Rename `spv.selection` to `spv.mlir.selection`. (authored by ergawy).
[MLIR][SPIRV] Rename `spv.selection` to `spv.mlir.selection`.
Mar 6 2021, 7:46 AM
ergawy closed D98014: [MLIR][SPIRV] Rename `spv.selection` to `spv.mlir.selection`..
Mar 6 2021, 7:46 AM · Restricted Project
ergawy updated the diff for D98014: [MLIR][SPIRV] Rename `spv.selection` to `spv.mlir.selection`..

Rebase.

Mar 6 2021, 7:41 AM · Restricted Project
ergawy abandoned D98017: [MLIR][SPIRV] Rename `spv.module` to `spv.mlir.module`..

Actually we can probably keep spv.module as-is. Similarly to spv.func, they maintain consistency with other module/func op names. What do you think?

Mar 6 2021, 6:39 AM · Restricted Project

Mar 5 2021

ergawy requested review of D98017: [MLIR][SPIRV] Rename `spv.module` to `spv.mlir.module`..
Mar 5 2021, 1:11 AM · Restricted Project
ergawy retitled D98016: [MLIR][SPIRV] Rename `spv.undef` to `spv.Undef`. from [MLIR][SPIRV] Rename `spv.selection` to `spv.mlir.selection`. to [MLIR][SPIRV] Rename `spv.undef` to `spv.Undef`..
Mar 5 2021, 1:00 AM · Restricted Project
ergawy requested review of D98016: [MLIR][SPIRV] Rename `spv.undef` to `spv.Undef`..
Mar 5 2021, 12:58 AM · Restricted Project
ergawy requested review of D98014: [MLIR][SPIRV] Rename `spv.selection` to `spv.mlir.selection`..
Mar 5 2021, 12:34 AM · Restricted Project
ergawy retitled D97918: [MLIR][SPIRV] Rename `spv.loop` to `spv.mlir.loop`. from [MLIR][SPIRV] Rename `spv.loop` to `spv.Loop`. to [MLIR][SPIRV] Rename `spv.loop` to `spv.mlir.loop`..
Mar 5 2021, 12:31 AM · Restricted Project

Mar 4 2021

ergawy updated the diff for D97918: [MLIR][SPIRV] Rename `spv.loop` to `spv.mlir.loop`..

Fix doc string.

Mar 4 2021, 11:38 PM · Restricted Project
ergawy updated the diff for D97918: [MLIR][SPIRV] Rename `spv.loop` to `spv.mlir.loop`..

Fix comments.

Mar 4 2021, 11:34 PM · Restricted Project
ergawy updated the diff for D97918: [MLIR][SPIRV] Rename `spv.loop` to `spv.mlir.loop`..

Rename to spv.mlir.loop.

Mar 4 2021, 11:31 PM · Restricted Project
ergawy requested review of D97920: [MLIR][SPIRV] Rename `spv.spcConstant...` to `spv.SpcConstant...`..
Mar 4 2021, 12:41 AM · Restricted Project
ergawy requested review of D97919: [MLIR][SPIRV] Rename `spv.globalVariable` to `spv.GlobalVariable`..
Mar 4 2021, 12:33 AM · Restricted Project
ergawy requested review of D97918: [MLIR][SPIRV] Rename `spv.loop` to `spv.mlir.loop`..
Mar 4 2021, 12:27 AM · Restricted Project
ergawy requested review of D97917: [MLIR][SPIRV] Rename `spv.constant` to `spv.Constant`..
Mar 4 2021, 12:16 AM · Restricted Project

Mar 2 2021

ergawy committed rG3b021fbdc04b: [MLIR][LinAlg] Detensorize interal function control flow. (authored by ergawy).
[MLIR][LinAlg] Detensorize interal function control flow.
Mar 2 2021, 2:49 AM
ergawy closed D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Mar 2 2021, 2:49 AM · Restricted Project
ergawy added inline comments to D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Mar 2 2021, 2:14 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..
  • Rebase.
  • Add a TODO.
Mar 2 2021, 2:13 AM · Restricted Project

Feb 28 2021

ergawy added inline comments to D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 28 2021, 3:54 AM · Restricted Project

Feb 26 2021

ergawy updated the summary of D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 26 2021, 12:17 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Rename function.

Feb 26 2021, 12:11 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Clean-up.

Feb 26 2021, 12:04 AM · Restricted Project
ergawy added inline comments to D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 26 2021, 12:02 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Handle review comments.

Feb 26 2021, 12:00 AM · Restricted Project

Feb 25 2021

ergawy added inline comments to D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 25 2021, 12:48 AM · Restricted Project
ergawy added inline comments to D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 25 2021, 12:13 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Handle some review comments.

Feb 25 2021, 12:13 AM · Restricted Project

Feb 24 2021

ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Handle review comments.

Feb 24 2021, 12:56 PM · Restricted Project
ergawy updated the summary of D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 24 2021, 1:45 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Update docs.

Feb 24 2021, 1:13 AM · Restricted Project
ergawy added reviewers for D97148: [MLIR][LinAlg] Detensorize interal function control flow.: silvas, rriddle.
Feb 24 2021, 1:10 AM · Restricted Project
ergawy retitled D97148: [MLIR][LinAlg] Detensorize interal function control flow. from {WIP: PLZ DON'T REVIEW YET}[MLIR][LinAlg] Detensorize interal CF. to [MLIR][LinAlg] Detensorize interal function control flow..
Feb 24 2021, 1:10 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Properly handle non-entry function blocks.

Feb 24 2021, 1:09 AM · Restricted Project

Feb 22 2021

ergawy committed rG67e0d58de4d3: [MLIR][LinAlg] Start detensoring implementation. (authored by ergawy).
[MLIR][LinAlg] Start detensoring implementation.
Feb 22 2021, 11:28 PM
ergawy closed D96271: [MLIR][LinAlg] Start detensoring implementation..
Feb 22 2021, 11:28 PM · Restricted Project

Feb 21 2021

ergawy added inline comments to D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 21 2021, 7:22 AM · Restricted Project
ergawy updated the diff for D97148: [MLIR][LinAlg] Detensorize interal function control flow..

Assert on 0 inputs.

Feb 21 2021, 7:02 AM · Restricted Project
ergawy requested review of D97148: [MLIR][LinAlg] Detensorize interal function control flow..
Feb 21 2021, 6:56 AM · Restricted Project

Feb 19 2021

ergawy updated the diff for D96271: [MLIR][LinAlg] Start detensoring implementation..

Simplify converted code by merging some blocks.

Feb 19 2021, 1:51 AM · Restricted Project
ergawy retitled D96271: [MLIR][LinAlg] Start detensoring implementation. from [WIP] -- [MLIR][LinAlg] Start detensoring implementation. to [MLIR][LinAlg] Start detensoring implementation..
Feb 19 2021, 12:23 AM · Restricted Project
ergawy updated the diff for D96271: [MLIR][LinAlg] Start detensoring implementation..

Handle review comments:

Feb 19 2021, 12:21 AM · Restricted Project

Feb 16 2021

ergawy added a comment to D96271: [MLIR][LinAlg] Start detensoring implementation..

@silvas Your last comments all seem to be on an old diff :). FuncBufferize changes were already reverted and the detensoring code was moved to its own file.

Feb 16 2021, 10:36 PM · Restricted Project

Feb 15 2021

ergawy added a comment to D96271: [MLIR][LinAlg] Start detensoring implementation..

Thanks @nicolasvasilache and @silvas again for your help in calibrating this to better fit the intended needs. I keep adding and deleting code but that's what happens when you are a newbie :).

Feb 15 2021, 12:52 AM · Restricted Project
ergawy updated the diff for D96271: [MLIR][LinAlg] Start detensoring implementation..
  • Don't detensorize control flow.
  • Don't detensorize across function boundaries.
  • Support only rank0 for now.
Feb 15 2021, 12:48 AM · Restricted Project

Feb 12 2021

ergawy added inline comments to D96527: [mlir][spirv] Add support for FrexpStruct in GLSL extended instruction set.
Feb 12 2021, 4:34 AM · Restricted Project
ergawy added inline comments to D96271: [MLIR][LinAlg] Start detensoring implementation..
Feb 12 2021, 2:42 AM · Restricted Project