User Details
- User Since
- Feb 9 2017, 1:26 AM (281 w, 5 d)
Sep 20 2021
Sep 17 2021
Aug 3 2021
Jul 28 2021
Glad to see the module combiner will see some action :D. Thank you.
Jun 3 2021
May 27 2021
Handle review comments.
May 26 2021
May 7 2021
Abandoned in favor of: D102055.
Thanks I will abandon my review. This fixes the issue for me.
I use: Apple clang version 11.0.3.
I might have misunderstood something. Let me know if I should abandon this in case this a local issue on my machine or there is a better solution.
May 6 2021
Handle review comments.
Apr 30 2021
Apr 20 2021
Add more detailed docs.
Apr 16 2021
Handle review comments:
- Fold the 2 phases of the cost-mode into one.
Apr 14 2021
Apr 13 2021
Apr 10 2021
Handle review comments.
Apr 9 2021
Add more tests.
Handle Sean's comments:
- Refactor control-flow model.
- Dedeuce branch op detensoring from block argument detensoring.
- Add more docs.
Apr 7 2021
Handle rridle's comments:
- Use ArrayRef for argument type.
- Use function_ref instead of DenseMap.
- Remove unneeded includes.
- Avoid dynamic memory allocation.
Apr 6 2021
Mar 28 2021
- Rearrange code a bit.
Mar 27 2021
Should be valid with sexti as well right?
Your folder does not do that actually. It is just the framework that does not perform such replacement for all folders.
(side note, you could write simply : If the type of trunci's destination does not match zexti's source types, no folding takes place. ; the intermediate type does not matter here)
- Handle review comments.
- Rebase.
I came across this pattern while working on detensoring in linalg-on-tensors for IREE. Let me know if there are any reasons why this might be a bad idea.
Mar 16 2021
We will halt working on this until a discussion on a good assembly scheme is discussed with a wider audience.
Mar 10 2021
@antiagainst, 2 points:
- I adopted the set of rules you suggested, we can refine them as we discuss on the review.
- I tried to define GlobalVariable using the declarative format, but it seems that is not possible due to the optional directives: bind and built_in. Let me know if I misunderstood something.
Mar 6 2021
Rebase.
Mar 5 2021
Mar 4 2021
Fix doc string.
Fix comments.
Rename to spv.mlir.loop.
Mar 2 2021
- Rebase.
- Add a TODO.
Feb 28 2021
Feb 26 2021
Rename function.
Clean-up.
Handle review comments.
Feb 25 2021
Handle some review comments.
Feb 24 2021
Handle review comments.
Update docs.
Properly handle non-entry function blocks.
Feb 22 2021
Feb 21 2021
Assert on 0 inputs.