Page MenuHomePhabricator

ergawy (Kareem Ergawy)
Spy

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:26 AM (205 w, 1 d)

Recent Activity

Sun, Jan 10

ergawy committed rGa40767ec8851: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation. (authored by ergawy).
[MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.
Sun, Jan 10, 10:59 PM
ergawy closed D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..
Sun, Jan 10, 10:59 PM · Restricted Project, Restricted Project
ergawy added a comment to D94360: [mlir][spirv] NFC: split deserialization into multiple source files.

Nice! Actually last Friday I was looking into seeing whether doing the same would be beneficial for SPIRVOps.cpp. Using -ftime-trace shows that it takes ~19 seconds to cleanly compile it. Most of that time ~13 is spent in the backend. So I guess parallelized compilation can be beneficial here as well. If you aren't planning to do that already, I can split it.

Sun, Jan 10, 10:50 PM · Restricted Project
ergawy added inline comments to D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..
Sun, Jan 10, 1:11 AM · Restricted Project, Restricted Project
ergawy updated the diff for D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Handle review comments.

Sun, Jan 10, 1:10 AM · Restricted Project, Restricted Project

Fri, Jan 8

ergawy committed rG25d882e758cc: [MLIR][SPIRV] Add `UsableInSpecConstantOp` trait. (authored by ergawy).
[MLIR][SPIRV] Add `UsableInSpecConstantOp` trait.
Fri, Jan 8, 6:08 AM
ergawy closed D94288: [MLIR][SPIRV] Add `UsableInSpecConstantOp` trait..
Fri, Jan 8, 6:08 AM · Restricted Project
ergawy requested review of D94288: [MLIR][SPIRV] Add `UsableInSpecConstantOp` trait..
Fri, Jan 8, 12:22 AM · Restricted Project

Thu, Jan 7

ergawy added inline comments to D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..
Thu, Jan 7, 11:18 PM · Restricted Project, Restricted Project
ergawy updated the diff for D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Handle review comments:

Thu, Jan 7, 11:18 PM · Restricted Project, Restricted Project

Wed, Jan 6

ergawy committed rGf60e0a91fbdd: [MLIR][SPIRV] Add `UnsignedOp` trait. (authored by ergawy).
[MLIR][SPIRV] Add `UnsignedOp` trait.
Wed, Jan 6, 6:29 AM
ergawy closed D94068: [MLIR][SPIRV] Add `UnsignedOp` trait..
Wed, Jan 6, 6:28 AM · Restricted Project
ergawy updated the diff for D94068: [MLIR][SPIRV] Add `UnsignedOp` trait..

Handle some formatting comments.

Wed, Jan 6, 5:53 AM · Restricted Project

Tue, Jan 5

ergawy updated the diff for D94068: [MLIR][SPIRV] Add `UnsignedOp` trait..

Add a new header for Op traits.

Tue, Jan 5, 10:39 PM · Restricted Project
ergawy updated the summary of D94068: [MLIR][SPIRV] Add `UnsignedOp` trait..
Tue, Jan 5, 1:10 AM · Restricted Project
ergawy requested review of D94068: [MLIR][SPIRV] Add `UnsignedOp` trait..
Tue, Jan 5, 1:08 AM · Restricted Project

Mon, Jan 4

ergawy updated the diff for D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Rebase and bing! :).

Mon, Jan 4, 10:48 PM · Restricted Project, Restricted Project

Thu, Dec 24

ergawy updated the diff for D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Rebase.

Thu, Dec 24, 12:15 AM · Restricted Project, Restricted Project

Wed, Dec 23

ergawy committed rG1d0dc9be6d72: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp. (authored by ergawy).
[MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp.
Wed, Dec 23, 6:48 AM
ergawy closed D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..
Wed, Dec 23, 6:48 AM · Restricted Project
ergawy updated ergawy.
Wed, Dec 23, 2:16 AM
ergawy updated the diff for D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..

Handle some minor clang-tidy comments.

Wed, Dec 23, 1:30 AM · Restricted Project
ergawy updated the diff for D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..

Add missing header guard.

Wed, Dec 23, 1:11 AM · Restricted Project
ergawy added inline comments to D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..
Wed, Dec 23, 12:49 AM · Restricted Project
ergawy updated the diff for D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..

Remove empty line.

Wed, Dec 23, 12:47 AM · Restricted Project
ergawy updated the diff for D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..

Fix file organization issue.

Wed, Dec 23, 12:45 AM · Restricted Project
ergawy updated the diff for D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..
  • Split GLSL-specific patterns in their own file.
  • Add a test pass to test them.
Wed, Dec 23, 12:39 AM · Restricted Project

Tue, Dec 22

ergawy added inline comments to D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..
Tue, Dec 22, 1:54 AM · Restricted Project, Restricted Project

Mon, Dec 21

ergawy committed rG9d2529a38b34: [MLIR][Docs] Fix a small typo in documentation. (authored by ergawy).
[MLIR][Docs] Fix a small typo in documentation.
Mon, Dec 21, 1:30 PM
ergawy closed D93616: [MLIR][Docs] Fix a small typo in documentation..
Mon, Dec 21, 1:30 PM · Restricted Project
ergawy added a comment to D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..

2 things I still need to figure out/need to make sure I got right:

  • How to enable these patterns only when the GLSL.std.450 extension is enabled?
  • Whether you think it's suitable to consider these rewrites as canonicalization patterns or we should move them somewhere else?
Mon, Dec 21, 12:39 AM · Restricted Project
ergawy requested review of D93618: [MLIR][SPIRV] Add rewrite pattern to convert select+cmp into GLSL clamp..
Mon, Dec 21, 12:34 AM · Restricted Project

Sun, Dec 20

ergawy added reviewers for D93616: [MLIR][Docs] Fix a small typo in documentation.: rriddle, ftynse.
Sun, Dec 20, 11:41 PM · Restricted Project
ergawy requested review of D93616: [MLIR][Docs] Fix a small typo in documentation..
Sun, Dec 20, 11:41 PM · Restricted Project
ergawy updated the diff for D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Add more comments.

Sun, Dec 20, 5:45 AM · Restricted Project, Restricted Project
ergawy added inline comments to D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..
Sun, Dec 20, 2:59 AM · Restricted Project, Restricted Project
ergawy requested review of D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..
Sun, Dec 20, 2:56 AM · Restricted Project, Restricted Project

Dec 16 2020

ergawy updated the summary of D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.
Dec 16 2020, 2:26 AM · Restricted Project
ergawy updated the diff for D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.

Rebase to see if CI bug is resolved.

Dec 16 2020, 2:25 AM · Restricted Project

Dec 15 2020

ergawy added a comment to D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.

Probably this hits a CI bug: https://github.com/google/llvm-premerge-checks/issues/268.

Dec 15 2020, 6:46 AM · Restricted Project
ergawy updated the diff for D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.

Rebase and erase extra space.

Dec 15 2020, 1:21 AM · Restricted Project
ergawy updated the diff for D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.

Revert unneeded changes.

Dec 15 2020, 1:11 AM · Restricted Project
ergawy added a comment to D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.

This custom assembly format is okay but I think we can further simplify it given we have very rigid structure inside the region. What about something like

%result = spv.SpecConstantOperation wraps "spv.IAdd"(%lhs, %rhs) : (i32, i32) -> i32

?

The spv.mlir.yield can then be implicitly constructed during parsing and omitted during printing.

We have examples for this in TensorFlow: tf_executor.island. See its parsing and printing function here:

And examples here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/mlir/tensorflow/tests/executor_island_coarsening.mlir#L183-L188

Let me know how do you think. :)

Dec 15 2020, 12:56 AM · Restricted Project
ergawy updated the diff for D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.
  • Add more traits to aid verification.
  • Change custom syntax.
Dec 15 2020, 12:53 AM · Restricted Project

Dec 11 2020

ergawy added a comment to D91548: [MLIR][SPIRV] Split (De-)serialization into 2 libs..

Friendly reminder to land this :). I would like to add (de-)serialization support for OpSpecConstantOp and conflicts will be easier to handle if this patch is merged before I start. If you need to wait on this one for a bit more, then no problem I will work on my new patch and handle conflicts later.

Dec 11 2020, 6:33 AM · Restricted Project
ergawy updated the diff for D91548: [MLIR][SPIRV] Split (De-)serialization into 2 libs..

Rebase.

Dec 11 2020, 6:28 AM · Restricted Project

Dec 9 2020

ergawy requested review of D92919: [mlir][spirv] Add parsing and printing support for SpecConstantOperation.
Dec 9 2020, 12:59 AM · Restricted Project

Dec 8 2020

ergawy retitled D92859: [MLIR][SPIRV] Add support for GLSL F/U/SClamp. from [MLIR][SPIRV] Add support for F/U/SClamp. to [MLIR][SPIRV] Add support for GLSL F/U/SClamp..
Dec 8 2020, 9:26 AM · Restricted Project
ergawy requested review of D92859: [MLIR][SPIRV] Add support for GLSL F/U/SClamp..
Dec 8 2020, 9:20 AM · Restricted Project

Dec 7 2020

ergawy added inline comments to D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..
Dec 7 2020, 12:37 AM · Restricted Project
ergawy updated the diff for D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..
  • Add IsolatedFromAbove trait to spv.SpecConstantOperation.
Dec 7 2020, 12:34 AM · Restricted Project

Dec 6 2020

ergawy updated the diff for D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..

Rebase.

Dec 6 2020, 10:56 PM · Restricted Project

Dec 2 2020

ergawy added inline comments to D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..
Dec 2 2020, 4:59 AM · Restricted Project
ergawy updated the diff for D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..

Handle review comments.

Dec 2 2020, 4:59 AM · Restricted Project

Dec 1 2020

ergawy added a comment to D92333: [MLIR][LLVM] Fix a tiny typo in the dialect docs..

I don't have commit access. Please commit on my behalf whenever you like.

Dec 1 2020, 5:32 AM · Restricted Project

Nov 30 2020

ergawy requested review of D92333: [MLIR][LLVM] Fix a tiny typo in the dialect docs..
Nov 30 2020, 9:50 AM · Restricted Project
ergawy updated the diff for D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..

Rename to spv.mlir.yield.

Nov 30 2020, 9:20 AM · Restricted Project
ergawy updated the diff for D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..
Nov 30 2020, 7:26 AM · Restricted Project

Nov 27 2020

ergawy added a comment to D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..

This is an initial patch to make sure I didn't anything disastrously wrong :D.

Nov 27 2020, 8:03 AM · Restricted Project
ergawy requested review of D92232: [MLIR][SPIRV] Add initial support for OpSpecConstantOp..
Nov 27 2020, 7:56 AM · Restricted Project

Nov 19 2020

ergawy retitled D91792: [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.endmodule` from [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.moduleend` to [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.endmodule`.
Nov 19 2020, 9:09 AM · Restricted Project
ergawy updated the diff for D91792: [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.endmodule`.

Rename to endmodule.

Nov 19 2020, 9:08 AM · Restricted Project
ergawy added a comment to D91792: [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.endmodule`.

What about naming it as spv.mlir.endmodule so it's more akin to spv.mlir.addressof and others? :)

Nov 19 2020, 8:08 AM · Restricted Project
ergawy retitled D91792: [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.endmodule` from [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.module_end` to [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.moduleend`.
Nov 19 2020, 8:07 AM · Restricted Project
ergawy updated the diff for D91792: [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.endmodule`.
  • Rename to moduleend instead.
Nov 19 2020, 8:07 AM · Restricted Project
ergawy requested review of D91797: [MLIR][SPIRV] Rename `spv._merge` to `spv.mlir.merge`.
Nov 19 2020, 6:47 AM · Restricted Project
ergawy requested review of D91792: [MLIR][SPIRV] Rename `spv._module_end` to `spv.mlir.endmodule`.
Nov 19 2020, 5:57 AM · Restricted Project
ergawy updated the diff for D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..
  • Add missing check in deduplication code.
Nov 19 2020, 5:45 AM · Restricted Project
ergawy added inline comments to D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..
Nov 19 2020, 5:42 AM · Restricted Project
ergawy updated the diff for D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..
  • Handle review comment.
  • Rebase.
Nov 19 2020, 5:42 AM · Restricted Project

Nov 18 2020

ergawy requested review of D91715: [MLIR][SPIRV] Rename `spv._reference_of` to `spv.mlir.referenceof`.
Nov 18 2020, 8:29 AM · Restricted Project
ergawy updated the diff for D91548: [MLIR][SPIRV] Split (De-)serialization into 2 libs..

Fix header guards.

Nov 18 2020, 4:49 AM · Restricted Project
ergawy updated the diff for D91548: [MLIR][SPIRV] Split (De-)serialization into 2 libs..

Re-organize files a bit differently.

Nov 18 2020, 4:22 AM · Restricted Project

Nov 17 2020

ergawy updated the diff for D91609: [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.addressof`.

Fix mistake due to batch editing using sed.

Nov 17 2020, 4:37 AM · Restricted Project
ergawy updated the diff for D91609: [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.addressof`.

Fix mistake due to batch editing using sed.

Nov 17 2020, 4:33 AM · Restricted Project
ergawy retitled D91609: [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.addressof` from [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.address_of` to [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.addressof`.
Nov 17 2020, 4:29 AM · Restricted Project
ergawy updated the diff for D91609: [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.addressof`.

Rename to addressof instead of address_of.

Nov 17 2020, 4:29 AM · Restricted Project
ergawy added a comment to D91609: [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.addressof`.

I think this should be actually renamed to spv.mlir.addressof to be truly consistent the style used in the llvm dialect. Are there any objections to this? If not, I will do as such.

Nov 17 2020, 3:33 AM · Restricted Project
ergawy requested review of D91609: [MLIR][SPIRV] Rename `spv._address_of` to `spv.mlir.addressof`.
Nov 17 2020, 3:29 AM · Restricted Project

Nov 16 2020

ergawy requested review of D91548: [MLIR][SPIRV] Split (De-)serialization into 2 libs..
Nov 16 2020, 8:27 AM · Restricted Project

Nov 13 2020

ergawy added a comment to D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..

Thanks for taking the time to review.

Nov 13 2020, 8:26 AM · Restricted Project
ergawy updated the diff for D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..

Handle further comments.

Nov 13 2020, 8:25 AM · Restricted Project
ergawy updated the diff for D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..

Handle review comments.

Nov 13 2020, 8:11 AM · Restricted Project

Nov 12 2020

ergawy updated the diff for D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..

Rebase.

Nov 12 2020, 3:43 AM · Restricted Project

Nov 10 2020

ergawy updated ergawy.
Nov 10 2020, 6:04 AM

Nov 9 2020

ergawy updated the diff for D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..

Some minor re-formatting.

Nov 9 2020, 4:01 AM · Restricted Project
ergawy updated the diff for D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..

Rebase

Nov 9 2020, 1:03 AM · Restricted Project

Nov 6 2020

ergawy added inline comments to D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..
Nov 6 2020, 8:35 AM · Restricted Project
ergawy abandoned D90855: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars and spec consts..

Abandoned in favor of: https://reviews.llvm.org/D90951

Nov 6 2020, 8:32 AM · Restricted Project
ergawy abandoned D90932: [MLIR][SPIRV] ModuleCombiner: deduplicate identical functions..

Abandoned in favor of: https://reviews.llvm.org/D90951

Nov 6 2020, 8:32 AM · Restricted Project
ergawy requested review of D90951: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars, spec consts, and funcs..
Nov 6 2020, 8:31 AM · Restricted Project
ergawy added a comment to D90855: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars and spec consts..

General comment regarding this patch as well as this: https://reviews.llvm.org/D90932.

Nov 6 2020, 6:09 AM · Restricted Project
ergawy added inline comments to D90932: [MLIR][SPIRV] ModuleCombiner: deduplicate identical functions..
Nov 6 2020, 5:43 AM · Restricted Project
ergawy requested review of D90932: [MLIR][SPIRV] ModuleCombiner: deduplicate identical functions..
Nov 6 2020, 5:36 AM · Restricted Project

Nov 5 2020

ergawy retitled D90855: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars and spec consts. from [MLIR][SPIRV] ModuleCombiner: deduplication global vars and spec consts. to [MLIR][SPIRV] ModuleCombiner: deduplicate global vars and spec consts..
Nov 5 2020, 10:29 PM · Restricted Project
ergawy added a comment to D90855: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars and spec consts..

I am not familiar with the implicit conversion rules within the spv dialect (or MLIR in general). But, I was expecting that replacing all uses of bar with foo in the following to snippet to fail:

Nov 5 2020, 8:31 AM · Restricted Project
ergawy updated the diff for D90855: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars and spec consts..
  • Remove unneeded comment.
Nov 5 2020, 8:26 AM · Restricted Project
ergawy requested review of D90855: [MLIR][SPIRV] ModuleCombiner: deduplicate global vars and spec consts..
Nov 5 2020, 8:23 AM · Restricted Project

Nov 4 2020

ergawy updated ergawy.
Nov 4 2020, 11:04 AM
ergawy updated ergawy.
Nov 4 2020, 11:00 AM