This is an archive of the discontinued LLVM Phabricator instance.

[flang][driver] Fix -fdefault* family bug

Authored by arnamoy10 on Mar 1 2021, 1:22 PM.



This patch provides a fix for the fdefault-* family in f18

(Please consult D96344 for details)

Diff Detail

Event Timeline

arnamoy10 requested review of this revision.Mar 1 2021, 1:22 PM
arnamoy10 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2021, 1:22 PM

This patch will allow us to share the tests for -fdefault-{double-8|integer-8|real-8} and -flarge-sizes (introduced in between f18 and flang-new. This is a very much welcomed change, thank you!

I don't think that we need any changes for -module though. f18 already supports -module-dir and there are no tests using -module that would require this change in the future. Please, could you revert it?

Ideally this patch would be accompanied with tests, but since D96344 is practically ready to land (and which contains tests for this), I suggest that we merge this as is. Could you mention e.g. in the commit message that tests will be added in a forthcoming patch? Thank you!

arnamoy10 updated this revision to Diff 327432.Mar 2 2021, 6:24 AM
arnamoy10 retitled this revision from [flang][driver] Add -module-dir alias to f18, also fix -fdefault* family bug to [flang][driver] Fix -fdefault* family bug.
arnamoy10 edited the summary of this revision. (Show Details)

Taken out -module related changes, updated the commit message as well.

This revision is now accepted and ready to land.Mar 2 2021, 9:18 AM
This revision was landed with ongoing or failed builds.Mar 2 2021, 9:44 AM
This revision was automatically updated to reflect the committed changes.