Page MenuHomePhabricator

[clang-tidy] Deprecate readability-deleted-default check
ClosedPublic

Authored by njames93 on Feb 25 2021, 11:18 AM.

Details

Summary

... For removal in next release cycle.
The clang warning that does the same thing is enabled by default and typically emits better diagnostics making this check surplus to requirements.

Diff Detail

Event Timeline

njames93 created this revision.Feb 25 2021, 11:18 AM
njames93 requested review of this revision.Feb 25 2021, 11:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2021, 11:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

If Wdefaulted-function-deleted was introduced in 12.0, I think it's safe just to remove readability-deleted-default.

If Wdefaulted-function-deleted was introduced in 12.0, I think it's safe just to remove readability-deleted-default.

Wdefaulted-function-deleted was introduced in 8.0 and I think it was enabled by default even then. I'm thinking we may be able to squeeze this notice into the 12 branch and then it will be gone by 13

If Wdefaulted-function-deleted was introduced in 12.0, I think it's safe just to remove readability-deleted-default.

Wdefaulted-function-deleted was introduced in 8.0 and I think it was enabled by default even then. I'm thinking we may be able to squeeze this notice into the 12 branch and then it will be gone by 13

Frankly, I don't remember any deprecated check in past. Obsolete checks were just removed and this change was reflected in Release Notes.

aaron.ballman accepted this revision.Mar 1 2021, 7:42 AM

If Wdefaulted-function-deleted was introduced in 12.0, I think it's safe just to remove readability-deleted-default.

Wdefaulted-function-deleted was introduced in 8.0 and I think it was enabled by default even then. I'm thinking we may be able to squeeze this notice into the 12 branch and then it will be gone by 13

Frankly, I don't remember any deprecated check in past. Obsolete checks were just removed and this change was reflected in Release Notes.

With checks that have been released to the public, I think it's good to have a notice that the check was deprecated before we remove it.

LGTM! If we want to squeeze the notice into 12, I think that's also reasonable, but given that this has been around for a while, I'm also fine with a slightly longer deprecation period.

This revision is now accepted and ready to land.Mar 1 2021, 7:42 AM
This revision was automatically updated to reflect the committed changes.