Page MenuHomePhabricator

[mlir] Move cuda tests
ClosedPublic

Authored by csigg on Feb 25 2021, 4:48 AM.

Details

Summary

Move test inputs to test/Integration directory.
Move runtime wrappers to ExecutionEngine.

Diff Detail

Event Timeline

csigg created this revision.Feb 25 2021, 4:48 AM
csigg requested review of this revision.Feb 25 2021, 4:48 AM
csigg updated this revision to Diff 326400.Feb 25 2021, 8:22 AM

Conditionally add mlir_cuda_runtime to test dependencies.

I have no idea why clang-tidy flags code in ADT that I didn't touch.

mehdi_amini accepted this revision.Feb 25 2021, 11:08 AM
This revision is now accepted and ready to land.Feb 25 2021, 11:08 AM

Can you double check that the mlir-nvidia buildbot is configured to activate the integration tests first?

Can you double check that the mlir-nvidia buildbot is configured to activate the integration tests first?

Thanks for reminding me. It looks like it isn't:
https://github.com/llvm/llvm-zorg/blob/c816513763961852ae753378e0525dd8e508d168/buildbot/osuosl/master/config/builders.py#L1086

I will send a patch. I hope it's OK for the mlir-nvidia bot to run all integration tests?

csigg updated this revision to Diff 327698.Mar 3 2021, 12:43 AM

Rebase.

csigg updated this revision to Diff 327712.Mar 3 2021, 1:41 AM

Fix clang-tidy, hopefully.

csigg updated this revision to Diff 327723.Mar 3 2021, 2:25 AM

Needs C++14, not C++11.

This revision was landed with ongoing or failed builds.Mar 3 2021, 4:17 AM
Closed by commit rG9d7be77bf91e: [mlir] Move cuda tests (authored by csigg). · Explain Why
This revision was automatically updated to reflect the committed changes.