These flags affect coverage mapping (-fcoverage-mapping), not
-fprofile-[instr-]generate so it makes more sense to use the
-fcoverage-* prefix.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I realized recently that -fcoverage-{prefix-map,compilation-dir} is a more accurate name but I'd be interested in your opinion, I don't feel too strongly about this.
Comment Actions
I personally prefer this, and this is what I landed in swiftc a while back, but I changed to -fprofile-prefix-map based on feedback from you 😛 https://reviews.llvm.org/D83154?id=275480#2146086
But I think the assumption there was it did apply to the other profile related flags
Comment Actions
I know, sorry about that :( I originally though of it as more associated with other profile flags but I changed my mind after getting more experience with that part of codebase.