Page MenuHomePhabricator

haowei (Haowei Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2017, 3:05 PM (305 w, 5 d)

Recent Activity

Thu, Mar 23

haowei updated the diff for D146672: [ifs] Print an error when llvm-ifs is supplied with an unknown arch.

Thanks for pointing them out.

Thu, Mar 23, 4:24 PM · Restricted Project, Restricted Project

Wed, Mar 22

haowei requested review of D146672: [ifs] Print an error when llvm-ifs is supplied with an unknown arch.
Wed, Mar 22, 4:55 PM · Restricted Project, Restricted Project

Tue, Mar 7

haowei accepted D145449: [Fuchsia] Add LLDB options to stage 1 cmake..

LGTM, but please wait @phosek to approve it.

Tue, Mar 7, 10:50 AM · Restricted Project, Restricted Project

Mon, Mar 6

haowei added inline comments to D145449: [Fuchsia] Add LLDB options to stage 1 cmake..
Mon, Mar 6, 4:15 PM · Restricted Project, Restricted Project
haowei updated the diff for D144603: Disable compiler launcher on external projects and multi stage clang.
Mon, Mar 6, 3:50 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 1

haowei updated the diff for D144603: Disable compiler launcher on external projects and multi stage clang.
Wed, Mar 1, 2:40 PM · Restricted Project, Restricted Project, Restricted Project
haowei added a comment to D144603: Disable compiler launcher on external projects and multi stage clang.

I agree, in that case let's remove C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER from the list of default passthrough variables which seems like a reasonable default, and provide CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH so developers have a way to pass these through to the next stage if they want to.

Wed, Mar 1, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
haowei added a comment to D144603: Disable compiler launcher on external projects and multi stage clang.

Hmm, what cache key does ccache use for compilers? Is it the --version output string, the path, or some combination? If the path is involved then I don't see any value in using ccache for configuring anything past stage1, since the compiler will (presumably) be installed somewhere else afterwards and not used directly from the build tree. If it's just --version, what are the cache pollution concerns? The compiler binaries output by all the stages should produce the same outputs given the same inputs (and presumably have the same --version), right?

Wed, Mar 1, 10:37 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Feb 28

haowei committed rGa7bb9a363923: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap (authored by haowei).
[Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap
Tue, Feb 28, 3:20 PM · Restricted Project, Restricted Project
haowei closed D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap.
Tue, Feb 28, 3:20 PM · Restricted Project, Restricted Project
haowei requested review of D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap.
Tue, Feb 28, 3:14 PM · Restricted Project, Restricted Project

Feb 24 2023

haowei added a comment to D138451: [lld/mac] Add support for distributed ThinLTO.

We are seeing a linker error on Mac builder today when we try to roll the clang toolchain for Flutter, error message (build task: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Unopt/25679/overview):

Feb 24 2023, 4:14 PM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2023

haowei requested review of D144603: Disable compiler launcher on external projects and multi stage clang.
Feb 22 2023, 4:55 PM · Restricted Project, Restricted Project, Restricted Project
haowei requested review of D144595: [WIP] Experimenting building Windows runtimes when cross compiling LLVM toolchain.
Feb 22 2023, 3:17 PM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2023

haowei committed rGac835ecb5fea: [Fuchsia] Set /winsysroot in Windows runtimes linker flags (authored by haowei).
[Fuchsia] Set /winsysroot in Windows runtimes linker flags
Feb 14 2023, 1:32 PM · Restricted Project, Restricted Project
haowei closed D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags.
Feb 14 2023, 1:32 PM · Restricted Project, Restricted Project
haowei added a comment to D141808: [Driver] Add --vfsoverlay flag.

I am seeing test failures on pre submit Windows builder after this change was landed: See https://buildkite.com/llvm-project/premerge-checks/builds/135752#01864d34-9024-4c13-9137-88b6f41ec695

Feb 14 2023, 1:25 PM · Restricted Project, Restricted Project

Feb 13 2023

haowei requested review of D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags.
Feb 13 2023, 3:53 PM · Restricted Project, Restricted Project

Feb 7 2023

haowei added a comment to D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

There are also cases that this clang type-limit check will warn when checking if a enum type is larger than 0. For example, we are seeing warnings on ICU source code (https://github.com/unicode-org/icu/blob/8d5a97ae0f49f6974372736ca67db15c37522f6f/icu4c/source/i18n/displayoptions.cpp#L79) after this patch was landed.

Feb 7 2023, 2:45 PM · Restricted Project, Restricted Project
haowei added a comment to D143516: [lit] [PATCH 1/2] Specify a common interface in a common base class for all report types.

LGTM. Please wait for the approval from @yln .

Feb 7 2023, 11:12 AM · Restricted Project, Restricted Project

Feb 6 2023

haowei added a comment to D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization.

FYI, this patch looks like was pushed into a new "Main" branch instead of the actual "main" branch.:

Feb 6 2023, 4:24 PM · Restricted Project, Restricted Project
haowei committed rG14ca2e68ff4c: Revert "[Fuchsia] Simplify Fuchsia stage2 toolchain setup" (authored by haowei).
Revert "[Fuchsia] Simplify Fuchsia stage2 toolchain setup"
Feb 6 2023, 3:02 PM · Restricted Project, Restricted Project
haowei added a reverting change for rGf9ff49882a65: [Fuchsia] Simplify Fuchsia stage2 toolchain setup: rG14ca2e68ff4c: Revert "[Fuchsia] Simplify Fuchsia stage2 toolchain setup".
Feb 6 2023, 3:02 PM · Restricted Project, Restricted Project
haowei committed rG5fcdab04c250: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei).
[Fuchsia] Build windows runtimes using cross compilation on Linux
Feb 6 2023, 2:59 PM · Restricted Project, Restricted Project, Restricted Project
haowei closed D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Feb 6 2023, 2:59 PM · Restricted Project, Restricted Project, Restricted Project
haowei committed rGf9ff49882a65: [Fuchsia] Simplify Fuchsia stage2 toolchain setup (authored by haowei).
[Fuchsia] Simplify Fuchsia stage2 toolchain setup
Feb 6 2023, 2:59 PM · Restricted Project, Restricted Project
haowei committed rGdc1c8917afd3: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency (authored by haowei).
[Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency
Feb 6 2023, 11:37 AM · Restricted Project, Restricted Project
haowei closed D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.
Feb 6 2023, 11:37 AM · Restricted Project, Restricted Project
haowei updated the diff for D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.
Feb 6 2023, 11:27 AM · Restricted Project, Restricted Project
haowei committed rG630266aed342: [Fuchsia] Simplified the stage2 build setup (authored by haowei).
[Fuchsia] Simplified the stage2 build setup
Feb 6 2023, 10:49 AM · Restricted Project, Restricted Project
haowei closed D143288: [Fuchsia] Simplified the stage2 build setup.
Feb 6 2023, 10:49 AM · Restricted Project, Restricted Project

Feb 3 2023

haowei added inline comments to D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.
Feb 3 2023, 3:24 PM · Restricted Project, Restricted Project
haowei updated the diff for D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.
Feb 3 2023, 3:21 PM · Restricted Project, Restricted Project
haowei requested review of D143288: [Fuchsia] Simplified the stage2 build setup.
Feb 3 2023, 11:19 AM · Restricted Project, Restricted Project

Feb 2 2023

haowei added inline comments to D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Feb 2 2023, 1:31 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.
Feb 2 2023, 10:44 AM · Restricted Project, Restricted Project

Jan 31 2023

haowei reopened D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Jan 31 2023, 4:11 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.

Correct dependency issues on llvm-mt

Jan 31 2023, 4:11 PM · Restricted Project, Restricted Project, Restricted Project
haowei requested review of D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.
Jan 31 2023, 3:39 PM · Restricted Project, Restricted Project

Jan 23 2023

haowei added a reverting change for rG20bb7658f53b: [Fuchsia] Build windows runtimes using cross compilation on Linux: rGf2b58eb4ad84: Revert "[Fuchsia] Build windows runtimes using cross compilation on Linux".
Jan 23 2023, 6:44 PM · Restricted Project, Restricted Project, Restricted Project
haowei committed rGf2b58eb4ad84: Revert "[Fuchsia] Build windows runtimes using cross compilation on Linux" (authored by haowei).
Revert "[Fuchsia] Build windows runtimes using cross compilation on Linux"
Jan 23 2023, 6:44 PM · Restricted Project, Restricted Project, Restricted Project
haowei added a reverting change for D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain: rGf2b58eb4ad84: Revert "[Fuchsia] Build windows runtimes using cross compilation on Linux".
Jan 23 2023, 6:44 PM · Restricted Project, Restricted Project, Restricted Project
haowei added inline comments to D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Jan 23 2023, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
haowei committed rG20bb7658f53b: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei).
[Fuchsia] Build windows runtimes using cross compilation on Linux
Jan 23 2023, 2:10 PM · Restricted Project, Restricted Project, Restricted Project
haowei closed D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Jan 23 2023, 2:10 PM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

haowei added a comment to D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.

Thanks for the review. I will land the change once Fuchsia clang builders are green.

Jan 20 2023, 3:53 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Jan 20 2023, 3:39 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.

Correct an issue llvm-rc and llvm-mt are not part of TOOLCHAIN_TOOLS

Jan 20 2023, 11:28 AM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

haowei added inline comments to D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Jan 19 2023, 3:54 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Jan 19 2023, 3:49 PM · Restricted Project, Restricted Project, Restricted Project

Jan 13 2023

haowei updated the diff for D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.

Correct C, CXX flag issue.

Jan 13 2023, 6:09 PM · Restricted Project, Restricted Project, Restricted Project
haowei requested review of D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.
Jan 13 2023, 4:54 PM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

haowei committed rGbc3edb627201: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain (authored by haowei).
[CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain
Jan 11 2023, 11:04 AM · Restricted Project, Restricted Project
haowei closed D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain.
Jan 11 2023, 11:04 AM · Restricted Project, Restricted Project

Jan 10 2023

haowei requested review of D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain.
Jan 10 2023, 5:01 PM · Restricted Project, Restricted Project

Jan 4 2023

haowei requested review of D141016: [vfs] Use FS->WorkingDirectory when converting relative path to ABS.
Jan 4 2023, 3:41 PM · Restricted Project, Restricted Project

Dec 16 2022

haowei added a comment to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

LGTM. If you could put up a PR after to fix the use of sys::fs::make_absolute that would be appreciated 🙇.

Dec 16 2022, 11:47 AM · Restricted Project, Restricted Project, Restricted Project
haowei committed rGa903ecb4a26d: [vfs] Allow root paths relative to the vfsoverlay YAML file (authored by haowei).
[vfs] Allow root paths relative to the vfsoverlay YAML file
Dec 16 2022, 11:46 AM · Restricted Project, Restricted Project, Restricted Project
haowei closed D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Dec 16 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

haowei added a comment to D139980: [lld-macho][test][nfc] Update stabs.s to use touch -d instead of -t.

Wondering what is the error you see when uses UTC? While there are some differences, UTC and GMT basically means the same thing. So I am really surprised one works fine while the other will fail.

Dec 15 2022, 11:21 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2022

haowei added a comment to D139980: [lld-macho][test][nfc] Update stabs.s to use touch -d instead of -t.

Thanks for acting upon this quickly, @thakis!

Sorry for the inconveniences caused by this change, @haowei. Do you mind trying the other form of the command (touch -d "1970-01-01T00:00:16Z") on your builder and see if that works? I am hoping that we can have a simple workaround for the container issue I encountered without breaking any other stuff of course.

Dec 14 2022, 10:26 AM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2022

haowei added a comment to D139980: [lld-macho][test][nfc] Update stabs.s to use touch -d instead of -t.

This change breaks lld/test/MachO/stabs.s on Fuchsia's Mac x64 Clang builder:

Dec 13 2022, 9:55 PM · Restricted Project, Restricted Project, Restricted Project
haowei added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

I tried again with

cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;compiler-rt" ../llvm -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_TARGETS_TO_BUILD="X86"
Dec 13 2022, 4:42 PM · Restricted Project, Restricted Project
haowei added a reverting change for rG255c3e3dcb06: Reland "[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests": rGbeb3fa2d2efb: Revert "Reland "[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling….
Dec 13 2022, 4:39 PM · Restricted Project, Restricted Project
haowei committed rGbeb3fa2d2efb: Revert "Reland "[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling… (authored by haowei).
Revert "Reland "[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling…
Dec 13 2022, 4:39 PM · Restricted Project, Restricted Project
haowei added a reverting change for D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests: rGbeb3fa2d2efb: Revert "Reland "[compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling….
Dec 13 2022, 4:39 PM · Restricted Project, Restricted Project
haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Dec 13 2022, 4:36 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

Rebased the change to solve the merge conflicts on the bots.

Dec 13 2022, 4:34 PM · Restricted Project, Restricted Project, Restricted Project
haowei added a comment to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

I changed some comments and add more details.
If there is no objection, can I get an approval on this change so I can land it? It will unblock our development on Windows cross compilation support.

Dec 13 2022, 3:46 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Dec 13 2022, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
haowei added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

So I tried

Dec 13 2022, 2:44 PM · Restricted Project, Restricted Project
haowei added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

What is your cmake command line when you test the code (when all Profile-x86_64 tests passes)?

Dec 13 2022, 1:42 PM · Restricted Project, Restricted Project
haowei added a comment to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.

We are seeing following test failures on Fuchsia's Clang Linux x64 builders after this change (255c3e3dcb06299aa2365f70817322a8a381c351) landed:

MemorySanitizer-Unit :: ./Msan-x86_64-Test/34/38
MemorySanitizer-Unit :: ./Msan-x86_64-Test/MemorySanitizer/SelectPartial
MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/34/38
MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial
MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial
Profile-x86_64 :: Linux/comdat_rename.test
Profile-x86_64 :: Linux/instrprof-show-debug-info-correlation.c
Profile-x86_64 :: instrprof-dump.c
Profile-x86_64 :: instrprof-write-file-only.c
Profile-x86_64 :: instrprof-write-file.c
Dec 13 2022, 12:53 PM · Restricted Project, Restricted Project

Dec 9 2022

haowei added a comment to D136335: [Assignment Tracking Analysis][5/*] Tests.

Test "DebugInfo/assignment-tracking/X86/remove-undef-fragment.ll" is failing on Fuchsia's Linux ARM64 Clang builder as well. Error message:

Dec 9 2022, 3:08 PM · Restricted Project, debug-info, Restricted Project
haowei added a comment to D139555: [libc++] Refactor char_traits.

Looks like it is Fuchsia's own issue as it overrides libcxx headers in kernel (https://fuchsia.googlesource.com/fuchsia/+/658bbc3cef7f340c058dde67c3d5dd2be4084bdd/zircon/kernel/lib/ktl/include/cwchar). You don't need to take any action. Sorry for the trouble.

Dec 9 2022, 12:23 PM · Restricted Project, Restricted Project
haowei added a comment to D139555: [libc++] Refactor char_traits.

We are seeing build breakages in Fuchsia's builders after this change was landed and this change is in the blamelist and looks directly related:

Dec 9 2022, 11:24 AM · Restricted Project, Restricted Project

Nov 18 2022

haowei added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 18 2022, 2:46 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2022

haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

Fixing Windows test failures.
overlay-relative flag will always using native path separator, therefore, it needs a separate base FS and OverlayYAML file setup on Windows. This diff adds this.

Nov 16 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

haowei added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 15 2022, 2:51 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

Address review comments

Nov 15 2022, 2:50 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

I have to revert back to use process cwd instead of base fs cwd. There are a few tests relied the behavior of using process cwd that I need to take a closer look.

Nov 15 2022, 2:17 PM · Restricted Project, Restricted Project, Restricted Project

Nov 14 2022

haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

Unit test failures under Windows should be fixed now.

Nov 14 2022, 10:53 PM · Restricted Project, Restricted Project, Restricted Project

Nov 9 2022

haowei added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 9 2022, 4:45 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

Add additional unit test.

Nov 9 2022, 4:42 PM · Restricted Project, Restricted Project, Restricted Project
haowei closed D118514: [doc] Add llvm-ifs commandline guide.

Patch was already landed. Not sure why it is not auto closed. Close it now.

Nov 9 2022, 11:33 AM · Restricted Project, Restricted Project

Nov 8 2022

haowei added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 8 2022, 5:00 PM · Restricted Project, Restricted Project, Restricted Project
haowei updated the diff for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 8 2022, 4:56 PM · Restricted Project, Restricted Project, Restricted Project

Nov 7 2022

haowei added reviewers for D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file: bnbarham, keith.

Please take a look.

Nov 7 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project
haowei updated the summary of D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 7 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project

Nov 4 2022

haowei requested review of D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 4 2022, 5:12 PM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

haowei added a comment to D135860: Fix lsan build for Fuchsia.

It is not just for Fuchsia, the previous change breaks all LSan build because the function declaration does not match the definition.

Oct 13 2022, 10:45 AM · Restricted Project, Restricted Project
haowei committed rGe851f7dbcad2: Fix LSan build (authored by wiktorg).
Fix LSan build
Oct 13 2022, 10:45 AM · Restricted Project, Restricted Project
haowei closed D135860: Fix lsan build for Fuchsia.
Oct 13 2022, 10:44 AM · Restricted Project, Restricted Project

Oct 12 2022

haowei added a comment to D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets.

@pcc @phosek

Can you please provide your respective minimal CMake invocations that reproduce that issue? I'll take a look.

Oct 12 2022, 6:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
haowei added a comment to D130237: [LeakSanitizer] Capture calling thread SP early to avoid false negatives..

We are seeing build failures after this change landed:

Oct 12 2022, 5:19 PM · Restricted Project, Restricted Project
haowei added a comment to D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets.

I reverted this change in a3539090884c9159893c0b2b4c1dc34f23510707. Both Fuchsia bots and LLVM TSan bots failures indicates there is a regression caused by this change and need further investigation.

Oct 12 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
haowei committed rGa3539090884c: Revert "[runtimes] Always define cxx_shared, cxx_static & other targets" (authored by haowei).
Revert "[runtimes] Always define cxx_shared, cxx_static & other targets"
Oct 12 2022, 12:56 PM · Restricted Project, Restricted Project
haowei added a reverting change for rG79ee0342dbf0: [runtimes] Always define cxx_shared, cxx_static & other targets: rGa3539090884c: Revert "[runtimes] Always define cxx_shared, cxx_static & other targets".
Oct 12 2022, 12:55 PM · Restricted Project, Restricted Project
haowei added a reverting change for D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets: rGa3539090884c: Revert "[runtimes] Always define cxx_shared, cxx_static & other targets".
Oct 12 2022, 12:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 27 2022

haowei added a comment to D134371: [clang-doc] Add typedef/using information..

This causes failures with -Werror such as: https://lab.llvm.org/buildbot/#/builders/57/builds/22322
Please fix or revert.

Sep 27 2022, 6:37 PM · Restricted Project, Restricted Project