Page MenuHomePhabricator

haowei (Haowei Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2017, 3:05 PM (179 w, 10 h)

Recent Activity

Yesterday

haowei added reviewers for D89764: [llvm] Fix ODRViolations for VersionTuple YAML specializations NFC: phosek, leonardchan.
Tue, Oct 20, 12:59 PM · Restricted Project

Wed, Oct 14

haowei requested review of D89432: [llvm-elfabi] Emit ELF .dynsym and .dynamic sections.
Wed, Oct 14, 4:04 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.

Rebase the change and fixes some format issues.

Wed, Oct 14, 3:52 PM · Restricted Project

Wed, Sep 30

haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.

Resolve clang-tidy warnings.

Wed, Sep 30, 12:10 PM · Restricted Project

Tue, Sep 29

haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Tue, Sep 29, 12:04 AM · Restricted Project

Mon, Sep 28

haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Mon, Sep 28, 11:54 PM · Restricted Project
haowei commandeered D61767: [llvm-elfabi] Emit ELF header and string table section.

I am commandeering this work as original author stopped working this project.

Mon, Sep 28, 11:53 PM · Restricted Project

Aug 14 2020

haowei committed rGee5d07e6ce89: Remove unnecessary HEADER_DIRS in lib/InterfaceStub/CMakeLists.txt (authored by haowei).
Remove unnecessary HEADER_DIRS in lib/InterfaceStub/CMakeLists.txt
Aug 14 2020, 11:23 AM
haowei closed D85936: [InterfaceStub] Remove unnecessary include dir from llvm/lib/InterfaceStub/CMakeLists.txt.
Aug 14 2020, 11:23 AM · Restricted Project

Aug 13 2020

haowei added inline comments to D85678: [elfabi] Move elfabi related code to InterfaceStub library.
Aug 13 2020, 2:29 PM · Restricted Project
haowei requested review of D85936: [InterfaceStub] Remove unnecessary include dir from llvm/lib/InterfaceStub/CMakeLists.txt.
Aug 13 2020, 2:28 PM · Restricted Project
haowei committed rGd650cbc349cc: [elfabi] Move llvm-elfabi related code to InterfaceStub library (authored by haowei).
[elfabi] Move llvm-elfabi related code to InterfaceStub library
Aug 13 2020, 11:52 AM
haowei closed D85678: [elfabi] Move elfabi related code to InterfaceStub library.
Aug 13 2020, 11:52 AM · Restricted Project

Aug 12 2020

haowei added a comment to D85678: [elfabi] Move elfabi related code to InterfaceStub library.

Are there any more comments?

Aug 12 2020, 2:12 PM · Restricted Project
haowei updated the diff for D85678: [elfabi] Move elfabi related code to InterfaceStub library.
Aug 12 2020, 2:10 PM · Restricted Project

Aug 11 2020

haowei updated the diff for D85678: [elfabi] Move elfabi related code to InterfaceStub library.
Aug 11 2020, 6:43 PM · Restricted Project
haowei added a comment to D85678: [elfabi] Move elfabi related code to InterfaceStub library.

This change moves ELFObjHandler and other elfabi code to a new IFS library so it can be used by both llvm-elfabi and llvm-ifs tool for reading and writing ELF objects. Previously I move it to TextAPI but it causes cyclic dependencies.

I can't find any explanation why the new file hierarchy works better and why 'IFS' instead of a more specific name (.e.g InterfaceStub) is picked.

In my first try I put it in TextAPI library and it causes a dependency loop as Object library is depends on TextAPI. Otherwise I think TextAPI is a better place for these files.

I think the sole reason that Object depends on TextAPI is due to D66159. Have you tried contacting the author about thinking whether we should continue organizing the two libraries this way?

I am OK with InterfaceStub name. It explains the purpose clearer.

If you look at existing library names. Abbreviation is not common, so IFS should probably be expanded.

Aug 11 2020, 5:13 PM · Restricted Project
haowei added a comment to D85678: [elfabi] Move elfabi related code to InterfaceStub library.

This change moves ELFObjHandler and other elfabi code to a new IFS library so it can be used by both llvm-elfabi and llvm-ifs tool for reading and writing ELF objects. Previously I move it to TextAPI but it causes cyclic dependencies.

I can't find any explanation why the new file hierarchy works better and why 'IFS' instead of a more specific name (.e.g InterfaceStub) is picked.

Aug 11 2020, 4:46 PM · Restricted Project
haowei added a comment to D85678: [elfabi] Move elfabi related code to InterfaceStub library.

I would like to improve llvm-ifs tool on ELF object handling. Right now it uses yaml2obj which is not robust.

How is it not robust?

Aug 11 2020, 4:43 PM · Restricted Project
haowei updated the diff for D85678: [elfabi] Move elfabi related code to InterfaceStub library.
Aug 11 2020, 12:32 PM · Restricted Project

Aug 10 2020

haowei added a reverting change for rGe6f8ba12e6ea: Move ELFObjHandler to TextAPI library: rGdb91320a8986: Revert "Move ELFObjHandler to TextAPI library".
Aug 10 2020, 9:32 PM
haowei committed rGdb91320a8986: Revert "Move ELFObjHandler to TextAPI library" (authored by haowei).
Revert "Move ELFObjHandler to TextAPI library"
Aug 10 2020, 9:32 PM
haowei committed rGe6f8ba12e6ea: Move ELFObjHandler to TextAPI library (authored by haowei).
Move ELFObjHandler to TextAPI library
Aug 10 2020, 9:24 PM
haowei updated the diff for D85678: [elfabi] Move elfabi related code to InterfaceStub library.

correct formating.

Aug 10 2020, 4:50 PM · Restricted Project
haowei added a reviewer for D85678: [elfabi] Move elfabi related code to InterfaceStub library: leonardchan.
Aug 10 2020, 12:32 PM · Restricted Project
haowei updated the summary of D85678: [elfabi] Move elfabi related code to InterfaceStub library.
Aug 10 2020, 11:59 AM · Restricted Project
haowei requested review of D85678: [elfabi] Move elfabi related code to InterfaceStub library.
Aug 10 2020, 11:55 AM · Restricted Project

Aug 10 2017

haowei added inline comments to D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker.
Aug 10 2017, 9:55 AM

Aug 8 2017

haowei created D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker.
Aug 8 2017, 10:37 AM

Aug 2 2017

haowei created D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker.
Aug 2 2017, 4:41 PM

Aug 1 2017

haowei updated the diff for D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker.

Add 1 line fix for the constraint on allocated handle in function allocateSingleHandle at line 647

Aug 1 2017, 3:41 PM

Jul 28 2017

haowei created D36024: [analyzer] Improved bug reporting in MagentaHandleChecker.
Jul 28 2017, 3:23 PM
haowei created D36023: [analyzer] Add array support for MagentaHandleChecker.
Jul 28 2017, 3:13 PM
haowei updated the summary of D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker.
Jul 28 2017, 2:56 PM
haowei created D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker.
Jul 28 2017, 2:49 PM

Jul 27 2017

haowei abandoned D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel.

Superseded by D35968

Jul 27 2017, 5:12 PM
haowei created D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel.
Jul 27 2017, 5:08 PM

Jul 18 2017

haowei updated the diff for D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel.

Thanks for reviewing this patch. I have modified the checker according NoQ's suggestions and refactored some long functions.

Jul 18 2017, 5:22 PM

Jun 27 2017

haowei created D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel.
Jun 27 2017, 4:25 PM

Jun 21 2017

haowei created D34489: [scan-build-py] Patch to fix "-analyzer-config" option.
Jun 21 2017, 4:57 PM

May 16 2017

haowei added a comment to D33263: [scan-build] Patch to scan-build tool to support "--target=<value>" flag.

Looks good. Thank you!
Do you have commit access or should we commit?

May 16 2017, 5:36 PM
haowei created D33263: [scan-build] Patch to scan-build tool to support "--target=<value>" flag.
May 16 2017, 3:48 PM