User Details
- User Since
- May 16 2017, 3:05 PM (305 w, 5 d)
Thu, Mar 23
Thanks for pointing them out.
Wed, Mar 22
Tue, Mar 7
LGTM, but please wait @phosek to approve it.
Mon, Mar 6
Wed, Mar 1
Tue, Feb 28
Feb 24 2023
We are seeing a linker error on Mac builder today when we try to roll the clang toolchain for Flutter, error message (build task: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Unopt/25679/overview):
Feb 22 2023
Feb 14 2023
I am seeing test failures on pre submit Windows builder after this change was landed: See https://buildkite.com/llvm-project/premerge-checks/builds/135752#01864d34-9024-4c13-9137-88b6f41ec695
Feb 13 2023
Feb 7 2023
There are also cases that this clang type-limit check will warn when checking if a enum type is larger than 0. For example, we are seeing warnings on ICU source code (https://github.com/unicode-org/icu/blob/8d5a97ae0f49f6974372736ca67db15c37522f6f/icu4c/source/i18n/displayoptions.cpp#L79) after this patch was landed.
LGTM. Please wait for the approval from @yln .
Feb 6 2023
FYI, this patch looks like was pushed into a new "Main" branch instead of the actual "main" branch.:
Feb 3 2023
Feb 2 2023
Jan 31 2023
Correct dependency issues on llvm-mt
Jan 23 2023
Jan 20 2023
Thanks for the review. I will land the change once Fuchsia clang builders are green.
Correct an issue llvm-rc and llvm-mt are not part of TOOLCHAIN_TOOLS
Jan 19 2023
Jan 13 2023
Correct C, CXX flag issue.
Jan 11 2023
Jan 10 2023
Jan 4 2023
Dec 16 2022
Dec 15 2022
Wondering what is the error you see when uses UTC? While there are some differences, UTC and GMT basically means the same thing. So I am really surprised one works fine while the other will fail.
Dec 14 2022
Dec 13 2022
This change breaks lld/test/MachO/stabs.s on Fuchsia's Mac x64 Clang builder:
I tried again with
cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;compiler-rt" ../llvm -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_TARGETS_TO_BUILD="X86"
Rebased the change to solve the merge conflicts on the bots.
I changed some comments and add more details.
If there is no objection, can I get an approval on this change so I can land it? It will unblock our development on Windows cross compilation support.
So I tried
What is your cmake command line when you test the code (when all Profile-x86_64 tests passes)?
We are seeing following test failures on Fuchsia's Clang Linux x64 builders after this change (255c3e3dcb06299aa2365f70817322a8a381c351) landed:
MemorySanitizer-Unit :: ./Msan-x86_64-Test/34/38 MemorySanitizer-Unit :: ./Msan-x86_64-Test/MemorySanitizer/SelectPartial MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/34/38 MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial MemorySanitizer-Unit :: ./Msan-x86_64-with-call-Test/MemorySanitizer/SelectPartial Profile-x86_64 :: Linux/comdat_rename.test Profile-x86_64 :: Linux/instrprof-show-debug-info-correlation.c Profile-x86_64 :: instrprof-dump.c Profile-x86_64 :: instrprof-write-file-only.c Profile-x86_64 :: instrprof-write-file.c
Dec 9 2022
Test "DebugInfo/assignment-tracking/X86/remove-undef-fragment.ll" is failing on Fuchsia's Linux ARM64 Clang builder as well. Error message:
Looks like it is Fuchsia's own issue as it overrides libcxx headers in kernel (https://fuchsia.googlesource.com/fuchsia/+/658bbc3cef7f340c058dde67c3d5dd2be4084bdd/zircon/kernel/lib/ktl/include/cwchar). You don't need to take any action. Sorry for the trouble.
We are seeing build breakages in Fuchsia's builders after this change was landed and this change is in the blamelist and looks directly related:
Nov 18 2022
Nov 16 2022
Fixing Windows test failures.
overlay-relative flag will always using native path separator, therefore, it needs a separate base FS and OverlayYAML file setup on Windows. This diff adds this.
Nov 15 2022
Address review comments
I have to revert back to use process cwd instead of base fs cwd. There are a few tests relied the behavior of using process cwd that I need to take a closer look.
Nov 14 2022
Unit test failures under Windows should be fixed now.
Nov 9 2022
Add additional unit test.
Patch was already landed. Not sure why it is not auto closed. Close it now.
Nov 8 2022
Nov 7 2022
Please take a look.
Nov 4 2022
Oct 13 2022
It is not just for Fuchsia, the previous change breaks all LSan build because the function declaration does not match the definition.
Oct 12 2022
We are seeing build failures after this change landed:
I reverted this change in a3539090884c9159893c0b2b4c1dc34f23510707. Both Fuchsia bots and LLVM TSan bots failures indicates there is a regression caused by this change and need further investigation.