User Details
- User Since
- May 16 2017, 3:05 PM (262 w, 3 d)
Fri, May 13
Thanks for working on this.
Fri, May 6
Wed, May 4
This seems to me another case that you need to fix the sysroot environment instead of adding file mapping logic to tools.
Currently you need clang and lld (lld-link or ld.lld), if you later need more tools, are you going to add the logic to all the involved tools?
I am working on cross compiling support for Fuchsia Clang toolchain targeting Windows and recently encountered an issue that would be the perfect use case for this case.
Mon, May 2
Apr 27 2022
Test LLVM :: tools/llvm-reduce/fail-file-open.test is still failing on our windows bots after the fix:
We are seeing test failures on Fuchsia Clang builder for windows-x64 after this change have landed.
We are seeing test failures on Fuchsia Clang builder for windows-x64 after this change and 18b9c4637099f6ed5414d8778de8c773291a9cf9 have landed.
Apr 8 2022
I think this breaks cmake configure. We saw errors like:
Mar 28 2022
Hi, we are seeing build failures in our clang bots in Performing build step for 'runtimes-x86_64-unknown-linux-gnu' after this change lands, error message:
Mar 18 2022
Mar 16 2022
We are seeing test failures after this patch is landed:
Filed https://github.com/llvm/llvm-project/issues/54407 with reproducer attached.
Mar 15 2022
While c1d4c67718db88be48f451b91f7bddab8fff2424 clears the cmake error. I am now seeing runtimes-i386-unknown-linux-gnu build failures related to the same symbol:
I just suppressed the error in c1d4c67718db88be48f451b91f7bddab8fff2424.
Can you provide i386-linux-gnu/crti.o and i386-linux-gnu/libc_nonshared.a(elf-init.oS)?
I need to understand the issue better to craft a better test. I believe the state before this patch worked for such symbols were accidental.
Thanks for the report, but with Host compiler does not support '-fuse-ld=lld' it might be difficult to know for sure whether the culprit was in an lld change or a brittle configure.
Providing CMakeError.log or CMakeOutput.log with the linker diagnostic could make me more sure that it was related to this lld change.
Anycase, I think the issue was exactly the one for i386 sanitizers and it should have been fixed by the aforementioned commit.
We are seeing build failures in cmake config step for the clang runtime builds after this patch. Example of error messages:
Feb 28 2022
Feb 17 2022
Please correct the comments of the test file.
Please wait for @mcgrathr 's approval before you land the change.
The implementation of the filtering feature LGTM. My concerns is that do we need both 2 flags are needed at the same time. I am not very familiar with the __asan symbols use case so I will ask @mcgrathr and @phosek to comment on this.
Feb 16 2022
Feb 15 2022
I wasn't aware yaml2obj support -D as well. Thanks for pointing it out.
Feb 14 2022
Test added in https://reviews.llvm.org/D119741
Feb 13 2022
Adds minimal validation of STRSZ from .dynamic.
Feb 11 2022
The latest patch no longer causes clang-refactor test failures on stage2 mac build on Fuchsia builders.
Feb 10 2022
Feb 9 2022
Feb 8 2022
Feb 4 2022
Hi, we are seeing clang Windows build breakages after this change was relanded, error message:
Feb 3 2022
Feb 2 2022
Hi, we found out that this patch breaks following tests in the Fuchsia's stage-2 mac clang builders:
Clang :: Refactor/Extract/ExtractExprIntoFunction.cpp Clang :: Refactor/Extract/ExtractionSemicolonPolicy.cpp Clang :: Refactor/Extract/ExtractionSemicolonPolicy.m Clang :: Refactor/Extract/FromMethodToFunction.cpp Clang :: Refactor/Extract/ObjCProperty.m
Jan 28 2022
Jan 25 2022
If there is no further objection or comments, can I get a LGTM to land this change please?
Jan 24 2022
Jan 18 2022
Hi, we are seeing test failures from libc++ :: libcxx/nasty_macros.compile.pass.cpp in Fuchsia's linux-x64 and arm64 clang builders after this patch was landed.
Jan 14 2022
Jan 13 2022
Jan 12 2022
Jan 11 2022
Change the fallback logics to Diff3. Also adds parents revision to make presubmit check happy.
Jan 7 2022
Jan 6 2022
Jan 4 2022
We are seeing assertion errors in some of Fuchsia's clang builders after this change was landed, the error message is:
Dec 28 2021
If you insist, please reach out to all of them with your understanding. I don't think I'm the only one to take your viewpoint.
OK, your team knows this but you need to show the proof publicly.
I feel you are asking the proof for a gentlemen's agreement. It is my bad that I didn't mention that the patch was confirmed by locally reverted this patch. If that caused some confusions, I apologize. But except for saying I did the local revert, I cannot give you any proof for that. If you feel local console logs will work I can attach them next time.
Hi, this change as well as 7c0881a38f5e0f50375a089e5a3c9b2d215be0e9 broke Fuchsia rust build and we are seeing crashes from some build tools. Both of your changes are not NFC but they landed without proper review. Could you revert them now so we can restore the build please?
Dec 9 2021
Dec 8 2021
Fix some "no newline" warnings.
Dec 3 2021
I updated the unit tests and adds new tests for the new flags.
Dec 2 2021
Nov 22 2021
Nov 19 2021
Example of build races failures: